whats wrong with this piece of code? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Need help with a small piece of code 0 replies

How to change this piece of code? 12 replies

Not sure whats wrong with code 2 replies

Need input on a piece of code..should be EZ for programmers 4 replies

Indicator fix...code included.. WHATS WRONG?!? 4 replies

whats wrong with this piece of code?

  • #1
  • First Post: Nov 2, 2008 2:18am Nov 2, 2008 2:18am
I am placing 2 pending orders simultaneous, a buy and sell at certain levels. Once the order is placed, now I want to delete one order as soon as the other order is triggered.

Here's what I have written for that. But it doesnt seem to be working. Please tell me what is wrong with this code.


PHP Code
int order_type;
int iTotal = OrdersTotal();
if(iTotal < 1)
         {
            int iTicketBuy = OrderSend(Symbol(),OP_BUYSTOP,iLots,UpEntry,3,iSL,iTP,"EURUSDBUY",iMN,iExpire,Green);
            int iTicketSell = OrderSend(Symbol(),OP_SELLSTOP,iLots,LowEntry,3,iSL1,iTP1,"EURUSDSELL",iMN1,iExpire,Red);
                if (iTicketBuy>0)
                  {
                      if(OrderSelect(iTicketBuy,SELECT_BY_TICKET,MODE_TRADES)) 
                        {
                           Print("Buy Order Placed : ",OrderOpenPrice());
                        }
                      else 
                        {
                           Print("Error Placing Buy Order : ",GetLastError());
                        }  
                  }  
               
                if (iTicketSell>0)
                  {
                     if(OrderSelect(iTicketSell,SELECT_BY_TICKET,MODE_TRADES)) 
                        {
                           Print("Sell Order Placed : ",OrderOpenPrice());
                        }
                      else 
                        {
                           Print("Error Placing Sell Order : ",GetLastError());
                        } 
                  }  
                  
          }
          else
            if (iTotal > 0)
               {
                  if(OrderSelect(iTicketBuy, SELECT_BY_TICKET,MODE_TRADES))
                   {
                     order_type = OrderType();
                     if (order_type == OP_BUY)
                        {
                           OrderDelete(iTicketSell);
                        } 
                    }
                  else  
                  if(OrderSelect(iTicketSell, SELECT_BY_TICKET,MODE_TRADES))
                     {
                        order_type = OrderType();
                        if (order_type == OP_SELL)
                           {
                              OrderDelete(iTicketBuy);
                            } 
                      }  
         
                }
  • #2
  • Nov 2, 2008 7:04am Nov 2, 2008 7:04am
Hi,

please provide more information about what is not working. Where is it stuck?
  • #3
  • Nov 2, 2008 7:11am Nov 2, 2008 7:11am
Quoting tradeigel
Hi,

please provide more information about what is not working. Where is it stuck?
the orders are getting placed. but when one of the order is executed the other one is not getting closed/deleted.
  • #4
  • Nov 2, 2008 8:21am Nov 2, 2008 8:21am
I think the problem is the "else" before if(OrderSelect(iTicketSell, SELECT_BY_TICKET,MODE_TRADES)). With the else, you'll only check the sell side if the buy side orderselect fails, which will only happen if the buy order failed. Remove the else and both sides will be checked each time.
PHP Code
int order_type;
int iTotal = OrdersTotal();
if(iTotal < 1)
         {
            int iTicketBuy = OrderSend(Symbol(),OP_BUYSTOP,iLots,UpEntry,3,iSL,iTP,"EURUSDBUY",iMN,iExpire,Green);
            int iTicketSell = OrderSend(Symbol(),OP_SELLSTOP,iLots,LowEntry,3,iSL1,iTP1,"EURUSDSELL",iMN1,iExpire,Red);
                if (iTicketBuy>0)
                  {
                      if(OrderSelect(iTicketBuy,SELECT_BY_TICKET,MODE_TRADES)) 
                        {
                           Print("Buy Order Placed : ",OrderOpenPrice());
                        }
                      else 
                        {
                           Print("Error Placing Buy Order : ",GetLastError());
                        }  
                  }  
               
                if (iTicketSell>0)
                  {
                     if(OrderSelect(iTicketSell,SELECT_BY_TICKET,MODE_TRADES)) 
                        {
                           Print("Sell Order Placed : ",OrderOpenPrice());
                        }
                      else 
                        {
                           Print("Error Placing Sell Order : ",GetLastError());
                        } 
                  }  
                  
          }
          else
            if (iTotal > 0)
               {
                  if(OrderSelect(iTicketBuy, SELECT_BY_TICKET,MODE_TRADES))
                   {
                     order_type = OrderType();
                     if (order_type == OP_BUY)
                        {
                           OrderDelete(iTicketSell);
                        } 
                    }
                  // Remove this: else
                  if(OrderSelect(iTicketSell, SELECT_BY_TICKET,MODE_TRADES))
                     {
                        order_type = OrderType();
                        if (order_type == OP_SELL)
                           {
                              OrderDelete(iTicketBuy);
                            } 
                      }  
         
                }
  • #5
  • Nov 2, 2008 8:31am Nov 2, 2008 8:31am
Hi 4xCoder,

Still not working. Deletion still not happening :-(.
  • #6
  • Nov 2, 2008 9:20am Nov 2, 2008 9:20am
what exactly is happening when the order is not deleted?
You need to do debugging like seeing if the block with OrderDelete() is executed at all etc.

However, since the opening and closing is done in two different cycles of the EA you need to save the ticket on the global level of the script so that it is still present in the run.
That at least is what I thought just throwing a glance at the EA not testing it or anything.
  • #7
  • Nov 2, 2008 9:41am Nov 2, 2008 9:41am
Quoting tradeigel
what exactly is happening when the order is not deleted?
You need to do debugging like seeing if the block with OrderDelete() is executed at all etc.

However, since the opening and closing is done in two different cycles of the EA you need to save the ticket on the global level of the script so that it is still present in the run.
That at least is what I thought just throwing a glance at the EA not testing it or anything.
Awesome :-) I just saved the ticket on the global level and boom.... i can see some delete orders.

Now let me test thing a little more in detail.

Thanks
  • #8
  • Nov 2, 2008 11:08am Nov 2, 2008 11:08am
Hmmm.... Now there is some new error showing in the journal.

It is "OrderDelete error 4108"

Here's whats happening. While backtesting in the results sheet it shows the order is deleted but actually the order is not deleted.

I checked up and tried to what out what the error means but could not understand it.

Error 4018 - ERR_CANNOT_LOAD_LIBRARY - At calling of an imported function, loading error of dll or ex4 library occurred

Can you please tell me what it means and how do I solve this problem?
  • #9
  • Nov 2, 2008 7:48pm Nov 2, 2008 7:48pm
Sorry, my mistake .

Its error 4108 and NOT 4018.

Sorry once again
  • #10
  • Nov 2, 2008 9:38pm Nov 2, 2008 9:38pm
Solved it now.

PHP Code
if (order_type == OP_BUY && iTicketSell > 0)
                        {
                           OrderDelete(iTicketSell);
                           iTicketSell = -1;
                        }
the iTicketSell > 0 in the first line and the iTicketSell = -1 solved the problem.
  • #11
  • Apr 9, 2009 12:10pm Apr 9, 2009 12:10pm
Hi Deedeed,

I recently found your old messages about your attempt to pertfect your simultaneous system. I was think of trying this strategy and would like to know if you have had some success using it?

thank you for your perspective.
D.
  • #12
  • Apr 10, 2009 12:59am Apr 10, 2009 12:59am
Quoting D&amp;s
Hi Deedeed,

I recently found your old messages about your attempt to pertfect your simultaneous system. I was think of trying this strategy and would like to know if you have had some success using it?

thank you for your perspective.
D.
Hi D,

I could not quite understand what you are exactly talking about. Pls be a little more clearer.

Cheers
  • #13
  • Apr 10, 2009 3:26am Apr 10, 2009 3:26am
Hi Deedeed,

i was looking for testimonies from traders who had been using a simultaneous pending order strategy in which you have orders ready to go in any direction. When one side is activated the other pending order is deleted. The operation repeates everytime we reach preset SL or TP to allow us to take advantage of most fluctuations (depending on how we adjust the parameters) and taking the guess work out of the equation.
Fairly straight forward... Just trying to see if you had had sucess with this kind of strategy.
thanks
D.
  • #14
  • Apr 11, 2009 11:30pm Apr 11, 2009 11:30pm
Quoting D&amp;s
Hi Deedeed,

i was looking for testimonies from traders who had been using a simultaneous pending order strategy in which you have orders ready to go in any direction. When one side is activated the other pending order is deleted. The operation repeates everytime we reach preset SL or TP to allow us to take advantage of most fluctuations (depending on how we adjust the parameters) and taking the guess work out of the equation.
Fairly straight forward... Just trying to see if you had had sucess with this kind of strategy.
thanks
D....
Hi D,

Firstly, I was trying to using the simultaneous pending orders for an inside day strategy.

I do not place new orders as soon a TP or SL is hit. So I don't think I will be able to give you any valuable input on this.

My question to you is lets say we do place a new order as soon as the TP or Sl of the previous order is executed, then on what conditions do you place the order?

Cheers
B
  • #15
  • Last Post: Apr 12, 2009 2:17pm Apr 12, 2009 2:17pm
Hi Deedeed,

My idea was to have a system that takes advantage of most market fluctuations. Orders will be triggered mechanically one ofter the other as their TP or Sl are reached. It still would be necessary to keep monitoring news and trends and adjust TP and Sl consevatively...
what do you think?

thanks
D.
0 traders viewing now