EA not working fully... cant figure out why. | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

EA working with a broker, not working with another 0 replies

Why cant i find Long setups? 13 replies

Can you figure out why this EA stops trading? 1 reply

Right now My metatrader3 is not working is yours working? 0 replies

HELP- I cant trade during NY market hrs. 9 replies

EA not working fully... cant figure out why.

  • #1
  • First Post: Oct 27, 2008 6:09am Oct 27, 2008 6:09am
Hi,

Please take a look at the code below.
The sell side is working fine. But the buy side is not working fine.
Can somebody please tell me why.

PHP Code
//+------------------------------------------------------------------+
//|                                                           A1.mq4 |
//|                                                          Brijesh |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright "Brijesh"
#property link      ""

extern double iLots = 1;

extern int iMagicNumber = 12444;
double iBuyPrice, iSellPrice,iRange1,iRange2, iStopLoss1, iStopLoss2, iTakeProfit1, iTakeProfit2, Entry;

int iTicket;



//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {

   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
{
   
  
  if (High[1] > High[2] && Low[1] > Low[2])  bn();
  else
  if (High[1] < High[2] && Low[1] < Low[2])  sn();
      
  
 
//----
   return(0);
}
//+------------------------------------------------------------------+

 void bn()
{
int iTotal  = OrdersTotal();
iBuyPrice = Close[1] + Point; // buy price
iRange1 = High[1] - Low[1]; // range of the previous bar
iStopLoss1 = Low[1]- iRange1; // sl
iTakeProfit1 = High[1] + iRange1; // tp
datetime iExpire1=CurTime()+PERIOD_M1*60; //order expiry
if(iTotal < 1) 
    {
       int Mode;
       if (Bid > iBuyPrice) {Mode = OP_BUYLIMIT; Entry = iBuyPrice;}
       if (Bid == iBuyPrice) {Mode = OP_BUY; Entry = iBuyPrice;}
       if (Bid < iBuyPrice) {Mode = OP_BUYSTOP; Entry = iBuyPrice;}
      
      iTicket = OrderSend(Symbol(),Mode, iLots, Entry, 3, iStopLoss1 , iTakeProfit1, "Buy Script", iMagicNumber,iExpire1,Green);
            if (iTicket>0)
                        {
                           if(OrderSelect(iTicket,SELECT_BY_TICKET,MODE_TRADES)) Print("BUY order opened : ",OrderOpenPrice());
                        }  
                        else
                        {
                        Print("Error opening BUY order : ",GetLastError());
                        }
   }
     
}                  
                  
                  
 void sn()
{
  int iTotal1  = OrdersTotal();
  iSellPrice = Close[1] - Point; //sell price
  iRange2 = High[1] - Low[1]; // range of the previous bar
  iStopLoss2 = High[1]+ iRange2; // Sl
  iTakeProfit2 = Low[1] - iRange2; // TP 
  datetime iExpire2=CurTime()+PERIOD_M1*60; // Order expiry
        
  
  if (iTotal1 < 1)
      {
       int Mode1;
       if (Bid > iSellPrice) {Mode1 = OP_SELLSTOP; Entry = iSellPrice;}
       if (Bid == iSellPrice) {Mode1 = OP_SELL; Entry = iSellPrice;}
       if (Bid < iSellPrice) {Mode1 = OP_SELLLIMIT; Entry = iSellPrice;}
      
      iTicket = OrderSend(Symbol(),Mode1, iLots, Entry, 3, iStopLoss2 , iTakeProfit2, "Sell Script", iMagicNumber,iExpire2,Red);
            if (iTicket>0)
                        {
                           if(OrderSelect(iTicket,SELECT_BY_TICKET,MODE_TRADES)) Print("SELL order opened : ",OrderOpenPrice());
                        }  
                        else
                        {
                        Print("Error opening BUY order : ",GetLastError());
                        }  
      }  
}
  • #2
  • Oct 27, 2008 7:32am Oct 27, 2008 7:32am
Got the buy thing to work. Seems like I had checked for taking only short positions in the options.

However I want some help with order expiry.

Meaning for a given chart the order if not executed immediately MUST be valid only until the next bar is completely formed. What is the logic for getting this done.

Example : - In a 5 min chart lets say the order is placed at 6:00PM. The order must be valid only until 6:05PM after which it must automatically be deleted.

How do I do this.
  • #3
  • Oct 27, 2008 12:25pm Oct 27, 2008 12:25pm
Quoting deedeed
Got the buy thing to work. Seems like I had checked for taking only short positions in the options.

However I want some help with order expiry.

Meaning for a given chart the order if not executed immediately MUST be valid only until the next bar is completely formed. What is the logic for getting this done.

Example : - In a 5 min chart lets say the order is placed at 6:00PM. The order must be valid only until 6:05PM after which it must automatically be deleted.

How do I do this.
You must use the Time[0] or
You can also use: D'2008.10.30 15:38', for example.
Request custom Expert Advisor or Indicator: dostapyuk "at" gmail . com
  • #4
  • Oct 27, 2008 8:44pm Oct 27, 2008 8:44pm
Quoting Oksana17
You must use the Time[0] or
You can also use: D'2008.10.30 15:38', for example.
No I couldnt quite understand what you mentioned.
Let me rephrase my question

Check this out.
iTicket = OrderSend(Symbol(),Mode, iLots, Entry, 3, iStopLoss1 , iTakeProfit1, "Buy Script", iMagicNumber,iExpire1,Green);

In this piece of code I have a varaible called "iExpire1",
and as per my knowledge this is the variable which will control the
expiry of the order if not executed.

So assuming I am on a 5 minute chart and I want the order to be cancelled if it is not executed in 5 minutes of order placement what must be the value of "iExpire1"

Is iExpire1 = Time[0] + PERIOD_M5*60; correct???

And does Time[0] mean it will take the time at the time of order placement???
  • #5
  • Oct 28, 2008 12:55am Oct 28, 2008 12:55am
Quoting deedeed
No I couldnt quite understand what you mentioned.
Let me rephrase my question

Check this out.
iTicket = OrderSend(Symbol(),Mode, iLots, Entry, 3, iStopLoss1 , iTakeProfit1, \"Buy Script\", iMagicNumber,iExpire1,Green);

In this piece of code I have a varaible called \"iExpire1\",
and as per my knowledge this is the variable which will control the
expiry of the order if not executed.

So assuming I am on a 5 minute chart and I want the order to be cancelled if it is not executed in 5 minutes of order placement what must be the value of \"iExpire1\"

Is iExpire1 = Time[0] + PERIOD_M5*60; correct???

And does Time[0] mean it will take the time at the time of order placement???

Time[0] is the bar's open price.

If you want the trade to expire 5 minutes after you place it...


extern ExpireMinutes = 5;

start()

datetime iExpire = TimeCurrent() + ExpireMinutes * 60;
  • #6
  • Oct 28, 2008 1:00am Oct 28, 2008 1:00am
Quoting Ronald Raygun
Time[0] is the bar's open price.

If you want the trade to expire 5 minutes after you place it...


extern ExpireMinutes = 5;

start()

datetime iExpire = TimeCurrent() + ExpireMinutes * 60;
Thanks Ron,

Now the extern ExpireMinutes = 5;

should it be extern int ExpireMinutes = 5;

or

should it be extern datetime ExpireMinutes = 5;
  • #7
  • Oct 28, 2008 1:01am Oct 28, 2008 1:01am
sorry, it should be extern int.
  • #8
  • Oct 28, 2008 1:08am Oct 28, 2008 1:08am
Quoting Ronald Raygun
sorry, it should be extern int.
Thanks Ron,

Tried it. Now the orders are not getting placed.

Here's my code... can you please tell me if you can see anything wrong?

Or is there any minimum expiration time? That is my big doubt.

I am using this following ea on a one minute usd/jpy.

PHP Code
//+------------------------------------------------------------------+
//|                                                           A1.mq4 |
//|                                                          Brijesh |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright "Brijesh"
#property link      ""

extern double iLots = 1;

extern int iMagicNumber = 12444;
double iBuyPrice, iSellPrice,iRange1,iRange2, iStopLoss1, iStopLoss2, iTakeProfit1, iTakeProfit2, Entry;
extern int SecondsToExpire = 57;
int iTicket;



//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {

   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
{
   
  
  if (High[1] > High[2] && Low[1] > Low[2])  bn();
  else
  if (High[1] < High[2] && Low[1] < Low[2])  sn();
      
  
 
//----
   return(0);
}
//+------------------------------------------------------------------+

 void bn()
{
int iTotal  = OrdersTotal();
iBuyPrice = Close[1] + Point; // buy price
iRange1 = High[1] - Low[1]; // range of the previous bar
iStopLoss1 = Low[1]- iRange1; // sl
iTakeProfit1 = High[1] + iRange1; // tp
datetime iExpire1=TimeCurrent() + SecondsToExpire; //order expiry
//Print ("Time to expire", iExpire1);


if(iTotal < 1) 
    {
       int Mode;
       if (Bid > iBuyPrice) {Mode = OP_BUYLIMIT; Entry = iBuyPrice;}
       if (Bid == iBuyPrice) {Mode = OP_BUY; Entry = iBuyPrice;}
       if (Bid < iBuyPrice) {Mode = OP_BUYSTOP; Entry = iBuyPrice;}
      
      iTicket = OrderSend(Symbol(),Mode, iLots, Entry, 3, iStopLoss1 , iTakeProfit1, "Buy Script", iMagicNumber,iExpire1,Green);
            if (iTicket>0)
                        {
                           if(OrderSelect(iTicket,SELECT_BY_TICKET,MODE_TRADES)) Print("BUY order opened : ",OrderOpenPrice());
                        }  
                        else
                        {
                        Print("Error opening BUY order : ",GetLastError());
                        }
   }
     
}                  
                  
                  
 void sn()
{
  int iTotal1  = OrdersTotal();
  iSellPrice = Close[1] - Point; //sell price
  iRange2 = High[1] - Low[1]; // range of the previous bar
  iStopLoss2 = High[1]+ iRange2; // Sl
  iTakeProfit2 = Low[1] - iRange2; // TP 
   datetime iExpire2=TimeCurrent()+SecondsToExpire; // Order expiry
 // Print ("Time to expire", iExpire2);
  
  
        
  
  if (iTotal1 < 1)
      {
       int Mode1;
       if (Bid > iSellPrice) {Mode1 = OP_SELLSTOP; Entry = iSellPrice;}
       if (Bid == iSellPrice) {Mode1 = OP_SELL; Entry = iSellPrice;}
       if (Bid < iSellPrice) {Mode1 = OP_SELLLIMIT; Entry = iSellPrice;}
      
      iTicket = OrderSend(Symbol(),Mode1, iLots, Entry, 3, iStopLoss2 , iTakeProfit2, "Sell Script", iMagicNumber,iExpire2,Red);
            if (iTicket>0)
                        {
                           if(OrderSelect(iTicket,SELECT_BY_TICKET,MODE_TRADES)) Print("SELL order opened : ",OrderOpenPrice());
                        }  
                        else
                        {
                        Print("Error opening BUY order : ",GetLastError());
                        }  
      }  
}
  • #9
  • Oct 28, 2008 1:10am Oct 28, 2008 1:10am
Is the EA returning an error?
  • #10
  • Oct 28, 2008 1:12am Oct 28, 2008 1:12am
Quoting Ronald Raygun
Is the EA returning an error?
no errors. when i set the expiry time parameter. it just doesnt do anything. else its perfect.
  • #11
  • Oct 28, 2008 1:19am Oct 28, 2008 1:19am
I would imagine it's an issue with "Mode" If mode is OP_BUY or OP_SELL, expiry isn't needed.

Interesting thing in the documentation:

Applying of pending order expiration time can be disabled in some trade servers. In this case, when a non-zero value is specified in the expiration parameter, the error 147 (ERR_TRADE_EXPIRATION_DENIED) will be generated.

Another option you could use is...

for (int i = 0; i < Total; i ++) {
OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
if((OrderType() == OP_SELLSTOP || OrderType() == OP_SELLLIMIT || OrderType() == OP_BUYLIMIT || OrderType() == OP_BUYSTOP) && OrderSymbol() == Symbol() && OrderMagicNumber() == MagicNumber) {
if(CurrentTime() - OrderOpenTime() < MinutesTo Expire * 60) OrderDelete...
}
  • #12
  • Last Post: Oct 28, 2008 1:30am Oct 28, 2008 1:30am
Thanks Ron,

Will try it out now. I was just changing the secondstoexpire to bigger values and seeing if its working. Let me do some modifications and post the code.

A Big thanks once again.
0 traders viewing now