Programming Newbie. Please Help.

Quoting LongToBeFree

Disliked

Roughly speaking, you would have to create a loop function that runs through all of the bars on the chart, determine if your criteria applies and then draw the arrows as needed. That would be the most straightforward way to do it and you'd want to make sure that you only do it once, so maybe you'd call it from init.

Ignored

//+------------------------------------------------------------------+
//|                                               Highlowexample.mq4 |
//|                                                          Brijesh |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright "Brijesh"
#property link      ""

#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 DarkGreen
#property indicator_color2 Red
//---- buffers
double ExtMapBuffer1[];
double ExtMapBuffer2[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
//---- indicators
   SetIndexStyle(0,DRAW_ARROW);
   SetIndexArrow(0,217);
   SetIndexBuffer(0,ExtMapBuffer1);
   SetIndexEmptyValue(0,0.0);
   SetIndexStyle(1,DRAW_ARROW);
   SetIndexArrow(1,218);
   SetIndexBuffer(1,ExtMapBuffer2);
   SetIndexEmptyValue(1,0.0);
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
  {
   int counted_bars=IndicatorCounted();
   Comment("High Low Running");
//----
   if (High[1] > High [2])
      {
      ExtMapBuffer1[1]=Low[1]-5*Point;
      Alert("New High");
      }
   
   else
   
   if (Low[1] < Low [2])
      {
      ExtMapBuffer2[1]=High[1]+5*Point;
      Alert("New Low");
      }
   
   else
//----
   return(0);
  }
//+------------------------------------------------------------------+ 

Quoting Kenz987

Disliked

1) Study and code the example in post #2. If you get that down it will save you hours and hours. When an indicator is first loaded it is given all the Bars (lets say there are 1000 of them). The number processed so far (ie Counted) is zero. The Bar count is relative to 1, but the array index is relative to zero. The first bar on the chart is the left-most and it has index of [Bars-1]. So to look at each bar in order from left to right the index would go from 9999 to 0, you could use a while loop as in the example but most people use a for loop. The example can explain this much better that I can.
2) You have to save the time that the alert was last made and not do it again until the time has changed. Time[0] gives the STARTING time of the bar, so there are no seconds.

Ignored

//+------------------------------------------------------------------+
//|                                                           A1.mq4 |
//|                                                          Brijesh |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright "Brijesh"
#property link      ""

#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 DarkGreen
#property indicator_color2 Red
//---- buffers
double ExtMapBuffer1[];
double ExtMapBuffer2[];
extern bool SoundON=true;
extern int BarsToProcess = 1000;
double alertTag;

//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
//---- indicators
   SetIndexStyle(0,DRAW_ARROW);
   SetIndexArrow(0,217);
   SetIndexBuffer(0,ExtMapBuffer1);
   SetIndexEmptyValue(0,0.0);
   SetIndexStyle(1,DRAW_ARROW);
   SetIndexArrow(1,218);
   SetIndexBuffer(1,ExtMapBuffer2);
   SetIndexEmptyValue(1,0.0);
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
  {
   int    counted_bars=IndicatorCounted();
   Comment("High Low Running");
//----
   pastdata();
   HL();
   
//----
   return(0);
  }
//+------------------------------------------------------------------+

void pastdata()
{   
   for (int a=BarsToProcess; a>=1; a--)
      {
         if (High[a] > High[a-1])
             
                  {
                     ExtMapBuffer1[a]=Low[a]-5*Point;
                   
                  }   
          else
          if (Close[a] < Close[a-1])
             
                  {
                     ExtMapBuffer2[a]=High[a]+5*Point;
                   
                  }        
             
      }

}


void HL()
   {
   if (High[1] > High [2] && alertTag!=Time[0])
         {
            
            ExtMapBuffer1[1]=Low[1]-15*Point;
            Alert("High Made");
            alertTag = Time[0];
               
         }
   
      else
    
   if (Low[1] < Low [2] && alertTag!=Time[0])
         {
      
         ExtMapBuffer2[1]=High[1]+15*Point;
         Alert("Low Made");
            alertTag = Time[0];
         
         }
    }