Attachments: Currenttime() - Orderclosetime() problem

Currenttime() - Orderclosetime() problem

#1
First Post: Sep 21, 2008 10:08pm Sep 21, 2008 10:08pm

Jwentro
| Joined Sep 2008 | Status: Pips do not always equal profits | 370 Posts

I'm having some problems getting my EA to wait a specific period of time between trades. I know I'm supposed to use the two variables listed above but i can't get it to work properly (especially in back tests). I know I'm not referencing previously closed orders correctly.

If anyone can help me insert the proper code i would greatly appreciate it.

Thank you in advance for any help.

#define SIGNAL_NONE 0
#define SIGNAL_BUY 1
#define SIGNAL_SELL 2
#define SIGNAL_CLOSEBUY 3
#define SIGNAL_CLOSESELL 4
extern int MagicNumber = 0;
extern bool SignalMail = False;
extern bool EachTickMode = True;
extern double Lots = 0.1;
extern int Slippage = 0;
extern bool UseStopLoss = True;
extern int StopLoss = 30;
extern bool UseTakeProfit = True;
extern int TakeProfit = 5;
extern bool UseTrailingStop = False;
extern int TrailingStop = 30;
extern string hd = " --Delay time--";
extern int useDelay = 1;
extern int useDelayAfterWin = 1;
extern int MinutesToDelay = 180;
int BarCount;
int Current;
bool TickCheck = False;
// expert initialization function
int init() {
BarCount = Bars;
if (EachTickMode) Current = 0; else Current = 1;
return(0);
}
// expert deinitialization function
int deinit() {
return(0);
}
// expert start function
int start() {
int Order = SIGNAL_NONE;
int Total, Ticket;
double StopLossLevel, TakeProfitLevel;

if (EachTickMode && Bars != BarCount) TickCheck = False;
Total = OrdersTotal();
Order = SIGNAL_NONE;
// Variable Begin
double Var1 = iBullsPower(NULL, 0, 13, PRICE_CLOSE, Current + 0);
double Var2 = iBullsPower(NULL, 0, 13, PRICE_CLOSE, Current + 1);
double Var3 = iBullsPower(NULL, 0, 13, PRICE_CLOSE, Current + 2);
double Var4 = iBearsPower(NULL, 0, 13, PRICE_CLOSE, Current + 0);
double Var5 = iBearsPower(NULL, 0, 13, PRICE_CLOSE, Current + 1);
double Var6 = iMACD(NULL, 0, 12, 20, 9, PRICE_CLOSE, MODE_MAIN, Current + 0);
double Var7 = iMACD(NULL, 0, 12, 20, 9, PRICE_CLOSE, MODE_MAIN, Current + 1);
double Var8 = iMACD(NULL, 0, 12, 20, 9, PRICE_CLOSE, MODE_MAIN, Current + 2);
double Var9 = iCCI(NULL, 0, 14, PRICE_CLOSE, Current + 0);
double Var10 = iCCI(NULL, 0, 14, PRICE_CLOSE, Current + 1);
double Var11 = iCCI(NULL, 0, 14, PRICE_CLOSE, Current + 2);
double Var12 = iCCI(NULL, 0, 14, PRICE_CLOSE, Current + 3);
double Buy1_1 = Var1 ;
double Buy1_2 = 0;
double Buy2_1 = Var1 ;
double Buy2_2 = Var2 ;
double Buy3_1 = Var2 ;
double Buy3_2 = -0.0003;
double Buy4_1 = Var3 ;
double Buy4_2 = -0.0008;
double Buy5_1 = Var4 ;
double Buy5_2 = 0;
double Buy6_1 = Var5 ;
double Buy6_2 = 0;
double Buy7_1 = Var6 ;
double Buy7_2 = Var7 ;
double Buy8_1 = Var7 ;
double Buy8_2 = Var8 ;
double Buy9_1 = Var9 ;
double Buy9_2 = 100;
double Buy10_1 = Var9 ;
double Buy10_2 = Var10 ;
double Buy11_1 = Var10 ;
double Buy11_2 = Var11 ;
double Buy12_1 = Var1 ;
double Buy12_2 = 0.006;
double Buy13_1 = Var2 ;
double Buy13_2 = Var3 ;
double Buy14_1 = Var4 ;
double Buy14_2 = Var5 ;
double Buy15_1 = Var2 ;
double Buy15_2 = 0.06;
double Buy16_1 = Var11;
double Buy16_2 = Var12;

double CloseBuy1_1 = Var3 ;
double CloseBuy1_2 = Var2 ;
double CloseBuy2_1 = Var2 ;
double CloseBuy2_2 = Var1 ;
double CloseBuy3_1 = 100;
double CloseBuy3_2 = Var9 ;

// Variable End

//Check position
bool IsTrade = False;
for (int i = 0; i < Total; i ++) {
OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
if(OrderType() <= OP_SELL && OrderSymbol() == Symbol()) {
IsTrade = True;
if(OrderType() == OP_BUY) {
//Close

// Signal Begin(Exit Buy)

if (CloseBuy1_1 > CloseBuy1_2 && CloseBuy2_1 > CloseBuy2_2 && CloseBuy3_1 > CloseBuy3_2) Order = SIGNAL_CLOSEBUY;

// Signal End(Exit Buy)
if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(UseTrailingStop && TrailingStop > 0) {
if(Bid - OrderOpenPrice() > Point * TrailingStop) {
if(OrderStopLoss() < Bid - Point * TrailingStop) {
OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
} else {
//Close

// Signal Begin(Exit Sell)

// Signal End(Exit Sell)

if (Order == SIGNAL_CLOSESELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Close Sell");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(UseTrailingStop && TrailingStop > 0) {
if((OrderOpenPrice() - Ask) > (Point * TrailingStop)) {
if((OrderStopLoss() > (Ask + Point * TrailingStop)) || (OrderStopLoss() == 0)) {
OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TrailingStop, OrderTakeProfit(), 0, DarkOrange);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
}
}
}

// Signal Begin(Entry)

if (Buy1_1 >= Buy1_2 && Buy2_1 > Buy2_2 && Buy3_1 > Buy3_2 && Buy4_1 >= Buy4_2 && Buy5_1 > Buy5_2 && Buy6_1 > Buy6_2 && Buy7_1 >= Buy7_2 && Buy8_1 >= Buy8_2 && Buy9_1 >= Buy9_2 && Buy10_1 >= Buy10_2 && Buy11_1 > Buy11_2 && Buy12_1 < Buy12_2 && Buy13_1 > Buy13_2 && Buy14_1 > Buy14_2 && Buy15_1 < Buy15_2 && Buy16_1 > Buy16_2) Order = SIGNAL_BUY;

// Signal End
//Buy
if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lots)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}
if (UseStopLoss) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0;
Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("BUY order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");
} else {
Print("Error opening BUY order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}
//Sell
if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lots)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}
if (UseStopLoss) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0;
Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("SELL order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Open Sell");
} else {
Print("Error opening SELL order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}
if (!EachTickMode) BarCount = Bars;
return(0);
}

#2
Sep 22, 2008 12:57am Sep 22, 2008 12:57am

trendchaser
| Membership Revoked | Joined Oct 2007 | 2,124 Posts

heres how i do it, some count the bar, but i use a interval, this way you can trade as if on any time frame
interval=1 is one minute, so 0.01 is 1 second

il post some code i made a while back, i made the parts you need in bold

//we can also use time as a trading interval

extern double interval=60;
bool trade_allowed=true;
double minutes = 0;

//put after start
double interval2 = interval*60;
if (TimeCurrent()<minutes) trade_allowed=false;
if (TimeCurrent()>minutes) trade_allowed=true;

if (trade_allowed&&indy1>indy2) {
OrderSend(Symbol(),OP_BUY, LotsOptimized(), Ask, 200, Ask-sl*Point, Ask+tp*Point, ""+oreder_comment+"", MagicNumber, 236, DodgerBlue);
minutes=TimeCurrent()+interval2;
{
}
}

if (trade_allowed&&indy1<indy2) {
OrderSend(Symbol(),OP_SELL, LotsOptimized(), Bid, 200, Bid+sl*Point, Bid-tp*Point, ""+oreder_comment+"", MagicNumber, 236, Red);
minutes=TimeCurrent()+interval2;
{
}
}

#3
Sep 22, 2008 9:15am Sep 22, 2008 9:15am

Jwentro
| Joined Sep 2008 | Status: Pips do not always equal profits | 370 Posts

Trendchaser, Im having problems executing trades whenever I set the interval to anything other than 0. obviously i have not inserted the coding into the proper areas

, i have labeled where i inserted the code in bold.

thank you for your help!

#define SIGNAL_NONE 0
#define SIGNAL_BUY 1
#define SIGNAL_SELL 2
#define SIGNAL_CLOSEBUY 3
#define SIGNAL_CLOSESELL 4

extern int MagicNumber = 0;
extern bool SignalMail = False;
extern bool EachTickMode = True;
extern double Lots = 0.1;
extern int Slippage = 0;
extern bool UseStopLoss = True;
extern int StopLoss = 30;
extern bool UseTakeProfit = True;
extern int TakeProfit = 5;
extern bool UseTrailingStop = False;
extern int TrailingStop = 30;
extern double interval=60;

bool trade_allowed=true;
double minutes = 0;
int BarCount;
int Current;
bool TickCheck = False;

//| expert initialization function
int init() {
BarCount = Bars;
if (EachTickMode) Current = 0; else Current = 1;
return(0);
}

//| expert deinitialization function
int deinit() {
return(0);
}

//| expert start function

int start() {
int Order = SIGNAL_NONE;
int Total, Ticket;
double StopLossLevel, TakeProfitLevel;
double interval2 = interval*60;
if (TimeCurrent()<minutes) trade_allowed=false;
if (TimeCurrent()>minutes) trade_allowed=true;
minutes=TimeCurrent()+interval2;

if (EachTickMode && Bars != BarCount) TickCheck = False;
Total = OrdersTotal();
Order = SIGNAL_NONE;
//| Variable Begin

double Var1 = iBullsPower(NULL, 0, 13, PRICE_CLOSE, Current + 0);
double Var2 = iBullsPower(NULL, 0, 13, PRICE_CLOSE, Current + 1);
double Var3 = iBullsPower(NULL, 0, 13, PRICE_CLOSE, Current + 2);
double Var4 = iBearsPower(NULL, 0, 13, PRICE_CLOSE, Current + 0);
double Var5 = iBearsPower(NULL, 0, 13, PRICE_CLOSE, Current + 1);
double Var6 = iMACD(NULL, 0, 12, 20, 9, PRICE_CLOSE, MODE_MAIN, Current + 0);
double Var7 = iMACD(NULL, 0, 12, 20, 9, PRICE_CLOSE, MODE_MAIN, Current + 1);
double Var8 = iMACD(NULL, 0, 12, 20, 9, PRICE_CLOSE, MODE_MAIN, Current + 2);
double Var9 = iCCI(NULL, 0, 14, PRICE_CLOSE, Current + 0);
double Var10 = iCCI(NULL, 0, 14, PRICE_CLOSE, Current + 1);
double Var11 = iCCI(NULL, 0, 14, PRICE_CLOSE, Current + 2);
double Var12 = iCCI(NULL, 0, 14, PRICE_CLOSE, Current + 3);

double Buy1_1 = Var1 ;
double Buy1_2 = 0;
double Buy2_1 = Var1 ;
double Buy2_2 = Var2 ;
double Buy3_1 = Var2 ;
double Buy3_2 = -0.0003;
double Buy4_1 = Var3 ;
double Buy4_2 = -0.0008;
double Buy5_1 = Var4 ;
double Buy5_2 = 0;
double Buy6_1 = Var5 ;
double Buy6_2 = 0;
double Buy7_1 = Var6 ;
double Buy7_2 = Var7 ;
double Buy8_1 = Var7 ;
double Buy8_2 = Var8 ;
double Buy9_1 = Var9 ;
double Buy9_2 = 100;
double Buy10_1 = Var9 ;
double Buy10_2 = Var10 ;
double Buy11_1 = Var10 ;
double Buy11_2 = Var11 ;
double Buy12_1 = Var1 ;
double Buy12_2 = 0.006;
double Buy13_1 = Var2 ;
double Buy13_2 = Var3 ;
double Buy14_1 = Var4 ;
double Buy14_2 = Var5 ;
double Buy15_1 = Var2 ;
double Buy15_2 = 0.06;
double Buy16_1 = Var11 ;
double Buy16_2 = Var12 ;

double CloseBuy1_1 = Var3 ;
double CloseBuy1_2 = Var2 ;
double CloseBuy2_1 = Var2 ;
double CloseBuy2_2 = Var1 ;
double CloseBuy3_1 = 100;
double CloseBuy3_2 = Var9 ;

//Variable End

//Check position
bool IsTrade = False;
for (int i = 0; i < Total; i ++) {
OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
if(OrderType() <= OP_SELL && OrderSymbol() == Symbol()) {
IsTrade = True;
if(OrderType() == OP_BUY) {
//Close

//Signal Begin(Exit Buy)

if (CloseBuy1_1 > CloseBuy1_2 && CloseBuy2_1 > CloseBuy2_2 && CloseBuy3_1 > CloseBuy3_2) Order = SIGNAL_CLOSEBUY;

// Signal End(Exit Buy)

if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(UseTrailingStop && TrailingStop > 0) {
if(Bid - OrderOpenPrice() > Point * TrailingStop) {
if(OrderStopLoss() < Bid - Point * TrailingStop) {
OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
} else {
//Close

// Signal Begin(Exit Sell)

// Signal End(Exit Sell)

if (Order == SIGNAL_CLOSESELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Close Sell");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(UseTrailingStop && TrailingStop > 0) {
if((OrderOpenPrice() - Ask) > (Point * TrailingStop)) {
if((OrderStopLoss() > (Ask + Point * TrailingStop)) || (OrderStopLoss() == 0)) {
OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TrailingStop, OrderTakeProfit(), 0, DarkOrange);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
}
}
}

// Signal Begin(Entry)

if (Buy1_1 >= Buy1_2 && Buy2_1 > Buy2_2 && Buy3_1 > Buy3_2 && Buy4_1 >= Buy4_2 && Buy5_1 > Buy5_2 && Buy6_1 > Buy6_2 && Buy7_1 >= Buy7_2 && Buy8_1 >= Buy8_2 && Buy9_1 >= Buy9_2 && Buy10_1 >= Buy10_2 && Buy11_1 > Buy11_2 && Buy12_1 < Buy12_2 && Buy13_1 > Buy13_2 && Buy14_1 > Buy14_2 && Buy15_1 < Buy15_2 && Buy16_1 > Buy16_2 && trade_allowed) Order = SIGNAL_BUY;
minutes=TimeCurrent()+interval2;

// Signal End

//Buy
if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lots)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}
if (UseStopLoss) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0;
Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("BUY order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");
} else {
Print("Error opening BUY order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}
//Sell
if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lots)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}
if (UseStopLoss) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0;
Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("SELL order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Open Sell");
} else {
Print("Error opening SELL order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}
if (!EachTickMode) BarCount = Bars;
return(0);
}

#4
Sep 22, 2008 9:32am Sep 22, 2008 9:32am

luxinterior
Joined Nov 2006 | Status: MT4 EA Coder Since 2006 | 300 Posts

You need to use braces in your IF statement, like...

Inserted Code

if(loads of conditions){
do this;
and do this;
}

Hope that makes sense.

Lux

MT4 EA, Indicator and Alert Coder Since 2006

#5
Sep 22, 2008 9:45am Sep 22, 2008 9:45am

Jwentro
| Joined Sep 2008 | Status: Pips do not always equal profits | 370 Posts

Lux,

the EA works fine as it is right now, I'm more concerned with adding the variables needed to make the EA sleep() or not trade for 30 minutes after closing a trade.

Thanks for your help

#6
Sep 22, 2008 10:55am Sep 22, 2008 10:55am

trendchaser
| Membership Revoked | Joined Oct 2007 | 2,124 Posts

ok youv put this in the wrong place minutes=TimeCurrent()+interval2;

that should be just after you open a trade, after the ordersend

put it after buy, and after sell
since you put it before, you wont get a trade, as its constantly setting it self every tick

#7
Sep 22, 2008 12:16pm Sep 22, 2008 12:16pm

Jwentro
| Joined Sep 2008 | Status: Pips do not always equal profits | 370 Posts

Trendchaser,

thank you so much for your help, I've got the code working properly.

Couldn't have done it without you.

Thanks Again

Jwentro

#8
Last Post: Sep 22, 2008 12:24pm Sep 22, 2008 12:24pm

Gambler180
| Joined Mar 2007 | Status: Trader | 680 Posts

I did something wrong. sorry. I wanted to create a new thread. Just ignore this post.

Attached File(s)

EURGBP_King1.mq4 3 KB | 321 downloads

If slaughterhouses had glass walls, everyone would be a vegetarian!

Platform Tech
/
Currenttime() - Orderclosetime() problem
Reply to Thread

0 traders viewing now

Options

Similar Threads

Currenttime() - Orderclosetime() problem