What am I doing wrong? (Simple Stochastic value problem) | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

In search of Stochastic indicator - MT4 - with numerical value 2 replies

Stochastic divergence indicator with stochastic cross? 0 replies

Why Is Price Doing What It's Doing? 65 replies

Simple daily stochastic system 10 replies

Simple EA based on stochastic 2 replies

What am I doing wrong? (Simple Stochastic value problem)

  • #1
  • First Post: Edited 4:34am Sep 17, 2008 4:22am | Edited 4:34am
Howdy, i'm trying to get my indicator to operate based on a different stochastic timeframe rather than 0 but it never seems to return the value I require at the time which is annoying.

It will return a 0 timeframe stochastic value correctly but anytime I try to say "Check if M30 is doing this" it never matches up with the actual value when I double check it by switching to the 30 at the same time frame.

Tried numerical and expression values for the timeframe but it NEVER gives me the right thing. Anyone know why?

simplified

i'm on a 15m time frame, want to get results for a stochastic on my chart timeframe of 15m and for the 30m as well. Can't get the stochastic to return the right value for 30m. Am I misinterpreting something? For reference sake the code compiles and returns correct values for the 0 timeframe. It's just when I require the current timeframe and a higher one it does not give the correct value. Even if I just tell the indicator to paint an arrow ONLY when the m30 stochastic is heading down it gives me really random readings. I use an MTF stochastic indicator to give me a visual aid without having to switch to a diff timeframe but I check my indicator manually.

Inserted Code
  sm1c=iStochastic(NULL,30,5,3,3,StochMethod,StochPrice,MODE_MAIN,i);
  sm2c=iStochastic(NULL,30,5,3,3,StochMethod,StochPrice,MODE_MAIN,i+1);  
  ss1c=iStochastic(NULL,30,5,3,3,StochMethod,StochPrice,MODE_SIGNAL,i);
  ss2c=iStochastic(NULL,30,5,3,3,StochMethod,StochPrice,MODE_SIGNAL,i+1);
  • #2
  • Sep 17, 2008 6:19am Sep 17, 2008 6:19am

could anyone at least show me a working example of an indicator that uses both a value from the current timeframe and a different one that works?

  • #3
  • Sep 17, 2008 7:10am Sep 17, 2008 7:10am
instead of simply 30, try PERIOD_M30
  • #4
  • Sep 17, 2008 7:16am Sep 17, 2008 7:16am
I said before that I have already tried numerical and the other expressions. i.e. PERIOD_M30 and 30 or PERIOD_H4 and 240

Is it perhaps just easier if I get an iCustom value from my MTF stochastic? I only wanted to use it for visual aid really.

Is the fact I use the i loop for all stochastic a problem? My coding is bare minimum so i'm sorry if I can't give the information required to solve my own problem.

I'll just post the entire code here. It may seem a tad messy but keep in mind that i'm learning as I go and i'm trying to create an indicator that I am happy with so there is a lot of statements that are no longer used but I keep there because I might return to them.

Inserted Code
#property indicator_chart_window
#property indicator_buffers 2

extern int offset=5;               // pips above/below high/low to paint arrows

extern int StochK=5;                // Stochastic %K
extern int StochD=3;                // Stochastic %D 
extern int StochSlowing=3;          // Stochastic Slowing
extern int StochMethod=MODE_SMA;    // Stochastic Method
extern int StochPrice=0;            // Stochastic Price (0=low/high, 1=close/close)

double SignalL[],SignalS[];


//===========================================================================================
//===========================================================================================
int init() 
{
 SetIndexBuffer(0,SignalL);
 SetIndexStyle(0, DRAW_ARROW,DRAW_ARROW,1,Green);
 SetIndexArrow(0,SYMBOL_ARROWUP);
 SetIndexBuffer(1,SignalS);
 SetIndexStyle(1, DRAW_ARROW,DRAW_ARROW,1,Red); 
 SetIndexArrow(1,SYMBOL_ARROWDOWN);
 
 return(0);
}
//===========================================================================================
//===========================================================================================
int deinit()
{
 return(0);
}
//===========================================================================================
//===========================================================================================

int start() 
{
 int i,imax,counted_bars=IndicatorCounted(); 
 double ao1,ac1,ao2,ac2,sm1a,sm2a,ss1a,ss2a,sm1b,sm2b,ss1b,ss2b,sm1c,sm2c,ss1c,ss2c,sm1d,sm2d,ss1d,ss2d,ma1,ma2,ma3,macd1a,macd1b;
 if(counted_bars>0) imax=Bars-IndicatorCounted();
 else imax=Bars-1; 
 
 double limit=50;  // your crossing point value (20, 50, or 80, etc) 
 
 for(i=imax;i>=0;i--) 
 {
  SignalL[i]=EMPTY_VALUE;
  SignalS[i]=EMPTY_VALUE;
  
  ao1=iAO(NULL,0,i);
  ao2=iAO(NULL,0,i+1);
  ac1=iAC(NULL,0,i);
  ac2=iAC(NULL,0,i+1);
  
  sm1a=iStochastic(NULL,0,5,3,3,StochMethod,StochPrice,MODE_MAIN,i);
  sm2a=iStochastic(NULL,0,5,3,3,StochMethod,StochPrice,MODE_MAIN,i+1);  
  ss1a=iStochastic(NULL,0,5,3,3,StochMethod,StochPrice,MODE_SIGNAL,i);
  ss2a=iStochastic(NULL,0,5,3,3,StochMethod,StochPrice,MODE_SIGNAL,i+1);
 
  sm1b=iStochastic(NULL,0,14,3,3,StochMethod,StochPrice,MODE_MAIN,i);
  sm2b=iStochastic(NULL,0,14,3,3,StochMethod,StochPrice,MODE_MAIN,i+1);  
  ss1b=iStochastic(NULL,0,14,3,3,StochMethod,StochPrice,MODE_SIGNAL,i);
  ss2b=iStochastic(NULL,0,14,3,3,StochMethod,StochPrice,MODE_SIGNAL,i+1);
   
  sm1c=iStochastic(NULL,30,5,3,3,StochMethod,StochPrice,MODE_MAIN,i);
  sm2c=iStochastic(NULL,30,5,3,3,StochMethod,StochPrice,MODE_MAIN,i+1);  
  ss1c=iStochastic(NULL,30,5,3,3,StochMethod,StochPrice,MODE_SIGNAL,i);
  ss2c=iStochastic(NULL,30,5,3,3,StochMethod,StochPrice,MODE_SIGNAL,i+1);

  sm1d=iStochastic(NULL,60,5,3,3,StochMethod,StochPrice,MODE_MAIN,i);
  sm2d=iStochastic(NULL,60,5,3,3,StochMethod,StochPrice,MODE_MAIN,i+1);  
  ss1d=iStochastic(NULL,60,5,3,3,StochMethod,StochPrice,MODE_SIGNAL,i);
  ss2d=iStochastic(NULL,60,5,3,3,StochMethod,StochPrice,MODE_SIGNAL,i+1);
  
  macd1a=iMACD(NULL,0,5,13,1,PRICE_CLOSE,MODE_MAIN,i);
  macd1b=iMACD(NULL,0,5,13,1,PRICE_CLOSE,MODE_MAIN,i+1);
    
  ma1=iMA(NULL,0,89,0,MODE_EMA,PRICE_CLOSE,i);
  ma2=iMA(NULL,0,4,0,MODE_EMA,PRICE_CLOSE,i);
  ma3=iMA(NULL,0,8,0,MODE_EMA,PRICE_CLOSE,i);
  
// Stochastic Notes

// Main = %K = Solid Line
// Signal = %D = Dashed Line

// sm2<limit && sm1>limit = Main line crossed above limit 
// sm2>limit && sm1<limit = Main line crossed below limit 
// ss2<limit && ss1>limit = Signal line crossed above limit 
// ss2>limit && ss1<limit = Signal line crossed below limit

// sm1>ss1&&sm2<ss2 = Stochastic Cross Up
// sm1<ss1&&sm2>ss2 = Stochastic Cross Down

// AC & AO Notes

// ac1>ac2 = Green AC
// ac1<ac2 = Red AC
// ao1>ao2 = Green AO
// ao1<ao2 = Red AO
  
  if(sm1b>ss1b && sm1c>ss1c)
  {
   if(sm1b<70) SignalL[i]=iLow(NULL,0,i)-offset*Point;
  }
  else if(sm1b<ss1b && sm1c<ss1c)
  {
   if(sm1b>30)SignalS[i]=iHigh(NULL,0,i)+offset*Point;
  }
 }

 return(0);
}
//===========================================================================================
//===========================================================================================
  • #5
  • Sep 17, 2008 9:40am Sep 17, 2008 9:40am
You cannot use same i value for different timeframes. 10 bars back in 15M is equal to 30 bars back in 5M chart. So, if you use same i value, the data will not match the bars correctly. For each timeframe, you have to use an appropriate shift. Check how MTF stoch handles this and use similar line for each timeframe, except for current chart TF (may be it uses a line called iBarShift).

Regards,
chandra
  • #6
  • Sep 17, 2008 10:00am Sep 17, 2008 10:00am
I have no idea how to incorporate ibarshift into this though.

Is it possible to have multiple i values perhaps?
  • #7
  • Sep 17, 2008 6:04pm Sep 17, 2008 6:04pm
Quoting Omniferum
I have no idea how to incorporate ibarshift into this though.

Is it possible to have multiple i values perhaps?
Yes. You have to use different shift variables (one for each TF). For example,

PHP Code
int i1 = iBarShift(Symbol(),30,Time[i],false); // use i1 for all 30M indicators, but leave Time[i] as such, do not change that i.
 sm1c=iStochastic(NULL,30,5,3,3,StochMethod,StochPrice,MODE_MAIN,i1);
 
int i2 = iBarShift(Symbol(),60,Time[i],false); // use i2 for all 60M indicators, but leave Time[i] as such, do not change that i.
 sm1d=iStochastic(NULL,60,5,3,3,StochMethod,StochPrice,MODE_MAIN,i2);
Leave all others as "i" itself (in "for" loop; or in any Buffer assignment, which you are not using, just mentioning).

I hope this helps/works (add/change other lines using this example).

Regards,
chandra
  • #8
  • Sep 17, 2008 6:35pm Sep 17, 2008 6:35pm
Worked like a charm, thanks chandra

Only thing I have a problem with now, and this is really something I can't explain, is that it works perfect. But I only get buy signals, no signals for short values occur anywhere on my chart.

Anyone know why?
  • #9
  • Sep 17, 2008 6:48pm Sep 17, 2008 6:48pm
Um, apparently if I use the 30m timeshifted stochastics the returned values are correct but I only get buy signals.

If I use the 60m then I only get sell signals but the values are wrong.

Those are both with 0 timeframe stochastic and on their own

If I try to use all 3, which is what I want, I get no signals at all
  • #10
  • Sep 17, 2008 8:24pm Sep 17, 2008 8:24pm
May be you can post the new code and I will look through.

chandra
  • #11
  • Last Post: Sep 17, 2008 9:11pm Sep 17, 2008 9:11pm
It's ok I sorted it out, pasted new code in a silly place.

All good Thanks again chandra

I actually understand the ibarshift, only ever need an example to learn stuff

Now all I need to get is the iCustom down pat for this one Ultra Trend Indicator and i'll be set
0 traders viewing now