Need Help in Coding! | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Need help coding a simple system 4 replies

I Will Learn Coding in 1 Month - Give me the 80/20 of MT4 Coding 14 replies

Need help with coding account number in EA 2 replies

Need help coding reverse strategy of this EA 0 replies

Need help with coding - Alert and Email 1 reply

Need Help in Coding!

  • #1
  • First Post: Aug 13, 2008 11:03am Aug 13, 2008 11:03am
i have created a really simple EA.. and a system which i use in atleast 3 Timeframe..May problem it doesn't stop opening and i don't want to have 3 EA and 3 chart for one pair..

i need a code that would only do one order per bar per TF and still open if it is on a different bar..

Sometimes i have 3 signal in 3 different TF.. i want to take all order but i want only order per TF and i can still take another order in same TF if it is still open but in a different bar..

example:
1 signal in 4h
1 signal in 1h but it falls in bar for 4h
1 signal in 30 min but only one bar for 1h and 4h..

i am ok with using magicnumber

can someone help me? thank you very much..
  • #2
  • Aug 13, 2008 12:57pm Aug 13, 2008 12:57pm
I will take a look at that.
If everyone believes it, it will work.
  • #3
  • Aug 13, 2008 9:00pm Aug 13, 2008 9:00pm
Quoting EAprogrammer
I will take a look at that.

Thank you.. hope to hear from you..
  • #4
  • Aug 14, 2008 5:49am Aug 14, 2008 5:49am
Anyone who has a similar code?
  • #5
  • Aug 15, 2008 3:10am Aug 15, 2008 3:10am
what can i do with this code? or i am not using the right code..

Time(OrderOpenTime()) = iTime(Symbol(),PERIOD_M30,0)
  • #6
  • Aug 16, 2008 7:37am Aug 16, 2008 7:37am
i think my explaination is bad.. try to explain again

i need a code that can take at least one order for buy and sell per bar..

but some times i have 3 signal for one bar in higher TF cause i use 3 TF and each has different signals but it falls on the same bar for higher TF.

so far this is my solution:
i am ok with using magic number as means of filter.

can someone help me? thank you very much.

so far this is what i thought:
for 30 mins
if (magicnumber == 123)
{
if (iTime(OrderOpenTime()) != iTime(Symbol(),PERIOD_M30,0))
{//my order code}

}

i don't have MT4 but i know somethings is not right in the logic or code. So guys please help me.
  • #7
  • Aug 16, 2008 3:06pm Aug 16, 2008 3:06pm
would this work???

int init()
{
LastBuyTime = 0;
LastSellTime = 0;
}

int start()
{
if (Buy Conditions Met)
{
if (Time[0] > LastBuyTime) //check the time of last buy order
{ //process order
OrderSend(blah blah blah);
if (No Error) LastBuyTime = Time[0];
}
}
//repeat the same for Sell
return(0);
}
  • #8
  • Aug 16, 2008 3:09pm Aug 16, 2008 3:09pm
if you use separate EA for different time frame, then the above code should work
if it works, it should be better compared to sending information to & from the server all the time to check the OrderOpenTime()??

but if you use the same EA for different time frame
then if you need to do the same with each time frame then either use arrays
ie. LastBuyTime[Period()]
or if you only trade 3 time frame then use
LastBuyTimeM15
LastBuyTimeH1
LastBuyTimeH4
etc.etc..


if the array method is too messy as it creates 240 arrays if you trade 4 hour chart, then you need separate code to convert Period() to an integer, ie. 1minute=0, 5 minute =1, 15min = 2 etc.etc. and use this integer to reference the array...
  • #9
  • Aug 16, 2008 3:10pm Aug 16, 2008 3:10pm
and if you are afraid that there's too many ticks happening in the same second, then you can also record down the Volume[0] of the moment when you last placed the order to make sure it won't place 2 orders in the same second...
  • #10
  • Aug 17, 2008 10:47am Aug 17, 2008 10:47am
actually i will use one EA and one chart to trade 3 TF..

anyways, i don't know much about array and so i will try the last code you posted.. if you can give me a bit of details about how to attach it would be much appreciated.. thank you..
  • #11
  • Aug 19, 2008 6:38am Aug 19, 2008 6:38am
i have a question..

would current time be equal to bar?

ei:

int init()
{
LastBuyTime = 0;
LastSellTime = 0;
}

int start()
{
if (OrderOpentime() > LastBuyTime30) //check the time of last buy order
{
LastBuyTime30 = OrderOpenTime ()
}
if LastBuyTime30 < iTime(null,period,0) && (magicnumber != 123)
{the buy order condition}
return(0);
}
  • #12
  • Aug 19, 2008 1:00pm Aug 19, 2008 1:00pm
if you trade 3 time frame using one chart using the same EA, it becomes much more complicated, as Time[0] returns the start time of the current un-closed candle in your chart, thus you will need some code to filter out the time range of each candle.
The problem is less complicated if you trade only 15min, hourly & daily, coz if you embedded the EA in the 15min chart, then you can use the TimeHour() function to filter out the hour of the last tick and it's quite easy...
But if you trade 4hour and 1hour chart at the same time, then you will need more code, ie. (NormalizeDouble(TimeHour(TimeCurrent())/4),0) * 4 will return the start time of the current 4 hour candle, then you have to use this value and together with the function DayOfYear & Year to store the time when you last entered an order when triggered by 4 hour signal...
  • #13
  • Aug 19, 2008 1:01pm Aug 19, 2008 1:01pm
the solution for your problem seem very complicated... if you must trade 3 different time frames using one chart...

note: your example is still trying to retrieve the Last order time from the server (OrderOpenTime()) which I don't recommend as it creates extra network traffic and may create unneccesary network traffic for your server if your EA is looped too many times per second
  • #14
  • Aug 19, 2008 9:44pm Aug 19, 2008 9:44pm
Quoting dragoncat
the solution for your problem seem very complicated... if you must trade 3 different time frames using one chart...

note: your example is still trying to retrieve the Last order time from the server (OrderOpenTime()) which I don't recommend as it creates extra network traffic and may create unneccesary network traffic for your server if your EA is looped too many times per second
Thank you.. i really like your idea but the problem is i am not good at coding..

if you show me a basic on how to attach what your posted here.. i don't know how to code arrays.. thank you..

another question what if my EA or MT4 reset? at the same time it took order will it take another order again?
  • #15
  • Aug 24, 2008 12:55am Aug 24, 2008 12:55am
Can someone stop this from modifing my order over and over again? also can someone give me help on code for step trailing stop? like only do trail stop every 10 pips or 5 pips instead of 1 pips.. can someone give me a code?

Quote
void BEM ()
{
int pips;
for (int k=0; k<OrdersTotal ();k++)
{
OrderSelect(k, SELECT_BY_POS, MODE_TRADES);
if(OrderType()==OP_BUY && OrderSymbol()== Symbol () && OrderMagicNumber()== Magic)
{
pips = (Bid - OrderOpenPrice())/Point;
if ((pips >= BE) && (OrderStopLoss() < OrderOpenPrice()))
{
OrderModify (OrderTicket (), OrderOpenPrice (),OrderOpenPrice ()+ 12*Point, OrderTakeProfit (), 0, LightBlue);
}
}
if(OrderType()==OP_SELL && OrderSymbol()== Symbol () && OrderMagicNumber()== Magic)
{
pips = (OrderOpenPrice() - Ask)/Point;
if ((pips >= BE) && (OrderStopLoss() > OrderOpenPrice()))
{
OrderModify (OrderTicket (), OrderOpenPrice (),OrderOpenPrice ()- 12*Point, OrderTakeProfit (), 0, Pink);
}
}
}
}
  • #16
  • Aug 24, 2008 7:25am Aug 24, 2008 7:25am
arrays is just like a variable, except that you use one variable name and use a number to reference to all the values, Time[], High[], Low[], Open[], Close[] etc.etc are examples of variable

i'd like to help more, but I've been very busy, and it's hard for me to help you if you don't know how to implement what I've suggested, you'll have to read the documentation on mq4 to try to learn more about the coding for the time being..
  • #17
  • Aug 24, 2008 7:41am Aug 24, 2008 7:41am
Quoting fercan
another question what if my EA or MT4 reset? at the same time it took order will it take another order again?

your EA should have codes, that when it first loads to check if any signal have been triggered with the most recent candle, and if so, resets the trigger/counter, thus preventing the EA from ever opening orders/creating alerts on the instance that the EA is loaded..
  • #18
  • Aug 24, 2008 9:03am Aug 24, 2008 9:03am
thanks.. if you don't mind.. maybe you can post an EA here with array i can study the code from there..

anyways, you have been of great help..
  • #19
  • Aug 25, 2008 10:07am Aug 25, 2008 10:07am
Can anyone give me the code for step trailing stop? i created one before but it always loops and loops
  • #20
  • Aug 26, 2008 8:26pm Aug 26, 2008 8:26pm
Quoting fercan
thanks.. if you don't mind.. maybe you can post an EA here with array i can study the code from there..
array is just like any other variable, hard to give an example
when you declare a variable, instead of "int MyValues", you declare it as "int MyValues[n]" instead, where "n" is the number of variables in your array,
so instead of having MyValues1=1.5400; MyValues2=1.5450; MyValues3=1.5520;
you can have an array, declare it as "int MyValues[3]"
then MyValues[1]=1.5400; MyValues[2]=1.5450; MyValues[3]=1.5520;

it may look silly, but if you are dealing with a lot of values, it makes sense...
0 traders viewing now