EA problem

EDIT...i solved it..but the solution makes no sense to me...i just removed the "return 0" and it suddenly worked...if anyone is willing to explain me why i would be grateful...

does the return somehow break the operation?

If psarnow is not rounded to the nearest whole Point, then your test will always fail.
A test like 'stoploss-psarnow > n*point' would be more reliable.

ok i changed the test to be similar to your suggestion...and it now works..ONCE!

I realized that even before not mnore than one order would be modified, while the same modify would be triggered forever. Now that is solved but it still works for one order only, once the first opened order (btw shouldnt the first opened order be the last to be modified) is modified, it wont do it again.

Here is the new code..anyone have a clue on what is wrong in it?

//moveall S.Loss
for (int cnt_moveall=0;cnt_moveall<total;cnt_moveall++)
{if(OrderSelect(cnt_moveall,SELECT_BY_POS))
{if (OrderType() == 0)
{if (psarnow - OrderStopLoss() > StopStep * Point)
{
Print ("Modifica tutti gli stoploss");
Sleep (60000);
OrderModify(OrderTicket(),OrderOpenPrice(),psarnow-1*Point,OrderTakeProfit(),0,Blue);
}
}
else if (OrderType() == 1)
{if (OrderStopLoss() - psarnow > StopStep * Point)
{
Print ("Modifica tutti gli stoploss");
Sleep (60000);
OrderModify(OrderTicket(),OrderOpenPrice(),psarnow+1*Point,OrderTakeProfit(),0,Blue);
}
}

i solved it..but the solution makes no sense to me...i just removed the "return 0" and it suddenly worked...if anyone is willing to explain me why i would be grateful...

does the return somehow break the operation?

I am sorry. I see no return (0) anywhere in your code posted.

I just posted the "heart" of the script, just to make people understand what it was like..the full section is like this...just a few parenthesis more and the return 0..wich i now slashed..

//moveall S.Loss
for (int cnt_moveall=0;cnt_moveall<total;cnt_moveall++)
{if(OrderSelect(cnt_moveall,SELECT_BY_POS))
{if (OrderType() == 0)
{if (psarnow - OrderStopLoss() > StopStep * Point)
{
Print ("Modifica tutti gli stoploss");
Sleep (60000);
OrderModify(OrderTicket(),OrderOpenPrice(),psarnow-1*Point,OrderTakeProfit(),0,Blue);
}
}
else if (OrderType() == 1)
{if (OrderStopLoss() - psarnow > StopStep * Point)
{
Print ("Modifica tutti gli stoploss");
Sleep (60000);
OrderModify(OrderTicket(),OrderOpenPrice(),psarnow+1*Point,OrderTakeProfit(),0,Blue);
}
}
//return(0);
}}

I think I see the problem here. The return(0) was INSIDE the loop, thus, making it work only once, as you said.
Hope I helped!!!
Warm regards,
Oksana17.