Attachments: Expert Advisor Help!

Expert Advisor Help!

#1
First Post: Jul 24, 2008 4:04pm Jul 24, 2008 4:04pm

drisc60
| Joined Feb 2008 | Status: Trader | 1 Post

I am trying to learn how to write code (yikes! I know) and have started with a simple EMA cross. The cross will trigger the trade with the given T/P, S/L, and trailing stop. So far...not so good. The trades are triggered, for what reason I have no idea and the trailing stop is not there.

Any help would be greatly appreciated. Also, I wanted to start embedding other indicators (if then statements) for a two to three tiered approach. Any comments or guidance on how I would accomplish this (for example if 5ema is over 10ema and RSI is greater than 50, place trade).

Again, any help would be greatly appreciated. I will attach my current pass at an EMA cross.

Attached File(s)

TEST EMA CROSS v1.mq4 5 KB | 340 downloads

#2
Last Post: Jul 24, 2008 6:33pm Jul 24, 2008 6:33pm

fxid10t
| Joined Jul 2007 | Status: accomplished neophyte | 170 Posts

I've noticed that when using Trading functions within "if" statements, the values don't always work, so I usually assign them to a variable then compare the variables... but I'm not a professional coder, and extensively use the trial and error (correction) method of scripting.

Here is some code that I use that works, perhaps you could look it over and use whatever you want...

PHP Code

//open sell(limit) management  
   if(OrderType()==OP_SELL/*&& OrderMagicNumber()==1776*/)  {
      st2=OrderOpenTime(); s2=OrderTicket();
      os=OrderOpenPrice(); ossl=OrderStopLoss(); ostp=OrderTakeProfit();
      /*
      if((dosc>=aob*0.618)/* || dosc<=aos*0.75 && Time[0]>OrderOpenTime())   {
         OrderClose(OrderTicket(),OrderLots(),Ask,0,CLR_NONE);
         s2=0; so=0;
         return(0);  }*/
      ssl=hi;//MathMax(hi+spread,dma25);
      if((ssl<ossl && Time[0]>OrderOpenTime() && ssl<sap && ssl>Ask+spread) ||(stp<ostp))   {
         mod=OrderModify(OrderTicket(),OrderOpenPrice(),ssl,stp,OrderExpiration(),CLR_NONE);
         if(mod==false) { Print("ssl=",ssl," stp=",stp); return(0);  }
         return(0);  }  }

and

PHP Code

//sell limit management
   if(OrderType()==OP_SELLLIMIT && OrderMagicNumber()==1776) {
      st2=OrderOpenTime(); s2=OrderTicket(); so=OrderOpenPrice();
      os=OrderOpenPrice(); ossl=OrderStopLoss(); ostp=OrderTakeProfit();
      if(ObjectFind(tll)<0 || ObjectFind(tlh)<0 || (dosc>aob))   { 
         OrderDelete(OrderTicket());
         s2=0; so=0;
         return(0);  }
      if(hi<OrderOpenPrice() && Ask<hi)  {
         s=hi;  s=NormalizeDouble(s,Digits);
         ssl=MathMin(s+aob,High[iHighest(0,0,MODE_HIGH,iBarShift(Symbol(),0,ObjectGet(tll,0)),0)])+spread;                
         ssl=NormalizeDouble(ssl,Digits)+spread;
         stp=0;//MathMin(s+dosc,MathMin(dma+aos,s+aos));   stp=NormalizeDouble(stp,Digits);
         if((s<os) || (ssl>ossl) || (stp<ostp)) {
            mod=OrderModify(OrderTicket(),s,ssl,stp,OrderExpiration(),CLR_NONE);
            if(mod==false) { Print("s=",s," ssl=",ssl," stp=",stp); return(0);  }
            return(0);  }  }  }

I usually keep an eye on the journal tab in the visual testing mode, and use Comment() to keep track of execution and variables to make sure everything is working the way I intended... good luck

Platform Tech
/
Expert Advisor Help!
Reply to Thread

0 traders viewing now

Options

Similar Threads

Expert Advisor Help!