Here is how iv tried to change it to an indicator. I think that maybe the map buffer does actually need a counter as the indicators i use have a for loop for counting back through the bars. I have tried it without also.
I also included a print statement to try to see if there is any value output.
It apears as 0.0000000. so i think there is a problem with converting it to an indicator, as im sure your code is correct. I have read through it as the computer would and i see how you have done this, so i think its just a case of getting the output value of totaldiff. Also maybe before the extmapbuffer is assigned the value totaldiff it needs to loop back to the top again maybe? or that might be stupid because it would never go back to extmapbuffer.
I will keep perservering.
Inserted Code
//+------------------------------------------------------------------+
//| Testindi.mq4 |
//| |
//| |
//+------------------------------------------------------------------+
#property copyright ""
#property link ""
#property indicator_separate_window
#property indicator_buffers 3
#property indicator_color1 Blue
#property indicator_color2 Red
#property indicator_color3 White
//---- buffers
double ExtMapBuffer1[];
double ExtMapBuffer2[];
double ExtMapBuffer3[];
extern int barcount = 3000;
//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
//---- indicators
SetIndexStyle(0,DRAW_LINE);
SetIndexBuffer(0,ExtMapBuffer1);
SetIndexStyle(1,DRAW_LINE);
SetIndexBuffer(1,ExtMapBuffer2);
SetIndexStyle(2,DRAW_LINE);
SetIndexBuffer(2,ExtMapBuffer3);
return(0);
}
//+------------------------------------------------------------------+
//| expert deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----
//----
return(0);
}
//+------------------------------------------------------------------+
//| expert start function |
//+------------------------------------------------------------------+
int start()
{
//----
double currentdiff = 0;
datetime lastCalculationTime;
double close1 = 0;
double close2 = 0;
bool calculationStarts = false;
double totaldiff = 0;
if (Time[0] > lastCalculationTime)
{
if (!calculationStarts)
{
close1 = Close[0];
lastCalculationTime = TimeCurrent();
calculationStarts = true;
}
else
{
close2 = close1;
close1 = Close[0];
currentdiff = close1 - close2;
totaldiff = totaldiff + currentdiff;
lastCalculationTime = TimeCurrent();
}
}
//// CHUNK OF NEW STUFF I PUT IN ////
Print("totaldiff" + totaldiff);
int counted_bars=IndicatorCounted(), limit ;
if(counted_bars>0)
counted_bars--;
limit=Bars-counted_bars;
if(limit>barcount)
limit=barcount;
for(int i=0;i<limit;i++)
{
ExtMapBuffer1[i] = totaldiff;
}
////------------/////
return(0);
}
//+------------------------------------------------------------------+
OK HERE IS AN OFFER TO A PROGRAMMER:
If you think you can make this indicator that Im trying to make I am willing to pay for it as long as it doesnt cost too much and it all works 100% as I want it to.
Just to re-iterate what im after:
An indicator with external variables:
pair1 string = "EURUSD"
pair2 string = "EURJPY"
barcount = number of bars back to start counting from
Here is the basics of what id like:
On start of indicator find the difference in close price of bar 1 and bar 2.
lets say the difference is 5 pips, so price closed 5 pips higher than previous bar. Store this value.
Next when a new bar closes again find the difference in close price between bar1 and bar 2. The old bar 1 and bar 2 will have shifted back 1 so bar 2 now was bar 1 before.
So get the new difference lets say its 3 pips, and add this to the stored value. Now we get 5 + 3 = 8.
Carry on for doing this for each new close of bar, just keep adding to the stored value and store the new value.
This new stored value i would like as the first map buffer. Also if I close the indicator down and restart id like it to still store this value, unless I want to delete it in which case I need a way to refresh it.
Then id like to do the same again the pair2. Store the stored value in map buffer 2.
Then id like to find the difference between boths pairs cumulative close difference. so :
pair1 stored value difference + pair2 stored value = positive difference of both pairs cumulative close difference.
Then put this value from both pairs into map buffer 3.
