OrderSelect by comment | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

return value of 'OrderSelect' should be checked - Help Please 7 replies

OrderSelect Warning Fix 5 replies

orderselect problem 1 reply

Can't get OrderSelect() to find order automatically 2 replies

OrderSelect() Index Problem 3 replies

OrderSelect by comment

  • #1
  • First Post: Jul 20, 2008 12:14am Jul 20, 2008 12:14am
I'm halfway thru the coding of a simple, fully functional EA. But i'm still just a newbie in coding.
I just cant figure out how to make my EA select all orders that have a specific comment and perform an action on those only.

For example i may have 3 open orders each commented "whatever comment 1" and another two commented "whatever comment 2".
How can i make my EA select only the first "whatever comment 1" order group and perform an action on those 3?

For what i have red in documentations on the MQL4 site there is no clue on how OrderSelect can do such a thing.
Sorry if this is a stupid question..i guess one has to start somewhere if he wants to get a grip on coding..
  • #2
  • Jul 20, 2008 12:21am Jul 20, 2008 12:21am
There is a function called "OrderComment()".

So, OrderSelect();

if (OrderMagicNumber == MagicNumber && OrderComment() = "Comment #1")

etc.
  • #3
  • Jul 20, 2008 12:32am Jul 20, 2008 12:32am
thx Ron..
i had seen that. but i'm confused on the use i should do of OrderSelect..since it only can select by position or ticket. How do i select all the open and pending orders and then filter out with OrderComment..

should i just pile on 10 different bits of code like
Orderselect by position 0 if comment so do this else do that
Orderselect by position 1 if comment so do this else do that
Orderselect by position 2 if comment so do this else do that
Orderselect by position 3 if comment so do this else do that
Orderselect by position 4 if comment so do this else do that
  • #4
  • Jul 20, 2008 1:15am Jul 20, 2008 1:15am
int num_orders = OrdersTotal();
for(int i = 0; i < num_orders; i++)
{
if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false)
{
break;
}
if (OrderComment() == "Blah")
{
//Do something
}
}
The breaking of a wave cannot explain the whole sea.
  • #5
  • Jul 20, 2008 2:48am Jul 20, 2008 2:48am
Quoting Postrock
thx Ron..
i had seen that. but i'm confused on the use i should do of OrderSelect..since it only can select by position or ticket. How do i select all the open and pending orders and then filter out with OrderComment..

should i just pile on 10 different bits of code like
Orderselect by position 0 if comment so do this else do that
Orderselect by position 1 if comment so do this else do that
Orderselect by position 2 if comment so do this else do that
Orderselect by position 3 if comment so do this else do that
Orderselect by position 4 if comment so do this else do that
what you can do, or rather what you should always do is loop thru all your current positions, pending and/or opened lies in the same list. I hope you're using Magic Number as well. if you're just going to find the trades opened by your EA, Magic Number comparison is the way to go. you should use OrderComment comparison only if your EA actually writes different comments for different trading situations and you wanna have it to have different actions for such cases.

Inserted Code
   int total = OrdersTotal();
   if (total > 0)
   {
      for(int cnt=0;cnt<total;cnt++)
      {
         if(OrderSelect(cnt,SELECT_BY_POS))
         {
            if(OrderSymbol()==Symbol() && OrderMagicNumber() == EA_MAGIC_NUM) // this checks for the orders opened by your EA
            {
               if (OrderComment() == "Whatever your 1st type of comment is") // compare the commenting
               {
                  // do what you want.
               }
               if (OrderComment() == "Whatever your 2nd type of comment is") // compare the commenting
               {
                  // do what you want.
               }
               if (OrderComment() == "Whatever your 3rd type of comment is") // compare the commenting
               {
                  // do what you want.
               }
            }
         }
      }
   }
Programming for a better future.
  • #6
  • Last Post: Edited 8:18am Jul 20, 2008 7:55am | Edited 8:18am
great responses!
Thank you guys..

I'll check magic number. I just need an efficient way to properly recognize one or more orders out of the list and do proper action. Once i could implement one in my EA i can experiment with different methods.
0 traders viewing now