Why ordermodify error 1? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

OrderModify - Error code 1 9 replies

OrderModify Error 32 replies

OrderModify error 1 HELP PLEASE 5 replies

OrderModify() problem (NOT error code 1) 3 replies

OrderModify error 1 ?? 0 replies

Why ordermodify error 1?

  • #1
  • First Post: Jul 18, 2008 1:13pm Jul 18, 2008 1:13pm
I have the following rule for trailing a stop level when the current order (previously selected) is of OP_BUY type.
Inserted Code
if(iMA(Symbol(), 0, lma, 0, 1, 0, 1) > OrderStopLoss())
                  OrderModify(OrderTicket(), OrderOpenPrice(), iMA(Symbol(), 0, lma, 0, 1, 0, 1), 0, 0, Blue);
However, when I run the EA through the tester, I get a few 'modify' lines and a lot of 'OrderModify: error 1' lines. This error is supposed to happen when the OrderModify command does not change anything about the order.

I can't understand why the error occurs since it is only supposed to be run when the MA at the previous bar is higher than the _current_ stop level.
Please help.
Thanks,
Ravi

PS - I get the same error when used in inverse when the current order is of type OP_SELL.
  • #2
  • Jul 18, 2008 1:33pm Jul 18, 2008 1:33pm
i think your problem is due to not normalizing the value you wanna pass into the order modification.

e.g. your MA's value gives you 2.45362892
your stop loss level is 2.4536

2.45362892 > 2.4536

so it will try to put 2.45362892 as your stoploss level, but since this hypothetical currency pair allows only 4 digits after decimal points, it'll try to insert 2.4536 instead, which is an unchanged value as far as your broker can tell, so it'll slap you with an error 1.

try this

Inserted Code
double ma_value = NormalizeDouble(iMA(Symbol(), 0, lma, 0, 1, 0, 1),Digits)
if(ma_value > OrderStopLoss())
                  OrderModify(OrderTicket(), OrderOpenPrice(), ma_value, 0, 0, Blue);

I could be wrong though.

good luck.

regards,
Zen

***edit***
on a sidenote, its good practise to always normalize your values to referencing to the Digits constant before putting it into any order function, like OrderSend, OrderModify, etc. this can prevent errors such as "invalid stop", blah blah..
Programming for a better future.
  • #3
  • Jul 18, 2008 6:34pm Jul 18, 2008 6:34pm
Zen_leow: Thanks for the reply.

I normalized both calls to the iMA() function, but the tester still continues to return 'OrderModify error 1'.

Do you have any alternative suggestions or ideas?

Thank you,
Ravi.
  • #4
  • Jul 18, 2008 6:42pm Jul 18, 2008 6:42pm
Your iMA syntax is incorrect.

Linky:
http://docs.mql4.com/indicators/iMA

LMA is the method, not the period, etc, etc.
  • #5
  • Jul 18, 2008 8:35pm Jul 18, 2008 8:35pm
Sorry, Rabid,
I should have explained earlier what the 'lma' variable is. This extern int is the number of periods the iMA function uses to calculate the moving average.
I apologize for the misinterpretation, I should have specified that in the beginning.

Ravi.
  • #6
  • Jul 18, 2008 9:33pm Jul 18, 2008 9:33pm
Oh. Hrm, still, I'd double check your syntax. There were a few things that looked unusual there.
  • #7
  • Jul 18, 2008 11:16pm Jul 18, 2008 11:16pm
ema of lma period on price close using current symbol and timeframe with no shift, looking at the previous value. although I would use NULL instead of Symbol(), the iMA syntax is correct...

hmm... the documentation did state that

"StopLoss and TakeProfit levels cannot be too close to the market. The minimal distance of stop levels in points can be obtained using the MarketInfo() function with MODE_STOPLEVEL parameter."

perhaps you might wanna look into that?
Programming for a better future.
  • #8
  • Jul 19, 2008 11:54am Jul 19, 2008 11:54am
Error #1 mean OrderModify attempts to replace the values already set with the same values. One or more values must be changed, then modification attempt can be repeated.

Logically you might think it should be different SL value to post on modify function. But market price/indicator value could be changed in millisecond.

It is better to not modify order per tick value, but per pips. For example to your case.
Inserted Code
int ModifyStep = 5; // better as global extern parameter;

double ma_value = NormalizeDouble(iMA(Symbol(), 0, lma, 0, 1, 0, 1),Digits);

if(ma_value > OrderStopLoss()+ModifyStep*Point) 
   OrderModify(OrderTicket(), OrderOpenPrice(), ma_value, 0, 0, Blue);
Keep your hands up, and use your pant! - FxMatics
  • #9
  • May 21, 2011 10:58am May 21, 2011 10:58am
Im also have the same problem...Can anyone suggest how to settle this problem..tqvm...

double l_iclose_0 = iClose(NULL, PERIOD_M5, 0);
double l_ima_8 = iMA(NULL, PERIOD_M5, 7, 0, MODE_SMA, PRICE_OPEN, 0);
double l_iclose_16 = iClose(NULL, PERIOD_M5, 0);
double l_ima_24 = iMA(NULL, PERIOD_M5, 6, 0, MODE_SMA, PRICE_OPEN, 0);
  • #10
  • Last Post: May 21, 2011 6:03pm May 21, 2011 6:03pm
Quoting Kyr4Fx
Im also have the same problem...Can anyone suggest how to settle this problem..tqvm...

double l_iclose_0 = iClose(NULL, PERIOD_M5, 0);
double l_ima_8 = iMA(NULL, PERIOD_M5, 7, 0, MODE_SMA, PRICE_OPEN, 0);
double l_iclose_16 = iClose(NULL, PERIOD_M5, 0);
double l_ima_24 = iMA(NULL, PERIOD_M5, 6, 0, MODE_SMA, PRICE_OPEN, 0);
Looks like decompiled code.

Anyway, if your'e getting Error 1 on OrderModify(), it's most likely because none of the trade settings have been changed. I usually trap the error with GetLastError(), and if the result is 1, just continue regardless. For example:

Inserted Code
  for (int j=attempts; j>0; j--)   {
    OrderModify(tkt,entry,SL,TP,expiry,arrow);
    errnum = GetLastError();
    if (errnum == 1)   errnum = 0;
    if (errnum == 0)   break;
    if (j==1)          return(errnum);
    Sleep(1000*wait);
    RefreshRates();
  }
0 traders viewing now