I tried to implement a TP using ATR (as you did for SL) in your code, but I must be doing it wrong, it doesn't seem to work as it's suppose to.
Other thing I notice in V1.5 (using ATR for SL):
It's not moving the SL as you enter into the quarters' zone; meaning for example if you're long and you hit the 1st quarter, the SL should become the entry point (break-even), but it's not - you see the candles penetrate beyond the entry point and not trigering the signal.
So it will give you a yellow cross only when the entry's SL is hit... compromising the results
Can you take a look at these 1, 2... maybe 3 last questions I've posted?
EMA 25-50 Trading System (Detailed)
- #1,822
- Jul 10, 2008 8:10am Jul 10, 2008 8:10am
Oops, you are correct. I think the only way to support trailing SL when using ATR it to use both SL and TP based on ATR - can you tell me your planned logic for using TP based on ATR?
The logic would be to make your "UseATRForSL" into a "UseATRForSL_TP", and:
if (UseATRForSL_TP)
PipForSL = atr * 2 / Point;
PipForTP = atr * 2 / Point;
(I don't understand the meaning of the "* 2 / Point", but I'm very newbie at this... I suppose it is right).
Meaning: if at a giving moment, the ATR is 25, we would have TP = SL = 25 (as you say, both SL and TP based on ATR). If the trade goes our way, once hitting the 1st quarter (entry+25), the SL becomes the entry point, and the TP becomes the entry point + 50.
Same logic for the next quarters.
Of course we could introduce 2 multiplying factors as external inputs (one for SL, other for TP), in order to make TP or SL equal to 0.5*ATR, 1*ATR, or 2*ATR, etc, in order to diversify our testing to different TP/SL/pairs.
But that's something that can be done easily later, isn't it?
Priority to the problems of trailing SL, and ATR for both SL and TP (as these seem connected);
then the multiple TP in one candle;
finally the possibility of introducing multiplying factor as external inputs.
If anyone has any positive/negative ideas about this, please come forward to discuss it... all together we can help to solve the bugs and make it better
- #1,823
- Edited 7:30pm Jul 12, 2008 6:49pm | Edited 7:30pm
From 1/1/08 to Today
normal system + 5 EMA (that improves it) = +2850pips (which is very cool, anyway)
corre system = +12250pips
yes they are 12thousands.
h1 chart, EURUSD.
It's 1:39am in Italy so I'll check tomorrow if this works cool on all the other markets...
Anyway I'm still working with the SL=TPquarters=50. ATR will wait now
normal system + 5 EMA (that improves it) = +2850pips (which is very cool, anyway)
corre system = +12250pips
yes they are 12thousands.
h1 chart, EURUSD.
It's 1:39am in Italy so I'll check tomorrow if this works cool on all the other markets...
Anyway I'm still working with the SL=TPquarters=50. ATR will wait now
- #1,824
- Jul 13, 2008 4:13am Jul 13, 2008 4:13am
From 1/1/08 to Today
normal system + 5 EMA (that improves it) = +2850pips (which is very cool, anyway)
corre system = +12250pips
yes they are 12thousands.
h1 chart, EURUSD.
It's 1:39am in Italy so I'll check tomorrow if this works cool on all the other markets...
Anyway I'm still working with the SL=TPquarters=50. ATR will wait now
I'm asking, because version 1.5 already includes your changes in the RSI and MACD.
Try other markets now, with different volatilities... the 50 TP/SL equals ATR*2 (more or less; ATR in this pair is usually around 20, 25).
My guess is you'll have to change the 50 TP/SL in other pairs for it to work as well (or close).
That's why the ATR TP/SL option with multiplying factors as external inputs would be good.
- #1,830
- Jul 13, 2008 10:01am Jul 13, 2008 10:01am
ok we have something big now.
GBP/USD
02/01/2008-->Today
Loss 41
Profit 1 57
Profit 2 28
Profit 3 15
Profit 4 17
Total = +16150 pips
remember
1 loss = -200 pips
profit 1 = +50 pips
profit 2 = +50+100+50+50= +250 pips
profit 3 = +50+100+150+100= +400 pips
profit 4 = +50+100+150+200= +500 pips
So:
EURUSD +12250pips
GBPUSD +16150 pips
Not so bad from January
GBP/USD
02/01/2008-->Today
Loss 41
Profit 1 57
Profit 2 28
Profit 3 15
Profit 4 17
Total = +16150 pips
remember
1 loss = -200 pips
profit 1 = +50 pips
profit 2 = +50+100+50+50= +250 pips
profit 3 = +50+100+150+100= +400 pips
profit 4 = +50+100+150+200= +500 pips
So:
EURUSD +12250pips
GBPUSD +16150 pips
Not so bad from January
- #1,832
- Jul 13, 2008 4:05pm Jul 13, 2008 4:05pm
ok we have something big now.
GBP/USD
02/01/2008-->Today
Loss 41
Profit 1 57
Profit 2 28
Profit 3 15
Profit 4 17
Total = +16150 pips
remember
1 loss = -200 pips
profit 1 = +50 pips
profit 2 = +50+100+50+50= +250 pips
profit 3 = +50+100+150+100= +400 pips
profit 4 = +50+100+150+200= +500 pips
So:
EURUSD +12250pips
GBPUSD +16150 pips
Not so bad from January
First of all, how have you done the counting? Manually (so fast)? With a programmed pip counter?
If manually, have you counted the stop and reverse (loss) situation (when an arrow of a colour follows one of another colour)?
Secondly... I wasn't understanding your pip counting, but now I think I get it:
You're counting the pips for each quarter of investment, right?
Meaning that if you always invest with the same amount, you have to divide the amount by 4 and then multiply by the total pips, to obtain the maximum possible gain for that amount of investment, right?
- #1,833
- Jul 13, 2008 4:40pm Jul 13, 2008 4:40pm
And have you taken this, about version 1.5 (with your changes), into account?
Just to be sure about your results!
(...)
Other thing I notice in V1.5 (using ATR for SL):
It's not moving the SL as you enter into the quarters' zone; meaning for example if you're long and you hit the 1st quarter, the SL should become the entry point (break-even), but it's not - you see the candles penetrate beyond the entry point and not trigering the signal.
So it will give you a yellow cross only when the entry's SL is hit... compromising the results
(...)
You've got me lost with this
First of all, how have you done the counting? Manually (so fast)? With a programmed pip counter?
If manually, have you counted the stop and reverse (loss) situation (when an arrow of a colour follows one of another colour)?
Secondly... I wasn't understanding your pip counting, but now I think I get it:
You're counting the pips for each quarter of investment, right?
Meaning that if you always invest with the same amount, you have to divide the amount by 4 and then multiply by the total pips, to obtain the maximum possible gain for that amount of investment, right?
2) I counted the Stop and Reverse as a Loss (-200) to dig deeper in the goodness of this indicator
So probably we're far above this pip lines but anyway... this sounds sweet too
Yes, the golden cross stays at -50 (that's where it was from the beginning, except that it wouldn't be golden if you hadn't enter a profit zone).
So sometimes, for example, you hit target 1, then you hit entry point (meaning you would have been stopped), but it lets the trade running, up and/or down, until it breaks the initial SL (at -50).
So if you're trusting the graphic's indicator to count... it's wrong!
we'll recount when this problem will be solved
- #1,840
- Jul 13, 2008 8:28pm Jul 13, 2008 8:28pm
we'll recount when this problem will be solved
By the way... have you noticed this is become more like a dialogue, or "trialogue", lately? Say for the last 2 pages?
Nobody else has inputs to this thread?