Trailing stop function not working. | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Looking for Trailing Stop EA like default MT4 trailing stop 7 replies

stop loss function and edit time function for Breakout EA 1 reply

Help with trailing stop function. 1 reply

Buy Stop and Sell Stop orders with OCO and Trailing Stop 0 replies

To Trailing Stop or Not To Trailing Stop.... 36 replies

Trailing stop function not working.

  • #1
  • First Post: Jul 13, 2008 1:58pm Jul 13, 2008 1:58pm
Hello,
So I have this trailing stop function, and it is supposed to put the trailing stop equal to a particular moving average's level if the unrealized profit is up to a certain level (10 pips) and then put the trailing stop at the level of another (tighter) moving average line if the unrealized profit reaches past that level.
The problem is that my trailing stop function works for stage one, but NEVER reaches stage two (when unrealized profits are greater than 10 pips). I was wondering if someone here could shed some light on this.
Thank you,
Ravi

Inserted Code
void trail_stop()
{
   switch(OrderType())
   {
      case OP_BUY:
      {
         if(Bid - OrderOpenPrice() < 10)
         {  Print("buy < 10");
            if(iMA(Symbol(), 0, lma, 0, 1, 0, 1) > OrderStopLoss())
                  OrderModify(OrderTicket(), OrderOpenPrice(), iMA(Symbol(), 0, lma, 0, 1, 0, 1), 0, 0, Blue);
            return(0);
         }
         else 
         if(Bid - OrderOpenPrice() < 20)
         {  Print("buy < 20");
            if(iMA(Symbol(), 0, mma, 0, 1, 0, 1) > OrderStopLoss())
                  OrderModify(OrderTicket(), OrderOpenPrice(), iMA(Symbol(), 0, mma, 0, 1, 0, 1), 0, 0, Green);
            return(0);
         }
         else
         {  Print("buy else");
            if(iMA(Symbol(), 0, sma, 0, 1, 0, 1) > OrderStopLoss())
               OrderModify(OrderTicket(), OrderOpenPrice(), iMA(Symbol(), 0, sma, 0, 1, 0, 1), 0, 0, Yellow);
            return(0);
         }
      }
      case OP_SELL:
      {
         if(OrderOpenPrice() - Ask < 10)
         {  Print("sell < 10");
            if(iMA(Symbol(), 0, lma, 0, 1, 0, 1) < OrderStopLoss())
                  OrderModify(OrderTicket(), OrderOpenPrice(), iMA(Symbol(), 0, lma, 0, 1, 0, 1), 0, 0, Red);
            return(0);
         }
         else 
         if(OrderOpenPrice() - Ask < 20)
         {  Print("sell < 20");
            if(iMA(Symbol(), 0, mma, 0, 1, 0, 1) < OrderStopLoss())
                  OrderModify(OrderTicket(), OrderOpenPrice(), iMA(Symbol(), 0, mma, 0, 1, 0, 1), 0, 0, Orange);
            return(0);
         }
         else
         {  Print("sell else");
            if(iMA(Symbol(), 0, sma, 0, 1, 0, 1) < OrderStopLoss())
               OrderModify(OrderTicket(), OrderOpenPrice(), iMA(Symbol(), 0, sma, 0, 1, 0, 1), 0, 0, White);
            return(0);
         }
      }
   }
}
  • #2
  • Edited 2:29pm Jul 13, 2008 2:14pm | Edited 2:29pm
Ravster,

Regardless of the trailing code. The code has to select an order to manipulate before being able to manipulate the order by using OrderType(), OrderTicket(),OrderOpenPrice()... etc...

Inserted Code
void trail_stop()
{
 int iOrdersTotal=OrdersTotal()-1;
 for(int x=0;x<=iOrdersTotal;x++)
 {
  OrderSelect(x,SELECT_BY_POS);
  if(Symbol()==OrderSymbol() && OrderMagicNumber()==123454321 || OrderComment()==StringConcatenate("ravster-",Symbol(),"-",Period())) // however you identify orders to keep them seperate from other orders?
  {
   switch(OrderType())
   {
    case OP_BUY:
    {
      if(Bid - OrderOpenPrice() < 10)
      {  Print("buy < 10");
         if(iMA(Symbol(), 0, lma, 0, 1, 0, 1) > OrderStopLoss())
               OrderModify(OrderTicket(), OrderOpenPrice(), iMA(Symbol(), 0, lma, 0, 1, 0, 1), 0, 0, Blue);
         return(0);
      }
      else 
      if(Bid - OrderOpenPrice() < 20)
      {  Print("buy < 20");
         if(iMA(Symbol(), 0, mma, 0, 1, 0, 1) > OrderStopLoss())
               OrderModify(OrderTicket(), OrderOpenPrice(), iMA(Symbol(), 0, mma, 0, 1, 0, 1), 0, 0, Green);
         return(0);
      }
      else
      {  Print("buy else");
         if(iMA(Symbol(), 0, sma, 0, 1, 0, 1) > OrderStopLoss())
            OrderModify(OrderTicket(), OrderOpenPrice(), iMA(Symbol(), 0, sma, 0, 1, 0, 1), 0, 0, Yellow);
         return(0);
      }
    }
    case OP_SELL:
    {
      if(OrderOpenPrice() - Ask < 10)
      {  Print("sell < 10");
         if(iMA(Symbol(), 0, lma, 0, 1, 0, 1) < OrderStopLoss())
               OrderModify(OrderTicket(), OrderOpenPrice(), iMA(Symbol(), 0, lma, 0, 1, 0, 1), 0, 0, Red);
         return(0);
      }
      else 
      if(OrderOpenPrice() - Ask < 20)
      {  Print("sell < 20");
         if(iMA(Symbol(), 0, mma, 0, 1, 0, 1) < OrderStopLoss())
               OrderModify(OrderTicket(), OrderOpenPrice(), iMA(Symbol(), 0, mma, 0, 1, 0, 1), 0, 0, Orange);
         return(0);
      }
      else
      {  Print("sell else");
         if(iMA(Symbol(), 0, sma, 0, 1, 0, 1) < OrderStopLoss())
            OrderModify(OrderTicket(), OrderOpenPrice(), iMA(Symbol(), 0, sma, 0, 1, 0, 1), 0, 0, White);
         return(0);
      }
    }
   }
  }
 }
}

Another error is you are using the user input for the trail, 10 & 20, in this case, which you have not converted into a valid pip format. So (EURUSD, for example) your BID is 1.5000 and your OrderOpenPrice() is 1.4980, you would expect the trail to function to start at 1.5000.

1.5000 minus
1.4980 equals
20 pips.

But you are comparing it to the whole number 20 whereas you should be comparing it to 0.0020.

So you code would wait for a BID of 24.4980 to initiate.

The code should convert the whole number 20 to pips by multiplying it by Point() :

Inserted Code
if(Bid - OrderOpenPrice() < 20)

should be:

Inserted Code
if(Bid - OrderOpenPrice() < 20*Point)

Point, in the case of EURUSD, would return 0.0001. so 20 time 0.0001 would give you the 20 pips you are looking for...

These are basic errors which have to be corrected before even trying to see if the logic in your code makes sense, would work...

lucidlamp
  • #3
  • Last Post: Jul 13, 2008 2:37pm Jul 13, 2008 2:37pm
Hey lucidlamp,
Your suggestion was spot-on. I multiplied the factor of unrealized profits by 'Point' and the function started working correctly.
Thank you.
0 traders viewing now