mt4 error - newb help please | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

MT4 EA error- when placing trade getting error 0 rate on ask 3 replies

need help adjusting a pivot indicator (newb) 1 reply

I'm a total Newb. Please help! 5 replies

Newb MT4 question... 1 reply

mt4 newb 3 replies

Attachments: mt4 error - newb help please
Exit Attachments

mt4 error - newb help please

  • #1
  • First Post: Jul 8, 2008 10:17pm Jul 8, 2008 10:17pm
Hey. I haven't done C++ related coding in awhile and i'm stuck on an error: "'\end of program' - unbalanced left parenthesis". I can't for the life of me find this error. The code's attached.

I'm doing a study into random trading. At first this EA just put in random trades, buy or sell, with 50/50 probability in each direction. I was actually surprised by those results. I did a frankenstein on that EA and got this EA. This EA has those directional probabilities altered by the level of a stoch oscillator. If i did it right, when the stoch's at 80, there should only be a 20% chance of buying. It's simple enough, but once we figure out this problem, i'll be able to move onto higher level concepts. I'll probably post the best EA when i'm done.

Thanks.
Attached File(s)
File Type: mq4 Random.mq4   3 KB | 449 downloads
  • #2
  • Jul 8, 2008 11:44pm Jul 8, 2008 11:44pm
error fixed. I placed a comment in the file so you can see where the error was located. You were missing one left paranthesis.
Attached File(s)
File Type: mq4 Random.mq4   3 KB | 449 downloads
  • #3
  • Jul 9, 2008 12:15am Jul 9, 2008 12:15am
thanks for the help bud.
  • #4
  • Jan 27, 2014 3:18am Jan 27, 2014 3:18am
Hi ,
can anyone tell me how to fix the unbalanced parentheses error in mt4 please. Need help...
  • #5
  • Jan 27, 2014 3:43am Jan 27, 2014 3:43am
Quoting Lynnye
Hi , can anyone tell me how to fix the unbalanced parentheses error in mt4 please. Need help...
you just need to go thru and make sure every bracket either ( or { has a matching ) or }

also ensure that you terminate command correctly with ;
  • #6
  • Jan 27, 2014 2:20pm Jan 27, 2014 2:20pm
Thank you MaxDoom,
i will try that. There are several places where there are just one half of the parentheses. I'm only getting one error message however. When I right click the error and click the "go to line" option, it takes me to just one place to correct. I will follow your instruction and keep you posted. Again, my sincere thanks.... Btw the other places with only part of the parentheses look like this: }
}
}
}
}
ill match them up and hopefully take care of the problem.
  • #7
  • Jan 27, 2014 4:27pm Jan 27, 2014 4:27pm
MaxDoom,
you were right!!! The parentheses error is gone. However, I'm seeing a new error that says "\end_of_program- ending bracket "}" expected. You've helped me so much, and I am grateful. Would you be so kind as to tell me how to fix this as well.
thank you in advance...
  • #8
  • Jan 28, 2014 2:46am Jan 28, 2014 2:46am
Quoting Lynnye
MaxDoom, you were right!!! The parentheses error is gone. However, I'm seeing a new error that says "end_of_program- ending bracket "}" expected. You've helped me so much, and I am grateful. Would you be so kind as to tell me how to fix this as well. thank you in advance...
it will still be the same issue, somewhere in the program you are missing a } as this is used to separate blocks of commands/functions it is possible that it could be anywhere even though it says it is at the end.

you could just post the code here to look at
  • #9
  • Jan 28, 2014 3:07am Jan 28, 2014 3:07am
MaxDoom,

Here it is. I hope you can spot the error. Please let me know. I am in your debt.

extern bool OverruleDirection = true;
extern bool DirectionLong = false;
extern bool StartTimeFilter =false; //Set it to true to allow start trade in EntryTimeHour and EntryTimeMinutes
extern bool TimeBreak =false; //Set it to true to set trades on trade only in EntryTimeHour to ExitTimeHour
extern int EntryTimeHour = 0;
extern int EntryTimeMinute = 0;
extern int ExitTimeHour = 23; // Set it equal of lower of
extern int MaxTrades = 0; // Set <= 0 to disable
extern bool AccountIsMini = true; // Set to true if trading mini account, otherwise set to false
extern bool threedigit=false; //set to true if the broker house use 3 decimal digits
extern int BEP_Level = 0; //breakeven bail out level Set <=0 to disable
extern double BEPpip=0.0; //the pip you set to break even
extern bool ProfitProtect=false; // ONLY set to true when the current profit pip > ProfitProtectpip
extern double ProfitProtectpip=0.0;
extern bool StepTrailingStop = false; //Set to true to eliminate takeprofit point, exit at Trailing point
extern int StartStepPip = 80;
extern int TrailingStopPip = 20;
extern bool TrailOnceStop = false;
extern bool TrailingStop = false;
extern bool StepStop = false; //Using Step Stop
extern double StepSize = 5;
extern double MinDistance = 10;
extern bool TakeProfitHold = false; //when using StepTrailingStop/Stepstop , takeprofit determined by new stop loss if set to TRUE
extern double Lots = 0.1;
extern double Multiplier = 2; //lots progressive multiplier factor
extern double LotInc = 0; //Lot increment on each level
extern int StopLoss = 35;
extern int TakeProfit = 120;
extern int Slippage = 4;
extern bool Closeimmediate = false; //Set to true if close all the trade and halt the system

int Magic;
int LotDigits;
int tic=-1;
static int Level=1;
int initialtrade=0;
int pip;
double plpip; //total profit and loss pip
static bool Lock = false; //Lock the EA forever so that it won't take position again even it trigger the reverse point
static bool positivepip,stpositivepip=false;
int init()
{
Comment("Waiting for tick");
if (Symbol() == "AUDCADm" || Symbol() == "AUDCAD") { Magic = 221001; }
if (Symbol() == "AUDJPYm" || Symbol() == "AUDJPY") { Magic = 221002; }
if (Symbol() == "AUDNZDm" || Symbol() == "AUDNZD") { Magic = 221003; }
if (Symbol() == "AUDUSDm" || Symbol() == "AUDUSD") { Magic = 221004; }
if (Symbol() == "CHFJPYm" || Symbol() == "CHFJPY") { Magic = 221005; }
if (Symbol() == "EURAUDm" || Symbol() == "EURAUD") { Magic = 221006; }
if (Symbol() == "EURCADm" || Symbol() == "EURCAD") { Magic = 221007; }
if (Symbol() == "EURCHFm" || Symbol() == "EURCHF") { Magic = 221008; }
if (Symbol() == "EURGBPm" || Symbol() == "EURGBP") { Magic = 221009; }
if (Symbol() == "EURJPYm" || Symbol() == "EURJPY") { Magic = 221010; }
if (Symbol() == "EURUSDm" || Symbol() == "EURUSD") { Magic = 221011; }
if (Symbol() == "GBPCHFm" || Symbol() == "GBPCHF") { Magic = 221012; }
if (Symbol() == "GBPJPYm" || Symbol() == "GBPJPY") { Magic = 221013; }
if (Symbol() == "GBPUSDm" || Symbol() == "GBPUSD") { Magic = 221014; }
if (Symbol() == "NZDJPYm" || Symbol() == "NZDJPY") { Magic = 221015; }
if (Symbol() == "NZDUSDm" || Symbol() == "NZDUSD") { Magic = 221016; }
if (Symbol() == "USDCHFm" || Symbol() == "USDCHF") { Magic = 221017; }
if (Symbol() == "USDJPYm" || Symbol() == "USDJPY") { Magic = 221018; }
if (Symbol() == "USDCADm" || Symbol() == "USDCAD") { Magic = 221019; }
if (Symbol() == "XAUUSDm" || Symbol() == "XAUUSD") { Magic = 221020; }
if (Symbol() == "XAGUSDm" || Symbol() == "XAGUSD") { Magic = 221021; }
if (Magic == 0) { Magic = 221999; }
LotDigits = 1;
if (AccountIsMini) { LotDigits = 2; }
return(0);
}

int deinit()
{
Comment("");
return(0);
}

int start()
{
if(Bars<100)
{
Comment("Waiting for bars...");
return(0);
}

return(StopAndReverse(Symbol(),Period(), Magic, Lots, Multiplier, StopLoss, TakeProfit, MaxTrades));
}

bool Visual = true;

#define MAX_CNT 120 // 1 minute

int StopAndReverse(string sym, int per, int magic, double vol, double multi, int sl, int tp, int mt)
{
// Internals
int _Digits = MarketInfo(sym, MODE_DIGITS);
if(_Digits == 0) _Digits = 4;
double _Point = MarketInfo(sym, MODE_POINT);
if(NormalizeDouble(_Point, _Digits) == 0.0) _Point = Point;
double _Bid = MarketInfo(sym, MODE_BID);
double _Ask = MarketInfo(sym, MODE_ASK);

static double maxlots;
static int dir = -1;
static int reverse = 0;

// Find trend (override possible and skip Sundays for Monday trend)

//if ((Closeimmediate)||Lock){ //need foward test
if (Closeimmediate) {
reverse =0;
dir =-1;
tic=-1;
maxlots=vol;
positivepip=false;
stpositivepip=false;
initialtrade=0;}
if((dir < 0)&&(!_Rhythm_ActivePosition(sym, magic))){ //if initial EA or Not Connection resume
maxlots=vol;
if(OverruleDirection)
if(DirectionLong)
dir = OP_BUY;
else
dir = OP_SELL;
else
{
if(DayOfWeek() == 1)
int bs = iBarShift(sym, PERIOD_D1, TimeCurrent()-72*3600);
else
bs = 1;
if(iOpen(sym, PERIOD_D1, bs) < iClose(sym, PERIOD_D1, bs))
dir = OP_BUY;
else
dir = OP_SELL;
}
if(dir == OP_BUY)
reverse = MathRound(_Ask/_Point);
else
reverse = MathRound(_Bid/_Point);
}


bool ct = _Rhythm_CanTrade(sym, magic, mt,tic) && IsTradeAllowed();
bool tt = _Rhythm_tt(per, EntryTimeHour, ExitTimeHour);
bool stt = _Rhythm_stt(EntryTimeHour, EntryTimeMinute)||(initialtrade!=0);
double lot2;
if (TimeBreak) ct = ct && tt;
if (StartTimeFilter) ct = ct && stt;
if((tt||!TimeBreak)&&(stt||!StartTimeFilter)) //Trade in define trading time slot
{//Start of Loop 1
//if(!_Rhythm_ActivePosition(sym, magic))
// tempcomment=tempcomment +"Trading times" + "\n" + "Level is : " + Level + "\n";
//else tempcomment=tempcomment +"Contain Active Position"+ "\n";
// Check for active position
int cnt = 0;
int tries;
while(!_Rhythm_ActivePosition(sym, magic) && ct &&!Lock)
{ //Start of while loop #2

lot2=NormalizeDouble(maxlots, LotDigits);
if(dir == OP_BUY)
{
if(ct)
{
_Ask = MarketInfo(sym, MODE_ASK);
tries = 0;
//if(MathRound(_Ask/_Point) >= reverse)
if(MathRound(_Ask/_Point) >= (reverse-Slippage)) //just to easily hit the reverse provided that the stop loss is hitted
{
if (!GlobalVariableCheck("InTrade"))
{
while (tries < 3)
{
GlobalVariableSet("InTrade", CurTime()); // set lock indicator
tic = OrderSend(sym, dir, lot2, _Ask, Slippage, _sl(dir, sym, sl), _tp(dir, sym, tp),"StopAndReverse", magic, 0, Blue);
GlobalVariableDel("InTrade"); // clear lock indicator
initialtrade=1;
if (tic<=0)
{
_ce();
tries++;
}
else {
Level = MathRound(MathLog((maxlots-LotInc)/vol)/MathLog(Multiplier)+1);
if (Level <=0)
Level =1;
else Level = Level;
maxlots = vol*MathPow(Multiplier, Level)+LotInc;
tries=3;
}
}
}
}
else
break;
_ce();
}
}
else
{
if(ct)
{
_Bid = MarketInfo(sym, MODE_BID);
tries = 0;
//if(MathRound(_Bid/_Point) <= reverse)
if(MathRound(_Bid/_Point) <= (reverse+Slippage))
{
if (!GlobalVariableCheck("InTrade"))
{
while (tries < 3)
{
GlobalVariableSet("InTrade", CurTime()); // set lock indicator
tic = OrderSend(sym, dir, lot2, _Bid, Slippage, _sl(dir, sym, sl), _tp(dir, sym, tp),"StopAndReverse", magic, 0, Red);
GlobalVariableDel("InTrade"); // clear lock indicator
initialtrade=1;
if (tic<=0)
{
_ce();
tries++;
}

else {

Level = MathRound(MathLog((maxlots-LotInc)/vol)/MathLog(Multiplier)+1);
if (Level <=0)
Level =1;
else Level = Level;
maxlots = vol*MathPow(Multiplier, Level)+LotInc;
tries=3;
}
}
}
}
else
break;
_ce();
}
}
/*
Sleep(500);
cnt++;
if(cnt >= MAX_CNT)
break;
*/
// Recalculate conditions
ct = _Rhythm_CanTrade(sym, magic, mt,tic) && IsTradeAllowed();
//ct = ct && _Rhythm_tt(per, EntryTimeHour, ExitTimeHour);
if (TimeBreak)
ct = ct && _Rhythm_tt(per, EntryTimeHour, ExitTimeHour);
if (StartTimeFilter)
ct = ct && ((_Rhythm_stt(EntryTimeHour, EntryTimeMinute))||(initialtrade!=0));
} // End of While Loop #2

// Show message after ending trade
if((!_Rhythm_ActivePosition(sym, magic))&&(!_Rhythm_CanTrade(sym, magic, mt,tic)))
{
for(int j=OrdersHistoryTotal()-1; j >= 0; j--)
{
if(OrderSelect(j, SELECT_BY_POS, MODE_HISTORY))
{
if(TakeProfit > 0)
{
if((StringFind(OrderComment(), "[tp]") >= 0)&&(OrderTicket()==tic))
Comment("pip>=TakeProfit" + "\n");
}
if (TrailingStop||TrailOnceStop||StepTrailingStop)
{
if((StringFind(OrderComment(), "[sl]") >= 0)&&(OrderTicket()==tic))
Comment("Trailing/TrailOnce/StepTrailing Stop hitted" + "\n");
}
if (ProfitProtect)
{
if (OrderTicket()==tic)
Comment("Profit Protection met" + "\n");
}
}
}
if ((Level>=BEP_Level)&&(BEP_Level>0))
{
if ((mt>0)&&(Level>=mt))
{
for(int k=OrdersHistoryTotal()-1; k >= 0; k--)
{
if(OrderSelect(k, SELECT_BY_POS, MODE_HISTORY))
{
if(StopLoss > 0)
if (OrderTicket()==tic)
if(StringFind(OrderComment(), "[sl]") >= 0)
//if((StringFind(OrderComment(), "[sl]") >= 0)&&(OrderTicket()==tic))
Comment("Level >= BEP Level and Level" + Level + " >= Max Level " + mt + "System Stoplossed. \n");
else Comment ("Level>=BEP_Level and Max Trade reached. Trade Stop at BEP. System will be locked, please reload the EA" + "\n");
}
}
//Comment ("Level>=BEP_Level and Max Trade reached. Trade Stop at BEP. System will be locked, please reload the EA" + "\n");
}
else Comment ("Level>=BEP_Level System will be locked, please reload the EA" + "\n");
}
else if (mt>0)
{
if (Level>=mt)
if(((TrailingStop||TrailOnceStop)&&(positivepip))||((StepTrailingStop)&&(stpositivepip)))
Comment("Either TrailingStop/TrailOnceStop/StepTrailingStop hitted. And so do max Level reached. System Locked, please reload the EA" + "\n");
else Comment ("Level "+ Level +" >= Max level " +mt+" System will be locked, please reload the EA" + "\n");
}

}
// Find reverse:
if(_Rhythm_ActivePosition(sym, magic))
{//Loop #3

string sComment;
string NL = "\n";
reverse = MathRound(OrderStopLoss()/_Point);

for (int y=OrdersTotal()-1; y>=0; y--)
{
OrderSelect(y, SELECT_BY_POS, MODE_TRADES);
if (OrderMagicNumber() == magic)
{
dir=OrderType();
Level = MathRound(MathLog((OrderLots()-LotInc)/vol)/MathLog(Multiplier)+1);
if (Level<=0)
Level = 1;
else Level = Level;
tic=OrderTicket();
maxlots = vol*MathPow(Multiplier, Level)+LotInc;
// calculate the current profit and loss pip
if (dir== OP_BUY)
{
if (threedigit)
pip=(MathRound(MarketInfo(sym,MODE_BID)/MarketInfo(sym,MODE_POINT))-MathRound(OrderOpenPrice()/MarketInfo(sym,MODE_POINT)))/10;
else pip=MathRound(MarketInfo(sym,MODE_BID)/MarketInfo(sym,MODE_POINT))-MathRound(OrderOpenPrice()/MarketInfo(sym,MODE_POINT));

}
else if (dir== OP_SELL)
{
if (threedigit)
pip=(MathRound(OrderOpenPrice()/MarketInfo(sym,MODE_POINT))-MathRound(MarketInfo(sym,MODE_ASK)/MarketInfo(sym,MODE_POINT)))/10;
else pip=MathRound(OrderOpenPrice()/MarketInfo(sym,MODE_POINT))-MathRound(MarketInfo(sym,MODE_ASK)/MarketInfo(sym,MODE_POINT));

}
}
}

if (pip>=0)
positivepip=true;
if (pip>=StartStepPip)
stpositivepip=true;
//Set the resevse lot size and direction

//lastsl=reverse;
if(dir == OP_BUY)
{
dir = OP_SELL;
//Level = MathRound(MathLog((maxlots-LotInc)/vol)/MathLog(Multiplier)+1);
// maxlots = NormalizeDouble(vol*MathPow(Multiplier, Level)+LotInc, LotDigits);
}
else
{
dir = OP_BUY;
//Level = MathRound(MathLog((maxlots-LotInc)/vol)/MathLog(Multiplier)+1);
//maxlots = NormalizeDouble(vol*MathPow(Multiplier, Level)+LotInc, LotDigits);
}



//if(Visual&&_Rhythm_CanTrade(sym, magic, mt))

double loss=0;
for (int x=Level-1; x>=1;x--)
{
loss = loss + (NormalizeDouble(vol*MathPow(Multiplier, x-1)+LotInc, LotDigits)*StopLoss);
//sComment = "x is " + x + NL;
//sComment =sComment + "Normalize is " + NormalizeDouble(vol*MathPow(Multiplier, x)+LotInc, LotDigits) +NL;
//sComment=sComment + "Loss " + (NormalizeDouble(vol*MathPow(Multiplier, x)+LotInc, LotDigits)*StopLoss) + NL;
//sComment=sComment + "Current Loss is : " + loss +NL;
}
if (Level==1) plpip = pip *vol ;
else {
plpip = pip *NormalizeDouble(vol*MathPow(Multiplier, Level-1)+LotInc, LotDigits) - loss ;
}
if (mt>0)
if (Level==mt) sComment=sComment + "Last Trading Level." + NL;
else if ((BEP_Level>0)&&(Level==BEP_Level)) sComment=sComment + "At BEP Level. " + NL;
else sComment=sComment + "Trading times. Reverse at " + DoubleToStr(reverse*_Point, _Digits) + NL;
sComment=sComment + "Level " + Level + " Current pip " + pip + NL;
sComment=sComment + "Total profit and loss pip " + DoubleToStr(plpip,_Digits) + NL;
//sComment=sComment + "maxlot is " + DoubleToStr(maxlots,_Digits) + NL;
//sComment=sComment + "AskPrice is " + DoubleToStr(MarketInfo(sym,MODE_ASK),_Digits) + NL;
//sComment=sComment + "OpenPrice is " + DoubleToStr(OrderOpenPrice(),_Digits) + NL;
Comment(sComment);


}//End of Loop 3

}//End of Loop 1

if((!tt&&TimeBreak)||(!stt&&StartTimeFilter))
{
if (initialtrade==0)
Comment("Outside of trading times ");
//if (!tt&&TimeBreak)
else if (!tt&&TimeBreak)
{
CloseAllTrades();
Comment("Outside of trading times");
reverse = 0;
dir = -1;
}
}

if(_Rhythm_ActivePosition(sym, magic))
{
int z;
// manage sl/reverse
if(TrailingStop)
{
if(OrderType() == OP_BUY)
{
double nsl = OrderClosePrice()-TrailingStopPip*_Point;
if(MathRound((_Bid-OrderStopLoss())/_Point)-TrailingStopPip > 0)
if(!OrderModify(OrderTicket(), OrderOpenPrice(), nsl, OrderTakeProfit(), OrderExpiration(), Blue))
_ce();
/*
if(OrderModify(OrderTicket(), OrderOpenPrice(), nsl, OrderTakeProfit(), OrderExpiration(), Blue))
reverse = MathRound(nsl/_Point);
*/ //do not need reverse compare with the orignal Rhythm version
//else _ce();
}
else
{
nsl = OrderClosePrice()+TrailingStopPip*_Point;
if(MathRound((OrderStopLoss()-_Ask)/_Point)-TrailingStopPip > 0)
if(!OrderModify(OrderTicket(), OrderOpenPrice(), nsl, OrderTakeProfit(), OrderExpiration(), Red))
_ce();
/*
if(OrderModify(OrderTicket(), OrderOpenPrice(), nsl, OrderTakeProfit(), OrderExpiration(), Red))
reverse = MathRound(nsl/_Point);
*/ //reverse pt using previous data which is different to the orignal Rhythm version
//else _ce();
}
}
else if(TrailOnceStop)
{
nsl = OrderOpenPrice();
if(OrderType() == OP_BUY)
{
if(MathRound((_Bid-nsl)/_Point)-TrailingStopPip > 0)
if(MathRound((nsl-OrderStopLoss())/_Point) != 0)
if(!OrderModify(OrderTicket(), OrderOpenPrice(), nsl, OrderTakeProfit(), OrderExpiration(), Blue))
_ce();
/*
if(OrderModify(OrderTicket(), OrderOpenPrice(), nsl, OrderTakeProfit(), OrderExpiration(), Blue))
reverse = MathRound(nsl/_Point);
else _ce();
*/ //reverse pt using previous data which is different to the orignal Rhythm version
}
else
{
if(MathRound((nsl-_Ask)/_Point) - TrailingStopPip > 0)
if(MathRound((nsl-OrderStopLoss())/_Point) != 0)
if(!OrderModify(OrderTicket(), OrderOpenPrice(), nsl, OrderTakeProfit(), OrderExpiration(), Blue))
_ce();
/*
if(OrderModify(OrderTicket(), OrderOpenPrice(), nsl, OrderTakeProfit(), OrderExpiration(), Blue))
reverse = MathRound(nsl/_Point);
else _ce();
*/
}
}
else if(StepTrailingStop)
{
if(OrderType() == OP_BUY)
{
nsl = OrderClosePrice()-TrailingStopPip*_Point;
if(MathRound((_Bid-OrderOpenPrice())/_Point)-StartStepPip > 0)
if(MathRound((_Bid-OrderStopLoss())/_Point)-TrailingStopPip > 0)
if (TakeProfitHold)
OrderModify(OrderTicket(), OrderOpenPrice(), nsl, OrderTakeProfit(), OrderExpiration(), Blue);
else OrderModify(OrderTicket(), OrderOpenPrice(), nsl, 0, OrderExpiration(), Blue); //TakeProfit judge by trailing stop only

}
else
{
nsl = OrderClosePrice()+TrailingStopPip*_Point;
if(MathRound((OrderOpenPrice()-_Ask)/_Point)-StartStepPip > 0)
if(MathRound((OrderStopLoss()-_Ask)/_Point)-TrailingStopPip > 0)
if (TakeProfitHold)
OrderModify(OrderTicket(), OrderOpenPrice(), nsl, OrderTakeProfit(), OrderExpiration(), Red);
else OrderModify(OrderTicket(), OrderOpenPrice(), nsl, 0, OrderExpiration(), Red); //TakeProfit judge by trailing stop only

}
}
else if(StepStop)
{
if(OrderType() == OP_BUY)
{
nsl = OrderStopLoss();
if ( Bid-OrderOpenPrice()>0)
{
for (z=1;Bid-OrderOpenPrice()>= z*StepSize*Point;z++)
{
nsl = OrderStopLoss()+ StepSize*Point;
if (Bid - nsl >= MinDistance*Point)
nsl=nsl;
else nsl = OrderStopLoss();
}

}
if (TakeProfitHold)
OrderModify(OrderTicket(), OrderOpenPrice(), nsl, OrderTakeProfit(), OrderExpiration(), Blue);
else OrderModify(OrderTicket(), OrderOpenPrice(), nsl, 0, OrderExpiration(), Blue);
}
else
{
nsl = OrderStopLoss();
if (OrderOpenPrice()-Ask>0)
{
for (z=1;OrderOpenPrice()-Ask>=z*StepSize*Point;z++)
{
nsl = OrderStopLoss() - StepSize*Point;
if (nsl - Ask >= MinDistance*Point)
nsl = nsl;
else nsl = OrderStopLoss();
}
}
if (TakeProfitHold)
OrderModify(OrderTicket(), OrderOpenPrice(), nsl, OrderTakeProfit(), OrderExpiration(), Red);
else OrderModify(OrderTicket(), OrderOpenPrice(), nsl, 0, OrderExpiration(), Red);
}
}
else if (BEP_Level>0)
{
if (Level>=BEP_Level)
if (plpip>BEPpip) //Close Ticket at Break Even
{
if (OrderType() == OP_BUY)
OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, Blue);
else if(OrderType() == OP_SELL)
OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, Red);
else Comment("Trading error in BEP_LEVEL");

}
}
else if (ProfitProtect)
{
if (plpip<=ProfitProtectpip) //Close Ticket when reached Profit Protection Pip
{
if (OrderType() == OP_BUY)
OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, Blue);
else if (OrderType() == OP_SELL)
OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, Red);
else Comment("Trading error in ProfitProtection");
}
}
}

return(0);
} //End of int StopAndReverse(....)

bool _Rhythm_CanTrade(string symbol, int magic, int max, int tic)
{
//Print("Passing Order Ticker is " + tic);
if (max>0){
if (Level>=max){
Lock=true;
return (false);}
}

for(int i=OrdersHistoryTotal()-1; i >= 0; i--)
{
if(OrderSelect(i, SELECT_BY_POS, MODE_HISTORY))
{
if(TakeProfit > 0)
{
if((StringFind(OrderComment(), "[tp]") >= 0)&&(OrderTicket()==tic))
{
Lock=true;
return(false);
}
}
if(((TrailingStop||TrailOnceStop)&&(positivepip))||((StepTrailingStop)&&(stpositivepip)))
/* If the option TrailingStop or TrailOncestop open , once have positive pip and meet stop loss point. trade Finish
If the option StepTrailingStop open, once have positive StepTrailingPip and meet stop loss poing. trade Finish
*/
{
if((StringFind(OrderComment(), "[sl]") >= 0)&&(OrderTicket()==tic))
{
Lock=true;
return(false);
}
}
}
}
/*
if (pip>=TakeProfit){
Lock=true;
return(false);}
*/
if ((Level>=BEP_Level)&&(BEP_Level>0))
if (plpip>BEPpip) {
Lock=true;
return (false);}
if (ProfitProtect)
if (plpip<=ProfitProtectpip) {
Lock=true;
return (false);}
if (Closeimmediate){
CloseAllTrades();
return (false);}
if (Lock) return (false);
return(true);
}

bool _Rhythm_ActivePosition(string symbol, int magic)
{
int i=0;
for(i=0; i<OrdersTotal(); i++)
if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES)){
//if(OrderType() <= OP_SELL)
if(OrderSymbol() == symbol)
if(OrderMagicNumber() == magic)
{//Comment ("Trade active \n");
return(true);}
}else
Print("OrderSelect() error - ", ErrorDescription(GetLastError()));
//Alert("No more Active Trade");
return(false);
}

bool _Rhythm_tt(int period, int openh, int closeh)
{
// Trade times
datetime st = MathFloor(TimeCurrent()/86400)*86400 + openh*3600;
datetime en = MathFloor(TimeCurrent()/86400)*86400 + closeh*3600+period*60;
datetime now = TimeCurrent();
while(st > now) st -= 86400;
while(en > now) en -= 86400;
if(st<en) return(false);
return(true);
}
bool _Rhythm_stt(int openh, int openmin)
{
// Trade times
if ((Hour()==openh)&&(Minute()>=openmin)) return (true);

return(false);
}

bool _ce()
{
int err=GetLastError();
if(err != ERR_NO_ERROR){
Print("Error #", err, " ", ErrorDescription(err));
return(true);
}
return(false);
}

double _sl(int type, string symbol, int stoploss)
{
if(type == OP_BUY)
if(stoploss > 0)
return(MarketInfo(symbol, MODE_BID)-stoploss*MarketInfo(symbol, MODE_POINT)+MarketInfo(symbol, MODE_SPREAD)*MarketInfo(symbol, MODE_POINT));
else
return(0.0);
else if(type == OP_SELL)
if(stoploss > 0)
return(MarketInfo(symbol, MODE_ASK)+stoploss*MarketInfo(symbol, MODE_POINT)-MarketInfo(symbol, MODE_SPREAD)*MarketInfo(symbol, MODE_POINT));
else
return(0.0);
}

double _tp(int type, string symbol, int takeprofit)
{
if(type == OP_BUY)
if(takeprofit > 0)
return(MarketInfo(symbol, MODE_BID)+takeprofit*MarketInfo(symbol, MODE_POINT)+MarketInfo(symbol, MODE_SPREAD)*MarketInfo(symbol, MODE_POINT));
else
return(0.0);
else if(type == OP_SELL)
if(takeprofit > 0)
return(MarketInfo(symbol, MODE_ASK)-takeprofit*MarketInfo(symbol, MODE_POINT)-MarketInfo(symbol, MODE_SPREAD)*MarketInfo(symbol, MODE_POINT));
else
return(0.0);
}

void CloseAllTrades()
{
int total = OrdersTotal();
for (int y=OrdersTotal()-1; y>=0; y--)
{
OrderSelect(y, SELECT_BY_POS, MODE_TRADES);
if (OrderMagicNumber() == Magic)
{
int type = OrderType();
bool result = false;
int TriesNum = 5;
int tries=0;
while (!result && tries < TriesNum)
{
RefreshRates();
switch(type)
{
case OP_BUY :
result = OrderClose(OrderTicket(),OrderLots(),MarketInfo(OrderSymbol(),MODE_BID),Slippage,Pink);
break;
case OP_SELL:
result = OrderClose(OrderTicket(),OrderLots(),MarketInfo(OrderSymbol(),MODE_ASK),Slippage,Pink);
}
tries++;
}
if (!result) Print("Error closing order : ",ErrorDescription(GetLastError()));
}
}
}
//+---- Programmed by Michal Rutka ----------------------------------+
//Amended by Christopher Lau
  • #10
  • Jan 28, 2014 3:11am Jan 28, 2014 3:11am
MaxDoom,

That is the original without any of the changes i have made in MT4. Thank you again...
  • #11
  • Jan 28, 2014 3:33am Jan 28, 2014 3:33am
Quoting Lynnye
MaxDoom, That is the original without any of the changes i have made in MT4. Thank you again...
you need to attach it as a file otherwise it is not readable
  • #12
  • Jan 28, 2014 3:44am Jan 28, 2014 3:44am
OH CRAP!!! Forgot... Will do
  • #13
  • Jan 28, 2014 4:08am Jan 28, 2014 4:08am
Attached File(s)
File Type: mq4 MQ4 S&R.mq4   33 KB | 247 downloads



O.K my friend. Sorry about that. You should be able to read it now. Thank you so much...
  • #14
  • Jan 28, 2014 4:26am Jan 28, 2014 4:26am
Quoting Lynnye
{file} O.K my friend. Sorry about that. You should be able to read it now. Thank you so much...
this is not well written, but you already know that....

it had 2 start sections
it refers to functions and variables that have not been defined to do with error message handling

I have commented out the error stuff and amended the other bits so it compiles search for ADDED & REMOVED to see changes

to be honest with code this bad, the value it is likely to give you even if it works has to be questionable

regards
Attached File(s)
File Type: mq4 MQ4 S&R.mq4   33 KB | 550 downloads
  • #15
  • Jan 28, 2014 2:26pm Jan 28, 2014 2:26pm
MAXDOOM,

yeah, I did recognize that. My thinking is that if it could be corrected, it might give a decent return. I'm going to run it with your updates on a demo account and see how it works. Either way, I appreciate you taking the time to look it over and make the corrections. You're a good person. Thank you my friend... :-)
  • #16
  • Jan 29, 2014 4:27am Jan 29, 2014 4:27am
MAXDOOM,

im im running the EA with your updates. Since I am a newb at this , I have a question that is probably going to sound completely insane to you, but please bear with me. I attached the EA to the chart, bought one mini lot, I can see the fluctuations on the chart. Up in the left hand corner I see "waiting for tic" and it has remained there since I attached the EA. Should that be there?? I have made a gross profit of fourteen pips so far. If the chart is moving, and the EA is working properly, should I be seeing the "waiting for tic"??? If not, how do I correct??? Please advise, and once again, thank you for your your patience.. Much appreciated... :-)
  • #17
  • Jan 29, 2014 4:56am Jan 29, 2014 4:56am
Quoting Lynnye
MAXDOOM, im im running the EA with your updates. Since I am a newb at this , I have a question that is probably going to sound completely insane to you, but please bear with me. I attached the EA to the chart, bought one mini lot, I can see the fluctuations on the chart. Up in the left hand corner I see "waiting for tic" and it has remained there since I attached the EA. Should that be there?? I have made a gross profit of fourteen pips so far. If the chart is moving, and the EA is working properly, should I be seeing the "waiting for tic"??? If...
you can ignore that message, the EA you have places that comment on at the start and never changes it.... so the message is nonsense

if the prices are changing you are getting ticks, a tick = a price change
  • #18
  • Jan 29, 2014 5:09am Jan 29, 2014 5:09am
MAXDOOM,

thats what I thought. The other thing I'm wondering about is this... The reverse on this EA is triggered when the stop/loss is reached. I know that the stop/loss is set at 3. I originally thought that when the stop was set, the reverse was automatically set as well, but I don't think that is the case. How do I check to see if the stop loss and the reverse are set at the same level? I'm thinking "inputs tab"??? And if so, what do I look for? I'm going to owe you a drink after this... :-)
thank you so very much.
  • #19
  • Jan 29, 2014 6:43am Jan 29, 2014 6:43am
MAXDOOM,

just checked my computer. Something very interesting has happened. The EA tried to execute buy/sell orders ten different times, but failed because of "not enough money" it automatically increased the lot size each time it attempted to execute a new order in increments as follows: 0.01,0.20,0.40,0.80,1.60,3.20,6.40,12.80,25.60... That would explain why a demo account with a balance of $50,000.00 would not have enough money. I need to be able to stop the the lot increases when a reverse order is executed. I think that if that can be done, this will be a profitable EA. Can you advise please... It also sets s/l and t/p automatically. Should this be eliminated also??? Thank you my friend... Two drinks.. :-)
  • #20
  • Jan 30, 2014 1:38am Jan 30, 2014 1:38am
Quoting Lynnye
MAXDOOM, just checked my computer. Something very interesting has happened. The EA tried to execute buy/sell orders ten different times, but failed because of "not enough money" it automatically increased the lot size each time it attempted to execute a new order in increments as follows: 0.01,0.20,0.40,0.80,1.60,3.20,6.40,12.80,25.60... That would explain why a demo account with a balance of $50,000.00 would not have enough money. I need to be able to stop the the lot increases when a reverse order is executed. I think that if that can be done,...
Hi Lynnye,

as much as I would like to help you further with this, I just do not have the time to get into the program and sort it out. It takes time with a well written program where the logic is already known but a poorly written one with the logic unknown takes much longer to work through. very sorry
0 traders viewing now