What's wrong with this EA?

I tried coding an EA and i get no errors when I compile it.

However, when I try testing it on the Strategy tester, none of the orders are executed. Looking at the journal (please see the picture below), I saw that the problem is with executing my orders. My orders were never executed.

I have the following lines of code for sending orders and closing positions.

For an order to go long
===============================================================
TicketNumber = OrderSend(Symbol(),OP_BUY,TradeLots,Ask,3,Ask-11*Point,0,"My EA",numOrders,0,Green);

if(TicketNumber <=0)
{ Alert("Buy Order NOT executed. Ticket Number: ",TicketNumber);
return(-1);
}
PositionOpen = TRUE;
PositionLong = TRUE;


//Similarly for an order to go short

TicketNumber = OrderSend(Symbol(), OP_SELL,TradeLots,Bid,3,Bid+5*Point,0, "My EA",numOrders,0,Red);

if(TicketNumber <=0)
{ Alert("Sell Order NOT executed. Ticket Number: ", TicketNumber);
Print("OrderSend failed with error # ",GetLastError());
return(-1);
}

PositionOpen = TRUE;
PositionLong = FALSE;
==========================================================

The following code is to close an existing open position.

================================================================


The following code to close an existing short position
=================================================================
OrderClosed = OrderClose(currentOrderTicketNumber, TradeLots, 2, CLR_NONE);

if(OrderClosed != true)
{ Alert("Short Position NOT successfully Closed. Ticket Number: ",currentOrderTicketNumber);
return(-1);
}

PositionOpen = FALSE;
PositionLong = FALSE;

==================================================================


Can anyone please tell me where am I going wrong, or why am I getting all these errors?

Your help is much appreciated.

looks like your routine for selecting the order to close is not selecting a valid order. Your order number is coming back as 1 it should be set to the ticket number of the order you wish to close.

Ok, what about the errors with Order Send. If you look at the second picture attached, it shows that there were problems with OrderSend function as well. What about that?

Also, is there a way to debug MT4 code line by line like its done in Java or C++ compilers?

no debugger in MT4, welcome to the nightmare.

error 134 is not enough money in the account to execute the order. By what I can see you are trying to purchase 10 standard lots with an account value of 10,000.

I fixed a few things and ran the Strategy Tester again. Now I see error # 4018 (Please see the attached picture).

Here's what I do for my Ticket number.

When an order is executed through OrderSend function, it is stored in integer variable TicketNumber. I also have two boolean variables to keep track of whether an order is currently opened right now and if its a long or short position. This is shown by the code below.

========================================================

//for long orders
TicketNumber = OrderSend(Symbol(),OP_BUY,TradeLots,Ask,10,Ask-11*Point,0,"My EA",numOrders,0,Green);
PositionOpen = TRUE;
PositionLong = TRUE;


//for short orders
TicketNumber = OrderSend(Symbol(),OP_SELL,TradeLots,Bid,10,Bid+5*Point,0,"My EA",numOrders,0,Red);
PositionOpen = TRUE;
PositionLong = TRUE;

=========================================================

Now, in my start function the very first line is an if statement to check if there is currently an open position. If there is, then it will see if it should be closed or not.

Also, if the position is closed, the two boolean variables are set back to false.


========================================================

if(PositionOpen)
{
if(PositionLong)
{
..............
{ // close the Long Position
OrderClosed = OrderClose(TicketNumber, TradeLots, Bid, 5, Green);
PositionOpen = FALSE;
PositionLong = FALSE;
}
}
else //meaning position is short
{
......
{ OrderSuccessfullyClosed = OrderClose(TicketNumber, TradeLots, Ask, 5, Red);
PositionOpen = FALSE;
PositionLong = FALSE
}
}
}

========================================================

I don't know if this is the most efficient way to keep a track of the existing positions. And I don't know where am I going wrong. Can anyone please suggest a replacement or something else? Or why am I getting this error?

it might make it easier for someone to look at the code if you would post the mq4 file for the ea. Right now it is hard to figure out what is going on with just snippets of code.

Ok, I have attached it with this post. This is just the first ea I'm writing for my own practice inspired from pip nailer.

I really appreciate your help with this magnumfreak.

*NOTE TO EVERYONE: This is just a sample file I posted that I am using to learn MT4. I am not making any claims about this sample EA. If you want to use it, please do so at your own risk (and if you can get it to work i.e.....)

Can someone please help me with the error in ordersend function in the EA posted above?

I will really appreciate your help.

Simple and clean codes there. I like it

There is nothing wrong with your codes. But ERROR #4018 is indicate that your Metatrader can not load library file(s).

Just try to reinstall you Metatrader.

Hello,
i would like to ask you a question..
did you assuming that the following code :

will always reserve the last initiated values? if so, then there is your problems you should define Globals variables if you need some variables is retaining it's last values on every tick.

Hope to help.

NO, I don't think this is the problem since my variables are delcared as global variables. I have attached the code on the post above.

Please do take a look. Its very simple and very short.

You help is greatly appreciated.

SVM

Yes, you are right, you declare the variables as your global variable. BUT you declare the variable at your script, not at your MetaTrader platform, you declare a meta trader global variable using the following sintax :
Hope to help

Right, but it still didn't help.


When I actually decalred the variables using GlobalVariableset

GlobalVariableSet("Lots", 1.0);
GlobalVariableSet("TicketNumber", 0);

I got the error message, that "Lots" or "TicketNumber" - variable not defined.

Not to mention that looking at the syntax from coder's guru lessons, he put his orders using the following syntax.

=================================================

if(isCrossed == 1)
{
ticket=OrderSend(Symbol(),OP_BUY,Lots,Ask,3,0,Ask+TakeProfit*Point,"My EA",12345,0,Green);
if(ticket>0)
{
if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES))
Print("BUY order opened : ",OrderOpenPrice());



=================================================

I don't get it, its suppose to be something simple. What am I missing? I have posted my EA in one of the posts above. Can anyone please take a look?

Its nothing hard/long, if you worked with MT 4 before.

I don't know why you intent to put your order ticket number in a variable. Any particular reason?

I think that global variable or variable global is not the main point on your strategy EA.

My suggestion: Use for() loop to close existing position. filter by OrderSymbol() and OrderMagicNumbers().

Well, the problem is coming from ordersend function. It won't send out orders initially to start off. I am trying to save the ticket number that OrderSend returns and store it in a variable.

I used that ticket number to close the position.

I can change the mehtod I use to close my positions, but the problem is with opening an order to start off with. I'll make the changes and post the updated file soon.

Thank you everyone for all your help.

I figured out finally. The problem was with the way Strategy Tester properties were setup.

My Initial deposit was set to 10,000
However, I still got the error, when the strategy tester was set to 100,000
So I changed it to a million and finally was able to run my strategy tester.