Order Modify Question | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

MT4 Order Pending Order/Order Modify Issue 1 reply

Not include "order modify" at MT4 backtest report 4 replies

Modify Pending Order Price 2 replies

Modify Pending Order EA 0 replies

Can set HotKey for Close Order and Modify Order? 9 replies

Attachments: Order Modify Question
Exit Attachments

Order Modify Question

  • #1
  • First Post: Jun 26, 2008 2:05am Jun 26, 2008 2:05am
So I started live testing a system that I have been working on (See attached Results up 10%+ in the first 6 hours, Its a scalper system so it will always carry a floating drawdown) I am having a problem with the Order Modify function ... Can anyone here identify what I have done wrong ? It is suppose to modify the SL when a position reaches 4 pips in profit to lock in 1 pip with a stoploss. but it doesent seem to be doing anything at all. Here is the code

PHP Code
void ManageOrders(){
    int cnt;
    //for(cnt = 0; cnt < OrdersTotal(); cnt++){
    for(cnt=OrdersTotal();cnt>0;cnt--){
      OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);  
        if (OrderType() == OP_BUY ){
           if(MarketInfo(OrderSymbol(),MODE_BID) >= OrderOpenPrice() + 4 * MarketInfo(OrderSymbol(),MODE_POINT)){
             if(OrderStopLoss() < MarketInfo(OrderSymbol(),MODE_BID) - 3 * MarketInfo(OrderSymbol(),MODE_POINT)){
               OrderModify(OrderTicket(),
                           OrderOpenPrice(),
                           MarketInfo(OrderSymbol(),MODE_BID) - 3 * MarketInfo(OrderSymbol(),MODE_POINT),
                           OrderTakeProfit(),
                           0,
                           Orange);
               }
           }
       }
       continue;
       if (OrderType() == OP_SELL ){
           if(MarketInfo(OrderSymbol(),MODE_ASK) <= OrderOpenPrice() - 4 * MarketInfo(OrderSymbol(),MODE_POINT)){
             if(OrderStopLoss() > MarketInfo(OrderSymbol(),MODE_ASK) + 3 * MarketInfo(OrderSymbol(),MODE_POINT)){
               OrderModify(OrderTicket(),
                           OrderOpenPrice(),
                           MarketInfo(OrderSymbol(),MODE_ASK) + 3 * MarketInfo(OrderSymbol(),MODE_POINT),
                           OrderTakeProfit(),
                           0,
                           Orange);
               }
           }
       }
       continue;
  }
}
Its gotta be something simple... it always is.
Attached Image (click to enlarge)
Click to Enlarge Name: first 6 hours.jpg Size: 113 KB
Keep it simple stoopid....
  • #2
  • Last Post: Jun 26, 2008 5:44am Jun 26, 2008 5:44am
One possibility: does your broker set a minimum number of pips between where the market is & where you set your SL? I know some brokers have a 5 or even 10 pip minimum, which means you can't set your SL to within 5-10 pips from market.

Another thing to do is to add a statement to print out any errors if the Order Modify does not succeed. Then check your Experts tab for error statements & compare the error-code with the MQL4 error list to see exactly why the command is failing.

Another thing to check is whether there is a conflict in the trading thread: if you're running the EA on multiple charts, when two or more of them signal at the same time, they will be competing for the trading thread, which in MT4 is singular (one-at-a-time). Use a semaphore (or comparable method) for proper crowd control.

Also, I've found that it's always good to normalize the results of any arithmetic calculation for more precise comparison. (Use NormalizeDouble().)
Dave
0 traders viewing now