OrderSelect() Index Problem

the following code snippet is used to close short positions:

total = OrdersTotal();
for(i=0;i<total;i++){
if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)){
if(OrderSymbol()==Symbol() && OrderMagicNumber()==magic_base){
if(OrderType()==OP_SELL){
OrderClose(OrderTicket(),OrderLots(),Ask,Slippage,clr_close);
}
}
}
}

however, I've discoverd that it doesn't always do that. if I have only one open position, it is closed correctly. but when I have multiple positions running, only some of them will be closed at the correct time, others are forgotten.

I guess that this strange behavior is caused by the index parameter of OrderSelect(). everytime an order is closed or deleted, the index diminishes and reassigns itself to the remaining orders. thus causing some orders to be left out.

my crude solution is to use multiple instances of the for() loop. this works but there has got be a more elegant way. does anybody know how to solve this more professionally?

In your statement that closes the order add two additional steps.

1. Reset i to 0.
2. reset total = OrdersTotal.

if(OrderType()==OP_SELL){
OrderClose(OrderTicket(),OrderLots( ),Ask,Slippage,clr_close);
i=0;
total=OrdersTotal();
}


This will force it to search from the beginning everytime it closes an order, then once it closes all of the orders it will just cycle through and continue on.

Hello magnumfreak, thanks for the solution!

[quote=magnumfreak;2063469]In your statement that closes the order add two additional steps.

1. Reset i to 0.
2. reset total = OrdersTotal.

if(OrderType()==OP_SELL){
OrderClose(OrderTicket(),OrderLots( ),Ask,Slippage,clr_close);
i=0;
total=OrdersTotal();
}


This will force it to search from the beginning everytime it closes an order, then once it closes all of the orders it will just cycle through and continue on.[/quot]

ok, this is weird, I've done what you suggested but the problem persists. I think the logic of your suggestion is sound, so why does it not deliver??

here is my modified CloseShorts() function:

int CloseShorts()
{
//----
int i,total;
total = OrdersTotal();
for(i=0;i<total;i++){
if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)){
if(OrderSymbol()==Symbol() && OrderMagicNumber()==magic_base){
if(OrderType()==OP_SELL){
OrderClose(OrderTicket(),OrderLots(),Ask,Slippage,clr_close);
total = OrdersTotal();
i = 0;
}
else continue;
}
}
}
//----
return(0);
}