Forward or Backwards ? That is the question | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

The Backwards System 96 replies

Anyone find it funny that Risk/Reward ratio's are said backwards? 9 replies

backwards shifted ma on present candle?? 0 replies

Coding something backwards 4 replies

Question on forward testing 5 replies

Forward or Backwards ? That is the question

  • #1
  • First Post: Jun 11, 2008 12:55am Jun 11, 2008 12:55am
Im having a problem with my Order Management Function. I have multiple open positions (15) and I only want to close a select few (7). If I count forward while selecting the orders to manage ,it only closes the most recently open order that meets my criteria.

for(cnt = 0; cnt < OrdersTotal(); cnt++){

But if I count Backwards it closes the first one opened then gives me a stack overflow error...

for(cnt=OrdersTotal();cnt>0;cnt--){



PHP Code
void ManageOrders(){
    RefreshRates();
    MarketDirection(); //check Market Direction
    
    int cnt;
    for(cnt = 0; cnt < OrdersTotal(); cnt++){
    //for(cnt=OrdersTotal();cnt>0;cnt--){
      OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);  
        if (OrderProfit() > 0 && OrderType() == OP_BUY){        
           C_Ticket = OrderTicket();
           C_Price = Bid;
           C_Slippage = 0;
           CloseTicket();
           //break;
           }
         if (OrderProfit() > 0 && OrderType() == OP_SELL){
           C_Ticket = OrderTicket();
           C_Price = Ask;
           C_Slippage = 0;
           CloseTicket();
           //break;
           }
       }
 }

Close Ticket Function...

PHP Code
void CloseTicket(){
            int ticket=0;
            int err=0;
            int c = 0;
            int Attempts = 3;
            
       for(c = Attempts ; c > 0; c--){
            RefreshRates();
            if(CheckBid != Bid){

               break;
               }
            ticket=OrderClose(C_Ticket,OrderLots(),C_Price,C_Slippage,White);
            if (ticket > 0) {Print (" Order Symbol : "+OrderSymbol()," Order Type : "+OrderType()," Lots : "+OrderLots()," Open Price : "+OrderOpenPrice()," Stop Loss : "+OrderStopLoss()," Take Profit : "+OrderTakeProfit()," Order Magic : "+OrderMagicNumber()," Open Time : "+OrderOpenTime(),"Order was open for : ",TimeToStr(TimeCurrent()-OrderOpenTime(),TIME_MINUTES|TIME_SECONDS)," EA Took ",GetTickCount() - TickStart," milliseconds" );

            break;
            }
            err=GetLastError();
            if(err==0 || err==2 || err==4 ||err==6 || err==8 || err==9 || err==64 || err==128 || err==132 || err==133 || err==137 || err==139 || err==141 || err==146){ //Sleep and retry errors
               Print("....................... Sleep And Retry Error Code= ", err," "+ErrorDescription(err));
               Sleep(10);
               continue;
               }
            if(err==135 || err==136 || err== 138){ // price change errors
               Print ("..................Invalid Price "+ OrderTicket() + " ..............");
               //WindowScreenShot("S_REQUOTE_"+Month()+"_D"+Day()+"_H"+Hour()+"_M"+Minute()+"_S"+Seconds()+".gif",1440,900);
               Print("....................... Price Error Code= ", err," "+ErrorDescription(err));
 entry criteria

               break;
               }
            else{ // other errors
               Print(".......................Error Code= ", err," "+ErrorDescription(err));

               break;
               }
            }
 }
I would like it to close all my orders that meet the criteria.... does anyone here see what I have done wrong?

Thanks.
Keep it simple stoopid....
  • #2
  • Jun 11, 2008 7:48pm Jun 11, 2008 7:48pm
bump...
Keep it simple stoopid....
  • #3
  • Jun 12, 2008 2:46am Jun 12, 2008 2:46am
Kurka, suppose there are 10 orders, in which case I assume OrdersTotal() would = 10.

Then
for(cnt = 0; cnt < OrdersTotal(); cnt++){
will process for cnt = {0,1,2,3,4,5,6,7,8,9}

while
for(cnt=OrdersTotal();cnt>0;cnt--){
will process for cnt = {10,9,8,7,6,5,4,3,2,1}

If the orders are numbered 0 to 9, then attempting to process an order when cnt=10 might cause a stack overflow?? – just a guess.
Ditto if orders are numbered 1 to 10, then attempting to process when cnt=0 would likely cause a similar error.

Also suggest that you debug by replacing your CloseTicket() statements with { Print(cnt); OrderPrint(); }
This will output all order data to the log file, allowing you to (1) see which orders are being processed for each value of cnt, and (2) help you determine whether your problem lies in the selection of the orders, or the CloseTicket() routine.

Does this help to get you started?

Good luck,
David
  • #4
  • Last Post: Jun 12, 2008 3:12am Jun 12, 2008 3:12am
OK, I tried:

int start()
{
Print("Orders = " + OrdersTotal());
// for(int cnt=0; cnt<OrdersTotal(); cnt++)
for(int cnt=OrdersTotal(); cnt>0 ; cnt--)
{ OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES); Print(cnt); OrderPrint(); }
return(0);

with loops both forward and backward. I have 12 orders. Didn't get a stack overflow. If there's no order matching a value of cnt, the OrderPrint() function simply prints nothing.

Next question: I assume C_Ticket, CheckBid etc are global variables?

It's too difficult to progress further without seeing all of the MQ4 source. All I can suggest is that you use Print() statements to narrow down the error to a single line of code, i.e. the basis of all MQL4 debugging.

David
0 traders viewing now