Correct code for Limit Entry | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Scripts for Limit entry, Stop entry, Market entry 47 replies

Please help to correct the code of OsMA_MTF 17 replies

Please correct code in my first self-built EA 3 replies

is this a correct double bottom entry? 2 replies

Is this correct? (About Limit order) 9 replies

Correct code for Limit Entry

  • #1
  • First Post: Edited Jun 5, 2008 12:28am Jun 4, 2008 11:34pm | Edited Jun 5, 2008 12:28am
Greetings,

I'm fine tuning an EA and would like to have it set a Limit order upon a particular trigger. The entry has been working fine with an OP_BUY command. Now, I'm trying to change it to set a Limit order instead of an Entry order. Unfortunately, my first "tweak" didn't work.

So, here's the question if you don't mind. Is this the proper way to code the entry price?

NormalizeDouble(Ask-LimitEntry,Digits),


For context it is set in the OrderSend string below:

OrderSend(Symbol(),
OP_BUYLIMIT, Lots, NormalizeDouble(Ask-LimitEntry,Digits), 3, NormalizeDouble(Bid - StopLoss*Point, Digits), NormalizeDouble(Bid + TakeProfit*Point,
Digits), "MGF-PSAR-LMT-3-2-15-a", magicnolong, 0, CLR_NONE);

Thank you ...
  • #2
  • Jun 5, 2008 1:12pm Jun 5, 2008 1:12pm
I think I figured this one out ...

Originally I was using:
NormalizeDouble(Ask-LimitEntry,Digits)

I've just run a single entry test with this code
NormalizeDouble(Ask - LimitEntry*Point,Digits)

and a Limit order DID open ... Looks like the addition of "*Point" was the key.

I'll run some more and see if this is consistant ... Hope it helps someone.

Pip Parade
  • #3
  • Jun 6, 2008 3:34pm Jun 6, 2008 3:34pm
What if we planned a big party and nobody showed up???

Even so, I did want to provide some closure for this topic. I am very happy to report that the change identified in the second post DOES Work I know the programmers in the group already knew that but now that this item has it's own thread here in the FF then I'll know where to look when I forget how it's done.

See you in the parade ...
  • #4
  • Jun 6, 2008 4:27pm Jun 6, 2008 4:27pm
Quoting Pip Parade
What if we planned a big party and nobody showed up???

Even so, I did want to provide some closure for this topic. I am very happy to report that the change identified in the second post DOES Work I know the programmers in the group already knew that but now that this item has it's own thread here in the FF then I'll know where to look when I forget how it's done.

See you in the parade ...
Hey Pip Parade!

This is really funny!

And I did not even know you could code a bit!!

See ya & nice weekend!
Matt Gnat
  • #5
  • Jun 6, 2008 5:43pm Jun 6, 2008 5:43pm
Quoting Gnat
Hey Pip Parade!

This is really funny!

And I did not even know you could code a bit!!

See ya & nice weekend!
Matt Gnat
Hiya Gnat, Good to hear from you !

Don't let the 1x results fool you. I suppose a monkey with a typewriter "could" have written War and Peace (or some other huge book I've never read), but that doesn't make him a writer.

I'm still a programming rookie but enjoy learning the ropes. It is comforting to fall back on this board as a base. Knowing that there are people here like yourself and others I've met who are willing and able to guide, steer, assist or correct when appropriate is helpful. Kind of like having the lifeguard on the side of the pool while learning how to swim. If you do go under for too long they'll pull you out ... hopefully.

The addition of the Limit order feature on this EA did help. Testing 4 different EA's currently and this was the only one that stayed profitable through NFP. Still looking for solid profits (or minimal losses) here and I've got another piece to add over the weekend. Next week should be fun.

Enjoy,

Pip Parade.


btw: I came "this close" to sending a non-forex pm to you. I've got some business associates vacationing in Germany and I think they will be reasonably near you. We were setting up contact logistics and you crossed my mind as a possible link. Other arrangements were made so they won't be bothering you. Maybe next time.
  • #6
  • Jun 7, 2008 5:55am Jun 7, 2008 5:55am
Quoting Pip Parade
Hiya Gnat, Good to hear from you !

Don't let the 1x results fool you. I suppose a monkey with a typewriter "could" have written War and Peace (or some other huge book I've never read), but that doesn't make him a writer.

I'm still a programming rookie but enjoy learning the ropes. It is comforting to fall back on this board as a base. Knowing that there are people here like yourself and others I've met who are willing and able to guide, steer, assist or correct when appropriate is helpful. Kind of like having the lifeguard on the side of the pool while learning how to swim. If you do go under for too long they'll pull you out ... hopefully.

The addition of the Limit order feature on this EA did help. Testing 4 different EA's currently and this was the only one that stayed profitable through NFP. Still looking for solid profits (or minimal losses) here and I've got another piece to add over the weekend. Next week should be fun.

Enjoy,

Pip Parade.


btw: I came "this close" to sending a non-forex pm to you. I've got some business associates vacationing in Germany and I think they will be reasonably near you. We were setting up contact logistics and you crossed my mind as a possible link. Other arrangements were made so they won't be bothering you. Maybe next time.
Hi Pip Parade!

Last things first: Don't hesitate to contact next time. Espcially in the northern harbour area of Germany I should be able to help. Lot's of clients and friends working in that field!

I am happy that you feel at home around here and I guess that the observation is right - as you stumble into the right group of people there is really endless willingness for help. (On the other hand you may get trashed as a newbie and are going to be talked down to ... but then you will not need to turn there ever again! )

I am interested in your EA projects. If you don't mind, that is! So PM me, if the forum is not the right place! Did you get along with the TC EAs?

Have a good one!
Ciao!
Matt Gnat
  • #7
  • Jun 9, 2008 1:01am Jun 9, 2008 1:01am
Hi Gnat,

Happy to share & discuss the details with you. Keep an eye on the PM feature as I'll try to bring you up to date there.

PP...
  • #8
  • Jun 9, 2008 6:49am Jun 9, 2008 6:49am
Quoting Pip Parade
Hi Gnat,

Happy to share & discuss the details with you. Keep an eye on the PM feature as I'll try to bring you up to date there.

PP...
Got it!

  • #9
  • Jun 10, 2008 8:25pm Jun 10, 2008 8:25pm
hey man
you dont need the normalize dbl
heres all u need

Ask - LimitEntry*Point

but if its working, good

Quoting Pip Parade
I think I figured this one out ...

Originally I was using:
NormalizeDouble(Ask-LimitEntry,Digits)

I've just run a single entry test with this code
NormalizeDouble(Ask - LimitEntry*Point,Digits)

and a Limit order DID open ... Looks like the addition of "*Point" was the key.

I'll run some more and see if this is consistant ... Hope it helps someone.

Pip Parade
  • #10
  • Jun 10, 2008 9:45pm Jun 10, 2008 9:45pm
Hey Trendchaser,

Nice of you to stop by and comment ... I appreciate it (& your other work).

I'll try to back up a bit and clean up the code as you suggested. Yes, the limit option is working & I'm happy about that but the less clutter the better.
  • #11
  • Jun 10, 2008 9:50pm Jun 10, 2008 9:50pm
hi,want to know do u have limit order script which can entry within spreads?thanks
  • #12
  • Jun 10, 2008 10:23pm Jun 10, 2008 10:23pm
Hi Amenlo9,

This is what I have for the OrderSend script ...

// ----------------------------------------

OrderSend(Symbol(), OP_BUY,
Lots, NormalizeDouble(Ask - LimitEntry*Point,Digits), 3, NormalizeDouble(Bid - StopLoss*Point, Digits),
NormalizeDouble(Bid + TakeProfit*Point, Digits), "MGF-PSAR-LMT-3-2-15-b", magicnolong, 0, CLR_NONE);

// ----------------------------------------

It includes the NormalizeDouble we were discussing but it has been working. Hope this helps.
  • #13
  • Jun 10, 2008 10:49pm Jun 10, 2008 10:49pm
hi,can u post completed script here because i don't have any programming skill.
  • #14
  • Jun 10, 2008 11:14pm Jun 10, 2008 11:14pm
Frankly, my programming skills aren't much better. Together, we would probably be a case of "the blind leading the blind". The OrderSend portion of script previously referenced works for me ... you'll have to find how to work it into your EA to achieve what you're working on.

What I have found is that research throughout this forum can teach someone a lot about the process. Review various EA's and you can probably develop a sense of their development. That's what I've done and from there I've managed to ask a pointed question or two of the programming community.

It's been my experience that they will help, if they see that you are showing evidence of doing research yourself (which I'm sure you are). There are some very good teachers here who pop up from time to time as they choose.

Best wishes to you.
  • #15
  • Last Post: Jun 11, 2008 6:21am Jun 11, 2008 6:21am
Quoting Pip Parade
Frankly, my programming skills aren't much better. Together, we would probably be a case of "the blind leading the blind". The OrderSend portion of script previously referenced works for me ... you'll have to find how to work it into your EA to achieve what you're working on.

What I have found is that research throughout this forum can teach someone a lot about the process. Review various EA's and you can probably develop a sense of their development. That's what I've done and from there I've managed to ask a pointed question or two of the programming community.

It's been my experience that they will help, if they see that you are showing evidence of doing research yourself (which I'm sure you are). There are some very good teachers here who pop up from time to time as they choose.

Best wishes to you.
What a picture there!
0 traders viewing now