Unbalanced Parenthesis

I'll spare you most of the backstory but suffice to say that I have been chasing an "unbalanced left parenthesis" for much longer than I care to.

I've been working on an EA based on the PSAR. Using the comment out features of /* */ I've been able to seemingly isolate the problem to a small section of code below. The full EA compiles when the code below is bracketed with the /* */. Without it ... the Error message '\end_of_program' - unbalanced left parenthesis surfaces.

I've tried everything I could possibly think of ... and a few others. Any suggestions???

Thank you in advance.

//+--------------------------------------------------+
//| Close - Long |
//+--------------------------------------------------+
int TradeClose=0;
if (SARD1>Bid) OrderSelect(magicnolong,SELECT_BY_POS,MODE_TRADES); TradeClose=1;
if (TradeClose=1, OrderClose(glbOrderTicket,Lots,Bid,3,CLR_NONE);


{
if (glbOrderType==OP_BUY) //confirm long open
{
if(SARD1>Bid && OrderMagicNumber(magicnolong) OrderClose(glbOrderTicket,Lots,Bid,3,CLR_NONE));

}
}

Closing ")" missing for "if" statement (and instead , is there) (also "=" should be "==");

Hi Chandra,

Thank you for your input, always appreciated.

I've added the "="'s so they are now ==.

However, if I understand the other part of your reply the ")" should go at the end of that line of code. So that ...3,CLR_NONE); becomes ...3,CLR_NONE));

Compiling now gives a whole new set of issues. Should the ")" go somewhere else or is there something else going on here?

p.s. ... as stated before there IS more of the code BUT it compiles fine with this section is blocked out with /* */.

if (TradeClose=1, OrderClose(glbOrderTicket,Lots,Bid, 3,CLR_NONE);

should be:

if (TradeClose==1) OrderClose(glbOrderTicket,Lots,Bid, 3,CLR_NONE);

also:

if(SARD1>Bid && OrderMagicNumber(magicnolong) OrderClose(glbOrderTicket,Lots,Bid, 3,CLR_NONE));

should be:
if(SARD1>Bid && OrderMagicNumber(magicnolong)) OrderClose(glbOrderTicket,Lots,Bid, 3,CLR_NONE);

Hi Magnum ...

Thanks for your input. I've rerun this with your suggestions now have a few different items.

Updated section of code is below:
--------------------------------------------------------------------

int TradeClose==0; // this is row 122

if (SARD1>Bid) OrderSelect(magicnolong,SELECT_BY_POS,MODE_TRADES); TradeClose==1;
if (TradeClose==1) OrderClose(glbOrderTicket,Lots,Bid,3,CLR_NONE);


{
if (glbOrderType==OP_BUY) //confirm long open
{
if(SARD1>Bid && OrderMagicNumber(magicnolong)) OrderClose(glbOrderTicket,Lots,Bid,3,CLR_NONE);

}
}

--------------------------------------------------------------
Error comments are below:


Compiling 'U&D-V1.mq4'...

'==' - comma or semicolon expected C:\Program Files\Interbank FX Trader 4\experts\U&D-V1.mq4 (122, 24)
'TradeClose' - variable not defined C:\Program Files\Interbank FX Trader 4\experts\U&D-V1.mq4 (124, 78)
'TradeClose' - variable not defined C:\Program Files\Interbank FX Trader 4\experts\U&D-V1.mq4 (125, 14)

3 error(s), 0 warning(s)



Any thoughts???

int TradeClose==0;

should be

int TradeClose=0;


a single = indicates that you want to assign a value, double == means you want to do a comparison (usually used in if statements and the like).

Thank you Magnum ...

Reduced the == to = as suggested. Compiled with errors.
Then reduced the == to = in the first of the 2 TradeClose=(=)1; Compiled with a single, different error.

--------------------------------------------
Compiling 'U&D-V1.mq4'...

')' - wrong parameters count C:\Program Files\Interbank FX Trader 4\experts\U&D-V1.mq4 (131, 57)


1 error(s), 0 warning(s)
----------------------------------------------

Then corrected the error (I thought) by removing one of the 2 "))" at (131, 57) and found myself back at square 1

Will try to post followup message for clarity.

int TradeClose=0;
if (SARD1>Bid) OrderSelect(magicnolong,SELECT_BY_POS,MODE_TRADES); TradeClose=1;
if (TradeClose==1) OrderClose(glbOrderTicket,Lots,Bid,3,CLR_NONE);


{
if (glbOrderType==OP_BUY) //confirm long open
{
if(SARD1>Bid && OrderMagicNumber(magicnolong)) OrderClose(glbOrderTicket,Lots,Bid,3,CLR_NONE); // this is row 131

}
}

------------------------------------------------
Compiling 'U&D-V1.mq4'...

')' - wrong parameters count C:\Program Files\Interbank FX Trader 4\experts\U&D-V1.mq4 (131, 57)

1 error(s), 0 warning(s)

int TradeClose=0;
if (SARD1>Bid) OrderSelect(magicnolong,SELECT_BY_POS,MODE_TRADES); TradeClose=1;
if (TradeClose==1) OrderClose(glbOrderTicket,Lots,Bid,3,CLR_NONE);


{
if (glbOrderType==OP_BUY) //confirm long open
{
if(SARD1>Bid && OrderMagicNumber(magicnolong) OrderClose(glbOrderTicket,Lots,Bid,3,CLR_NONE);

}
}

-----------------------------------------------------------
Compiling 'U&D-V1.mq4'...
'\end_of_program' - unbalanced left parenthesis C:\Program Files\Interbank FX Trader 4\experts\U&D-V1.mq4 (284, 2)
1 error(s), 0 warning(s)

So close, and yet so absolutely maddening ....

your thoughts?

if(SARD1>Bid && OrderMagicNumber(magicnolong)) OrderClose(glbOrderTicket,Lots,Bid, 3,CLR_NONE);

should be:

if(SARD1>Bid && OrderMagicNumber()==magicnolong) OrderClose(glbOrderTicket,Lots,Bid, 3,CLR_NONE);

MMMMMMaaaggggggnnnnnuuuuummmmmmmmmmmmmm!!!!!!!!!

you are the MAN !!!!!!!!!!!!!

Yeozers. The log jam is undone. Thank you very much. There are a few other key aspects of this EA in my mind. Hopefully I'll be able to run for a while with the development. Will certainly let you know if it succeeds.

Also, my thanks to you of course and others in this community. A few months ago I hadn't even heard of MetaTrader and EA's. Now I'm using it as an income tool and taking baby steps towards some degree of programming ... and I'm NOT a programmer.

My thanks to all who have helped.

not a problem. Glad to see it is working. Hopefully it will return major dividends for you.

pls can someone help me with same problem.i dont understand where and wht i did wrong in code.

This line...

I think you mean:

i put ; at the end but still same probllem

OrderModify(OrderTicket(),OrderOpenPrice(),Bid-(pips*TrailAmount),OrderTakeProfit(),0,CLR_NONE);

You are looking for unbalanced parenthesis. That's where you have a "(" without a ")". I gave you one line where you had an "if(" that you didn't need. It's possible that you did that on more than one line.

pls try (search for fxdaytrader to find lines I have changed) ...

thanks my friend.
its done
thanks a ton

Several errors ..
this corrects it but not checked what code does.

HTH

M.