Code Help, please!

Quoting ze0202

Disliked

Hi all! I’m new in programming… and maybe more expericed members can give me a little help with this…

I’m trying to find out the best code to detect:

1- the number of pairs which have Open Orders at the moment, starting from OrdersTotal( )…”

2- And then for each of those pairs, the total of Sells, Buys, LongProfit and ShortProfit respectively.

thanks anyway

Ignored

Quoting trader101

Disliked

Give the specifics of your requirement, examples, your needed output etc.

Ignored

Quoting ze0202

Disliked

First I need a way to detect which pairs are present with open orders and maybe give them a number according to their open time and date... if you see the example on the attached image, it would be:

usdjpy = pair1 (the pair with the oldest open order at 14:40 2008.04.04)
usdchf = pair2
gbpusd =pair3 (the most recent pair with open orders)

So, every time a new pair opens a new order the number of pairs would increase... and have a number by order of appearance

how can I code this?

Ignored

Quoting trader101

Disliked

All what you are saying can be seen in your terminal, you can also Symbol()according to the time that it was open, you can also see if your in profit or at a loss. The image you attached is invisible.

Ignored

for(int idx=0; idx < OrdersTotal(); idx++)
{
   if (OrderSelect(idx, SELECT_BY_POS, MODE_TRADES))
   {
        //Test the order here using the Orderxxxxxx series of functions
   }
}

Quoting ze0202

Disliked

My intention is NOT to specify the name of the pair (Symbol()) every time I retrieve those variables... what's the best way to sort them out using code, do you have any ideas?

Ignored

Quoting Royce

Disliked

In an indicator or EA you may loop through all the orders like so:

Inserted Code

for(int idx=0; idx < OrdersTotal(); idx++)
{
   if (OrderSelect(idx, SELECT_BY_POS, MODE_TRADES))
   {
 
   }
}

Ignored

Quoting ze0202

Disliked

Hi all! I’m new in programming… and maybe more expericed members can give me a little help with this…

I’m trying to find out the best code to detect:

1- the number of pairs which have Open Orders at the moment, starting from OrdersTotal( )…”

2- And then for each of those pairs, the total of Sells, Buys, LongProfit and ShortProfit respectively.

thanks anyway

Ignored

int CountBuyOrders()
{ int i,Bought=0;
   for (i=0;i<OrdersTotal();i++)
   {
      OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
      if(OrderType()==OP_BUY) Bought++;
   }
   return(Bought);
}

int CountSellOrders()
{ int i,Sold=0;
   for (i=0;i<OrdersTotal();i++)
   {
      OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
      if(OrderType()==OP_SELL) Sold++;
   }
   return(Sold);
}

double CountBuyProfit()
{ int i=0;
   double BuyProfit;
   for (i=0;i<OrdersTotal();i++)
   {
      OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
      if(OrderType()==OP_BUY) BuyProfit += OrderProfit();
   }
   return(BuyProfit);
}

double CountSellProfit()
{ int i=0;
   double SellProfit;
   for (i=0;i<OrdersTotal();i++)
   {
      OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
      if(OrderType()==OP_SELL) SellProfit += OrderProfit();
   }
   return(SellProfit);
}

Quoting skyline

Disliked

Hi ze0202,
you may use these functions :

Inserted Code

int CountBuyOrders()
{ int i,Bought=0;
   for (i=0;i<OrdersTotal();i++)
   {
      OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
      if(OrderType()==OP_BUY) Bought++;
   }
   return(Bought);
}
 
int CountSellOrders()
{ int i,Sold=0;
   for (i=0;i<OrdersTotal();i++)
   {
      OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
      if(OrderType()==OP_SELL) Sold++;
   }
   return(Sold);
}
 
double CountBuyProfit()
{ int i=0;
   double BuyProfit;
   for (i=0;i<OrdersTotal();i++)
   {
      OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
      if(OrderType()==OP_BUY) BuyProfit += OrderProfit();
   }
   return(BuyProfit);
}
 
double CountSellProfit()
{ int i=0;
   double SellProfit;
   for (i=0;i<OrdersTotal();i++)
   {
      OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
      if(OrderType()==OP_SELL) SellProfit += OrderProfit();
   }
   return(SellProfit);
}

Happy coding !

Ignored

Quoting ze0202

Disliked

Thanks a lot Skyline! But before that how will I sort out open pairs, based on opentime?

Ignored

Quoting skyline

Disliked

You're welcome
I think you have to use the OrderOpenTime() function to pick open time of trade selected by OrderSelect...but why do you want to order pairs based on time ?

Ignored

Quoting Royce

Disliked

I think you might want to invest some time in learning arrays. The technique you appear to be attempting would result in truly massive amounts of code.

I've attached a very basic EA that will pickup some orders, store them in an array and sort them by their open times.

Arrays are special variables that contain multiple instances of its variable type. Each instance may be referred to in code by an index number.

If you have int tickets[20], you have an 'array' of 20 integers. You can read and write from the first integer in the array with the expression tickets[0], the second with the expression tickets[1] and so on. The index itself may come from an expression. So if you have just a regular integer named idx and idx contains the number 3, then the expression tickets[idx] will refer to the fourth integer in tickets array. A more complex expression for the index such as tickets[idx + 2] would then refer to the sixth instance if idx were again the number 3.

Arrays are a bit more difficult than regular variables because you have to be mindful of when the array is full, that is every instance contains a value. If you refer to the 21st instance of an array that has only 20 instances, you will get a severe runtime error. Often times you must also be mindful of when the array in not completely full and some of the instances do not contain meaningful data. In the EA I initialize each instance of tickets to -1, and then check carefully for that number through out the code. If I see -1 I know my array wasn't totally full and some of the instances do not contain real ticket numbers.


There are three major functions in the EA:
AccquireTickets - This function gathers tickets and places some of them in the tickets array according to a filter. (just OP_BUY or OP_SELL, atm)
SortTicketsByOpen - This function leverages the power of arrays to sort the ticket numbers in the tickets array by their associated open time. It uses nested loops, another control-flow mechanism you should be come familiar with. It will fully scan the array, two instances at a time, looking for out of order tickets. If it finds them it swaps them in to the right order relative to each other but possibly not relative to the whole array. As long as it continues to find tickets out of order to each other it will continue to perform full scans of the array, two instances at a time. Eventually all the orders will fall into place relative to the whole array. Then the sorter will finish.
PrintTickets - The function simply dumps the ticket to the log so that you can see that they were sorted. Try remarking out the call to the sorter in the init() function to see that the orders come to the log in the wrong order when you don't use the sorter.

Ignored