exit on psar | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Neurus PSAR 1 hour system 71 replies

PSAR + AO + MACD 28 replies

trendchaser psar 268 replies

Neurus Psar Demark System- 5 Min 103 replies

Looking for a Multi-timeframe PSAR indicator 7 replies

Attachments: exit on psar
Exit Attachments

exit on psar

  • #1
  • First Post: Apr 5, 2008 7:56pm Apr 5, 2008 7:56pm
I am trying hard to write the code into my EA to exit on change in PSAR. I use something like this

if(OrderType()==OP_BUY)
{
if(iSAR(0,0,0.02,0.2,1)<Ask && iSAR(0,0,0.02,0.2,0)>Ask)
{
OrderClose(OrderTicket(),OrderLots(),Bid,3,Violet);
return(0);
}

It closes but upon a last candle before changing psar it does this ugly thing where it opens and closes numerous times (see image)

Could anybody write a simple example how to cleanly exit on a psar change?
Attached Image (click to enlarge)
Click to Enlarge Name: untitled.JPG Size: 321 KB
  • #2
  • Apr 5, 2008 8:38pm Apr 5, 2008 8:38pm
Quoting jasius
I am trying hard to write the code into my EA to exit on change in PSAR. I use something like this

if(OrderType()==OP_BUY)
{
if(iSAR(0,0,0.02,0.2,1)<Ask && iSAR(0,0,0.02,0.2,0)>Ask)
{
OrderClose(OrderTicket(),OrderLots(),Bid,3,Violet);
return(0);
}

It closes but upon a last candle before changing psar it does this ugly thing where it opens and closes numerous times (see image)

Could anybody write a simple example how to cleanly exit on a psar change?
before you make a trade, verify that you have 0 open trades on current timeframe and pair.
Request custom Expert Advisor or Indicator: dostapyuk "at" gmail . com
  • #3
  • Apr 5, 2008 9:30pm Apr 5, 2008 9:30pm
Quoting Oksana17
before you make a trade, verify that you have 0 open trades on current timeframe and pair.
I did

if(OrdersTotal()<1)
{order open conditions

...then...

total=OrdersTotal();
for(cnt=0;cnt<total;cnt++)
{
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
if(OrderType()<=OP_SELL &&
OrderSymbol()==Symbol())
{
if(OrderType()==OP_BUY)
{
if(iSAR(0,0,0.02,0.2,1)<Ask && iSAR(0,0,0.02,0.2,0)>Ask)
{
OrderClose(OrderTicket(),OrderLots(),Bid,3,Violet);
return(0);
}
  • #4
  • Apr 5, 2008 9:51pm Apr 5, 2008 9:51pm
Quoting jasius
I did

if(OrdersTotal()<1)
{order open conditions

...then...

total=OrdersTotal();
for(cnt=0;cnt<total;cnt++)
{
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
if(OrderType()<=OP_SELL &&
OrderSymbol()==Symbol())
{
if(OrderType()==OP_BUY)
{
if(iSAR(0,0,0.02,0.2,1)<Ask && iSAR(0,0,0.02,0.2,0)>Ask)
{
OrderClose(OrderTicket(),OrderLots(),Bid,3,Violet);
return(0);
}
Bite the bullet, you want help..open your code. Thats the price for asking people to help you. Otherwise do it yourself.
  • #5
  • Edited Apr 6, 2008 4:58pm Apr 5, 2008 10:35pm | Edited Apr 6, 2008 4:58pm
I am attaching mq4
Attached File(s)
File Type: mq4 QQE_EA.mq4   4 KB | 692 downloads
  • #6
  • Apr 6, 2008 2:38am Apr 6, 2008 2:38am
Rather than post the code directly into your reply, just attach the .mq4 file so people can quickly open it in their own editor to look at. When you copy and paste it here, it does some funny stuff with the spacing and makes it hard to look at.
  • #7
  • Apr 6, 2008 2:46am Apr 6, 2008 2:46am
instead of looking at candle 0 and 1 look at candle 1 and 2. What is happening is on the last candle just as it is getting ready to close, the psar is bouncing from below to above the candle. As it does your logic is telling it to open close open close etc. By looking at candle 1 and 2 you will be waiting for the close of the candle to close the order.
  • #8
  • Apr 6, 2008 7:27am Apr 6, 2008 7:27am
With all due respect to magnum, I think the problem is not about the psar jumping up and down on candle 0, and changing to candle 2 and 1 will solve the problem. Here is the scenario.. the entry is mainly controlled by QQE indi ( idont know the fastQQE why it is there) and the exit is controlled by psar. Both entry and exit logic occur simultaneously, it should not for the EA to work. This problem cannot be solve by one line of code or candle designation change, it is about entry and exit logic. The logic either on entry or exit must be revise. IMHO.
  • #9
  • Apr 6, 2008 9:27am Apr 6, 2008 9:27am
Quoting magnumfreak
instead of looking at candle 0 and 1 look at candle 1 and 2. What is happening is on the last candle just as it is getting ready to close, the psar is bouncing from below to above the candle. As it does your logic is telling it to open close open close etc. By looking at candle 1 and 2 you will be waiting for the close of the candle to close the order.

thanks, but unfortunately didn't work. To answer the other comment, cross QQE and change in PSAR are separated by several candles so shouldn't interfere with each other

To confuse things even more, this happens only once in a while (see attached)
Attached Image (click to enlarge)
Click to Enlarge Name: untitled.JPG Size: 328 KB
  • #10
  • Apr 6, 2008 9:34am Apr 6, 2008 9:34am
I only briefly looked at the code, but I have found generally that ythe exit logic works best if it is coded before the entry logic. I wonder if you are getting unexpected results, because you are testing open orders at the wrong time, thus closing the trade and then imeadiatley opening it back up.
  • #11
  • Apr 6, 2008 9:47am Apr 6, 2008 9:47am
It also for some reasons misses some exits and exits on the second change in psar
  • #12
  • Apr 6, 2008 9:54am Apr 6, 2008 9:54am
I have never coded Psar this way.
iSAR(0,0,0.02,0.2,0)

I have always followed Metatrader's way and listed it as
iSAR(NULL,0,0.02,0.2,0) or
iSAR(Symbol(),0,0.02,0.2,0)

I am not sure if it makes any difference, but I do know that NULL means current currency. I do not know what a 0 in this field meansas this field is expecting a string variable, not a int.

If you place your curser on any part of your code and press F1, the compile area will show you the format for that bit of code, and examples of how to use it.
Attached Image (click to enlarge)
Click to Enlarge Name: ScreenHunter_002.jpg Size: 91 KB
  • #13
  • Apr 6, 2008 1:53pm Apr 6, 2008 1:53pm
double fastQQE1 = iCustom(NULL,0,"QQEA",fastQQEparm,14,4.236,0,1); IndicatorBuffer 0
double fastQQE2 = iCustom(NULL,0,"QQEA",fastQQEparm,14,4.236,1,1); Indicator Buffer1
double slowQQE1 = iCustom(NULL,0,"QQEA",slowQQEparm,14,4.236,0,1); IndicatorBuffer 0
double slowQQE2 = iCustom(NULL,0,"QQEA",slowQQEparm,14,4.236,1,1); IndicatorBuffer1


if(slowQQE1 > slowQQE2)
{
OrderSend(Symbol(),OP_BUY…

if(slowQQE1 < slowQQE2)
{
OrderSend(Symbol(),OP_SELL …….

There is a conflict on the above logic.. I think they should be interchange. What is the purpose of the fastQQE1 & 2. If you can post the QQEA indicator so i can determine which one is using a particular indicator buffer, it can help in the debugging. I think I can fix this..
  • #14
  • Apr 6, 2008 3:24pm Apr 6, 2008 3:24pm
Quoting trader101
double fastQQE1 = iCustom(NULL,0,"QQEA",fastQQEparm,14,4.236,0,1); IndicatorBuffer 0
double fastQQE2 = iCustom(NULL,0,"QQEA",fastQQEparm,14,4.236,1,1); Indicator Buffer1
double slowQQE1 = iCustom(NULL,0,"QQEA",slowQQEparm,14,4.236,0,1); IndicatorBuffer 0
double slowQQE2 = iCustom(NULL,0,"QQEA",slowQQEparm,14,4.236,1,1); IndicatorBuffer1


if(slowQQE1 > slowQQE2)
{
OrderSend(Symbol(),OP_BUY…

if(slowQQE1 < slowQQE2)
{
OrderSend(Symbol(),OP_SELL …….

There is a conflict on the above logic.. I think they should be interchange. What is the purpose of the fastQQE1 & 2. If you can post the QQEA indicator so i can determine which one is using a particular indicator buffer, it can help in the debugging. I think I can fix this..

With pleasure. Now I am using only slowQQE. I'll be using a combination of those in the future if I'll figure out psar exit. QQE is attached
Attached File(s)
File Type: mq4 QQEA.mq4   3 KB | 538 downloads
  • #15
  • Apr 6, 2008 4:30pm Apr 6, 2008 4:30pm
Do you want your entry after the cross of QQE lines or just simply when the red is higher or dotted line lower on candle 1????
  • #16
  • Apr 6, 2008 4:51pm Apr 6, 2008 4:51pm
Here it is try this. I have modified your EA and do the crossing of the 2 QQE lines as the logic for entry. I also made a slight modification to your QQE indicator to suit the EA. Tell me if this is what you want. Check the calculation. And please retract that "useless comments" comments.
Attached File(s)
File Type: mq4 QQE_EA[1].mq4   4 KB | 753 downloads
File Type: mq4 QQEA.mq4   3 KB | 747 downloads
  • #17
  • Apr 6, 2008 4:57pm Apr 6, 2008 4:57pm
Quoting trader101
Do you want your entry after the cross of QQE lines or just simply when the red is higher or dotted line lower on candle 1????
Cross!!! That might be a problem when I look back, that's why it always re-enters after taking profit or loss and I don't want thst... Thanks for thinking for me
  • #18
  • Apr 6, 2008 4:59pm Apr 6, 2008 4:59pm
Quoting trader101
Here it is try this. I have modified your EA and do the crossing of the 2 QQE lines as the logic for entry. I also made a slight modification to your QQE indicator to suit the EA. Tell me if this is what you want. Check the calculation. And please retract that "useless comments" comments.
Most useful. Appreciate it. However exit on psar still doesn't work
  • #19
  • Apr 6, 2008 5:42pm Apr 6, 2008 5:42pm
Make some revision on the Isar..Hope this work now. TRy it/
Attached File(s)
File Type: mq4 QQE_EA[2].mq4   4 KB | 729 downloads
  • #20
  • Apr 6, 2008 6:28pm Apr 6, 2008 6:28pm
Quoting trader101
With all due respect to magnum, I think the problem is not about the psar jumping up and down on candle 0, and changing to candle 2 and 1 will solve the problem. Here is the scenario.. the entry is mainly controlled by QQE indi ( idont know the fastQQE why it is there) and the exit is controlled by psar. Both entry and exit logic occur simultaneously, it should not for the EA to work. This problem cannot be solve by one line of code or candle designation change, it is about entry and exit logic. The logic either on entry or exit must be revise. IMHO.
CRAP! That's what I get for trying to look at code at 4 am. LOL!
0 traders viewing now