Coding something backwards | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

I Will Learn Coding in 1 Month - Give me the 80/20 of MT4 Coding 14 replies

The Backwards System 96 replies

Anyone find it funny that Risk/Reward ratio's are said backwards? 9 replies

backwards shifted ma on present candle?? 0 replies

Forward or Backwards ? That is the question 3 replies

Coding something backwards

  • #1
  • First Post: Feb 28, 2008 3:13pm Feb 28, 2008 3:13pm
Greetings,

I am working on code for a new EA which means I'm doing a lot of "cut & paste". Apparently I'm not able to tell up from down.

The Code is intended to place a trade either Long or Short. Upon testing last night 4 of 4 positions entered Short even though 1 of them should have been Long. So, I'm trying to correct this direction.

Parts of the code are below
--------------------------------------------------------------------------

double SAR0 = iSAR(Window, 0, 0.02, 0.2, 0); // current period

// check condition to open trade
int TradeDirection=0;
if(Point>SAR0) TradeDirection=1; // long
if(Point<SAR0) TradeDirection=-1; // short

// check if trade should be opened
if (TradeDirection==1 && !OrderFind(magicno)) OrderSend(Symbol(), OP_BUY, Lots, Ask, 3, NormalizeDouble(Bid - StopLoss*Point, Digits),
NormalizeDouble(Ask + TakeProfit*Point, Digits), "LONG", magicno, 0, CLR_NONE);
if (TradeDirection==-1 && !OrderFind(magicno)) OrderSend(Symbol(), OP_SELL, Lots, Bid, 3, NormalizeDouble(Ask + StopLoss*Point, Digits),
NormalizeDouble(Bid - TakeProfit*Point, Digits), "SHORT", magicno, 0, CLR_NONE);

--------------------------------------------------------------------------

Perhaps the problem is my attempt to identify the "price point" ... ?

Would appreciate any comments.

Thanks,

Pip Parade
  • #2
  • Feb 28, 2008 3:17pm Feb 28, 2008 3:17pm
Quoting Pip Parade
Greetings,

I am working on code for a new EA which means I'm doing a lot of "cut & paste". Apparently I'm not able to tell up from down.

The Code is intended to place a trade either Long or Short. Upon testing last night 4 of 4 positions entered Short even though 1 of them should have been Long. So, I'm trying to correct this direction.

Parts of the code are below
--------------------------------------------------------------------------

double SAR0 = iSAR(Window, 0, 0.02, 0.2, 0); // current period

// check condition to open trade
int TradeDirection=0;
if(Point>SAR0) TradeDirection=1; // long
if(Point<SAR0) TradeDirection=-1; // short

// check if trade should be opened
if (TradeDirection==1 && !OrderFind(magicno)) OrderSend(Symbol(), OP_BUY, Lots, Ask, 3, NormalizeDouble(Bid - StopLoss*Point, Digits),
NormalizeDouble(Ask + TakeProfit*Point, Digits), "LONG", magicno, 0, CLR_NONE);
if (TradeDirection==-1 && !OrderFind(magicno)) OrderSend(Symbol(), OP_SELL, Lots, Bid, 3, NormalizeDouble(Ask + StopLoss*Point, Digits),
NormalizeDouble(Bid - TakeProfit*Point, Digits), "SHORT", magicno, 0, CLR_NONE);

--------------------------------------------------------------------------

Perhaps the problem is my attempt to identify the "price point" ... ?

Would appreciate any comments.

Thanks,

Pip Parade


Possible :

if(Bid>SAR0) TradeDirection=1; // long
if(Bid<SAR0) TradeDirection=-1; // short


and also

double SAR0 = iSAR(Null, 0, 0.02, 0.2, 0); // current period
?
  • #3
  • Feb 28, 2008 3:22pm Feb 28, 2008 3:22pm
Tunera,

You may have something with the Bid instead of Point. Thank you ... Will look into that. Maybe Bid one way and Ask the other.

RE: the Null vs Window, as I understand, Null is the standard. What I've done with Window is tried to lock to a particular (preset) time frame window so that it doesn't change on me when reviewing progress in other windows.

Thanks much ... hope others kick in also.

PP


Quoting tunera
Possible :

if(Bid>SAR0) TradeDirection=1; // long
if(Bid<SAR0) TradeDirection=-1; // short


and also

double SAR0 = iSAR(Null, 0, 0.02, 0.2, 0); // current period
?
  • #4
  • Feb 28, 2008 4:27pm Feb 28, 2008 4:27pm
Quoting Pip Parade
Tunera,

You may have something with the Bid instead of Point. Thank you ... Will look into that. Maybe Bid one way and Ask the other.

RE: the Null vs Window, as I understand, Null is the standard. What I've done with Window is tried to lock to a particular (preset) time frame window so that it doesn't change on me when reviewing progress in other windows.

Thanks much ... hope others kick in also.

PP
Well, sure, "Point" is just a value like 0,0001 (for eurusd for example) or 0,01 (for usd-jpy for example), so surely your EA short only because Sar is always > then Point, putting Bid it should work correctly. U can put also Ask, but it will result in a bad working, because the Sar are calculated on the close_price (Bid price!), so if u put Ask instead of Bid it will give a lot of false signals surely giving you more losses then it should give.
About the Window, i never used it, i always use Null (it refer to the window where the EA is attached, so no problem you can also open other windows and the EA will continue to work correctly), the timeframe is just the "0" after the "Null,"

hope to helped you
  • #5
  • Last Post: Feb 28, 2008 5:11pm Feb 28, 2008 5:11pm
Nice work Tunera, Running a multiple/random test and the entries are all correct. Will be sure to hit the Bid/Bid instead of Bid/Ask. Glad I hit the board today ... always learning something new, Including a revisit of Window vs Null ... .

Now the fun really begins ... forward monitor the rest of it and see what pops up next. Hooray for demos and teeny tiny mini's.

PP
0 traders viewing now