Reduce Lot level following 2 consecutive losses?

Hello,

I created an EA using the "expert advisor builder" that's available on the web and then made some modifications to it for fine tuning which worked great. I have some programming experience from a distant past.

I am now stuck however as I try to program into the EA to cut my Lot level in half following 2 consecutive losses and then returning to the original Lot level following 2 consecutive wins.

This is what I have been trying to use:

If Buy or Sell signal is generated then

If OrderProfit() < 0 then
Losses = Losses + 1
Wins = 0

If Order Profit() > 0 then
Wins = Wins + 1
Losses = 0

If (Losses == 2) then reduce Lot Level by 50%
If (Wins == 2) then return Lot Level to prior manual amount


No errors generate when I compile but the Losses and Wins values don't increase? It seems as though the Losses and Wins values are not being stored properly or something as each time the EA returns to this code it should be increasing the value of Losses or Wins by 1?

Any input, ideas, or suggestions of better ways you would code this would be greatly appreciated. I'm posting the EA so you can see it. (Notice however that for testing purposes I have modified my code to give me a no trade signal when Losses = 2 or Wins = 2).

Thanks in Advance,

Scott Nelson

I think this is missing brackets

if (Order == SIGNAL_BUY || Order == SIGNAL_SELL)
{
if (OrderProfit() < 0)
Losses = Losses + 1;
Wins = 0;
if (OrderProfit() > 0)
Wins = Wins + 1;
Losses = 0;
if (Losses == 2 || Wins == 2)
Order = SIGNAL_NONE;
}


Should be

if (Order == SIGNAL_BUY || Order == SIGNAL_SELL)
{
if (OrderProfit() < 0)
{
Losses = Losses + 1;
Wins = 0;
}
if (OrderProfit() > 0)
{
Wins = Wins + 1;
Losses = 0;
}
if (Losses == 2 || Wins == 2)
{
Order = SIGNAL_NONE;
}
}


Put the missing brackets in for each IF statement. Otherwise you are just saying Losses = 0 every time the EA runs no matter what. Without the brackets its ignoring the conditions for it to be true. Does that make sense. Simple typo. I think that's probably the problem.

Actually go through your EA and make sure every if statement has an opening and closing bracket {}

I tried putting in the brackets and was able to get the losses and wins to in increase in value but there are some other coding problems as it's not working the way it is supposed to.

For instance, the conditions to be met for this code to be accessed have to be set and as I understand it those conditions are:

1) The are no open trades currently.
2) There is a current buy or sell signal

Any ideas?

Thanks,

Scott

check under the experts tab in the terminal window to see if there are any error messages being generated. If they are, post them here please.

Just thought of something. Since there is no incoming data, the ea won't work. Wait for the markets to open tomorrow night and see if it works.