Attachments: Little code help from the experts :)

Little code help from the experts :)

#1
First Post: Feb 1, 2008 7:57am Feb 1, 2008 7:57am

matrixebiz
| Joined Nov 2006 | Status: Trader | 1,143 Posts

Hi, I'm trying to code

but have a question. I've made this simple EA based on reading indicators and seems to work but not totally the way I want and I'm sure it's something simple

What I have is my EA calling signals from two indicators (VQ and QQEA)and trade when they agree to buy or sell together. The problem is that I only want the EA to initiate a trade when they signal at the exact same time but what is happening is that it's trading anytime when they agree. You'll see by the pic the EA is trading as both indicators are in a downward direction every tick

I only want it to trade when they first signal not every bar

Here is my code. hope it's a simple fix

Inserted Code

double VQ0 = iCustom(NULL, 0, "VQ", false,0,5,3,1,5,true,false,true,true,false,true,1485, 0,0);
double VQ1 = iCustom(NULL, 0, "VQ", false,0,5,3,1,5,true,false,true,true,false,true,1485, 0,1);
double QQEA0 = iCustom(NULL, 0, "QQEA",5,14,4.236, 0, 0);
double QQEA1 = iCustom(NULL, 0, "QQEA",5,14,4.236, 0, 1);

Inserted Code

//Buy
   if (VQ0>VQ1 && QQEA0>QQEA1 && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
      if(!IsTrade) {

Attached Image (click to enlarge)

Click to Enlarge

Name: NewEA.JPG
Size: 177 KB

24 hours in a day – 24 bottles of beer in a case – Coincidence? I think not

#2
Feb 1, 2008 8:17am Feb 1, 2008 8:17am

GirlFlyer
Joined Aug 2006 | Status: Trader | 485 Posts

You need to have the EA set a flag or something that once it has placed an order it doesn't order again until the position is closed.

Not a hard fix.

GF

#3
Feb 1, 2008 8:24am Feb 1, 2008 8:24am

matrixebiz
| Joined Nov 2006 | Status: Trader | 1,143 Posts

It doesn't place two orders, it just places the order anytime it wants, not ONLY when the indicators first signal like I want it to.

I would like it to only place the order when QQEA and VQ first signals a buy on the same bar not later when they still agree on direction.

Thank you

24 hours in a day – 24 bottles of beer in a case – Coincidence? I think not

#4
Feb 1, 2008 8:44am Feb 1, 2008 8:44am

blueruby
Joined Feb 2007 | Status: Stock Broker, October 1987 | 1,281 Posts

I don't fully understand how your indicators work, let's just assume they each give a "buy" or "sell" signal.

Put in an "if" statement such that:

if ((VQ0 = buy && VQ1 != buy) && (QQEA0 = buy && QQEA1 != buy)) buycondition = true;

this will only set buycondition to true if both have changed from notbuy to buy on the current candle.

If you want to take it only on closed candles, then use 1 and 2 instead of 0 and 1.

capiche?

Edit: whoops, I didn't read your whole post.

How about

//Buy
if ((VQ0>VQ1 && VQ1 < VQ2) && (QQEA0>QQEA1 && QQEA1 < QQEA2) && ...

#5
Feb 1, 2008 8:56am Feb 1, 2008 8:56am

matrixebiz
| Joined Nov 2006 | Status: Trader | 1,143 Posts

Quoting blueruby

Disliked

I don't fully understand how your indicators work, let's just assume they each give a "buy" or "sell" signal.

Put in an "if" statement such that:

if ((VQ0 = buy && VQ1 != buy) && (QQEA0 = buy && QQEA1 != buy)) buycondition = true;

this will only set buycondition to true if both have changed from notbuy to buy on the current candle.

If you want to take it only on closed candles, then use 1 and 2 instead of 0 and 1.

capiche?

Edit: whoops, I didn't read your whole post.

How about

//Buy
if ((VQ0>VQ1 && VQ1 < VQ2) && (QQEA0>QQEA1 && QQEA1 < QQEA2) && ...

Ignored

Ok thanks, here is a pic. The Green vertical shows EA traded correctly when QQEA crossed to Buy and at the same the VQ signaled Buy, good

But if you look at the Red vertical, EA traded when indicators continue agreeing to Sell but I only want it to trade when they both agree at the same time ONLY.
Thanks

Attached Image (click to enlarge)

Click to Enlarge

Name: two indis.JPG
Size: 175 KB

24 hours in a day – 24 bottles of beer in a case – Coincidence? I think not

#6
Feb 1, 2008 12:06pm Feb 1, 2008 12:06pm

matrixebiz
| Joined Nov 2006 | Status: Trader | 1,143 Posts

Ok, why did this trade happen? (Red line)
Here is the EA

Attached Image (click to enlarge)

Click to Enlarge

Name: what.JPG
Size: 178 KB

Attached File(s)

My First EA MOD 2indi.mq4 9 KB | 1,087 downloads

24 hours in a day – 24 bottles of beer in a case – Coincidence? I think not

#7
Feb 1, 2008 1:21pm Feb 1, 2008 1:21pm

achandrasek
| Joined Feb 2006 | Status: Trader | 476 Posts

Quoting matrixebiz

Disliked

Ok thanks, here is a pic. The Green vertical shows EA traded correctly when QQEA crossed to Buy and at the same the VQ signaled Buy, good
But if you look at the Red vertical, EA traded when indicators continue agreeing to Sell but I only want it to trade when they both agree at the same time ONLY.
Thanks

Ignored

I hope you made similar condition statement for Sell/Short also.

#8
Feb 1, 2008 1:34pm Feb 1, 2008 1:34pm

matrixebiz
| Joined Nov 2006 | Status: Trader | 1,143 Posts

Yes

24 hours in a day – 24 bottles of beer in a case – Coincidence? I think not

#9
Feb 1, 2008 3:38pm Feb 1, 2008 3:38pm

achandrasek
| Joined Feb 2006 | Status: Trader | 476 Posts

Quoting matrixebiz

Disliked

Ok thanks, here is a pic. The Green vertical shows EA traded correctly when QQEA crossed to Buy and at the same the VQ signaled Buy, good
But if you look at the Red vertical, EA traded when indicators continue agreeing to Sell but I only want it to trade when they both agree at the same time ONLY.
Thanks

Ignored

HI,

I think you have not changed the code using BlueRuby's suggestion.
The suggested line is as shown below:
if ((VQ0>VQ1 && VQ1 < VQ2) && (QQEA0>QQEA1 && QQEA1 < QQEA2) && ...

But you are still using:
if (VQ0>VQ1 && QQEA0>QQEA1 && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount))))

Sell also has the same problem.

Use the following code for BUY:

PHP Code

 if ((VQ0>VQ1 && VQ1 < VQ2) && (QQEA0>QQEA1 && QQEA1 < QQEA2) && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) // for BUY

Use the following code for SELL:

PHP Code

 if ((VQ0<VQ1 && VQ1 > VQ2) && (QQEA0<QQEA1 && QQEA1 > QQEA2) && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) // for Short

I did not check the rest of the code and hope it is ok. I think this should fix the problem.

Regards,
chandra

#10
Edited 2:26am Feb 2, 2008 2:10am | Edited 2:26am

matrixebiz
| Joined Nov 2006 | Status: Trader | 1,143 Posts

Quoting achandrasekaran99

PHP Code

 if ((VQ0>VQ1 && VQ1 < VQ2) && (QQEA0>QQEA1 && QQEA1 < QQEA2) && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) // for BUY

Use the following code for SELL:

PHP Code

 if ((VQ0<VQ1 && VQ1 > VQ2) && (QQEA0<QQEA1 && QQEA1 > QQEA2) && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) // for Short

I did not check the rest of the code and hope it is ok. I think this should fix the problem.

Regards,
chandra

Your right I didn't make the change, woops, but I'm not using a VQ2 ?? That's why I didn't make the change. Where did the VQ2 come from?

and this comment;
" If you want to take it only on closed candles, then use 1 and 2 instead of 0 and 1"
this is the shift value on the iCustom line, correct? what does 0 and 1 do, current candle? if I would like the trade to wait until the candle closes and initiate trade on next candle use 1 and 2?

Thanks BlueRuby and chandra

BTW, this is the indicator part that I'm going to add two more. Format is correct?

Inserted Code

double VQ0 = iCustom(NULL, 0, "VQ", false,0,5,3,1,5,true,false,true,true,false,true,1485, 0,0);
double VQ1 = iCustom(NULL, 0, "VQ", false,0,5,3,1,5,true,false,true,true,false,true,1485, 0,1);
double QQEA0 = iCustom(NULL, 0, "QQEA",5,14,4.236, 0, 0);
double QQEA1 = iCustom(NULL, 0, "QQEA",5,14,4.236, 0, 1);

24 hours in a day – 24 bottles of beer in a case – Coincidence? I think not

#11
Feb 2, 2008 5:37am Feb 2, 2008 5:37am

blueruby
Joined Feb 2007 | Status: Stock Broker, October 1987 | 1,281 Posts

Quoting matrixebiz

Disliked

. Where did the VQ2 come from?

and this comment;
" If you want to take it only on closed candles, then use 1 and 2 instead of 0 and 1"
this is the shift value on the iCustom line, correct? what does 0 and 1 do, current candle? if I would like the trade to wait until the candle closes and initiate trade on next candle use 1 and 2?

Ignored

Dude, you need to learn to progarm, this is basic stuff. Or forget it and just learn to trade.

You have to add the VQ2, it would be calculated on the candle before VQ1

double VQ0 = iCustom(NULL, 0, "VQ", false,0,5,3,1,5,true,false,true,true,false,true,1485, 0,0);
double VQ1 = iCustom(NULL, 0, "VQ", false,0,5,3,1,5,true,false,true,true,false,true,1485, 0,1);
double VQ2 = iCustom(NULL, 0, "VQ", false,0,5,3,1,5,true,false,true,true,false,true,1485, 0,2);

double QQEA0 = iCustom(NULL, 0, "QQEA",5,14,4.236, 0, 0);
double QQEA1 = iCustom(NULL, 0, "QQEA",5,14,4.236, 0, 1);
double QQEA2 = iCustom(NULL, 0, "QQEA",5,14,4.236, 0, 2);

Yes, it is 2 candles back from the current one.

#12
Edited 9:48am Feb 2, 2008 8:35am | Edited 9:48am

matrixebiz
| Joined Nov 2006 | Status: Trader | 1,143 Posts

Quoting blueruby

Disliked

Dude, you need to learn to progarm, this is basic stuff. Or forget it and just learn to trade.

You have to add the VQ2, it would be calculated on the candle before VQ1

double VQ0 = iCustom(NULL, 0, "VQ", false,0,5,3,1,5,true,false,true,true,false,true,1485, 0,0);
double VQ1 = iCustom(NULL, 0, "VQ", false,0,5,3,1,5,true,false,true,true,false,true,1485, 0,1);
double VQ2 = iCustom(NULL, 0, "VQ", false,0,5,3,1,5,true,false,true,true,false,true,1485, 0,2);

double QQEA0 = iCustom(NULL, 0, "QQEA",5,14,4.236, 0, 0);
double QQEA1 = iCustom(NULL, 0, "QQEA",5,14,4.236, 0, 1);
double QQEA2 = iCustom(NULL, 0, "QQEA",5,14,4.236, 0, 2);

Yes, it is 2 candles back from the current one.

Ignored

Ok, thank you for your help. So I should use a shift of 1 for everyone so it checks for a Buy or Sell on previous candle, correct? Maybe you could just explain a little why the two or three same indicator values and why shift is different? That would explain alot. Thank you
double QQEA1 = iCustom(NULL, 0, "QQEA",5,14,4.236, 0, 1);
double QQEA2 = iCustom(NULL, 0, "QQEA",5,14,4.236, 0, 2);

24 hours in a day – 24 bottles of beer in a case – Coincidence? I think not

#13
Feb 3, 2008 9:30pm Feb 3, 2008 9:30pm

trendchaser
| Membership Revoked | Joined Oct 2007 | 2,124 Posts

both lines are the same indy, same values

the numbers 1 & 2 at the end are bars back
0= current bar
1= previouse bar
2= two bars back

if youd like to trade at the cross
you can check if the previouse bar was crossed

if prev bar crossed, and current crossed= no trade

if previouse not crossed, current crossed= trade

this will prevent you from entering in the middle of a trade

heres a example

double qq1 = iCustom(NULL, 0, "QQEA", SF,RSI_Period,DARFACTOR,0, 0);
double qq2 = iCustom(NULL, 0, "QQEA", SF,RSI_Period,DARFACTOR,1, 0);
double qq3 = iCustom(NULL, 0, "QQEA", SF,RSI_Period,DARFACTOR,0, 1);
double qq4 = iCustom(NULL, 0, "QQEA", SF,RSI_Period,DARFACTOR,1, 1);

if (qq1 > qq2 && qq3 < qq4 ) Order = SIGNAL_BUY;

-------------------------------------------------------

also the number second to last identifies the line since theres 2
0= the main line
1= the signal line

also qqea lokks to the open, that why u had that trade a few posts back

qqea crossed, trade opened
then uncrossed

i edited qqea to look at open
because sometimes cross is same as close

or u could look not at current bar, but that delays entry more then looking at open

hope this info helps

Quoting matrixebiz

Disliked

Ok, thank you for your help. So I should use a shift of 1 for everyone so it checks for a Buy or Sell on previous candle, correct? Maybe you could just explain a little why the two or three same indicator values and why shift is different? That would explain alot. Thank you
double QQEA1 = iCustom(NULL, 0, "QQEA",5,14,4.236, 0, 1);
double QQEA2 = iCustom(NULL, 0, "QQEA",5,14,4.236, 0, 2);

Ignored

#14
Edited 9:47pm Feb 3, 2008 9:35pm | Edited 9:47pm

trendchaser
| Membership Revoked | Joined Oct 2007 | 2,124 Posts

if u use 0 for the signal line on all qqea's

youd trade if qq now is higher than previouse
i use that teqnique if i trade the slope of the line but ignore the cross

without using both 0 and 1 your not even trading the cross

double iCustom( string symbol, int timeframe, string name, other Parameters..., int mode, int shift)

so what all this means

double iCustom( GBPJPYm, 0, indicator name, other Parameters, 0, 0)

for symbol NULL means current from the chart

timeframe 0=current from the chart

m1=1
m5=5 ect...ect

not all indies have 2 lines, some 7eral, heres rsi for example

double iRSI( string symbol, int timeframe, int period, int applied_price, int shift)

#15
Aug 29, 2021 12:06pm Aug 29, 2021 12:06pm

Zami84
| Joined Mar 2021 | Status: Trader | 6 Posts

Hi there.
Im new and i cant start new thread so i will post here. Maybe some admin will movie it.
I try to code a three line strike and i need some help
For now i have something like that:

Inserted Code

StrikeS = ((MathAbs(Close[1]-Open[1]) > MathAbs(Close[2]-Open[2]) *0.8) && (MathAbs(Close[2]-Open[2]) > MathAbs(Close[3]-Open[3]*0.8)) && (MathAbs(Open[0]-Close[0]) > (MathAbs(Close[1]-Open[3]*0.5))));
StrikeB = ((MathAbs(Open[1]-Close[1]) > MathAbs(Open[2]-Close[2]) *0.8) && (MathAbs(Open[2]-Close[2]) > (MathAbs(Open[3]-Close[3]*0.8))) && (MathAbs(Close[0]-Open[0]) > (MathAbs(Open[1]-Close[3]*0.5))));

Yes, i know, i dont have idea what im doing, but im trying.
I try to get:
candle 1 bigger than 80% of candle 2, candle 2 bigger than 80% of candle 3, candle0 bigger than 80% of candle 3 to candle 1 move for StrikeS

#16
Aug 30, 2021 10:09pm Aug 30, 2021 10:09pm

RedLineFred
Joined Sep 2012 | Status: Trader | 327 Posts

There are a few problems with your code:

1. your brackets are not in the correct places and should look more like this:

StrikeS =

(

MathAbs(Close[1]-Open[1]) > MathAbs(Close[2]-Open[2]) *0.8

)

(

MathAbs(Close[2]-Open[2]) > MathAbs(Close[3]-Open[3] *0.8

)

(

MathAbs(Open[0]-Close[0]) > MathAbs(Close[1]-Open[3] *0.5

)

;

2. Because you are using MathAbs

MathAbs(Open[1]-Close[1]) is equal to MathAbs(Close[1]-Open[1]) which means (once the code is corrected) StrikeS = StrikeB, which i assume is not what youwere looking for.

3. Candle0 is still forming and so MathAbs(Open[0]-Close[0]) will keep changing until it becomes Candle1 - not sure that this is what you are loooking for.

4. Your last condition candle 3 to candle 1 move, will be best represented by Close[3] - Open [1] and not the reverse as you have it.

5. One other point to consider - are you better off looking for High - Low rather than Open - Close.

best of luck
Fred

" check out The Traders Outpost "

#17
Aug 31, 2021 11:31am Aug 31, 2021 11:31am

Zami84
| Joined Mar 2021 | Status: Trader | 6 Posts

Quoting RedLineFred

Disliked

There are a few problems with your code:

Ignored

Thank you for answer. I will try to improve my code.
Anyway, there is a "picture" of patter that i want to code (three line strike + engulfing candle).

Attached Image

I have problem with MA angle, but im working on solution (external indicator).

#18
Last Post: Oct 23, 2021 5:17am Oct 23, 2021 5:17am

ntk
Joined Dec 2018 | Status: Trader | 1,271 Posts

Quoting Zami84

Disliked

{quote} Thank you for answer. I will try to improve my code. Anyway, there is a "picture" of patter that i want to code (three line strike + engulfing candle). {image} I have problem with MA angle, but im working on solution (external indicator).

Ignored

say it from beginning it would be easier or right people forming idea to help you

Platform Tech
/
Little code help from the experts :)
Reply to Thread

0 traders viewing now

Options

Similar Threads

Little code help from the experts :)