X50 - M5 trend following

Quoting fxaus

Disliked

trading room is very good idea
but i couldn,t find the room
thx, good luck

Ignored

Quoting nealc99

Disliked

Another sucessful EA trade:

2008.01.25 21:20 buy gbpjpy 211.65 211.77 = +12pips

Maybe starting Tuesday I'll have to list the previous days EA trades so we can keep track of things.

So far that's 4 out of 5 winners for a total of +108 pips for the past 24 hours!

Perhaps filtering out the slow periods (non London/New York sessions) will weed out the less likley to succeed trades.

Neal

Ignored

Quoting rydnek

Disliked

Neal, I made a couple of corrections. I used "Orders Total() <1" on Line 45 and changed your code on Line 47 col 69 to show MAIN rather than SIGNAL (which may not be what you intended).
I could not get the EA to run without the first correction.
Charles

Ignored

double asbull=iCustom(NULL, 5, "AbsoluteStrength_v1.1july 30..1", 0,10,5,5,0,3,0,0, false, 0,1);

Quoting nealc99

Disliked

Thanks DGC for catching those items.

1) It was the Absolute Strength that has some type of bug and NOT the Awesome Ocillator.
2) The FALSE should not have been there (but didn't help the backtesting problem)

ATTACHED: The most recient version 1.02 of the x50 EA (just minor bug fixes)

Ignored

Quoting Ronald Raygun

Disliked

When calling on an indicator which is not included as a standard indicator with metatrader, it needs to be placed in the "Indicators" folder. I had the same problem when I was coding my own version of an EA for canuckCT

Ignored

Quoting CanuckCT

Disliked

Why can you only forward test and not backtest...please explain. Thanks
Cheers
CanuckCT

Ignored

//+------------------------------------------------------------------+
//|                                                       x50 System |
//|                                   Copyright © 2008, Neal Chapman |
//|                                                [email protected] |
//+------------------------------------------------------------------+


//---- input parameters
extern int        MagicNumber = 3043231;
extern string     Remark2= "== Main Settings ==";
extern int        StopLoss=55;
extern int        Stop2BE=30;
extern int        TakeProfit=100;
extern int        TrailStop=20; 
extern string     Remark3= "== Money Management ==";
extern double     Lots=0.1;
extern bool       MoneyManagement=false;
extern int        Risk=3;  // percent of risk
int               Bought=0;


//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {

   //---- 
   int i,j,Ticket,Closed;
   double Vol;
   
  
      //Check to see if there is an order currently open
      int cnt, total = OrdersTotal();

      for(cnt=0;cnt<total;cnt++)
      {
         OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
         if(OrderMagicNumber() == MagicNumber)
            Bought++;
       }
   
     
      if (MoneyManagement==true) Lots = CalculateLots(Risk);
      if(OrdersTotal()<1){ //no order yet
         double mcad4hr=iCustom(NULL,5,"MACD_H4_300_v100",5,13,1,false,2,1);
         double stochbull=iStochastic(NULL,5,14,3,3,MODE_SMA,0,MODE_MAIN,1);
         double stochbear=iStochastic(NULL,5,5,3,3,MODE_SMA,0,MODE_MAIN,1);
         double asbull=iCustom(NULL, 5,"AbsoluteStrength_v1.1july 30..1",0,10,5,5,0,3,0,0,0,1);
         double asbear=iCustom(NULL, 5,"AbsoluteStrength_v1.1july 30..1",0,10,5,5,0,3,0,0,1,1);
         int sw=0;
         
         // logic for buy/sell

         if((stochbull > 55 && stochbear > 55) && stochbull > stochbear){
            if(mcad4hr > 2){
               if(asbull > asbear)
               {
                  sw=1;
               }
            }
         }
         
         if((stochbull < 45 && stochbear > 45)&& stochbear < stochbull){
            if(mcad4hr < 2){
               if(asbull < asbear)
               {
                  sw=-1;
               }
            }         
         }

         if(sw >= 1){
            Vol=Lots;
            Ticket=OrderSend(Symbol(),OP_BUY,Vol,Ask,3,Ask-StopLoss*Point,Ask+TakeProfit*Point,"x50 v1.0",MagicNumber,0,Green);
            Bought=1;
         }
         if(sw <= -1){ //sell order
            Vol=Lots;
            Ticket=OrderSend(Symbol(),OP_SELL,Vol,Bid,3,Bid+StopLoss*Point,Bid-TakeProfit*Point,"x50 v1.0",MagicNumber,0,Green);
            Bought=1;
         }
      }
   
   MoveStop2BE();
   trailingStopManager();

   return(0);
   }

void trailingStopManager() 
{
   
   if(TrailStop>0)
   {
      int cnt, total = OrdersTotal();

      for(cnt=0;cnt<total;cnt++)
      {
         OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);

         if (OrderType() == OP_BUY && OrderMagicNumber() == MagicNumber && OrderCloseTime()==0)
           {
             if ((Bid - OrderOpenPrice() >= Stop2BE * Point && OrderOpenPrice() == OrderStopLoss()) || (OrderStopLoss() >= OrderOpenPrice()))
               {
                 if (Bid - TrailStop * Point > OrderStopLoss())
                   {          
                     OrderModify(OrderTicket(),0,Bid - TrailStop * Point,0,0,CLR_NONE); 
                   }
               }
           }
         if (OrderType() == OP_SELL && OrderMagicNumber() == MagicNumber && OrderCloseTime()==0)
           {
             if ((OrderOpenPrice() - Ask >= Stop2BE * Point && OrderOpenPrice() == OrderStopLoss()) || (OrderStopLoss() <= OrderOpenPrice()))
               {
                 if (Ask + TrailStop * Point < OrderStopLoss() || OrderStopLoss() == 0)
                   {
                     OrderModify(OrderTicket(),0, Ask + TrailStop * Point,0,0,CLR_NONE); 
                   }
               }
           }
      }
   }
}

void MoveStop2BE()  // Moves stop to breakeven
{
   
   if(Stop2BE>0)
   {
      int cnt, total = OrdersTotal();

      for(cnt=0;cnt<total;cnt++)
      {
         OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);

         if (OrderType() == OP_BUY && OrderMagicNumber() == MagicNumber && OrderCloseTime()==0)
           {
             if (Bid - OrderOpenPrice() >= Stop2BE * Point && OrderStopLoss() < OrderOpenPrice())
               {
                 OrderModify(OrderTicket(),0,OrderOpenPrice(),OrderTakeProfit(),0,CLR_NONE);
               }
           }
   
         if (OrderType() == OP_SELL && OrderMagicNumber() == MagicNumber && OrderCloseTime()==0)  
           {
             if (OrderOpenPrice() - Ask >= Stop2BE * Point && OrderStopLoss() > OrderOpenPrice())
               {
                 OrderModify(OrderTicket(),0,OrderOpenPrice(),OrderTakeProfit(),0,CLR_NONE); 
               }          
           }
      }
   }
}

double CalculateLots(int Risk)
{
   if(MoneyManagement==false) return(Lots);
   double lot=Lots;
   int orders=HistoryTotal();
   int losses=0;
   int decimalPlaces=1;

   lot=NormalizeDouble((AccountFreeMargin()*Risk/1000.0)/100,decimalPlaces);

   if(lot<0.1) lot=0.1;
   if(lot>99) lot=99;
   return(lot);

}

Quoting Ronald Raygun

Disliked

I'm not sure why, but it works on my end. Is the indicator in the proper folder?

Ignored

#property copyright "Ben Kennedy, Programming by Jose Cabanero"


extern string Remark1 = "== Main Settings ==";
extern int MagicNumber = 0;
extern bool SignalMail = False;
extern bool EachTickMode = False;
extern double Lots = 0.1;
extern int Slippage = 5;
extern bool UseStopLoss = False;
extern int StopLoss = 30;
extern bool UseTakeProfit = True;
extern int TakeProfit = 30;
extern bool UseTrailingStop = False;
extern int TrailingStop = 30;
extern int TimeStoploss = 0.30;

extern string Remark2 = "== MACD Settings ==";
extern int FastEMA = 5;
extern int SlowEMA = 13;
extern int SignalMA = 1;
extern int MACDCross = 0;

extern string Remark3 = "== Stochastic Oscillator Settings ==";
extern int K_period1 = 5;
extern int D_period1 = 3;
extern int Slowing1 = 3;
extern int K_period2 = 14;
extern int D_period2 = 3;
extern int Slowing2 = 3;
extern int StochCross = 50;

extern string Remark4 = "== Absolute Strength Settings ==";
extern int Mode = 0;
extern int Length = 10;
extern int Smooth = 5;
extern int Signal = 5;
extern int Price = 0;
extern int ModeMA = 3;
extern double OverBought = 0.0;
extern double OverSold = 0.0;
extern double MinimumDistance = 0;


int BarCount;
int Current;
bool TickCheck = False;
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init() {
   BarCount = Bars;

   if (EachTickMode) Current = 0; else Current = 1;

   return(0);
}
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit() {
   return(0);
}
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start() 



{
   int Order = SIGNAL_NONE;
   int Total, Ticket;
   double StopLossLevel, TakeProfitLevel;



   if (EachTickMode && Bars != BarCount) TickCheck = False;
   Total = OrdersTotal();
   Order = SIGNAL_NONE;

   //+------------------------------------------------------------------+
   //| Variable Begin                                                   |
   //+------------------------------------------------------------------+

double Var1 = iCustom(NULL, 0, "AbsoluteStrength_v1.1july 30..1", Mode,Length,Smooth,Signal,Price,ModeMA,OverBought,OverSold, 0, Current + 0);
double Var2 = iCustom(NULL, 0, "AbsoluteStrength_v1.1july 30..1", Mode,Length,Smooth,Signal,Price,ModeMA,OverBought,OverSold, 1, Current + 0);
double Var3 = iCustom(NULL, 0, "AbsoluteStrength_v1.1july 30..1", Mode,Length,Smooth,Signal,Price,ModeMA,OverBought,OverSold, 2, Current + 0);
double Var4 = iCustom(NULL, 0, "AbsoluteStrength_v1.1july 30..1", Mode,Length,Smooth,Signal,Price,ModeMA,OverBought,OverSold, 3, Current + 0);
double Var5 = iOpen(NULL, PERIOD_M5, Current + 1);
double Var6 = iClose(NULL, PERIOD_M5, Current + 0);




   
   //+------------------------------------------------------------------+
   //| Variable End                                                     |
   //+------------------------------------------------------------------+

   //Check position
   bool IsTrade = False;

   for (int i = 0; i < Total; i ++) {
      OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
      if(OrderType() <= OP_SELL &&  OrderSymbol() == Symbol()) {
         IsTrade = True;
         if(OrderType() == OP_BUY) {
            //Close

            //+------------------------------------------------------------------+
            //| Signal Begin(Exit Buy)                                           |
            //+------------------------------------------------------------------+

              


            //+------------------------------------------------------------------+
            //| Signal End(Exit Buy)                                             |
            //+------------------------------------------------------------------+

            if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
               OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);
               if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");
               if (!EachTickMode) BarCount = Bars;
               IsTrade = False;
               continue;
            }
            //Trailing stop
            if(UseTrailingStop && TrailingStop > 0) {                 
               if(Bid - OrderOpenPrice() > Point * TrailingStop) {
                  if(OrderStopLoss() < Bid - Point * TrailingStop) {
                     OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen);
                     if (!EachTickMode) BarCount = Bars;
                     continue;
                  }
               }
            }
         } else {
            //Close


            //+------------------------------------------------------------------+
            //| Signal End(Exit Sell)                                            |
            //+------------------------------------------------------------------+

            if (Order == SIGNAL_CLOSESELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
               OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);
               if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Close Sell");
               if (!EachTickMode) BarCount = Bars;
               IsTrade = False;
               continue;
            }
            //Trailing stop
            if(UseTrailingStop && TrailingStop > 0) {                 
               if((OrderOpenPrice() - Ask) > (Point * TrailingStop)) {
                  if((OrderStopLoss() > (Ask + Point * TrailingStop)) || (OrderStopLoss() == 0)) {
                     OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TrailingStop, OrderTakeProfit(), 0, DarkOrange);
                     if (!EachTickMode) BarCount = Bars;
                     continue;
                  }
               }
            }
         }
      }
   }




   //+------------------------------------------------------------------+
   //| Signal End                                                       |
   //+------------------------------------------------------------------+

   //Buy
   if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
      if(!IsTrade) {
         //Check free margin
         if (AccountFreeMargin() < (1000 * Lots)) {
            Print("We have no money. Free Margin = ", AccountFreeMargin());
            return(0);
         }

         if (UseStopLoss) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0;
         if (UseTakeProfit) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0;

         Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
         if(Ticket > 0) {
            if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
                Print("BUY order opened : ", OrderOpenPrice());
                if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");
            } else {
                Print("Error opening BUY order : ", GetLastError());
            }
         }
         if (EachTickMode) TickCheck = True;
         if (!EachTickMode) BarCount = Bars;
         return(0);
      }
   }

   //Sell
   if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
      if(!IsTrade) {
         //Check free margin
         if (AccountFreeMargin() < (1000 * Lots)) {
            Print("We have no money. Free Margin = ", AccountFreeMargin());
            return(0);
         }

         if (UseStopLoss) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0;
         if (UseTakeProfit) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0;

         Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);
         if(Ticket > 0) {
            if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
                Print("SELL order opened : ", OrderOpenPrice());
                if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Open Sell");
            } else {
                Print("Error opening SELL order : ", GetLastError());
            }
         }
         if (EachTickMode) TickCheck = True;
         if (!EachTickMode) BarCount = Bars;
         return(0);
      }
   }

   if (!EachTickMode) BarCount = Bars;

   return(0);
}
//+------------------------------------------------------------------+

       if((stochbull < 45 && stochbear > 45)&& stochbear < stochbull){
            if(mcad4hr < 2){
               if(asbull < asbear)
               {
                  sw=-1;
               }
            }         
         }

         if((stochbull < 45 && stochbear < 45)&& stochbear < stochbull){
            if(mcad4hr < 2){
               if(asbull < asbear)
               {
                  sw=-1;
               }
            }         
         }

Quoting jam

Disliked

Regarding the Sell Order issue, double check this section of logic in your EA:

Ignored