MwlRCT WorkSpace: Custom EA and Indicator Development

Quoting MwlRCT

Disliked

{image} ---{image} --- Download: {file}

Ignored

/*====================================================================
CHANGELOG:
Version: 2.0-P3e
Updated: 2026-02-26
Author: MwlRCT
Platform: MT4
======================================================================
[2.0-P3e] - 2026-02-26
+ Added: ProgStep_StartLevel_Buy / ProgStep_StartLevel_Sell inputs
* Fixed: CalcProgressiveStep() — new startLevel param, flat base below threshold
* Fixed: PlaceGridOrder() — passes side-specific start level, step logged
* Fixed: UpdatePanel() — step status shows @L threshold
* Fixed: OnInit() — print log includes StartLevel values
* Fixed: Version bump P3d → P3e
======================================================================*/

/*====================================================================
  CHANGELOG: Inverse Fisher Transform of RSI
  Base:      Original by mladen ([email protected])
  Modified:  2025-03-17 by MwlRCT
  Platform:  MT4
======================================================================

  [2.0.0] - 2025-07-01  (Feature Graft: Alerts + Proof Arrows)
  ── FEATURE 1: DEDICATED ALERT SYSTEM ──────────────────────────────
  + Added: extern int    SIGNALBAR (default=1, closed-bar)
  + Added: extern bool   AlertsMessage / AlertsSound / AlertsEmail / AlertsMobile
  + Added: extern string SoundFile (default="expert.wav")
  + Added: File-scope datetime AlertTimeBar for once-per-bar gating
  + Added: 4-channel independent alert dispatch (popup/sound/email/push)
  + Added: Alert triggers on trend[] color transition at SIGNALBAR
  + Added: Message format: "BUY| SYMBOL - TF |Price X.XXXXX"
  + Added: MTF guard — alerts fire only in native timeframe branch
 
  ── FEATURE 2: PROOF OBJECT_ARROWS ON CHART ────────────────────────
  + Added: extern bool  EnableProofArrows (default=true)
  + Added: extern color ProofBuyColor (clrAqua) / ProofSellColor (clrYellow)
  + Added: extern int   ProofBuyArrowCode (241) / ProofSellArrowCode (242)
  + Added: extern int   ProofBuyArrowSize (2) / ProofSellArrowSize (2)
  + Added: ProofPrefix() — unique name scoping by Symbol()+Period()
  + Added: ProofCreateArrow() — OBJ_ARROW on chart window 0
  + Added: ProofStampBar() — stamps arrows at trend[] transitions
  + Added: ProofCleanup() — deletes all proof objects on deinit
  + Added: ATR-based vertical offset for arrow placement
  + Added: ObjectFind guard to prevent duplicate objects
 
  ── STRUCTURAL CHANGES ─────────────────────────────────────────────
  * Changed: OnDeinit() — replaced empty body with ProofCleanup() call
  * Changed: _mtfCall macro — updated parameter list to pass all new externs
  + Added: ProofStampBar() call inside native-branch main calc loop
  + Added: Alert evaluation block after native-branch main loop
 
  ── PRESERVED (UNTOUCHED) ──────────────────────────────────────────
  ~ Intact: All 7 original buffers (5 visible + trend + count)
  ~ Intact: All RSI calculation methods (rsi/wil/rap/har/rsx/cut)
  ~ Intact: iNonLagMa engine and inverse fisher transform formula
  ~ Intact: All enums (enPrices, enRsiTypes, enColorOn)
  ~ Intact: MTF iCustom delegation and interpolation logic
  ~ Intact: PlotPoint / CleanPoint rendering functions
  ~ Intact: getPrice with Heiken Ashi variants
  ~ Intact: timeFrameToString utility
  ~ Intact: All original extern parameters unchanged
 
  [1.0.0] - Original
  + Initial release by mladen
======================================================================*/

Quote

Disliked

can add alarm to this Nonlag indicator when its changes color red/green

Quote

Disliked

Dear Coders,

Is there a Coder who can add the following to the attached EA?

A start time plus an end time setting in hours and minutes.

And if it’s not too much to ask, then preferably the end time optimizable.

I tried it myself but I got 18 errors and a lot of warnings.

I would be very grateful.

/*====================================================================
  CHANGELOG: T.E.rev.ea_1.00
  Version:   1.10
  Updated:   2026-04-24
  Author:    MwlRCT
  Platform:  MT4
======================================================================
  [1.10] - 2026-04-24
  --- Feature ---
  + Added: ENUM_HOUR dropdown (H00-H23)
  + Added: ENUM_MINUTE dropdown (M00-M59)
  + Added: UseTradingWindow input (master switch)
  + Added: TradingStartHour / TradingStartMinute inputs
  + Added: TradingEndHour / TradingEndMinute inputs
  + Added: IsWithinTradingWindow() reusable broker-time gate
  + Added: Same-day, overnight, and always-open window support
  + Added: Early-return gate at top of OpenOrders()
  --- Critical Bug Fixes ---
  * Fixed: OrderModifyFnct() loop bounds (was unreachable range)
  * Fixed: OrderModifyCheck() TP comparison used wrong operand
  * Fixed: OrderModifyCheck() PriceOpenChanged defaulted to true
  * Fixed: PrintFormat() missing % in "SL=.5f" specifier
  --- Hygiene ---
  * Renamed: Signal variable  -> g_signal
  * Renamed: Signal() function -> UpdateSignal()
  * Renamed: Envelopes_Desviation -> Envelopes_Deviation
  - Removed: Unused 'point' variable and OnInit() digit-scaling block
  - Removed: Unused 'description' local in OpenOrders()
  - Removed: Unused 'spread' locals in TrailingStop() and getStopLoss()
  * Changed: Spanish comments translated to English
  * Changed: Deep-nested OrderSelect blocks -> early-continue style
  * Changed: getTakeProfit min-stop check aligned with getStopLoss
  --- Publication Polish ---
  + Added: #property version "1.10"
  + Added: #property description lines
  + Added: Input section separators (Trading / Indicator / Window / Other)
  + Added: OnInit() input validation (returns INIT_PARAMETERS_INCORRECT)
  + Added: GetLastError() logging on OrderSend() failures
  --- Preserved ---
  = Kept: Full 60-minute ENUM_MINUTE granularity
  = Kept: Envelopes breakout strategy logic
  = Kept: Default Magic, lot, SL/TP values
  = Kept: Trailing stop behavior
  --- Breaking Change ---
  ! Note: Envelopes_Desviation -> Envelopes_Deviation
  ! Note: Old .set preset files will reset this field to default
  [1.00] - Original
  + Initial template release
======================================================================*/

 //+------------------------------------------------------------------+
//|                                        Template_M5_Envelopes.mq4 |
//|                                                   JorgeDeveloper |
//|                     https://www.mql5.com/en/users/jorgedeveloper |
//+------------------------------------------------------------------+
#property copyright "JorgeDeveloper"
#property link      "https://www.mql5.com/en/users/jorgedeveloper"
#property version   "1.10"
#property strict
#property description "Envelopes breakout EA with configurable broker-time trading window."
#property description "Places pending stop orders when price extends beyond the envelope."
//+------------------------------------------------------------------+
//| Hour / Minute enums for clean dropdown inputs                    |
//+------------------------------------------------------------------+
enum ENUM_HOUR
  {
   H00 = 0,  H01 = 1,  H02 = 2,  H03 = 3,
   H04 = 4,  H05 = 5,  H06 = 6,  H07 = 7,
   H08 = 8,  H09 = 9,  H10 = 10, H11 = 11,
   H12 = 12, H13 = 13, H14 = 14, H15 = 15,
   H16 = 16, H17 = 17, H18 = 18, H19 = 19,
   H20 = 20, H21 = 21, H22 = 22, H23 = 23
  };
enum ENUM_MINUTE
  {
   M00 = 0,  M01 = 1,  M02 = 2,  M03 = 3,  M04 = 4,  M05 = 5,
   M06 = 6,  M07 = 7,  M08 = 8,  M09 = 9,  M10 = 10, M11 = 11,
   M12 = 12, M13 = 13, M14 = 14, M15 = 15, M16 = 16, M17 = 17,
   M18 = 18, M19 = 19, M20 = 20, M21 = 21, M22 = 22, M23 = 23,
   M24 = 24, M25 = 25, M26 = 26, M27 = 27, M28 = 28, M29 = 29,
   M30 = 30, M31 = 31, M32 = 32, M33 = 33, M34 = 34, M35 = 35,
   M36 = 36, M37 = 37, M38 = 38, M39 = 39, M40 = 40, M41 = 41,
   M42 = 42, M43 = 43, M44 = 44, M45 = 45, M46 = 46, M47 = 47,
   M48 = 48, M49 = 49, M50 = 50, M51 = 51, M52 = 52, M53 = 53,
   M54 = 54, M55 = 55, M56 = 56, M57 = 57, M58 = 58, M59 = 59
  };
//+------------------------------------------------------------------+
//| Inputs                                                           |
//+------------------------------------------------------------------+
extern string sep_Trading           = "========== TRADING SETTINGS ==========";
extern int    Max_Spread            = 10;         // Max Spread / points
extern int    Take_Profit           = 50;         // Take profit / points
extern int    Stop_Loss             = 100;        // Stop loss / points
extern int    Enter_Point           = 30;         // Points for Order entry
extern bool   Trail_My_Orders       = true;       // Enable trailing stop
extern int    Trailing_Stop         = 30;         // Trailing distance / points
extern double FixedLot              = 0.01;       // Fixed lot size
extern string sep_Indicator         = "========== ENVELOPES SETTINGS ==========";
extern int    Envelopes_Period      = 3;          // Envelopes period
extern double Envelopes_Deviation   = 0.07;       // Envelopes deviation
extern int    Distance              = 140;        // Breakout distance / points
extern string sep_TradingWindow     = "========== TRADING WINDOW ==========";
extern bool        UseTradingWindow     = true;   // Enable broker-time session filter
extern ENUM_HOUR   TradingStartHour     = H08;    // Session start hour  / broker time
extern ENUM_MINUTE TradingStartMinute   = M00;    // Session start minute / broker time
extern ENUM_HOUR   TradingEndHour       = H17;    // Session end hour    / broker time
extern ENUM_MINUTE TradingEndMinute     = M00;    // Session end minute  / broker time
extern string sep_Other             = "========== OTHER SETTINGS ==========";
extern int    Magic                 = 924578;     // Magic number
extern int    Slippage              = 15;         // Slippage / points
//+------------------------------------------------------------------+
//| Global variables                                                 |
//+------------------------------------------------------------------+
string g_signal = "empty";
//+------------------------------------------------------------------+
//| Expert initialization function                                   |
//+------------------------------------------------------------------+
int OnInit()
  {
//--- Basic input validation
   if(FixedLot <= 0.0)
     {
      Print("Invalid input: FixedLot must be > 0");
      return(INIT_PARAMETERS_INCORRECT);
     }
   if(Enter_Point < 0 || Stop_Loss < 0 || Take_Profit < 0 || Trailing_Stop < 0)
     {
      Print("Invalid input: point-based settings cannot be negative");
      return(INIT_PARAMETERS_INCORRECT);
     }
   if(Envelopes_Period <= 0 || Envelopes_Deviation <= 0.0)
     {
      Print("Invalid input: Envelopes_Period and Envelopes_Deviation must be > 0");
      return(INIT_PARAMETERS_INCORRECT);
     }
   if(Distance < 0)
     {
      Print("Invalid input: Distance cannot be negative");
      return(INIT_PARAMETERS_INCORRECT);
     }
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Expert deinitialization function                                 |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
  {
//--- Nothing to clean up
  }
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick()
  {
   UpdateSignal();
   OpenOrders();
   OrderModifyFnct();
  }
//+------------------------------------------------------------------+
//| Generic broker-time session gate.                                |
//| Returns true if the EA may open NEW trades right now.            |
//| Safe reusable drop-in function for other MQL4 EAs.               |
//+------------------------------------------------------------------+
bool IsWithinTradingWindow()
  {
   if(!UseTradingWindow)
      return(true);
   datetime now = TimeCurrent();   // Broker/server time, not PC local time
   int nowMin   = TimeHour(now) * 60 + TimeMinute(now);
   int startMin = (int)TradingStartHour * 60 + (int)TradingStartMinute;
   int endMin   = (int)TradingEndHour   * 60 + (int)TradingEndMinute;
   // Start == End means always open.
   if(startMin == endMin)
      return(true);
   // Same-day session, e.g. 08:00 to 17:00.
   if(startMin < endMin)
      return(nowMin >= startMin && nowMin < endMin);
   // Overnight session, e.g. 22:00 to 02:00.
   return(nowMin >= startMin || nowMin < endMin);
  }
//+------------------------------------------------------------------+
//| Evaluate envelope breakout signal                                |
//+------------------------------------------------------------------+
void UpdateSignal()
  {
   RefreshRates();
   double envup = iEnvelopes(Symbol(), 0, Envelopes_Period, MODE_LWMA, 1,
                             PRICE_MEDIAN, Envelopes_Deviation, MODE_UPPER, 1);
   double envdn = iEnvelopes(Symbol(), 0, Envelopes_Period, MODE_LWMA, 1,
                             PRICE_MEDIAN, Envelopes_Deviation, MODE_LOWER, 1);
   g_signal = "empty";
   if(envdn - Low[1]  > Distance * Point && envdn - Bid > Distance * Point)
      g_signal = "sell";
   else if(High[1] - envup > Distance * Point && Bid - envup > Distance * Point)
      g_signal = "buy";
  }
//+------------------------------------------------------------------+
//| Open new pending orders                                          |
//+------------------------------------------------------------------+
void OpenOrders()
  {
   // Session filter:
   // Blocks NEW entries outside the configured broker-time window.
   // Does NOT block trailing stop, order modification, deletion,
   // or management of existing positions.
   if(!IsWithinTradingWindow())
      return;
   RefreshRates();
   double lot = FixedLot;
   long spread = SymbolInfoInteger(Symbol(), SYMBOL_SPREAD);
   // Spread filter + single-order limit
   if(spread <= Max_Spread && CountMyOrders("all") < 1)
     {
      // Buy
      if(g_signal == "buy")
        {
         double price = NormalizeDouble(Ask + (Enter_Point * Point), Digits);
         double sl = ((Stop_Loss   == 0) ? 0 : getStopLoss(Stop_Loss,   OP_BUYSTOP, price));
         double tp = ((Take_Profit == 0) ? 0 : getTakeProfit(Take_Profit, OP_BUYSTOP, price));
         if(OrderSend(Symbol(), OP_BUYSTOP, lot, price, Slippage, sl, tp,
                      "Order BUY STOP", Magic, 0, clrBlue) == -1)
           {
            Print("OrderSend - BuyStop ended with error #", GetLastError());
            return;
           }
        }
      // Sell
      if(g_signal == "sell")
        {
         double price = NormalizeDouble(Bid - (Enter_Point * Point), Digits);
         double sl = ((Stop_Loss   == 0) ? 0 : getStopLoss(Stop_Loss,   OP_SELLSTOP, price));
         double tp = ((Take_Profit == 0) ? 0 : getTakeProfit(Take_Profit, OP_SELLSTOP, price));
         if(OrderSend(Symbol(), OP_SELLSTOP, lot, price, Slippage, sl, tp,
                      "Order SELL STOP", Magic, 0, clrRed) == -1)
           {
            Print("OrderSend - SellStop ended with error #", GetLastError());
            return;
           }
        }
     }
  }
//+------------------------------------------------------------------+
//| Order modification / deletion / trailing management              |
//+------------------------------------------------------------------+
void OrderModifyFnct()
  {
   RefreshRates();
   long spread = SymbolInfoInteger(Symbol(), SYMBOL_SPREAD);
   // Delete pending orders if spread widens beyond tolerance
   if(spread > Max_Spread)
      DeleteOrders();
   // Re-price pending orders if price has drifted away from entry point
   for(int i = OrdersTotal() - 1; i >= 0; i--)
     {
      RefreshRates();
      if(!OrderSelect(i, SELECT_BY_POS))
         continue;
      if(OrderMagicNumber() != Magic)
         continue;
      int    ticket    = OrderTicket();
      int    type      = OrderType();
      double openPrice = OrderOpenPrice();
      double price = 0.0, sl = 0.0, tp = 0.0;
      int    aux  = 0;
      // BuyStop: if price has dropped more than Enter_Point from the pending entry, re-price it
      if(type == OP_BUYSTOP)
        {
         price = NormalizeDouble(Ask + (Enter_Point * Point), Digits);
         aux   = (int)((openPrice - Ask) / Point);
         if(openPrice != price && aux > Enter_Point)
           {
            sl = ((Stop_Loss   == 0) ? 0 : getStopLoss(Stop_Loss,   OP_BUYSTOP, price));
            tp = ((Take_Profit == 0) ? 0 : getTakeProfit(Take_Profit, OP_BUYSTOP, price));
            if(OrderModifyCheck(ticket, price, sl, tp))
              {
               if(!OrderModify(ticket, price, sl, tp, 0, clrBlue))
                  Print("OrderModify - BuyStop ended with error #", GetLastError());
              }
           }
        }
      // SellStop: if price has risen more than Enter_Point from the pending entry, re-price it
      if(type == OP_SELLSTOP)
        {
         price = NormalizeDouble(Bid - (Enter_Point * Point), Digits);
         aux   = (int)((Bid - openPrice) / Point);
         if(openPrice != price && aux > Enter_Point)
           {
            sl = ((Stop_Loss   == 0) ? 0 : getStopLoss(Stop_Loss,   OP_SELLSTOP, price));
            tp = ((Take_Profit == 0) ? 0 : getTakeProfit(Take_Profit, OP_SELLSTOP, price));
            if(OrderModifyCheck(ticket, price, sl, tp))
              {
               if(!OrderModify(ticket, price, sl, tp, 0, clrRed))
                  Print("OrderModify - SellStop ended with error #", GetLastError());
              }
           }
        }
     }
   // Trailing stop for filled positions
   if(Trail_My_Orders)
      TrailingStop();
  }
//+------------------------------------------------------------------+
//| Check whether an order's levels differ enough to justify modify  |
//+------------------------------------------------------------------+
bool OrderModifyCheck(int ticket, double price, double sl, double tp)
  {
   if(!OrderSelect(ticket, SELECT_BY_TICKET))
      return(false);
   string symbol  = OrderSymbol();
   double _point  = SymbolInfoDouble(symbol, SYMBOL_POINT);
   int    type    = OrderType();
   // Only compare open price for pending orders (market orders cannot re-price)
   bool PriceOpenChanged = false;
   if(!(type == OP_BUY || type == OP_SELL))
      PriceOpenChanged = (MathAbs(OrderOpenPrice() - price) > _point);
   bool StopLossChanged   = (MathAbs(OrderStopLoss()   - sl) > _point);
   bool TakeProfitChanged = (MathAbs(OrderTakeProfit() - tp) > _point);
   if(PriceOpenChanged || StopLossChanged || TakeProfitChanged)
      return(true);
   PrintFormat("Order #%d already has levels of Open=%.5f SL=%.5f TP=%.5f",
               ticket, OrderOpenPrice(), OrderStopLoss(), OrderTakeProfit());
   return(false);
  }
//+------------------------------------------------------------------+
//| Trailing stop for open market positions                          |
//+------------------------------------------------------------------+
void TrailingStop()
  {
   for(int i = OrdersTotal() - 1; i >= 0; i--)
     {
      RefreshRates();
      if(!OrderSelect(i, SELECT_BY_POS))
         continue;
      if(OrderMagicNumber() != Magic)
         continue;
      int    ticket    = OrderTicket();
      int    type      = OrderType();
      double sl        = OrderStopLoss();
      double tp        = OrderTakeProfit();
      double openPrice = OrderOpenPrice();
      if(type == OP_BUY)
        {
         double newSl = NormalizeDouble(Bid - (Trailing_Stop) * Point, Digits);
         if(sl < newSl || sl == 0)
           {
            if(OrderModifyCheck(ticket, openPrice, newSl, tp))
              {
               if(!OrderModify(ticket, openPrice, newSl, tp, 0))
                  Print("OrderModify - Buy trailing ended with error #", GetLastError());
              }
           }
        }
      if(type == OP_SELL)
        {
         double newSl = NormalizeDouble(Ask + (Trailing_Stop) * Point, Digits);
         if(sl > newSl || sl == 0)
           {
            if(OrderModifyCheck(ticket, openPrice, newSl, tp))
              {
               if(!OrderModify(ticket, openPrice, newSl, tp, 0))
                  Print("OrderModify - Sell trailing ended with error #", GetLastError());
              }
           }
        }
     }
  }
//+------------------------------------------------------------------+
//| Count EA-owned orders by category                                |
//+------------------------------------------------------------------+
int CountMyOrders(string type)
  {
   int count = 0;
   for(int i = OrdersTotal() - 1; i >= 0; i--)
     {
      if(!OrderSelect(i, SELECT_BY_POS))
         continue;
      if(OrderMagicNumber() != Magic)
         continue;
      // OP_BUY=0, OP_SELL=1, OP_BUYLIMIT=2, OP_SELLLIMIT=3, OP_BUYSTOP=4, OP_SELLSTOP=5
      if(type == "all")
         count++;
      else if(type == "pending" && OrderType() > 1)
         count++;
      else if(type == "buy" && OrderType() == OP_BUY)
         count++;
      else if(type == "sell" && OrderType() == OP_SELL)
         count++;
     }
   return(count);
  }
//+------------------------------------------------------------------+
//| Delete all EA-owned pending orders                               |
//+------------------------------------------------------------------+
void DeleteOrders()
  {
   if(CountMyOrders("pending") <= 0)
      return;
   for(int i = OrdersTotal() - 1; i >= 0; i--)
     {
      if(!OrderSelect(i, SELECT_BY_POS))
         continue;
      if(OrderMagicNumber() == Magic && OrderType() > 1)
        {
         if(!OrderDelete(OrderTicket()))
            Print("OrderDelete ended with error #", GetLastError());
        }
     }
  }
//+------------------------------------------------------------------+
//| Broker-reported minimum stop level                               |
//+------------------------------------------------------------------+
double getMinStopLevel()
  {
   return(MarketInfo(Symbol(), MODE_STOPLEVEL));
  }
//+------------------------------------------------------------------+
//| Broker-reported current spread                                   |
//+------------------------------------------------------------------+
long getSpread()
  {
   return(SymbolInfoInteger(Symbol(), SYMBOL_SPREAD));
  }
//+------------------------------------------------------------------+
//| Compute stop-loss price for the given order type                 |
//+------------------------------------------------------------------+
double getStopLoss(double sl, int type, double price = 0.00000001)
  {
   sl = (sl > getMinStopLevel()) ? sl : getMinStopLevel();
   if(type == OP_BUY)
      return(NormalizeDouble(Bid - (sl * Point), Digits));
   if(type == OP_SELL)
      return(NormalizeDouble(Ask + (sl * Point), Digits));
   if(type == OP_BUYSTOP)
      return(NormalizeDouble(price - (sl * Point), Digits));
   if(type == OP_SELLSTOP)
      return(NormalizeDouble(price + (sl * Point), Digits));
   return(0.0);
  }
//+------------------------------------------------------------------+
//| Compute take-profit price for the given order type               |
//+------------------------------------------------------------------+
double getTakeProfit(double tp, int type, double price = 0.00000001)
  {
   tp = (tp > getMinStopLevel()) ? tp : getMinStopLevel();
   if(type == OP_BUY)
      return(NormalizeDouble(Bid + (tp * Point), Digits));
   if(type == OP_SELL)
      return(NormalizeDouble(Ask - (tp * Point), Digits));
   if(type == OP_BUYSTOP)
      return(NormalizeDouble(price + (tp * Point), Digits));
   if(type == OP_SELLSTOP)
      return(NormalizeDouble(price - (tp * Point), Digits));
   return(0.0);
  }
//+------------------------------------------------------------------+

#property strict
#property indicator_chart_window
#property indicator_buffers 5
#property indicator_color1 Red
#property indicator_color2 Blue
#property indicator_color3 Magenta
#property indicator_color4 DodgerBlue
#property indicator_color5 Yellow
//--- inputs (preserved)
extern bool DoAlert         = true;
extern bool EachTickMode    = false; // if true, also evaluate shift 0 (REPAINTS)
extern int  Fast_MA_Period  = 1;
extern int  Slow_MA_Period  = 34;
extern int  Signal_period   = 14;
extern int  Signal_period2  = 5;
//--- buffers
double b2[];        // SELL arrow buffer (above bar)   - index 0
double b3[];        // BUY  arrow buffer (below bar)   - index 1
double Buffer1[];   // Fast MA - Slow MA               - index 2
double Buffer2[];   // LWMA(Buffer1, Signal_period)    - index 3
double Buffer3[];   // LWMA(Buffer1, Signal_period2)   - index 4
//--- alert deduplication
datetime LastAlertBar = 0;
double   LastBuyArrow  = 0.0;
double   LastSellArrow = 0.0;
//+------------------------------------------------------------------+
int init()
{
   IndicatorBuffers(5);
   SetIndexStyle(0, DRAW_ARROW, STYLE_SOLID, 1);
   SetIndexArrow(0, 242);
   SetIndexBuffer(0, b2);
   SetIndexEmptyValue(0, EMPTY_VALUE);
   SetIndexLabel(0, "SellArrow");
   SetIndexStyle(1, DRAW_ARROW, STYLE_SOLID, 1);
   SetIndexArrow(1, 241);
   SetIndexBuffer(1, b3);
   SetIndexEmptyValue(1, EMPTY_VALUE);
   SetIndexLabel(1, "BuyArrow");
   SetIndexBuffer(2, Buffer1);
   SetIndexLabel(2, "Fast-Slow");
   SetIndexBuffer(3, Buffer2);
   SetIndexLabel(3, "Signal LWMA");
   SetIndexBuffer(4, Buffer3);
   SetIndexLabel(4, "Signal LWMA 2");
   IndicatorShortName("SMA Cross Signal (fixed)");
   return(0);
}
//+------------------------------------------------------------------+
int deinit()
{
   return(0);
}
//+------------------------------------------------------------------+
int start()
{
   int counted_bars = IndicatorCounted();
   if(counted_bars < 0) counted_bars = 0;
   // We need i+1 valid for cross detection, so cap the oldest bar we touch.
   int limit = Bars - counted_bars;
   if(counted_bars > 0) limit++;
   if(limit > Bars - 1) limit = Bars - 1; // protect Buffer1[i+1]
   //--- 1) Fast-Slow MA difference
   for(int i = 0; i < limit; i++)
   {
      double MA_fast = iMA(NULL, 0, Fast_MA_Period, 0, MODE_SMA, PRICE_MEDIAN, i);
      double MA_slow = iMA(NULL, 0, Slow_MA_Period, 0, MODE_SMA, PRICE_MEDIAN, i);
      Buffer1[i] = MA_fast - MA_slow;
   }
   //--- 2) Two LWMA signal lines on Buffer1
   for(int j = 0; j < limit; j++)
   {
      Buffer2[j] = iMAOnArray(Buffer1, Bars, Signal_period,  0, MODE_LWMA, j);
      Buffer3[j] = iMAOnArray(Buffer1, Bars, Signal_period2, 0, MODE_LWMA, j);
   }
   //--- 3) Signal detection
   //    Default: closed bars only. Signal candle = shift 1, prior = shift 2.
   //    If EachTickMode==true we additionally evaluate shift 0 (repaints).
   int startShift = EachTickMode ? 0 : 1;
   for(int k = 0; k < limit; k++)
   {
      // Always clear arrow slots first so stale values cannot persist.
      b2[k] = EMPTY_VALUE;
      b3[k] = EMPTY_VALUE;
      // Need a valid previous (older) bar at k+1.
      if(k + 1 >= Bars) continue;
      // Skip live bar unless explicitly enabled.
      if(k < startShift) continue;
      double cur_diff  = Buffer1[k];
      double cur_sig   = Buffer2[k];
      double prev_diff = Buffer1[k + 1];   // older bar in MT4 series indexing
      double prev_sig  = Buffer2[k + 1];
      double prev_sig2 = Buffer3[k + 1];
      // Bullish cross of Buffer1 above Buffer2 (original placed arrow ABOVE bar
      // and alerted "SELL"; we keep that user-facing behavior unchanged but
      // make the Print message consistent with the Alert).
      if(cur_diff > cur_sig && prev_diff < prev_sig && prev_diff < prev_sig2)
      {
         b2[k] = High[k] + 5 * Point;
         if(k == 1 && DoAlert && LastAlertBar < Time[0] && b2[k] != LastSellArrow)
         {
            LastSellArrow = b2[k];
            LastAlertBar  = Time[0];
            Print(TimeToStr(TimeCurrent(), TIME_DATE | TIME_MINUTES),
                  ", SMA Cross ", Symbol(), " SELL on bar ", TimeToStr(Time[k]));
            Alert("SMA Cross ", Symbol(), " SELL");
         }
      }
      // Bearish cross of Buffer1 below Buffer2 -> BUY arrow below bar.
      if(cur_diff < cur_sig && prev_diff > prev_sig && prev_diff > prev_sig2)
      {
         b3[k] = Low[k] - 5 * Point;
         if(k == 1 && DoAlert && LastAlertBar < Time[0] && b3[k] != LastBuyArrow)
         {
            LastBuyArrow = b3[k];
            LastAlertBar = Time[0];
            Print(TimeToStr(TimeCurrent(), TIME_DATE | TIME_MINUTES),
                  ", SMA Cross ", Symbol(), " BUY on bar ", TimeToStr(Time[k]));
            Alert("SMA Cross ", Symbol(), " BUY");
         }
      }
   }
   return(0);
}
//+------------------------------------------------------------------+

/*====================================================================
  CHANGELOG: SMA_Cross_Signal_Indicator
  Version:   1.0.1
  Updated:   2026-04-27
  Author:    MwlRCT
  Platform:  MT4
======================================================================
  [1.0.1] - 2026-04-27
  * Fixed: Previous-bar index changed from i-1 to i+1 (MT4 series direction).
  * Fixed: Out-of-range access on Buffer1[-1] when i=0.
  * Fixed: Loop capped at Bars-1 to protect i+1 reads.
  * Fixed: Arrow buffers reset to EMPTY_VALUE every pass (no stale arrows).
  * Fixed: Print messages aligned with Alert text (BUY/SELL consistent).
  * Fixed: Alert dedup via LastAlertBar < Time[0] (once per bar, not per tick).
  + Added: #property strict for safer compilation.
  + Added: SetIndexEmptyValue and SetIndexLabel for all buffers.
  + Added: IndicatorShortName "SMA Cross Signal (fixed)".
  + Added: EachTickMode now actually controls shift 0 evaluation (repaints).
  * Changed: Default signal candle = shift 1 (closed, repaint-free).
  * Changed: Comparison candle = shift 2 (older bar).
  * Changed: Loop indices explicitly scoped (i, j, k).
  - Removed: Unused PreBarTime / NotSameBar bar-change tracking.
  - Removed: Redundant b3[i] != EMPTY_VALUE inner re-check.
  [1.0.0] - Original
  + Initial version (signals appeared one bar late due to inverted indexing).
======================================================================*/

Quote

Disliked

Hi there, in this given indicator signal comes after second candle appears using the same parameter settings.

Could I get signal on first candle instead of second ...please help

/*====================================================================
  CHANGELOG: LiquiditySweep_0r0_Alerts_MTF_BT
  Version:   V1.02
  Released:  2026-05-15
  Author:    MwlRCT (ForexFactory)
  Platform:  MT4
======================================================================
  [V1.02]
  TL;DR: Adds MTF logic, push notifications, and chart visibility control.
  ──────────────────────────────────────────────────────────────────
  CHANGE BLOCK
  ──────────────────────────────────────────────────────────────────
  :warning: Breaking: Object names now include symbol and source timeframe
  # Tags:     #breaking #objects #mtf
  @ Audience: Manual
  ! Note:     Old object names are no longer reused
  ! Setting:  InpSourceTF controls new object namespace
  > Action:   Remove old template objects if chart looks duplicated
  ? Impact:   Prevents timeframe collisions and stale object overwrites
  ✓ Verify:   New objects show symbol and source timeframe in names
  ──────────────────────────────────────────────────────────────────
  + Added: Multi-timeframe source calculation support
  # Tags:     #mtf #signals #calculation
  @ Audience: All
  ! Note:     Sweep logic now reads selected source timeframe
  ! Setting:  InpSourceTF=PERIOD_CURRENT by default
  > Action:   Select required source timeframe before live testing
  ? Impact:   Allows H1/H4 logic to project onto lower charts
  ✓ Verify:   M5 chart lines match selected source timeframe levels
  ──────────────────────────────────────────────────────────────────
  + Added: OPEN and CLOSED MTF read modes
  # Tags:     #mtf #repaint #confirmation
  @ Audience: All
  ! Note:     CLOSED ignores live source candle
  ! Setting:  InpMTFMode=MTF_CLOSED for confirmed signals
  > Action:   Use MTF_OPEN only for live preview behavior
  ? Impact:   Separates confirmed mode from repaint-capable live mode
  ✓ Verify:   CLOSED mode never depends on source candle zero
  ──────────────────────────────────────────────────────────────────
  + Added: Lower-timeframe source guard
  # Tags:     #mtf #safety #inputs
  @ Audience: All
  ! Note:     Lower source timeframe is blocked by default
  ! Setting:  InpAllowLowerTF=false
  > Action:   Enable only when lower-timeframe sourcing is intentional
  ? Impact:   Prevents accidental lower-timeframe logic leakage
  ✓ Verify:   Lower source input resolves back to chart timeframe
  ──────────────────────────────────────────────────────────────────
  + Added: Higher sweep push notification
  # Tags:     #alerts #push #sweep
  @ Audience: Manual
  ! Note:     Sends push after new higher sweep event
  ! Setting:  InpHigherLqSwNotificationEnabled=true
  > Action:   Configure MT4 mobile notifications first
  ? Impact:   Sends mobile notice without changing sweep logic
  ✓ Verify:   Push fires once per new higher sweep
  ──────────────────────────────────────────────────────────────────
  + Added: Lower sweep push notification
  # Tags:     #alerts #push #sweep
  @ Audience: Manual
  ! Note:     Sends push after new lower sweep event
  ! Setting:  InpLowerLqSwNotificationEnabled=true
  > Action:   Configure MT4 mobile notifications first
  ? Impact:   Sends mobile notice without changing sweep logic
  ✓ Verify:   Push fires once per new lower sweep
  ──────────────────────────────────────────────────────────────────
  + Added: Forecast swept push notification
  # Tags:     #alerts #push #forecast
  @ Audience: Manual
  ! Note:     Extends existing forecast swept popup event
  ! Setting:  InpForecastLqSwNotificationEnabled=true
  > Action:   Keep popup alert enabled only if needed
  ? Impact:   Adds mobile delivery beside existing popup alert
  ✓ Verify:   Push fires when forecast liquidity disappears
  ──────────────────────────────────────────────────────────────────
  + Added: Separate notification dedupe states
  # Tags:     #alerts #dedupe #runtime
  @ Audience: All
  ! Note:     Higher, lower, and forecast events dedupe independently
  ! Setting:  No user setting required
  > Action:   None
  ? Impact:   Prevents one event type suppressing another
  ✓ Verify:   Same-bar higher and lower events can both notify
  ──────────────────────────────────────────────────────────────────
  + Added: On-chart visibility button
  # Tags:     #ui #button #objects
  @ Audience: Manual
  ! Note:     Button toggles sweep and forecast objects
  ! Setting:  InpButtonEnabled=true
  > Action:   Click button to hide or show drawings
  ? Impact:   Cleans chart without unloading the indicator
  ✓ Verify:   First click hides objects; second click restores them
  ──────────────────────────────────────────────────────────────────
  + Added: Button position and style inputs
  # Tags:     #ui #inputs #button
  @ Audience: Manual
  ! Note:     Button corner, size, and colors are configurable
  ! Setting:  InpButtonCorner, InpButtonX, InpButtonY
  > Action:   Adjust inputs if button overlaps chart elements
  ? Impact:   Allows button placement per chart template
  ✓ Verify:   Button appears at configured chart position
  ──────────────────────────────────────────────────────────────────
  + Added: Visibility state persistence
  # Tags:     #ui #persistence #objects
  @ Audience: Manual
  ! Note:     Visibility state is stored by chart and symbol
  ! Setting:  No user setting required
  > Action:   None
  ? Impact:   Hidden or shown state survives recalculation
  ✓ Verify:   State remains after timeframe or parameter refresh
  ──────────────────────────────────────────────────────────────────
  ▲ Improved: Forecast logic now uses source timeframe
  # Tags:     #forecast #mtf #calculation
  @ Audience: All
  ! Note:     Forecast fractals no longer depend on chart arrays
  ! Setting:  InpSourceTF controls forecast source
  > Action:   Compare forecast lines against selected source timeframe
  ? Impact:   Aligns forecast levels with MTF sweep engine
  ✓ Verify:   Forecast lines match source timeframe fractals
  ──────────────────────────────────────────────────────────────────
  ▲ Improved: Trendline creation respects button state
  # Tags:     #ui #objects #visibility
  @ Audience: Manual
  ! Note:     New objects inherit current visibility state
  ! Setting:  InpButtonEnabled=true
  > Action:   None
  ? Impact:   Hidden mode remains clean during new recalculations
  ✓ Verify:   New lines stay hidden while button is OFF
  ──────────────────────────────────────────────────────────────────
  ▲ Improved: Object cleanup targets current indicator namespace
  # Tags:     #objects #cleanup #namespace
  @ Audience: Manual
  ! Note:     Cleanup uses symbol and source timeframe identity
  ! Setting:  InpSourceTF controls namespace identity
  > Action:   None
  ? Impact:   Reduces accidental deletion of unrelated objects
  ✓ Verify:   Other timeframe objects remain untouched after recalculation
======================================================================*/

Quote

Disliked

please can someone make this indicator MTF ,push notification and button as well.Thanks