Code help required please | Page 2 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Excel help required please 1 reply

mt4 on mobile help required please 15 replies

Help required with simple code on puredeal platform 0 replies

S/R EA Modification Required - Please Help! 5 replies

Market Sessions Indicator Required - Please Help! 2 replies

Attachments: Code help required please
Exit Attachments

Code help required please

  • #21
  • Jan 25, 2026 2:06am Jan 25, 2026 2:06am
Quoting emmzett
{quote} All the previous code examples don't check for a green bar. A green (bullish) bar is defined by the close price being higher than the open price, independant of the wicks. So, instead of checking Highs/Lows you have to check Open/Close of the bar in question. {image}
thank you everyone for your help for years I have struggled with problems and I forgot I was in forex factory and what a mistake that was. This site is amazing there’s so many brilliant people willing to help it’s mega but I’ve decided to give up and go to the pub for a few beers today.

thanks loads
Geoff
  • #22
  • Jan 25, 2026 3:54am Jan 25, 2026 3:54am
I had to have one last go trying something different didn't I lol I just couldn't leave it alone and I got the result I wanted now it's only in one place, When I trade manually I trade HH-LL and rejection trades as in picture below but I have to spend all my time looking at monitors. It would be nice if I could just let an ea select the right trades and make money, when I crack this I will share it, what is the good of catching 1 trade if it missed loads more. I'm defiantly getting a shower and going out and that's it

Geoff Hornibrook
Attached Image (click to enlarge)
Click to Enlarge Name: last go.PNG Size: 45 KB
  • #23
  • Jan 27, 2026 11:14am Jan 27, 2026 11:14am
Quoting emmzett
{quote} All the previous code examples don't check for a green bar. A green (bullish) bar is defined by the close price being higher than the open price, independant of the wicks. So, instead of checking Highs/Lows you have to check Open/Close of the bar in question. {image}
emmzett thanks for re posting. I’ve been trying all weekend I don’t think it’s doable. I realise how important this is as it’s a sure way to print money that’s why I’m starting to think it’s blocked in some way or the platform itself is not working correctly as crazy as that sounds. It should be as simple as if h1>h2 ask < low 1 unless one of the coding super brains figures it out we’ll have to live in front of our monitors
  • #24
  • Feb 25, 2026 9:13am Feb 25, 2026 9:13am
Hello,
I am a trader specializing in commodities, particularly gold. My strategy is based on price action and specific time slots.
I would like to create an EA (Expert Advisor) to automate my trading. My method is already profitable, but I want to explore how to fully automate it.
Would it be possible to arrange a phone call to discuss this in more detail?
Thank you in advance for your attention to my request.
Best regards,
  • #25
  • Feb 25, 2026 9:45am Feb 25, 2026 9:45am
I see the issue with your logic. You're checking `Ask <= Low[2]` but this condition
would trigger when price is already at or below the 2nd candle's low — that's too late.
Try using `Bid <= Low[2] + (DistancePips*Point*10)` instead, and consider adding
a confirmation that the green candle actually closed above the fast MA:
```cpp
if (MAfast < MAslow &&
High[2] > High[1] &&
Close[2] > Open[2] && // confirm green candle
Bid <= Low[2] + (DistancePips*Point*10) &&
GETORDERS(my_Orderdata) == 0 &&
my_Orderdata.AllowSell)
This way you're entering on a retrace to the Low[2] level, not chasing price
  • #26
  • Edited 2:46pm Feb 25, 2026 2:20pm | Edited 2:46pm
This is my understanding from what I see on the screenshots.
Attached File(s)
File Type: mq4 MA_Rejection_v1.0.mq4   11 KB | 80 downloads
  • #27
  • Feb 27, 2026 1:49pm Feb 27, 2026 1:49pm
Quoting Switzerland1
Hello, I am a trader specializing in commodities, particularly gold. My strategy is based on price action and specific time slots. I would like to create an EA (Expert Advisor) to automate my trading. My method is already profitable, but I want to explore how to fully automate it. Would it be possible to arrange a phone call to discuss this in more detail? Thank you in advance for your attention to my request. Best regards,

Message me and tell me what you want and I will try and make it for you.

Geoff Hornibrook
  • #28
  • Last Post: Apr 9, 2026 10:36pm Apr 9, 2026 10:36pm
perhaps instead of globbing all of those comparisons into a single statement, maybe break them up into chunks with debug messages.. this way you can see where it is failing..

Inserted Code
Print(".");
Print(".");
Print(".");
 
int fail=0;
 
if(MAfast>=MAslow) {fail=1; Print("failed on mafast>=maslow"); }
 
if(High[2]<=High[1]) {fail=1; Print("failed on high[2]<=High[1]"); }
 
if(Ask>Low[2]) {fail=1; Print("failed on ask>Low[2]"); }
 
if(GETORDERS(my_Ordersdata)!=0) {fail=1; Print("failed on getorders");}
 
if(!my_Orderdata.AllowSell) {fail=1; Print("failed on allowsell"); }
 
if(fail==1) ...abort
 
..otherwise continue with trade..
0 traders viewing now