OrderModify - Error code 1 | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Why ordermodify error 1? 9 replies

OrderModify Error 32 replies

OrderModify error 1 HELP PLEASE 5 replies

OrderModify() problem (NOT error code 1) 3 replies

OrderModify error 1 ?? 0 replies

OrderModify - Error code 1

  • #1
  • First Post: Edited 5:50am Aug 6, 2007 5:39am | Edited 5:50am
Hi all,

This is my second ever post on forexfactory but I have read the site for some time.

My post is with regard to the 'error 1' on the MT4 backtest. I am currently getting similar messages on other EA's I write (I'm a programmer by trade). From the MT4 documentation the error means you are updating either a stop or TP with an unchanged value.

For example if a stop on cable is 2.0200 and you update it using OrderModify to be 2.0200 you will get error 1. I don't think it is a serious problem and may well be informational only. In fact if you backtest the supplied MacD EA that comes with MT4 you will see it also generates these errors.

The question is how to remove them? I have tried comparing OrderStopLoss() with the variable I store the new stop in and not doing the OrderModify if they are the same but somehow the EA always does the OrderModify and generates the error 1 message. Despite printing both values (the values appear the same) and even doing a NormaliseDouble to both values to remove any rounding problems when comparing them but it still happens.

for example, something like the following still performs the OrderModify even when the values of NewStop and OrderStopLoss appear the same when printed:

if (OrderStopLoss() != NewStop) {
OrderModify.....
}

Have any programmers out there found a work around? Maybe it is a bug being that Metatraders own EA does it.
  • #2
  • Aug 7, 2007 4:57pm Aug 7, 2007 4:57pm
Still working on it... I'm afraid the solution is going to be more code to loop through the orders to see if they need to be modified before looping through to modify them. Big ol pain in the arse.
  • #3
  • Aug 7, 2007 7:13pm Aug 7, 2007 7:13pm
Why not just check the current values before updating, to update the order you have to call SelectOrder() right? so why not check the current value at that point. Don't see why you have to do any extra looping.
The breaking of a wave cannot explain the whole sea.
  • #4
  • Aug 7, 2007 7:17pm Aug 7, 2007 7:17pm
Quoting Craig
Why not just check the current values before updating, to update the order you have to call SelectOrder() right? so why not check the current value at that point. Don't see why you have to do any extra looping.
Tried this, comparing the variable to the OrderStopLoss() or OrderTakeProfit(), and the reverse, comparing the OrderStopLoss(TakeProfit)() to the variable, if not equal, modify, still error 1 is triggered...
  • #5
  • Aug 7, 2007 8:11pm Aug 7, 2007 8:11pm
Maybe instead of comparing floating point numbers (which can be tricky) you could try something like...

if (MathAbs(new_tp - OrderTakeProfit()) > Point)
{
//Modify
}
The breaking of a wave cannot explain the whole sea.
  • #6
  • Aug 7, 2007 9:51pm Aug 7, 2007 9:51pm
Point*newstop not just newstop

Quoting Philfx
Hi all,

This is my second ever post on forexfactory but I have read the site for some time.

My post is with regard to the 'error 1' on the MT4 backtest. I am currently getting similar messages on other EA's I write (I'm a programmer by trade). From the MT4 documentation the error means you are updating either a stop or TP with an unchanged value.

For example if a stop on cable is 2.0200 and you update it using OrderModify to be 2.0200 you will get error 1. I don't think it is a serious problem and may well be informational only. In fact if you backtest the supplied MacD EA that comes with MT4 you will see it also generates these errors.

The question is how to remove them? I have tried comparing OrderStopLoss() with the variable I store the new stop in and not doing the OrderModify if they are the same but somehow the EA always does the OrderModify and generates the error 1 message. Despite printing both values (the values appear the same) and even doing a NormaliseDouble to both values to remove any rounding problems when comparing them but it still happens.

for example, something like the following still performs the OrderModify even when the values of NewStop and OrderStopLoss appear the same when printed:

if (OrderStopLoss() != NewStop) {
OrderModify.....
}

Have any programmers out there found a work around? Maybe it is a bug being that Metatraders own EA does it.
  • #7
  • Aug 8, 2007 2:35am Aug 8, 2007 2:35am
Quoting Craig
Maybe instead of comparing floating point numbers (which can be tricky) you could try something like...

if (MathAbs(new_tp - OrderTakeProfit()) > Point)
{
//Modify
}
Craig - I tried

if (MathAbs(new_tp - OrderTakeProfit()) > 0)
{
//Modify

So I tried 0 instead of 'Point'. I printed both out and they are the same figures but I'll give 'Point' a try also. Thanks for the suggestion,

FXid10t - yep tried this too and I agree it doesn't solve it.

Tdion - Thanks I will try this. I know u have to use Point sometimes i.e.
if (OrderStopLoss() > (Ask-(TrailingStop*Point)) {...}

but I'm not sure why it would be needed here. The two numbers look identical when printed out and I have also tried MathsAbs and Normalize double to remove and floating point MT4 features. That said I will try your suggestion nonetheless. Metatrader's own Expert does it so I assume in absence of a workaround we can just ignore the code 1 messages when it comes to our testing?

In the meantime thanks for the feedback.
  • #8
  • Oct 4, 2007 1:59pm Oct 4, 2007 1:59pm
Maybe it's some kind of bug of the tester. I solve the problem by simply adding 1*Point.

if (NewStop>OrderStopLoss()+Point) {
OrderModify.....NewStop
}
  • #9
  • May 4, 2014 11:15pm May 4, 2014 11:15pm
you can try putting an if statement...

issue is that could be in a loop and going so fast that it tries to make an update. Don't know how often it happens normally but could be the way you set up your Model in the EA tester.. ie crude points vs ticks

if (OrderStopLoss() != MoveSLPrice)
{
PrintFormat("%s: PipCurrentProfit > bePips: %f > %f %i",OrderSymbol(),PipCurrentProfit,bePips,OrderTakeProfit());
OrderModify(OrderTicket(),0,MoveSLPrice,OrderTakeProfit(),0,Blue);
}

MoveSLPrice - the new SL price to modify the order if conditions are met
  • #10
  • Last Post: Jan 20, 2021 5:42am Jan 20, 2021 5:42am
Before calling ModifyOrder() . make sure that new openPrice/stopLoss/takeProfit you want to change is at least one point different from previous price.
something like this :

//====================================
double newStopLoss;
double minimumPriceDifference = MarketInfo(Symbol(), MODE_POINT);

if(MathAbs(newStopLoss - OrderStopLoss()) > minimumPriceDifference) {
// do the change here
// ModifyOrder(......)
}
//==================================

Hope this helps.
Thanks
0 traders viewing now