Hello friends this ea look profitable but open only buy. not open any sell trades. can someone fix it pls ? if can fix, I will tell how to use as profitable. {file}
/*-------------------------------------------------------------------- Change-log: myfxbk str_fix Updated:[21-05-2025] By: MwlRCT -------------------------------------------------------------------- - Fixed ZigZag detection for SELL signals - Replaced single ZigZagValue with proper buy/sell signal detection - Added proper identification of ZigZag peaks (for sells) and troughs (for buys) - Enabled EA to open both BUY and SELL trades when conditions are met --------------------------------------------------------------------*/
//+------------------------------------------------------------------+
//| Expert Advisor: Trend Following ZigZag MA Strategy |
//| Test edildi ve geliştirildi: 2025 |
//+------------------------------------------------------------------+
/*--------------------------------------------------------------------
Change-log: myfxbk str_fix
Updated:[21-05-2025]
By: MwlRCT
--------------------------------------------------------------------
- Fixed ZigZag detection for SELL signals
- Replaced single ZigZagValue with proper buy/sell signal detection
- Added proper identification of ZigZag peaks (for sells) and troughs (for buys)
- Enabled EA to open both BUY and SELL trades when conditions are met
--------------------------------------------------------------------*/
#property strict
// Parametreler
extern int MA1_Period = 15;
extern int MA2_Period = 30;
extern int MA3_Period = 60;
extern int ZigZag_Depth = 18;
extern int ZigZag_Deviation = 5;
extern int ZigZag_Backstep = 3;
extern int StopLoss = 200; // pip
extern int TakeProfit = 200; // pip
extern int TrailingStop = 1; // pip
extern double RiskPercentage = 10; // Yüzde risk
extern int MaxOrders = 10; // Maksimum emir sayısı
extern int Slippage = 3; // Slippage
// Global Değişkenler
double MA1, MA2, MA3;
bool isZigZagBuySignal;
bool isZigZagSellSignal;
//+------------------------------------------------------------------+
int OnInit()
{
// Başlangıçta gerekli ayarları yap
Print("EA Başlatıldı: Trend Takibi ve ZigZag");
return(INIT_SUCCEEDED);
}
//+------------------------------------------------------------------+
void OnTick()
{
// Göstergeleri Hesapla
MA1 = iMA(Symbol(), 0, MA1_Period, 0, MODE_SMA, PRICE_CLOSE, 0);
MA2 = iMA(Symbol(), 0, MA2_Period, 0, MODE_SMA, PRICE_OPEN, 0);
MA3 = iMA(Symbol(), 0, MA3_Period, 0, MODE_SMA, PRICE_OPEN, 0);
// Get ZigZag peak and trough values from the previous completed bar
double zz_high_bar1 = iCustom(Symbol(), Period(), "ZigZag", ZigZag_Depth, ZigZag_Deviation, ZigZag_Backstep, 0, 1); // Buffer 0 for highs, shift 1
double zz_low_bar1 = iCustom(Symbol(), Period(), "ZigZag", ZigZag_Depth, ZigZag_Deviation, ZigZag_Backstep, 1, 1); // Buffer 1 for lows, shift 1
// Determine signals based on whether a ZigZag point exists
isZigZagBuySignal = (zz_low_bar1 != EMPTY_VALUE && zz_low_bar1 > 0);
isZigZagSellSignal = (zz_high_bar1 != EMPTY_VALUE && zz_high_bar1 > 0);
// Eğer aktif işlem yoksa, yeni işlem aç
if (OrdersTotal() < MaxOrders)
{
// Buy (Long) İşlem için Koşul
if (MA1 > MA2 && MA2 > MA3 && isZigZagBuySignal)
{
// ALİM (BUY) işlemi aç
OpenTrade(OP_BUY);
}
// Sell (Short) İşlem için Koşul
if (MA1 < MA2 && MA2 < MA3 && isZigZagSellSignal)
{
// SATIŞ (SELL) işlemi aç
OpenTrade(OP_SELL);
}
}
}
//+------------------------------------------------------------------+
void OpenTrade(int tradeType)
{
double price = 0, sl = 0, tp = 0; // Initialize variables
double lotSize;
// Risk oranını hesapla
lotSize = AccountBalance() * RiskPercentage / 100 / 1000; // 1 pip'lik değişim için risk
if (tradeType == OP_BUY)
{
price = Ask;
sl = price - StopLoss * Point;
tp = price + TakeProfit * Point;
}
else if (tradeType == OP_SELL)
{
price = Bid;
sl = price + StopLoss * Point;
tp = price - TakeProfit * Point;
}
// Emir gönder
int ticket = OrderSend(Symbol(), tradeType, lotSize, price, Slippage, sl, tp, "ZigZag MA EA", 0, 0, clrBlue);
if (ticket < 0)
{
int errorCode = GetLastError();
Print("İşlem Açılmadı: Hata Kodu - ", errorCode);
ResetLastError();
}
else
{
// Trailing stop ekle
if (TrailingStop > 0)
{
SetTrailingStop(ticket);
}
}
}
//+------------------------------------------------------------------+
void SetTrailingStop(int ticket)
{
double currentPrice;
if (OrderSelect(ticket, SELECT_BY_TICKET))
{
if (OrderType() == OP_BUY)
{
currentPrice = Ask;
if (currentPrice - OrderOpenPrice() >= TrailingStop * Point)
{
double newStopLoss = currentPrice - TrailingStop * Point;
if(!OrderModify(ticket, OrderOpenPrice(), newStopLoss, OrderTakeProfit(), 0, clrBlue))
{
Print("OrderModify failed for BUY: ", GetLastError());
}
}
}
else if (OrderType() == OP_SELL)
{
currentPrice = Bid;
if (OrderOpenPrice() - currentPrice >= TrailingStop * Point)
{
double newStopLoss = currentPrice + TrailingStop * Point;
if(!OrderModify(ticket, OrderOpenPrice(), newStopLoss, OrderTakeProfit(), 0, clrRed))
{
Print("OrderModify failed for SELL: ", GetLastError());
}
}
}
}
}
//+------------------------------------------------------------------+ {image}
solution to the initial concerns should be interesting.
mq4 file is as attached. I checked too much with chatgbt to fix the problem but not succeed. {file}
