Real coders: How bad is this?

Let's get one thing clear; I am not a coder, but I have been known to change the Default settings, e.g. numbers and colors, to suit my requirements, that's the limit of my knowledge.

There is this indicator that has been revised from a session high & low breakout into a 2-day breakout, that is Monday + Tuesday.

Find it attached here below and the original concept there -> https://www.forexfactory.com/thread/...on-breakout-v2

When the focus of the indicator is to find the level of breakout of Monday and Tuesday, I had an issue with the indicator's accuracy of identifying the Mon.+ Tue. Pip Range after the Tuesday close on different time frames; shouldn't they all be the same?

Here is the 4-Hour with range of 295 pips:
Here is the 1-Hour with range of 258 pips:

Here is the 15-Minutes with range of 224 pips:


So, I thought it has to be in the code, right, how hard can it be?

I found this and figured the original number of 48 was the time range and figured that it should be less, changed it to 47.98 being the closest to 59 minutes using math.

And now all the charts have the same range of pips for Mon-Tue, here the 4-Hour with same 224 pips as the 15-Minutes.
Okay, tell me how bad that was, and if so, what is actually the coding issue and the proper way to "fix" it?


Thanks very much

I'm not a very good coder & metatrader base language isn't very code-readable friendly.
But recently, I wanted to modify my tradingview currency strength indicator (pinescript language) . And i managed to do it by copying the code to ChatGPT and asking it to make modifications.
Sometimes there were errors, and i would copy the error and it would fix it. I went through a whole bunch of ' i want it this way, not that way ! ' conversations with ChatGPT and eventually, i have my working modified indicator. Hope that helps.

Assuming the market is (already) opened at your tBoxStart on Monday and your need is to look for a 48 hours box, then tBoxEnd = tBoxStart + (48*60*60) -1;

The "-1" (second) is to ensure the box ends on the previous bar.

Also be sure to compare your charts within the same broker especially for H4 charts as some brokers with different times have different H4 bars start times.

Trading law :
Never put your stop loss near
Equal highs/lows.

Thanks for the coding tip, I shall try that.

Yes, definitely all the same broker, I only have 1 demo running now due to a bank / FX account hacking issue and had to reset desktop, iPad, and mobile phone.

Will update later.

That definitely works, 224 Pip Range it is on the 4-Hour and all-time frames lower! Thanks again to FerruFX.

I will have to let the coders mentioned, Squalou and mer071898, know about that.

Now if anybody is interested in a real challenge, is it possible to have, within the same indicator, calculations for ADR and AWR and fill in the Min and Max Box settings autonomously?

Currently, I manually set these for each pair:

ADR(60) for the Min Size, which is probably a better sign to take a breakout due to narrow range of Mon + Tue.

AWR(12) for the Max Size because mean reversion is probably more likely at that point.

See this chart for what I am on about, cheers.

Great!

Greeting oh Esteemed Ones : Who has been so magnanimous in Decades Past? No ones or shall we say, Few have been, as you Hanover & FerruFx. Thank you is just the start!

With the advent of A.I. has it made your work easier?
What are your views on the quality of codes they are able to generate..
Just attempting to change the temperature.
It has been oft said, having the knowledge of doing better?
demonstrate Same by actually doing better Even your Best.

Have a Blessed Day All.

Hello Erebus

Can you please post this Indicator.

No, I cannot, first it won't work for you, and second, it's paid for, so that's not kosher!

Go and buy your own copy.

I can't even post the link for fear of being branded Commercial, but it's not my work, I do not sell anything.

The name is in the screenshot, it ends with Dashboard, easy to find at MQL5.com

Even easier in the Market tab of Metatrader when you know how to use MT.

Cheers.