Return of Index Number With Certain Conditions - MQL4

 int bars = iBars(NULL,PERIOD_H1);
      
      for(int i = 0; i >= bars - 1; i++)
      {
         if(MAH1.Main(i) >= iLow(NULL,PERIOD_H1,i) && MAH1.Main(i) <= iHigh(NULL,PERIOD_H1,i)) maTouched = true;
         if(maTouched == true) lastIndexDigit = i;
         break;
      }

Quoting declaime

Disliked

Hello, I try to query for the index number of a previous bar, where certain conditions were met, i.e. a moving average was within a bars range. I used a for loop as follows. But that does not work as intended: int bars = iBars(NULL,PERIOD_H1); for(int i = 0; i >= bars - 1; i++) { if(MAH1.Main(i) >= iLow(NULL,PERIOD_H1,i) && MAH1.Main(i) <= iHigh(NULL,PERIOD_H1,i)) maTouched = true; if(maTouched == true) lastIndexDigit = i; break; } Has someone an idea where I my code goes off the rails? Thanks.

Ignored

if (maTouched)

int last_touched = -1;
for (int i=0; i<bars; i++) {
   if (ma.Main(i) >= iLow(NULL,PERIOD_H1, i) && ma.Main(i) <= iHigh(NULL,PERIOD_H1,i)) {
      last_touched = i;
      break;
   }
}

int last_touched(CiMA *ma)
{
   for (int i=0; i < bars; i++) 
      if (ma.Main(i) >= iLow(NULL,PERIOD_H1, i) && ma.Main(i) <= iHigh(NULL,PERIOD_H1,i))
         return i;
   return -1;
}

Quote

Disliked

First and foremost, the for loop is fundamentally broken. Zero is never greater than bars-1 so the program will never enter the loop.

Quote

Disliked

In this case the break statement is not nested in the block of (maTouched == true) like you think it is. Also maTouched is a bool so maTounched == true is redundant.

Quote

Disliked

You should learn how to use the debugger because if you had set a break-point to step through this you would have immediately caught your first mistake.

Quoting declaime

Disliked

Hi Nicholishen, thank you very much for your instructive and incisive reply. You helped building my understanding quite a bit. {quote} So true. It turns out, I fundamentally misunderstood the underlying logic of a for-loop. {quote} I get it now. Apart from being lazy, being in a rush also does not help. {quote} You were right. I never fully used the debugger before. In part, because I did /do not understand its workings. Even now, after doing some research and testing, I am still having trouble. For example, it shows me a value of "expression could...

Ignored

Quoting Nicholishen

Disliked

{quote} First and foremost, the for loop is fundamentally broken. Zero is never greater than bars-1 so the program will never enter the loop. You should learn how to use the debugger because if you had set a break-point to step through this you would have immediately caught your first mistake. The next mistake is an example of when being lazy f*%ks you up. Don't worry, we've all been there, but in the future you should get in the habit of using proper style so you don't confuse control statements. In this case the break statement is not nested in...

Ignored

for(int i = limit-1; i >= 0; i--)
     {
      if (i >= MathMin(PLOT_MAXIMUM_BARS_BACK-1, rates_total-1-OMIT_OLDEST_BARS)) continue; //omit some old rates to prevent "Array out of range" or slow calculation  
      
      int barshift_H1 = iBarShift(Symbol(), PERIOD_H1, Time[i]);
      if(barshift_H1 < 0) continue;
 
           while
         ( iCustom ( Conditions_bla_bla_Buy,  i+ barshift_H1 ) != EMPTY_VALUE )
 
      {
         Buffer1[i] = 1;
        }

Quoting PinoArla

Disliked

{quote} I'm going to apologize in advance, because this is probably a very simple thing,but I'm not able to solve it, and I'm not able to find the solution online - maybe I'm not able to use the right search words because of language...

Ignored

 while ( iCustom ( Conditions_bla_bla_Buy, i+ barshift_H1 ) != EMPTY_VALUE ) { Buffer1[i] = 1; }

if (i >= MathMin(PLOT_MAXIMUM_BARS_BACK-1, rates_total-1-OMIT_OLDEST_BARS)) continue;

while ( check1 && check2 && ! IsStopped() ) { do blah, blah }
 
// or e.g.
while ( ! EventSetTimer(10) )
  {
    if ( IsStopped() ) return(INIT_FAILED);
    Sleep(5);
  }

Quoting pah

Disliked

{quote} Hi, Your problem with freezing is almost certainly caused by: while ( iCustom ( Conditions_bla_bla_Buy, i+ barshift_H1 ) != EMPTY_VALUE ) { Buffer1 = 1; } Assuming your iCustom() call is returning some value other than EMPTY_VALUE it will continuously update the current buffer position Buffer1 = 1. You don't want a while just an if statement to allow the outer loop to continue. I'd also suggest setting up your loop from..to limits before entering the loop to reflect the range of bars you want to process rather than checking for: if...

Ignored

Quoting PinoArla

Disliked

{quote} thank you so much for taking the time to help me Let's say we use "if" statement - that is the original setting, but it outputs something only when the conditions are met. What I'm trying to get, is a binary output - when Buffer1 (Buy conditions) is true and until the opposite (Buffer2 i.e. Sell) is true, we want a +1 output; when Buffer2 is true and until nothing happens again (which is simply Buffer1 true again), we will get a simple -1. How could I get that? Hope I'm able to explain myself - I said it's not something huge, but I'm not...

Ignored

  for(int i = limit-1; i >= 0; i--)
  {
    if (i >= MathMin(PLOT_MAXIMUM_BARS_BACK-1, rates_total-1-OMIT_OLDEST_BARS)) continue;
      
    int barshift_H1 = iBarShift(Symbol(), PERIOD_H1, Time[i]);
    
    if ( barshift_H1 < 0 ) continue;
 
    if ( i < limit-1 ) Buffer1[i] = Buffer1[i+1]; //default to match previous Buffer1 value
 
    double icval = iCustom ( Conditions_bla_bla_Buy,  i+ barshift_H1 );
    
    if ( icval != EMPTY_VALUE )
    {
      //may need some more complicated checks here
      //to determine buy 1 or sell -1
      
      if ( icval > threshold ) Buffer1[i] = 1;
      
      else if ( icval < threshold ) Buffer1[i] = -1;
    }
  }

Quoting pah

Disliked

{quote} Something like the following. If it's more complicated you will have to post your original code with the if statements. for(int i = limit-1; i >= 0; i--) { if (i >= MathMin(PLOT_MAXIMUM_BARS_BACK-1, rates_total-1-OMIT_OLDEST_BARS)) continue; int barshift_H1 = iBarShift(Symbol(), PERIOD_H1, Time); if ( barshift_H1 < 0 ) continue; if ( i < limit-1 ) Buffer1 = Buffer1[i+1]; //default to match previous Buffer1 value double icval = iCustom ( Conditions_bla_bla_Buy, i+ barshift_H1 ); if ( icval != EMPTY_VALUE ) { //may need some more complicated...

Ignored

      //Indicator Buffer 1
      if(iCustom( blah_blah_Buy_Conditions) != EMPTY_VALUE
      )
        {
         Buffer1[i] = 1; //Set indicator value at fixed value
        }
      else
        {
         Buffer1[i] = EMPTY_VALUE;
        }
     
// **************************************

      //Indicator Buffer 2
      if(iCustom( blah_blah_Sell_Conditions) != EMPTY_VALUE
      )
        {
         Buffer2[i] = -1; //Set indicator value at fixed value
        }
      else
        {
         Buffer2[i] = EMPTY_VALUE;
        }

Quoting PinoArla

Disliked

{quote} Hello and thank you so much before I'll try to implement your solution, and since I'm not that smart in coding, I just want to try to understand if I was able to explain myself in the first place....

Ignored

  for(int i = limit-1; i >= 0; i--)
  {
    if (i >= MathMin(PLOT_MAXIMUM_BARS_BACK-1, rates_total-1-OMIT_OLDEST_BARS)) continue;
      
    int barshift_H1 = iBarShift(Symbol(), PERIOD_H1, Time[i]);
    
    if ( barshift_H1 < 0 ) continue;
 
    if ( i < limit-1 ) MyBuffer[i] = MyBuffer[i+1]; //default to match previous MyBuffer value
 
    double icval = iCustom(NULL,0,"MyIndi",13,1,0); //line index 0 for buy
    
    if ( icval != EMPTY_VALUE ) MyBuffer[i] = 1;
    
    icval = iCustom(NULL,0,"MyIndi",13,1,1); //line index 1 for sell
    
    if ( icval != EMPTY_VALUE  ) MyBuffer[i] = 1;
  }

Quoting pah

Disliked

{quote} I think you explained it correctly but I'm confused now as you show saving the Buy values to Buffer1 and sell values to Buffer2. Is this for use in an EA or are you creating another indicator? For an indicator I'm wondering why you need two different buffers 1 & 2 when you only want to save the values -1 or 1 according to the iCustom() calls. If you're building a new indicator then wouldn't you just want one buffer in which the elements are set to either -1 or 1 ?? Also, could you not incorporate this into the original indicator? Maybe you...

Ignored

Quoting pah

Disliked

Assuming one buffer it would look like: for(int i = limit-1; i >= 0; i--) { if (i >= MathMin(PLOT_MAXIMUM_BARS_BACK-1, rates_total-1-OMIT_OLDEST_BARS)) continue; int barshift_H1 = iBarShift(Symbol(), PERIOD_H1, Time); if ( barshift_H1 < 0 ) continue; if ( i < limit-1 ) MyBuffer = MyBuffer[i+1]; //default to match previous MyBuffer value double icval = iCustom(NULL,0,"MyIndi",13,1,0); //line index 0 for buy if ( icval != EMPTY_VALUE ) MyBuffer = 1; icval = iCustom(NULL,0,"MyIndi",13,1,1); //line index 1 for sell if ( icval != EMPTY_VALUE...

Ignored

Quoting pah

Disliked

Assuming one buffer it would look like: for(int i = limit-1; i >= 0; i--) { if (i >= MathMin(PLOT_MAXIMUM_BARS_BACK-1, rates_total-1-OMIT_OLDEST_BARS)) continue; int barshift_H1 = iBarShift(Symbol(), PERIOD_H1, Time); if ( barshift_H1 < 0 ) continue; if ( i < limit-1 ) MyBuffer = MyBuffer[i+1]; //default to match previous MyBuffer value double icval = iCustom(NULL,0,"MyIndi",13,1,0); //line index 0 for buy if ( icval != EMPTY_VALUE ) MyBuffer = 1; icval = iCustom(NULL,0,"MyIndi",13,1,1); //line index 1 for sell if ( icval != EMPTY_VALUE...

Ignored

 
#include <stdlib.mqh>
#include <stderror.mqh>
 
// Dichiarazioni di variabili globali
int openBuyBarIndex = -1;  // Barra di apertura per posizioni BUY
int openSellBarIndex = -1; // Barra di apertura per posizioni SELL
int tradeVolume = 0.1;     // Volume della posizione (esempio: 0.1)
 
int LotDigits; //initialized in OnInit
int MagicNumber = 1681032;
int TOD_From_Hour = 00; //time of the day (from hour)
int TOD_From_Min = 01; //time of the day (from min)
int TOD_To_Hour = 23; //time of the day (to hour)
int TOD_To_Min = 59; //time of the day (to min)
double TradeSize = 0.1;
int MaxSlippage = 3; //slippage, adjusted in OnInit
int MaxOpenTrades = 1;
int MaxLongTrades = 1000;
int MaxShortTrades = 1000;
int MaxPendingOrders = 1000;
int MaxLongPendingOrders = 1000;
int MaxShortPendingOrders = 1000;
bool Hedging = true;
int OrderRetry = 5; //# of retries if sending order returns error
int OrderWait = 5; //# of seconds to wait if sending order returns error
double myPoint; //initialized in OnInit
 
            // Funzione per verificare se la condizione di apertura BUY è ancora valida -Function to check if the BUY opening condition is still valid
            bool IsBuyConditionTrue(int barsAgo, int barsToCheck) {
                for (int i = 0; i < barsToCheck; i++) {
                    if (iCustom(Symbol(), PERIOD_CURRENT, "TEST_scambioPosiz", 1, barsAgo + i, 1) != 1) {
                        return false;
                    }
                }
                return true;
            }
 
            // Funzione per verificare se la condizione di apertura SELL è ancora valida - Function to check if the SELL opening condition is still valid
            bool IsSellConditionTrue(int barsAgo, int barsToCheck) {
                for (int i = 0; i < barsToCheck; i++) {
                    if (iCustom(Symbol(), PERIOD_CURRENT, "TEST_scambioPosiz", 1, barsAgo + i, 0) != -1) {
                        return false;
                    }
                }
                return true;
            }
 
 
bool inTimeInterval(datetime t, int From_Hour, int From_Min, int To_Hour, int To_Min)
  {
   string TOD = TimeToString(t, TIME_MINUTES);
   string TOD_From = StringFormat("%02d", From_Hour)+":"+StringFormat("%02d", From_Min);
   string TOD_To = StringFormat("%02d", To_Hour)+":"+StringFormat("%02d", To_Min);
   return((StringCompare(TOD, TOD_From) >= 0 && StringCompare(TOD, TOD_To) <= 0)
     || (StringCompare(TOD_From, TOD_To) > 0
       && ((StringCompare(TOD, TOD_From) >= 0 && StringCompare(TOD, "23:59") <= 0)
         || (StringCompare(TOD, "00:00") >= 0 && StringCompare(TOD, TOD_To) <= 0))));
  }
 
void myAlert(string type, string message)
  {
   if(type == "print")
      Print(message);
   else if(type == "error")
     {
      Print(type+" | close_and_reverse_GB @ "+Symbol()+","+IntegerToString(Period())+" | "+message);
     }
   else if(type == "order")
     {
     }
   else if(type == "modify")
     {
     }
  }
 
int TradesCount(int type) //returns # of open trades for order type, current symbol and magic number
  {
   int result = 0;
   int total = OrdersTotal();
   for(int i = 0; i < total; i++)
     {
      if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES) == false) continue;
      if(OrderMagicNumber() != MagicNumber || OrderSymbol() != Symbol() || OrderType() != type) continue;
      result++;
     }
   return(result);
  }
 
bool SelectLastHistoryTrade()
  {
   int lastOrder = -1;
   int total = OrdersHistoryTotal();
   for(int i = total-1; i >= 0; i--)
     {
      if(!OrderSelect(i, SELECT_BY_POS, MODE_HISTORY)) continue;
      if(OrderSymbol() == Symbol() && OrderMagicNumber() == MagicNumber)
        {
         lastOrder = i;
         break;
        }
     }
   return(lastOrder >= 0);
  }
 
int LastHistoryDirection()
  {
   if(SelectLastHistoryTrade())
     {
      int direction = 0;
      if(OrderType() == OP_BUY)
        direction = 1;
      else if(OrderType() == OP_SELL)
        direction = -1;
      return(direction);
     }
   return(0);
  }
 
int myOrderSend(int type, double price, double volume, string ordername) //send order, return ticket ("price" is irrelevant for market orders)
  {
   if(!IsTradeAllowed()) return(-1);
   int ticket = -1;
   int retries = 0;
   int err = 0;
   int long_trades = TradesCount(OP_BUY);
   int short_trades = TradesCount(OP_SELL);
   int long_pending = TradesCount(OP_BUYLIMIT) + TradesCount(OP_BUYSTOP);
   int short_pending = TradesCount(OP_SELLLIMIT) + TradesCount(OP_SELLSTOP);
   string ordername_ = ordername;
   if(ordername != "")
      ordername_ = "("+ordername+")";
   //test Hedging
   if(!Hedging && ((type % 2 == 0 && short_trades + short_pending > 0) || (type % 2 == 1 && long_trades + long_pending > 0)))
     {
      myAlert("print", "Order"+ordername_+" not sent, hedging not allowed");
      return(-1);
     }
   //test maximum trades
   if((type % 2 == 0 && long_trades >= MaxLongTrades)
   || (type % 2 == 1 && short_trades >= MaxShortTrades)
   || (long_trades + short_trades >= MaxOpenTrades)
   || (type > 1 && type % 2 == 0 && long_pending >= MaxLongPendingOrders)
   || (type > 1 && type % 2 == 1 && short_pending >= MaxShortPendingOrders)
   || (type > 1 && long_pending + short_pending >= MaxPendingOrders)
   )
     {
      myAlert("print", "Order"+ordername_+" not sent, maximum reached");
      return(-1);
     }
   //prepare to send order
   while(IsTradeContextBusy()) Sleep(100);
   RefreshRates();
   if(type == OP_BUY)
      price = Ask;
   else if(type == OP_SELL)
      price = Bid;
   else if(price < 0) //invalid price for pending order
     {
      myAlert("order", "Order"+ordername_+" not sent, invalid price for pending order");
              return(-1);
     }
   int clr = (type % 2 == 1) ? clrRed : clrBlue;
   while(ticket < 0 && retries < OrderRetry+1)
     {
      ticket = OrderSend(Symbol(), type, NormalizeDouble(volume, LotDigits), NormalizeDouble(price, Digits()), MaxSlippage, 0, 0, ordername, MagicNumber, 0, clr);
      if(ticket < 0)
        {
         err = GetLastError();
         myAlert("print", "OrderSend"+ordername_+" error #"+IntegerToString(err)+" "+ErrorDescription(err));
         Sleep(OrderWait*1000);
        }
      retries++;
     }
   if(ticket < 0)
     {
      myAlert("error", "OrderSend"+ordername_+" failed "+IntegerToString(OrderRetry+1)+" times; error #"+IntegerToString(err)+" "+ErrorDescription(err));
      return(-1);
     }
   string typestr[6] = {"Buy", "Sell", "Buy Limit", "Sell Limit", "Buy Stop", "Sell Stop"};
   myAlert("order", "Order sent"+ordername_+": "+typestr[type]+" "+Symbol()+" Magic #"+IntegerToString(MagicNumber));
   return(ticket);
  }
 
void myOrderClose(int type, double volumepercent, string ordername) //close open orders for current symbol, magic number and "type" (OP_BUY or OP_SELL)
  {
   if(!IsTradeAllowed()) return;
   if (type > 1)
     {
      myAlert("error", "Invalid type in myOrderClose");
      return;
     }
   bool success = false;
   int retries = 0;
   int err = 0;
   string ordername_ = ordername;
   if(ordername != "")
      ordername_ = "("+ordername+")";
   int total = OrdersTotal();
   ulong orderList[][2];
   int orderCount = 0;
   int i;
   for(i = 0; i < total; i++)
     {
      while(IsTradeContextBusy()) Sleep(100);
      if(!OrderSelect(i, SELECT_BY_POS, MODE_TRADES)) continue;
      if(OrderMagicNumber() != MagicNumber || OrderSymbol() != Symbol() || OrderType() != type) continue;
      orderCount++;
      ArrayResize(orderList, orderCount);
      orderList[orderCount - 1][0] = OrderOpenTime();
      orderList[orderCount - 1][1] = OrderTicket();
     }
   if(orderCount > 0)
      ArraySort(orderList, WHOLE_ARRAY, 0, MODE_ASCEND);
   for(i = 0; i < orderCount; i++)
     {
      if(!OrderSelect(orderList[i][1], SELECT_BY_TICKET, MODE_TRADES)) continue;
      while(IsTradeContextBusy()) Sleep(100);
      RefreshRates();
      double price = (type == OP_SELL) ? Ask : Bid;
      double volume = NormalizeDouble(OrderLots()*volumepercent * 1.0 / 100, LotDigits);
      if (NormalizeDouble(volume, LotDigits) == 0) continue;
 
      success = false; retries = 0;
      while(!success && retries < OrderRetry+1)
        {
         success = OrderClose(OrderTicket(), volume, NormalizeDouble(price, Digits()), MaxSlippage, clrWhite);
         if(!success)
           {
            err = GetLastError();
            myAlert("print", "OrderClose"+ordername_+" failed; error #"+IntegerToString(err)+" "+ErrorDescription(err));
            Sleep(OrderWait*1000);
           }
         retries++;
        }
      if(!success)
        {
         myAlert("error", "OrderClose"+ordername_+" failed "+IntegerToString(OrderRetry+1)+" times; error #"+IntegerToString(err)+" "+ErrorDescription(err));
         return;
       }
     }
   string typestr[6] = {"Buy", "Sell", "Buy Limit", "Sell Limit", "Buy Stop", "Sell Stop"};
   if(success) myAlert("order", "Orders closed"+ordername_+": "+typestr[type]+" "+Symbol()+" Magic #"+IntegerToString(MagicNumber));
  }
 
//+------------------------------------------------------------------+
//| Expert initialization function                                   |
//+------------------------------------------------------------------+
int OnInit()
  {  
   //initialize myPoint
   myPoint = Point();
   if(Digits() == 5 || Digits() == 3)
     {
      myPoint *= 10;
      MaxSlippage *= 10;
     }
   //initialize LotDigits
   double LotStep = MarketInfo(Symbol(), MODE_LOTSTEP);
   if(NormalizeDouble(LotStep, 3) == round(LotStep))
      LotDigits = 0;
   else if(NormalizeDouble(10*LotStep, 3) == round(10*LotStep))
      LotDigits = 1;
   else if(NormalizeDouble(100*LotStep, 3) == round(100*LotStep))
      LotDigits = 2;
   else LotDigits = 3;
   return(INIT_SUCCEEDED);
  }
 
//+------------------------------------------------------------------+
//| Expert deinitialization function                                 |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
  {
  }
 
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick()
  {
   int ticket = -1;
   double price;  
  
                // Verifica se la condizione di chiusura per la posizione BUY è soddisfatta - Check if the closing condition for the BUY position is satisfied
                if (TradesCount(OP_BUY) > 0 && openBuyBarIndex != -1) {
                    int barsAgo = Bars - openBuyBarIndex;
                    int barsToCheck = barsAgo; // Calcola barsToCheck dinamicamente in base alla barra di apertura
                    if (!IsBuyConditionTrue(barsAgo, barsToCheck)) {
                        myOrderClose(OP_BUY, 100, "CloseBuyPrincipal");  // Chiudi la posizione BUY
                    }
                }
 
                // Verifica se la condizione di chiusura per la posizione SELL è soddisfatta - Check if the closing condition for the SELL position is satisfied
                if (TradesCount(OP_SELL) > 0 && openSellBarIndex != -1) {
                    int barsAgo = Bars - openSellBarIndex;
                    int barsToCheck = barsAgo; // Calcola barsToCheck dinamicamente in base alla barra di apertura
                    if (!IsSellConditionTrue(barsAgo, barsToCheck)) {
                        myOrderClose(OP_SELL, 100, "CloseSellPrincipal");  // Chiudi la posizione SELL
                    }
                }
 
  
   //Close Long Positions (CloseBuyPrincipal)
   if(iCustom(NULL, PERIOD_CURRENT, "TEST_scambioPosiz", 1, 5, 1, 1) == -1 //TEST_scambioPosiz is equal to fixed value
   && iCustom(NULL, PERIOD_CURRENT, "TEST_scambioPosiz", 1, 5, 1, 2) != -1 //TEST_scambioPosiz is not equal to fixed value
   )
     {  
      if(IsTradeAllowed())
         myOrderClose(OP_BUY, 100, "CloseBuyPrincipal");
      else //not autotrading => only send alert
         myAlert("order", "CloseBuyPrincipal");
     }
  
   //Close Short Positions (CloseSellPrincipal)
   if(iCustom(NULL, PERIOD_CURRENT, "TEST_scambioPosiz", 1, 5, 0, 1) == 1 //TEST_scambioPosiz is equal to fixed value
   && iCustom(NULL, PERIOD_CURRENT, "TEST_scambioPosiz", 1, 5, 0, 2) != 1 //TEST_scambioPosiz is not equal to fixed value
   )
     {  
      if(IsTradeAllowed())
         myOrderClose(OP_SELL, 100, "CloseSellPrincipal");
      else //not autotrading => only send alert
         myAlert("order", "CloseSellPrincipal");
     }
/*
*****************************************************************************
*****************************************************************************
*****************************************************************************
*****************************************************************************
*****************************************************************************
*/
 
   //Open Buy Order (Buy2)
   if(TradesCount(OP_BUY) + TradesCount(OP_SELL) == 0 //Open Trades is equal to fixed value
   && iCustom(NULL, PERIOD_CURRENT, "TEST_scambioPosiz", 1, 5, 0, 1) == 1 //TEST_scambioPosiz is equal to fixed value
   && iCustom(NULL, PERIOD_CURRENT, "TEST_scambioPosiz", 1, 5, 0, 2) != 1 //TEST_scambioPosiz is not equal to fixed value
   )
     {
      RefreshRates();
      price = Ask;
      if(!inTimeInterval(TimeCurrent(), TOD_From_Hour, TOD_From_Min, TOD_To_Hour, TOD_To_Min)) return; //open trades only at specific times of the day  
      if(IsTradeAllowed())
        {
         ticket = myOrderSend(OP_BUY, price, TradeSize, "Buy2");
         if(ticket <= 0) return;
        }
      else //not autotrading => only send alert
         myAlert("order", "Buy2");
     }
  
   //Open Buy Order (BuyAfterSellClose)
   if(iCustom(NULL, PERIOD_CURRENT, "TEST_scambioPosiz", 1, 5, 0, 1) == 1 //TEST_scambioPosiz is equal to fixed value
   && LastHistoryDirection() == -1 //Last Historical Trade Direction is equal to fixed value
   && iCustom(NULL, PERIOD_CURRENT, "TEST_scambioPosiz", 1, 5, 0, 2) != 1 //TEST_scambioPosiz is not equal to fixed value
   )
     {
      RefreshRates();
      price = Ask;
      if(!inTimeInterval(TimeCurrent(), TOD_From_Hour, TOD_From_Min, TOD_To_Hour, TOD_To_Min)) return; //open trades only at specific times of the day  
      if(IsTradeAllowed())
        {
         ticket = myOrderSend(OP_BUY, price, TradeSize, "BuyAfterSellClose");
         if(ticket <= 0) return;
        }
      else //not autotrading => only send alert
         myAlert("order", "BuyAfterSellClose");
     }
  
   //Open Sell Order (Sell2)
   if(TradesCount(OP_BUY) + TradesCount(OP_SELL) == 0 //Open Trades is equal to fixed value
   && iCustom(NULL, PERIOD_CURRENT, "TEST_scambioPosiz", 1, 5, 1, 1) == -1 //TEST_scambioPosiz is equal to fixed value
   && iCustom(NULL, PERIOD_CURRENT, "TEST_scambioPosiz", 1, 5, 1, 2) != -1 //TEST_scambioPosiz is not equal to fixed value
   )
     {
      RefreshRates();
      price = Bid;
      if(!inTimeInterval(TimeCurrent(), TOD_From_Hour, TOD_From_Min, TOD_To_Hour, TOD_To_Min)) return; //open trades only at specific times of the day  
      if(IsTradeAllowed())
        {
         ticket = myOrderSend(OP_SELL, price, TradeSize, "Sell2");
         if(ticket <= 0) return;
        }
      else //not autotrading => only send alert
         myAlert("order", "Sell2");
     }
  
   //Open Sell Order (SellAfterBuyClose)
   if(iCustom(NULL, PERIOD_CURRENT, "TEST_scambioPosiz", 1, 5, 1, 1) == -1 //TEST_scambioPosiz is equal to fixed value
   && LastHistoryDirection() == 1 //Last Historical Trade Direction is equal to fixed value
   && iCustom(NULL, PERIOD_CURRENT, "TEST_scambioPosiz", 1, 5, 1, 2) != -1 //TEST_scambioPosiz is not equal to fixed value
   )
     {
      RefreshRates();
      price = Bid;
      if(!inTimeInterval(TimeCurrent(), TOD_From_Hour, TOD_From_Min, TOD_To_Hour, TOD_To_Min)) return; //open trades only at specific times of the day  
      if(IsTradeAllowed())
        {
         ticket = myOrderSend(OP_SELL, price, TradeSize, "SellAfterBuyClose");
         if(ticket <= 0) return;
        }
      else //not autotrading => only send alert
         myAlert("order", "SellAfterBuyClose");
     }
  }
//+------------------------------------------------------------------+

Quoting PinoArla

Disliked

{quote} I hope I'm not being intrusive... Hello, in the meantime... Could you help me? Thanks Pino

Ignored

Quoting pah

Disliked

{quote} Hi, I had a quick look and I'm assuming the previous code we talked about is still in play (in the other custom indicator). If something is subject to the repaint issue you might avoid that by not looking at (or not calculating) the current open bar. Try just using/calculating the last closed bar instead (index 1, not 0 ). Other stuff concerning the code above which doesn't compile due to errors... delete this line as it is not used int tradeVolume = 0.1; // Volume della posizione (esempio: 0.1) Check use of openBuyBarIndex & openSellBarIndex....

Ignored

int openBuyBarIndex ; // Barra di apertura per posizioni BUY
int openSellBarIndex ; // Barra di apertura per posizioni SELL