Hello,this indicator attached,sometimes doesn't alert about buy or sell signal arrow,if someone can fix the bug,I can pay if is needed.
Attached File(s)
- #5
- Feb 7, 2025 3:00pm Feb 7, 2025 3:00pm
Fixed. Erroneous curly braces and the compiler silently ignored it. Caused the alerts to be skipped because some array vars weren't computed.
It takes blood, sweat and enough tears to wash away the blood.
- #8
- Feb 8, 2025 8:35pm Feb 8, 2025 8:35pm
- Joined Apr 2007 | Status: Trader | 1,016 Posts
{quote} Thanks my friend,to fix this indicator,it must have some type of bug,but 3/4 mt4 coders,says no bug is found on indicator. Im really apreciate for that,let me know if you want some fee for your amzing work please. Best Regards.
When utterly confused by why code is behaving badly, it may help to "Style" it, which helps to see how it is interpreting the flow. Those extra curly braces surround a big block of code, and since it's the true result to an "if(condition...) { {...} }" it doesn't flow through as you would expect. But with the actual indentations, it may jump out easier what is the problem.
The original "look":
Run the styler:
Get the reorganized result which shows the actual flow. One should be able to spot why some lines were skipped. They are "too far" indented, which points out how it is inside the true condition for the if() { ... } :
Styled again with the extra curly braces removed:
{quote} It wasn't a bug in the way of bad code syntax, since it compiled fine. But yes, a bug with a bad flow through the code. When utterly confused by why code is behaving badly, it may help to "Style" it, which helps to see how it is interpreting the flow. Those extra curly braces surround a big block of code, and since it's the true result to an "if(condition...) { {...} }" it doesn't flow through as you would expect. But with the actual indentations, it may jump out easier what is the problem. The original "look": {image} Run the styler: {image}...
. Sorry and once again,thank you 
- #12
- Edited 5:30am Feb 11, 2025 5:16am | Edited 5:30am
{quote} Hello RosaSurfer,after test it,i see still some signals doesnt come,no alert window,no alert pop-up,no evidence of signal,and trades show that no signal come,can you please kindly re-check again? Yellow circles,is where it fail,thank you. Best Regards.4896426 {image}
First thing I see is that the indicator repaints. You also can see it from your screenshot. On history it looks OK but with realtime data it produces multiple blue and white arrows on every new bar. If I fix this it would give you an alert on every such bar. Do you want this?
Example: it just produced a new signal. If the next bar closes higher it will produce another signal. On history you will only see the last signal, because in hindsight it's easy to spot the high/low of a swing. Not so in a real market :-)
It takes blood, sweat and enough tears to wash away the blood.
- #13
- Edited 6:02am Feb 11, 2025 5:41am | Edited 6:02am
...and trades show that no signal come...
Are you aware that the issue may as well be with your EA? I have the indicator running on M1 for some time now, and it gives the alerts correctly.
Try to reproduce the issue and give a more concrete example. Make a screenshot with missing trades and alert dialog open, so we can see the triggered alerts and the corresponding trades. Also post the source code of the EA if you have it. Don't worry, nobody can "steal" a profitable idea only by giving away the EA's sources. The internet is full of stolen codes. If it was that easy we must all be millionaires, right?
Example: Two consecutive long signals.
It takes blood, sweat and enough tears to wash away the blood.
- #20
- Feb 12, 2025 11:00pm Feb 12, 2025 11:00pm
I think broker, its afraid of this Strategy :-) and manipulate the chart or indicator ! during the night it was +600$ profit,the closed at 150$ profit...because of that bug on alerts.
- The signals calculated from history are different then the ones from the real market. See how the indicator omits/skips the signals from yesterday evening when the first trades where opened. Now there is no signal anymore.
- At 01:35 short trades should have been closed. The alert dialog confirms that the indicator failed to give a signal. Last signal before was 01:05, next signal at 01:55. No long signal in between.
Will try to reproduce in tester and see whether I can fix it.
It takes blood, sweat and enough tears to wash away the blood.