FF Calendar Indicator for MT

Quoting Kurka Fund

Disliked

Works like a charm..... Or seem to so far.

Is there any way to get a history dump of the XML file so that I can use the filter for backtesting ?

Thanks

KK

Ignored

Quoting DerkWehler

Disliked

What do you mean? You mean you want it to save each XML w/date so they do not get overwritten?

Ignored

Quoting Kurka Fund

Disliked

It would be nice to be able to see how the EA's performed over last year with the news time filtered out. How far back does the XML file go ? Is there a way that I could get the file with the data from the last 12 months and just point to that instead of theFF site for backtest purposes ?

Ignored

Quoting DerkWehler

Disliked

You will have to ask Merlin about that one. Right now the only way is to make the EA save each one (not a tough change) and wait a year.

However, there was a guy on the yahoo group who had put together a file with all the news events over the past year. Ron (Thompson) was going to use it to backtest BollTrade. So if you are a member of the Yahoo group, I suggest you ask on there. In fact, I still have his CSV file (csv, not xml). So I will attach it here if it does you any good. At the moment I do not have time to make changed to he Indicator to handle this though. Again, you might speak to Ron Thompson to see if he ever did anything with it.

-Derk

PS: I had to rename the extension to get it to uplad here. Change the .txt extension back to .csv

Ignored

Quoting merlin

Disliked

btw, if you would pay for this service, you should just subscribe to TTN for $20/month! thats who we are getting our actuals from (via a special partnership). why get it second hand from us when you can get it firsthand from TTN?? and you would get a whole lot more than just actuals!

Ignored

Quoting DerkWehler

Disliked

Greets all:

I found a problem with FFCal (v.05). When called from an EA, if there were no more events for the week (for the currency pair it was assigned to), it would report zero for "Minutes until next event". Likewise, before the first event, it would return zero for "Minutes since last event". This caused EAs to think it was news time when it was not; a major flaw.

Now it will return 99999 instead, which the EA will interpret as a long way away (1666 hours).

I was going to name it FFCal_v06, inline with my previous convention, but I am tired of changing all my EAs to match, every time the name changes, so I have decided to permanently name it just "FFCal". Folks using it will simply have to keep updated when there is a new version. The comment header at the top will always be the best way to tell if something has been changed since the version you are using.

It is my hope that there will not really be any more changes, unless more bugs are found. But either way, to those using it with iCustom calls, this will be the last time you have to change the name.

Best to all,
-Derk

Ignored

 // Refresh FF calendar on startup, and once at the top of each hour
//if (FirstRun || Minute() == 0)   [color=red]this is the orginal control[/color].
  Print(GlobalVariableGet("LastUpdateTime")+" "+(TimeCurrent()-GlobalVariableGet("LastUpdateTime")));
  if (GlobalVariableCheck("LastUpdateTime")==false || (TimeCurrent()-GlobalVariableGet("LastUpdateTime"))>3600)  [color=red]i try to use this way , then if we use this indicator on many cureency ,it will don't keep downloading the file.[/color]
 //if(false)
 {
  //FirstRun = false;
  if (DebugLevel > 1)
   Print("sUrl == ", sUrl);
  
  if (DebugLevel > 0)
   Print("Grabbing Web, url = ", sUrl);
 
  // THIS CALL WAS DONATED BY PAUL TO HELP FIX THE RESOURCE ERROR
  GrabWeb(sUrl, sData);
  if (DebugLevel > 0)
  {
   Print("Opening XML file...\n");
   Print(sData);
  }
  // Write the contents of the ForexFactory page to an .htm file
  xmlHandle = FileOpen(xmlFileName, FILE_BIN|FILE_READ|FILE_WRITE);
  if (xmlHandle < 1)
  {
   if (DebugLevel > 0)
    Print("Can\'t open new xml file, the last error is ", GetLastError());
   return(false);
  }
  FileWriteString(xmlHandle, sData, StringLen(sData));
  FileClose(xmlHandle);
  if (DebugLevel > 0)
   Print("Wrote XML file...\n");
  // THIS BLOCK OF CODE DONATED BY WALLY TO FIX THE RESOURCE ERROR
  //--- Look for the end XML tag to ensure that a complete page was downloaded ---//
  end = StringFind(sData, "</weeklyevents>", 0);
  if (end <= 0)
  {
   Alert("GetNewsFF Error - Web page download was not complete!");
   return(false);
  }
  else
     GlobalVariableSet("LastUpdateTime",TimeCurrent());  [color=red]and i mark time[/color] here . 
  //-------------------------------------------------------------------------------//
 }

Quoting feri_pur

Disliked

I try to attach FFCal_04 to my GBP Chart. It was error
the messages like this:

GetNewsFF Error - Web page download was not complete!

Anyone would help... please

Ignored

Quoting amenlo9

Disliked

anyone can modify this indicator in order to display it at different position of the chart?eg: right-middle,right-top or right-down etc....

Ignored

Quoting flourishing

Disliked

it already have , you didn't read it ,did you ?

Ignored

Quoting feri_pur

Disliked

I try to attach FFCal_04 to my GBP Chart. It was error
the messages like this:

GetNewsFF Error - Web page download was not complete!

Anyone would help... please

Ignored

Quoting flourishing

Disliked

hi Derk , this indicator is very good. but i think the good way is not return the number . i already use it in ea, and i already find that , if we control in ea will be the best way , not change the indicator, so sometime it will found no events , then the time and impact will be 0 same time , so in ea , when we found that time and impact be 0 same time , we do trade.

and here is my question.

every 4 hour indicator update news file can 't reduce the downloading this file time , if we use it on serveral pairs , it will download it when attach it to the new chart, but the file hasn't updated, so i try to use like that below,

Inserted Code

 // Refresh FF calendar on startup, and once at the top of each hour
//if (FirstRun || Minute() == 0)   [color=red]this is the orginal control[/color].
  Print(GlobalVariableGet("LastUpdateTime")+" "+(TimeCurrent()-GlobalVariableGet("LastUpdateTime")));
  if (GlobalVariableCheck("LastUpdateTime")==false || (TimeCurrent()-GlobalVariableGet("LastUpdateTime"))>3600)  [color=red]i try to use this way , then if we use this indicator on many cureency ,it will don't keep downloading the file.[/color]
 //if(false)
 {
  //FirstRun = false;
  if (DebugLevel > 1)
   Print("sUrl == ", sUrl);
  
  if (DebugLevel > 0)
   Print("Grabbing Web, url = ", sUrl);
 
  // THIS CALL WAS DONATED BY PAUL TO HELP FIX THE RESOURCE ERROR
  GrabWeb(sUrl, sData);
  if (DebugLevel > 0)
  {
   Print("Opening XML file...\n");
   Print(sData);
  }
  // Write the contents of the ForexFactory page to an .htm file
  xmlHandle = FileOpen(xmlFileName, FILE_BIN|FILE_READ|FILE_WRITE);
  if (xmlHandle < 1)
  {
   if (DebugLevel > 0)
    Print("Can\'t open new xml file, the last error is ", GetLastError());
   return(false);
  }
  FileWriteString(xmlHandle, sData, StringLen(sData));
  FileClose(xmlHandle);
  if (DebugLevel > 0)
   Print("Wrote XML file...\n");
  // THIS BLOCK OF CODE DONATED BY WALLY TO FIX THE RESOURCE ERROR
  //--- Look for the end XML tag to ensure that a complete page was downloaded ---//
  end = StringFind(sData, "</weeklyevents>", 0);
  if (end <= 0)
  {
   Alert("GetNewsFF Error - Web page download was not complete!");
   return(false);
  }
  else
     GlobalVariableSet("LastUpdateTime",TimeCurrent());  [color=red]and i mark time[/color] here . 
  //-------------------------------------------------------------------------------//
 }

i haven't update it , still use 0.3,
i dindn't change anything else , but , when i attachment it to the chart , it will occupy almost all the ram , kill the mt4 terminal. so any advice ?

thank you for your time .

Ignored

Quoting Plutonite

Disliked

I just needed to say thank you. I'm comp science graduate student myself, and this little piece of code is an example of how software rocks the world. You have written a tool that automates the trading reactions to some dude speaking in a conference half way across the world, in real time. Good quality code (well most of it haha) as well.

Kudos and Thank you DarkWehler & team.

Ignored

Quoting flourishing

Disliked

hi Derk , this indicator is very good. but i think the good way is not return the number . i already use it in ea, and i already find that , if we control in ea will be the best way , not change the indicator, so sometime it will found no events , then the time and impact will be 0 same time , so in ea , when we found that time and impact be 0 same time , we do trade.

Ignored