Need Help from Coders: Get Open Order Info from a Loop | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Need Help from Coders: Get Shift of Last Day of Current Month 4 replies

Loop to get Desired Counts and its Shift, then Stop the Loop 2 replies

How to Write a Loop of a Loop for Different TF 8 replies

Need Help: Array to get the Longest Green Bar Value of a Loop 20 replies

DIY platform - Any C# coders? Need info, not code! 3 replies

Need Help from Coders: Get Open Order Info from a Loop

  • #1
  • First Post: Edited 4:50am Aug 26, 2023 2:57am | Edited 4:50am
Hi coders, I'm a beginner, please help as I do not know the correct way to code.

I would like to get below Open Trades info from a loop :-
1) OrderOpenTime() of BUY open order, i.e. bOpTm
2) OrderOpenTime() of SELL open order, i.e. sOpTm
3) OrderOpenPrice() of BUY open order, i.e. bOpPx
4) OrderOpenPrice() of SELL open order, i.e. sOpPx

You may have a question what if there are 3 BUY open trades and 5 SELL open trades for a symbol, but no worry about the number of BUY and SELL trades as I have set to maximum number of BUY trades=1 and maximum number of SELL trades=1 for each symbol.

FYI, in my MT4's "Trade" tab, there are many open trades for different symbols but all the BUY trades are standardly assigned with mnBUY magic number and all the SELL trades are standardly assigned with mnSEL magic number.

Inserted Code
   // input variables
   int mnBUY=10; // Magic Number for BUY Trades
   int mnSEL=20; // Magic Number for SELL Trades
 
   datetime bOpTm=0, sOpTm=0;
   double bOpPx=0, sOpPx=0;
 
   for(int i=OrdersTotal()-1; i>=0; i--) {
   if(OrderSelect(i,SELECT_BY_POS) && OrderSymbol()==symbol)
      {
      bOpTm=OrderOpenTime();
      bOpPx=OrderOpenPrice();
      if(OrderMagicNumber()==mnBUY) {i=bOpTm; i=bOpPx;}}
 
      {
      sOpTm=OrderOpenTime();
      sOpPx=OrderOpenPrice();
      if(OrderMagicNumber()==mnSEL) {i=sOpTm; i=sOpPx;}}
   }

I know that the way I wrote {i=bOpTm; i=bOpPx;} and {i=sOpTm; i=sOpPx;} are seriously and logically wrong as the " i " is an integer value, ended up the MetaEditor prompts a warning message "possible loss of data due to type conversion". I purposely present my wrong set of codes just for the coders to understand what I intend to achieve.

Could you please help to correct my codes so that I can get the correct Open Order outputs for the bOpTm, sOpTm, bOpPx=0 and sOpPx, thanks.
  • #2
  • Aug 26, 2023 4:21am Aug 26, 2023 4:21am
The assignment of the i makes no sense as it is the variable that contains the total number of orders.As you have already done previously that's fine, you just have to enter the control of the magic Number together with that of the symbol. If instead you want to do it separately like the code is now, you have to assign OrderOpenTime and OpenPrice back to the variables
  • #3
  • Aug 26, 2023 4:31am Aug 26, 2023 4:31am
Quoting gian97
The assignment of the i makes no sense as it is the variable that contains the total number of orders.As you have already done previously that's fine, you just have to enter the control of the magic Number together with that of the symbol. If instead you want to do it separately like the code is now, you have to assign OrderOpenTime and OpenPrice back to the variables
Hi Gian, thanks for your reply. FYI, in my MT4's "Trade" tab, there are many open trades for different symbols but all the BUY trades are standardly assigned with mnBUY magic number and all the SELL trades are standardly assigned with mnSEL magic number.

Honestly, I don't really get what you said as I don't have programming background, and I'm learning now.

Could you please help to write down your set of codes so that I can test it ? Highly appreciated.
  • #4
  • Aug 26, 2023 7:45am Aug 26, 2023 7:45am
Ok no problem,
Inserted Code
// input variables
   int mnBUY=10; // Magic Number for BUY Trades
   int mnSEL=20; // Magic Number for SELL Trades
 
   datetime bOpTm=0, sOpTm=0;
   double bOpPx=0, sOpPx=0;
 
   for(int i=OrdersTotal()-1; i>=0; i--) {
   if(OrderSelect(i,SELECT_BY_POS) && OrderSymbol()==symbol)
      {
      If ( OrderMagicNumber()==mnBUY ) {
      bOpTm=OrderOpenTime();
      bOpPx=OrderOpenPrice();
      }
       if(OrderMagicNumber()==mnSEL) {
      sOpTm=OrderOpenTime();
      sOpPx=OrderOpenPrice();
      }
     }
   }

Or if there is no specific reason to do so you can use only one Magic Number for both buy and sell. Then filter the order by comparing OrderType() == OP_BUY or OP_SELL

Inserted Code
// input variables
   int magicNumber = 123456;
 
   datetime bOpTm=0, sOpTm=0;
   double bOpPx=0, sOpPx=0;
 
   for(int i=OrdersTotal()-1; i>=0; i--) {
   if(OrderSelect(i,SELECT_BY_POS) && OrderSymbol()==symbol && OrderMagicNumber() == magicNumber)
      {
      If ( OrderType() == OP_BUY) {
      bOpTm=OrderOpenTime();
      bOpPx=OrderOpenPrice();
      }
       if(OrderType() == OP_SELL) {
      sOpTm=OrderOpenTime();
      sOpPx=OrderOpenPrice();
      }
     }
   }
  • #5
  • Aug 26, 2023 11:18am Aug 26, 2023 11:18am
Quoting gian97
Ok no problem, // input variables int mnBUY=10; // Magic Number for BUY Trades int mnSEL=20; // Magic Number for SELL Trades datetime bOpTm=0, sOpTm=0; double bOpPx=0, sOpPx=0; for(int i=OrdersTotal()-1; i>=0; i--) { if(OrderSelect(i,SELECT_BY_POS) && OrderSymbol()==symbol) { If ( OrderMagicNumber()==mnBUY ) { bOpTm=OrderOpenTime(); bOpPx=OrderOpenPrice(); } if(OrderMagicNumber()==mnSEL) { sOpTm=OrderOpenTime(); sOpPx=OrderOpenPrice(); } } } Or if there is no specific reason to do so you can use only one Magic Number for both buy and sell. Then...
Hi Gian, thanks, I'll test your quotes on next Monday.
  • #6
  • Edited 10:50pm Aug 27, 2023 10:32pm | Edited 10:50pm
Quoting gian97
Ok no problem, // input variables int mnBUY=10; // Magic Number for BUY Trades int mnSEL=20; // Magic Number for SELL Trades datetime bOpTm=0, sOpTm=0; double bOpPx=0, sOpPx=0; for(int i=OrdersTotal()-1; i>=0; i--) { if(OrderSelect(i,SELECT_BY_POS) && OrderSymbol()==symbol) { If ( OrderMagicNumber()==mnBUY ) { bOpTm=OrderOpenTime(); bOpPx=OrderOpenPrice(); } if(OrderMagicNumber()==mnSEL) { sOpTm=OrderOpenTime(); sOpPx=OrderOpenPrice(); } } } Or if there is no specific reason to do so you can use only one Magic Number for both buy and sell. Then...
Hi Gian, I ran your codes and created 2 alerts as follows :-

Inserted Code
   for(int i=OrdersTotal()-1; i>=0; i--) {
   if(OrderSelect(i,SELECT_BY_POS) && OrderSymbol()==symbol) {
      if(OrderMagicNumber()==mnBUY) {
         bOpTm=OrderOpenTime();
         bOpPx=OrderOpenPrice();}
      if(OrderMagicNumber()==mnSEL) {
         sOpTm=OrderOpenTime();
         sOpPx=OrderOpenPrice();}}}
 
   if(OrderMagicNumber()==mnBUY) {Alert(symbol+" BUY Time/Px : "+TimeToStr(bOpTm)+" / "+DoubleToStr(bOpPx,5))}
   if(OrderMagicNumber()==mnSEL) {Alert(symbol+" SEL Time/Px : "+TimeToStr(sOpTm)+" / "+DoubleToStr(sOpPx,5))}

Issue : Only the "SEL Time/Px" has output, but the "BUY Time/Px" doesn't have output, could you please advise where the codes go wrong, thanks.
  • #7
  • Aug 28, 2023 1:37am Aug 28, 2023 1:37am
Quoting chimoong
{quote} Hi Gian, I ran your codes and created 2 alerts as follows :- for(int i=OrdersTotal()-1; i>=0; i--) { if(OrderSelect(i,SELECT_BY_POS) && OrderSymbol()==symbol) { if(OrderMagicNumber()==mnBUY) { bOpTm=OrderOpenTime(); bOpPx=OrderOpenPrice();} if(OrderMagicNumber()==mnSEL) { sOpTm=OrderOpenTime(); sOpPx=OrderOpenPrice();}}} if(OrderMagicNumber()==mnBUY) {Alert(symbol+" BUY Time/Px : "+TimeToStr(bOpTm)+" / "+DoubleToStr(bOpPx,5))} if(OrderMagicNumber()==mnSEL) {Alert(symbol+" SEL Time/Px : "+TimeToStr(sOpTm)+" / "+DoubleToStr(sOpPx,5))} Issue...
This code does not compile. There is an error in the last if, you didn't use ; in the end.
Since you're learning, I recommend that you use proper formatting to make your code more readable.
I have reviewed and this way it seems to me that it should work without problems.
symbol I don't know if it was a variable declared by you in some other part of the code, so I replaced it with Symbol() which is an internal function that returns precisely the symbol on which I attached the expert advisor.
I also added alerts in the for loop, because without entering an orderselect you can't extract the magic number of the order.
Inserted Code
 
   int mnBUY = 123, mnSEL = 456;
   datetime bOpTm = 0, sOpTm = 0;
   double bOpPx = 0, sOpPx = 0;
   for(int i = OrdersTotal() - 1; i >= 0; i--)
     {
      if(OrderSelect(i, SELECT_BY_POS) && OrderSymbol() == Symbol())
        {
         if(OrderMagicNumber() == mnBUY)
           {
            bOpTm = OrderOpenTime();
            bOpPx = OrderOpenPrice();
            Alert(Symbol() + " BUY Time/Px : " + TimeToStr(bOpTm) + " / " + DoubleToStr(bOpPx, 5));
           }
         if(OrderMagicNumber() == mnSEL)
           {
            sOpTm = OrderOpenTime();
            sOpPx = OrderOpenPrice();
            Alert(Symbol() + " SEL Time/Px : " + TimeToStr(sOpTm) + " / " + DoubleToStr(sOpPx, 5));
           }
        }
     }
  • #8
  • Aug 29, 2023 10:26am Aug 29, 2023 10:26am
Quoting gian97
{quote} This code does not compile. There is an error in the last if, you didn't use ; in the end. Since you're learning, I recommend that you use proper formatting to make your code more readable. I have reviewed and this way it seems to me that it should work without problems. symbol I don't know if it was a variable declared by you in some other part of the code, so I replaced it with Symbol() which is an internal function that returns precisely the symbol on which I attached the expert advisor. I also added alerts in the for loop, because without...
Hi Gian, thanks.

In fact, the position of Alerts doesn't matter as the bOpTm, sOpTm, bOpPx and sOpPx should store the correct values respectively.

A coder PMed me to give me the solution.

The changes are pretty simple, from the original :-

Inserted Code
if(OrderSelect(i,SELECT_BY_POS) && OrderSymbol()==symbol)

to be changed to :-

Inserted Code
if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES) && OrderSymbol()==symbol)

That's all. The one-line of Alert as follows will give the correct answers :-

Inserted Code
{Alert(symbol+" Time/Px : "+TimeToStr(bOpTm)+" / "+DoubleToStr(bOpPx,5)+" + "+TimeToStr(sOpTm)+" / "+DoubleToStr(sOpPx,5));}
  • #9
  • Aug 30, 2023 3:40am Aug 30, 2023 3:40am
The MODE_TRADES it's the default mode.
From the mql4 reference :

pool=MODE_TRADES
[in] Optional order pool index. Used when the selected parameter is SELECT_BY_POS. It can be any of the following values:
MODE_TRADES (default)- order selected from trading pool(opened and pending orders),
MODE_HISTORY - order selected from history pool (closed and canceled order).


MODE_TRADES it's the default, if you don't write anything, MODE_TRADES it's used.
My code is correct, the location of the alerts is at your discretion based on its use. I entered in the for because you were trying to compare the magic number out of the orderselect in your previous post.
  • #10
  • Last Post: Aug 30, 2023 4:48am Aug 30, 2023 4:48am
Quoting gian97
The MODE_TRADES it's the default mode. From the mql4 reference : pool=MODE_TRADES [in] Optional order pool index. Used when the selected parameter is SELECT_BY_POS. It can be any of the following values: MODE_TRADES (default)- order selected from trading pool(opened and pending orders), MODE_HISTORY - order selected from history pool (closed and canceled order). MODE_TRADES it's the default, if you don't write anything, MODE_TRADES it's used. My code is correct, the location of the alerts is at your discretion based on its use. I entered in the...
Anyway, thanks Gian, I already have the answers. The MODE_TRADES really gives me the correct outputs.
0 traders viewing now