Help needed trying to learn the MQ4 language | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

how to learn mq4 ? 11 replies

I need some MQ4 help from a real MQ4 programmer 2 replies

mq4 code convert to easy language to use in Tradestation 1 reply

moutaki Mq4+fibo grid Mq4=profit+ease 39 replies

How can I learn MT4 language? 2 replies

Help needed trying to learn the MQ4 language

  • #1
  • First Post: Jun 23, 2023 12:03pm Jun 23, 2023 12:03pm
I am trying to create a script that will draw horizontal lines on the high and low of the last candle of the W1, D1 and the Swing High and Swing Low of M15.
I seem to be having issues calling my timeframes, if that is even possible.

Inserted Code
//+------------------------------------------------------------------+
//|                                                HighLow_W1_D1_M15 |
//|                                        Copyright 2023, NoizeUnit |
//+------------------------------------------------------------------+
#property strict
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
void OnStart()
  {
// Switch to the W1 timeframe
   PeriodSet(Period("W1"));
// Calculate the high and low prices of the current week's candle
   double weeklyHigh = iHigh(NULL, PERIOD_CURRENT, 0);
   double weeklyLow = iLow(NULL, PERIOD_CURRENT, 0);
// Draw horizontal lines on the high and low points for the weekly candle
   ObjectCreate("WeeklyHighLine", OBJ_HLINE, 0, Time[0], weeklyHigh);
   ObjectSet("WeeklyHighLine", OBJPROP_COLOR, Blue);
   ObjectSet("WeeklyHighLine", OBJPROP_WIDTH, 1);
   ObjectCreate("WeeklyLowLine", OBJ_HLINE, 0, Time[0], weeklyLow);
   ObjectSet("WeeklyLowLine", OBJPROP_COLOR, Blue);
   ObjectSet("WeeklyLowLine", OBJPROP_WIDTH, 1);
// Switch to the D1 timeframe
   PeriodSet(Period("D1"));
// Calculate the high and low prices of the current day's candle
   double dailyHigh = iHigh(NULL, PERIOD_CURRENT, 0);
   double dailyLow = iLow(NULL, PERIOD_CURRENT, 0);
// Draw horizontal lines on the high and low points for the daily candle
   ObjectCreate("DailyHighLine", OBJ_HLINE, 0, Time[0], dailyHigh);
   ObjectSet("DailyHighLine", OBJPROP_COLOR, Blue);
   ObjectSet("DailyHighLine", OBJPROP_WIDTH, 1);
   ObjectCreate("DailyLowLine", OBJ_HLINE, 0, Time[0], dailyLow);
   ObjectSet("DailyLowLine", OBJPROP_COLOR, Blue);
   ObjectSet("DailyLowLine", OBJPROP_WIDTH, 1);
// Switch to the M15 timeframe
   PeriodSet(Period("M15"));
// Calculate the high and low prices of the swing high and swing low on M15 timeframe
   double swingHigh = High[0];
   double swingLow = Low[0];
   for(int i = 1; i <= Bars; i++)
     {
      if(High[i] > swingHigh)
         swingHigh = High[i];
      if(Low[i] < swingLow)
         swingLow = Low[i];
     }
// Draw horizontal lines on the swing high and swing low points for the M15 timeframe
   ObjectCreate("M15SwingHighLine", OBJ_HLINE, 0, Time[0], swingHigh);
   ObjectSet("M15SwingHighLine", OBJPROP_COLOR, DarkTurquoise);
   ObjectSet("M15SwingHighLine", OBJPROP_WIDTH, 1);
   ObjectCreate("M15SwingLowLine", OBJ_HLINE, 0, Time[0], swingLow);
   ObjectSet("M15SwingLowLine", OBJPROP_COLOR, DarkTurquoise);
   ObjectSet("M15SwingLowLine", OBJPROP_WIDTH, 1);
  }
//+------------------------------------------------------------------+

Am I close?
Any help from the programmers out there would be appreciated.
Thanks in advance.

I would post the file, but not sure how to do that as it requires a web address.
  • #2
  • Jun 23, 2023 9:14pm Jun 23, 2023 9:14pm
Quoting NoizeUnit
I am trying to create a script that will draw horizontal lines on the high and low of the last candle of the W1, D1 and the Swing High and Swing Low of M15. I seem to be having issues calling my timeframes, if that is even possible .
Very close You don't need to be switching TF

// Calculate the high and low prices of the current week's candle
double weeklyHigh = iHigh(NULL, PERIOD_W1, 0);
double weeklyLow = iLow(NULL, PERIOD_W1, 0);

// Calculate the high and low prices of the current Day's candle
double weeklyHigh = iHigh(NULL, PERIOD_D1, 0);
double weeklyLow = iLow(NULL, PERIOD_D1, 0);

I'm not sure what you are tying to do with the 15min TF code. The way it is, it will show the highest and lowest points on the 15min TF for all bars

Use the same code you have for drawing the lines, and the colors will differentiate between them. The values and lines will stay the same as you change TF. You may find OBJ_TREND cleaner than OBJ_HLINE
  • #3
  • Jun 24, 2023 8:24am Jun 24, 2023 8:24am
Quoting Kafin
{quote} Very close You don't need to be switching TF // Calculate the high and low prices of the current week's candle double weeklyHigh = iHigh(NULL, PERIOD_W1, 0); double weeklyLow = iLow(NULL, PERIOD_W1, 0); // Calculate the high and low prices of the current Day's candle double weeklyHigh = iHigh(NULL, PERIOD_D1, 0); double weeklyLow = iLow(NULL, PERIOD_D1, 0); I'm not sure what you are tying to do with the 15min TF code. The way it is, it will show the highest and lowest points on the 15min TF for all bars Use the same code you have...
Thank you so much for the help. With your help, I got the Weekly and Daily exactly how I want it.

For the M15, I am trying to get the latest Swing High and Swing Low points.
That isn't working yet, but I will keep messing around as I am new to this MQ4 language.
  • #4
  • Jun 24, 2023 9:34am Jun 24, 2023 9:34am
Quoting NoizeUnit
{quote}...I am trying to get the latest Swing High and Swing Low points. That isn't working yet...
Re-read your posted code to see what it is doing, and check the prices of the objects made that use the prices found in it, ie it is working, just not what you expect.

Inserted Code
double swingHigh = High[0];
double swingLow = Low[0];
 
for(int i = 1; i <= Bars; i++) {
    if(High[i] > swingHigh) swingHigh = High[i];
   if(Low[i] < swingLow) swingLow = Low[i];
}

- what you currently have setup, is to find the highest high and lowest low in the entire chart history
- i<=Bars, Bars is not a valid candle index, the candle/array indexes are from 0, up to their quantity -1, ie 100 candles means indexes from 0 to 99, not 100
- the loop has no break so it runs from 1 to the end of the chart
- if you're trying to get the highest high and lowest low of a fixed recent period, eg last 20 candles, then either loop up from 1 to 20 or use ihighest()
  • #5
  • Jun 24, 2023 10:35am Jun 24, 2023 10:35am
Here is what I have and I must still be doing something wrong as this part is still not working.

Inserted Code
// Calculate the high and low prices of the swing high and swing low on M15 timeframe
   
   double swingHigh = iHighest(NULL,PERIOD_M15,MODE_HIGH,20,0);
   double swingLow = iLowest(NULL,PERIOD_M15,MODE_LOW,20,0);

// Draw horizontal lines on the swing high and swing low points for the M15 timeframe
   ObjectCreate("M15SwingHighLine", OBJ_HLINE, 0, Time[0], swingHigh);
   ObjectSet("M15SwingHighLine", OBJPROP_COLOR, DarkTurquoise);
   ObjectSet("M15SwingHighLine", OBJPROP_WIDTH, 1);
   ObjectCreate("M15SwingLowLine", OBJ_HLINE, 0, Time[0], swingLow);
   ObjectSet("M15SwingLowLine", OBJPROP_COLOR, DarkTurquoise);
   ObjectSet("M15SwingLowLine", OBJPROP_WIDTH, 1);

Any idea what I am doing wrong.
I am just learning MQ4, as this is my first script, hence the issues.
  • #6
  • Jun 24, 2023 11:05am Jun 24, 2023 11:05am
Hey NoizeUnit,
In my view the iHighest..etc on 20 last bars may not give you a 'swing high/ low'... May I suggest to first define 'swing high/ low'.. be more specific of how a computer with no eyes would identify that swing... a common way would be to use zigzag... then you can write code to get the last 2 for each side so that you do not need to scan the entire history.. and plot the latest as your line going from the swing to either time of current bar or extend it into the right... best of luck
&quot;Work hard, put in the effort, and follow your dreams...&quot; -Me
  • #7
  • Jun 24, 2023 12:09pm Jun 24, 2023 12:09pm
Quoting NoizeUnit
...I must still be doing something wrong...
Read the documentation, in metaeditor you can highlight the word and press f1 to bring up the doc. ihighest gives you an index value.
https://docs.mql4.com/series/ihighest
  • #8
  • Jun 28, 2023 4:51pm Jun 28, 2023 4:51pm
Is there a way to when you add the horizontal line, it will allow you to add text to the line?
For example, you add a Controlling Swing Low horizontal line on the D1, you can add "D1 CSL"
  • #9
  • Last Post: Jun 29, 2023 8:55pm Jun 29, 2023 8:55pm
Quoting NoizeUnit
...horizontal line, it will allow you to add text to the line?...
In the same way you make the horizontal line, you can make a text object. Look at the documentation for obj_text, give it time and price coords, and a text, when you make the hline.
0 traders viewing now