Calculating Angles | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Trendline Angles 0 replies

Angles & Separation Systems 0 replies

Now it's Angles 1 reply

Calculating rollover 2 replies

Calculating Acc/Dist 12 replies

Calculating Angles

  • #1
  • First Post: May 11, 2007 12:46pm May 11, 2007 12:46pm
I am trying to calculate the angle of a few lines. I got the calculations correct but for some reason I get divide by zero errors can anyone tell me why

here is the code....

PHP Code

  HighStartPoint       = iHigh(Symbol(),0,VectorPer);
  PreviousBarHigh      = iHigh(Symbol(),0,SIGNALCANDLE+1);
  HighestPoint         = High[iHighest(Symbol(),0,MODE_HIGH,VectorPer,SIGNALCANDLE+1)];
  HighestAngle         = MathArctan(MathTan(((HighStartPoint-HighestPoint)/(WindowPriceMax()- WindowPriceMin()))/((VectorPer-SIGNALCANDLE+1)/WindowBarsPerChart())))*180/3.14;
  PreviousHighBarAngle = MathArctan(MathTan(((HighStartPoint-PreviousBarHigh)/(WindowPriceMax()- WindowPriceMin()))/((VectorPer-SIGNALCANDLE+1)/WindowBarsPerChart())))*180/3.14;
  pHighStartPoint       = iHigh(Symbol(),0,VectorPer+1);
  pPreviousBarHigh      = iHigh(Symbol(),0,SIGNALCANDLE+2);
  pHighestPoint         = High[iHighest(Symbol(),0,MODE_HIGH,VectorPer+1,SIGNALCANDLE+2)];
  pHighestAngle         = MathArctan(MathTan(((pHighStartPoint-pHighestPoint)/(WindowPriceMax()- WindowPriceMin()))/((VectorPer+1-SIGNALCANDLE+2)/WindowBarsPerChart())))*180/3.14;
  pPreviousHighBarAngle = MathArctan(MathTan(((pHighStartPoint-pPreviousBarHigh)/(WindowPriceMax()- WindowPriceMin()))/((VectorPer+1-SIGNALCANDLE+2)/WindowBarsPerChart())))*180/3.14;
Keep it simple stoopid....
  • #2
  • May 11, 2007 4:13pm May 11, 2007 4:13pm
do you run the loop through every bar on the chart or start, say 100 bars ago?

because if you are starting at Bars then you will have alot of zeros for:
WindowPriceMax()- WindowPriceMin()



another thing you can try for fail safe is mathmax(WindowPriceMax()- WindowPriceMin(),0.01) or 1 or what ever makes sense.
  • #3
  • May 11, 2007 7:29pm May 11, 2007 7:29pm
= MathArctan(MathTan(((pHighStartPoint-pHighestPoint)/(WindowPriceMax()- WindowPriceMin()))/((VectorPer+1-SIGNALCANDLE+2)/WindowBarsPerChart())))*180/3.14;


I use WindowBarsPerChart(), doesent this return all the bars on the screen ?
Keep it simple stoopid....
  • #4
  • Last Post: May 12, 2007 8:09am May 12, 2007 8:09am
  •  iya
  • | Joined Oct 2006 | Status: always protect yourself | 129 Posts
Try using the dot product to get the cosine between vectors or lines instead of the ugly ArcTan(Tan((b2-b1)/(a2-a1))):

http://upload.wikimedia.org/math/c/3...17c36fd83f.png
http://upload.wikimedia.org/math/6/9...dc2260b972.png
http://upload.wikimedia.org/math/f/5...0eda99656a.png
0 traders viewing now