Menu

Options

Bookmark Thread

First Page First Unread Last Page Last Post

Print Thread

Similar Threads

I will code your pivot EAs for no charge 25 replies

I will code your scalping EAs for no charge 163 replies

Oanda MT4 - Indicators and EAs not showing 2 replies

EAs and indicators relating to moutaki... 22 replies

InterbankFX has loaded its MT4 platform with custom EAs, indicators and scripts 1 reply

Attachments: I will code your EAs and Indicators for no charge
Exit Attachments

I will code your EAs and Indicators for no charge

I'm looking to get a auto trend line coded with alerts and the pip value from the top to the bottom or the bottom to the top depending on which way it's going
Is there anyway we can make it an EA
Quoting Sincere007
{quote} hey bluerain... this zigzag indicator with button is making my mt4 slow even if button is off position... I have like 20 charts. is there anything you can do to fix it or rewrite its button function. original indicator you posted don't have any issues like slowness problem. {file} {file}
In preface, I'm willing to comment on this code, but I've no interest in fixing it myself; nor do I do coding-for-hire projects, as my plate is plenty full of my own.

This is in no way criticism of bluerain, nor any other coder who does provide such modifications. It's "free", appreciated by many, and might still work, but there are drawbacks if the code isn't optimized. When I first learned how to code, I started with existing programs and made modifications as best I knew how, often by following other examples. Unfortunately, a lot of such examples to add on/off buttons is terribly written. Elsewhere, I made some posts (here and here and here ) about the topic and provided an example of "better" written code that is more optimized. I also commented here how different indicators on the same chart can interfere with each other, especially with respect to use of one or more of these in OnInit() :
ChartSetInteger(0,CHART_EVENT_MOUSE_MOVE,1);
ChartSetInteger(0,CHART_EVENT_OBJECT_CREATE,1);
ChartSetInteger(0,CHART_EVENT_OBJECT_DELETE,1);


The primary reason that most 'BT' (on/off button) modified code is slow is because the 'OnChartEvent' function is poorly written with little understanding of what it does. From this indicator:
Inserted Code
init()
{  ...
   ChartSetInteger(0,CHART_EVENT_MOUSE_MOVE,1);
}
 
void OnChartEvent(const int id, const long &lparam, const double &dparam, const string &sparam)      
{  
   setGlobal(0,PrefBT);  
  
   if (id==CHARTEVENT_OBJECT_CLICK)  //&& ObjectGet(sparam,OBJPROP_TYPE)==OBJ_BUTTON)
     if (sparam==PrefBT) { downloadhistory=false; Started=true; /*init();*/ start(); }
    
   if (buttON[0])  ObjectSetInteger(0,PrefBT,OBJPROP_COLOR,buttColor);
   else {          ObjectSetInteger(0,PrefBT,OBJPROP_COLOR,clrBlack);   InitZero(0); }   ChartRedraw(0);
}

The most obvious reason this code is slow is because "ChartRedraw(0);" is outside of every if/then/else condition, therefore it runs EVERY time there is ANY chart event!

Since this program has enabled CHART_EVENT_MOUSE_MOVE, just moving the mouse anywhere over the chart generates 100's of "id" events per move. (One could momentarily add 'Alert(id);' into the OnChartEvent code and just observe how huge the number of events is).

Even if this program had not enabled the mouse events, if any OTHER indicator on the same chart enables it, it will affect this (and every) program with an OnChartEvent section. Therefore, each indicator must be properly optimized, even if just to filter away the unwanted events.

The call to "setGlobal(0,PrefBT);" is also inefficient since it is also called for EVERY chart event also. It's not going to be as slow as "ChartRedraw(0);", but it's still a bad practice to run any commands unnecessarily. Better to qualify it and limit it to the specific "id" events that would cause the button to change status.

That said, I'm not a fan myself of using "GlobalVariableSet" to store the status of a chart-specific button. When I click on a button in one chart, my preference is to only affect the chart I'm looking at, and not the other charts with the same indicator. My code examples posted elsewhere have additional comments on this.

Although you have "start();" called by OnChartEvent, at least it is limited to running when a specific button object is pressed. You code seems ok for this, but I mention this because I've seen lots of other BT code that runs "start();" every single event, which is terrible for performance. (FYI, better to create a differently named function that is called by start() and/or OnChartEvent. It's just better practice not to call "start()" directly, and would be more forward compatible with MT4's current focus on using "OnCalculate(...) {...}" )


Writing this has already taken more time than I intended, but if you follow the links you'll get more information how to improve your BT code. No PM's please... I'm getting back to my own coding projects now.

Good luck.
Quoting inversio
{quote} that's really helpful, and I setup the function according to my need, if its not more do u have any script or ea which will close all order on current chart. i used one before but not singing on my PC may be deleted. thanks again for pending order ea. great help. cheers
This script will close all open orders in FIFO manner. Not pending orders.
Attached File(s)
File Type: mq4 Close-All-FIFO.mq4   2 KB | 258 downloads
Quoting Sincere007
{quote} hey bluerain... this zigzag indicator with button is making my mt4 slow even if button is off position... I have like 20 charts. is there anything you can do to fix it or rewrite its button function. original indicator you posted don't have any issues like slowness problem. {file} {file}
Those indicators are not mine and I just had this in my ZigZag folder.
Some Russian programmer seems to added extra button to original code which seems a bit complicated way of handling.
Quoting pips4life
{quote} In preface, I'm willing to comment on this code, but I've no interest in fixing it myself; nor do I do coding-for-hire projects, as my plate is plenty full of my own. This is in no way criticism of bluerain, nor any other coder who does provide such modifications. It's "free", appreciated by many, and might still work, but there are drawbacks if the code isn't optimized. When I first learned how to code, I started with existing programs and made modifications as best I knew how, often by following other examples. Unfortunately, a lot of...
Not sure why you name "bluerain" - Those two indicators are not mine.
If you see those comments inside of BT mod version, it was done by some Russian programmer.
I hardly do any Button On/Off - if at all.

Since it seems your comments are geared into other programmer, it seems you are just show casing how smart you are.
What you are saying is "I know better than you but I won't do anything" in public.

if you don't want to do anything.. just stay away.

this thread is not "I can do better but I won't do anything" thread.
This thread is to help other "FF" members as much as you can.. not your show case.
Quoting BlueRain
{quote} This script will close all open orders in FIFO manner. Not pending orders. {file}

Sorry BlueRain if it feels like I'm picking on you; I'm not intending to, especially since you are sharing freely.

The Close-All-FIFO.mq4 you posted is definitely not a true FIFO closer. It doesn't actuallly sort the list of orders by 1st priority Open-Dt, then 2nd priority by Order#.

Mine -- which is itself a modification of one written by Nicholishen -- is posted here as "FIFO_CloseAll_Options.mq4"
Quoting pips4life
{quote} Sorry BlueRain if it feels like I'm picking on you; I'm not intending to, especially since you are sharing freely. The Close-All-FIFO.mq4 you posted is definitely not a true FIFO closer. It doesn't actuallly sort the list of orders by 1st priority Open-Dt, then 2nd priority by Order#. Mine -- which is itself a modification of one written by Nicholishen -- is posted here as "FIFO_CloseAll_Options.mq4"
I don't write everything I post - it was from some other thread I picked up and it worked fine in my trading.
And I just upload as it seems fitting to what is asked.

if you see the code, it has name

#property copyright "Matus German"

Not sure what is your intention is...
Worst kind of people in my career was those who just criticize and don't contribute.
Quoting BlueRain
{quote} I don't write everything I post - it was from some other thread I picked up and it worked fine in my trading. And I just upload as it seems fitting to what is asked. Not sure what is your intention is... Worst kind of people in my career was those who just criticize and don't contribute.
I only mentioned you because the previous poster (Sincere007) had said the indy you posted had hugely slowed down his MT4, and he was asking if you could fix it. I didn't know you hadn't done the modification yourself, so, my apology for that.

I took some time to look at the code, and pointed out some of the obvious deficiencies. Even if I didn't fix it, is that not a contribution?

While I was composing my next reply, you posted the mislabeled script, Close-All-FIFO.mq4, which is most definitely NOT FIFO compliant. I provided a link to my own (a previous contribution, obviously).

My intention was and is to be helpful to other traders, to point out some of the code problems, and sometimes post actual code for traders. There are many 1000's of people who don't themselves code, and some PM me for help, which I just don't have the bandwidth for. My comment to not PM me is just to minimize the inevitable requests that I am too busy to do.

You wrote: "Not sure what is your intention is... Worst kind of people in my career was those who just criticize and don't contribute."

You should have stopped with not being sure what my intention was. By posting as many details as I did, it is more like "teaching a man to fish" who can then eat for life. You, on the other hand, took offense where none was intended. And though you mean well, some of the code you are posting would be better left unshared if it doesn't work properly and/or causes other problems.

I won't be commenting to you further. Welcome to my Ignore list...
Quoting pips4life
{quote} I only mentioned you because the previous poster (Sincere007) had said the indy you posted had hugely slowed down his MT4, and he was asking if you could fix it. I didn't know you hadn't done the modification yourself, so, my apology for that. I took some time to look at the code, and pointed out some of the obvious deficiencies. Even if I didn't fix it, is that not a contribution? While I was composing my next reply, you posted the mislabeled script, Close-All-FIFO.mq4, which is most definitely NOT FIFO compliant. I provided a link to my...
I get really offended when I got blamed for something I didn't do.

You are the one who started this with incorrect information.
You could have just said "I looked into the code and it seems this is not right and correct way of doing is this"

You were critical to me as well as other developers who are just trying to help.

I maybe not as smart as you are But I don't criticize other people. Regardless, we are all just living day to day.

As you wish, I will start ignoring you also.
Quoting pips4life
{quote} ...a lot of such examples to add on/off buttons is terribly written...I made some posts (here and here and here ) about the topic and provided an example of "better" written code...
I disagree with some points and some approaches you have, but of course there are many ways to skin a cat.

I do agree that many on/off btn modifications are questionable. From what I recall and glad to be corrected, banzaifx started the indicator-on/off thread in this subforum, and is continued by tankk, both do valuable work but this on/off stuff is iffy. Their approach is done by copy-pasting blocks of code that rely on older pre-600 event functions, that are easy to call, but of course event functions shouldn't be called by the user. There's additional unnecessary actions happening, and sometimes the start function is prevented from running which is needed in some indicators. So there's stuff happening all over the place, btn states, global variables, calling event functions, all the while object/buffer visibility is never actually being handled directly.
Quoting BlueRain
{quote} This script will close all open orders in FIFO manner. Not pending orders. {file}

thanks again
Could one coder pls rewrite/convert this tool for MT5
Attached File(s)
File Type: ex4 SR_Equal_HL.ex4   21 KB | 364 downloads
Hi pips4life,

I am a button Nut I am always looking for better ways to add them to my Experts.
Thank you for your post much respect.

Cheers
Roddo
Hi pips4life.
Can you make repaint indicator for high and low in "x" bars in the current timeframe?
Quoting rayscentro
Is there anyway we can make it an EA
How would a ea work compared to the actual indicator? I haven't messed with eas before..
Quoting Sincere007
{quote} hey bluerain... this zigzag indicator with button is making my mt4 slow even if button is off position... I have like 20 charts. is there anything you can do to fix it or rewrite its button function. original indicator you posted don't have any issues like slowness problem. {file} {file}
Hi Sincere007 try this . max tf = w1 . not perfect but I think it can use.
Attached Image(s) (click to enlarge)
Click to Enlarge Name: 2022-08-16_104124.jpg Size: 172 KB
Click to Enlarge Name: 2022-08-16_105716.jpg Size: 453 KB
Attached File(s)
File Type: ex4 ZZ_Fractal_Value-BT.ex4   61 KB | 336 downloads
Quoting bingo2015
{quote} hi Tintep I want to send photos and notifications to telegram , if possible, please help me with the code I need an indicator when the price touches the trendline, the indicator will send a photo and notify about telegram can you help me. I will be very happy for that hi {file}
Hi bingo2015 . ok I will made for you . It need 2 things "ChatID and BotToken" you send 1 things to me ChatID or BotToken. and PM me it have little trick for do that.
Good day house,

Can anyone here recommend a good a d free or open source Telegram tool that will send notification from my MT4 to telegram when ever I get an alert.

Thanks...
Live and Let Live
Quoting tintep
{quote} Hi bingo2015 . ok I will made for you . It need 2 things "ChatID and BotToken" you send 1 things to me ChatID or BotToken. and PM me it have little trick for do that.
Please sir, I am interested in this tool
Live and Let Live
29 traders viewing now, 2 are members:
,
deepakmadan