Need someone to shed some light on a programming issue | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Need help programming some indicators/EAs 67 replies

I need some easy programming work done 0 replies

Looking for someone familiar with programming expert advisors for MT4... 6 replies

Programming question ( give me some advices ) 2 replies

I need someone to make me some EA 2 replies

Need someone to shed some light on a programming issue

  • #1
  • First Post: Edited 7:24pm Nov 14, 2006 6:00pm | Edited 7:24pm
Hi,

I have two things happening and would really appreciate it if someone know why it happens and how to over come it.

At times when I'm comparing to equal values, the conditions files

e.g:

/*the values that I'm comparing are dynamic, but I'm printing them out and printing out the condition results and at times it fails*/

val1 = 0.01;
val2 = 0.01;
/*at times this if condition fails*/
if(val1 == val2)
{
}

Second Issue: SOLVED

Thanks for any help.
Saaedb.
  • #2
  • Nov 14, 2006 6:16pm Nov 14, 2006 6:16pm
I think the first one might be a mt bug. there is a post on the meta quotes forum similar to this.
  • #3
  • Nov 14, 2006 6:35pm Nov 14, 2006 6:35pm
This is just a shot in the dark but wouldn't you need to tell it what the "IsActiveLongPostion" is not equal to? Shouldn't it be more like this?

if(var == 1)
{
if(X!=IsActiveLongPostion && var2 >= varCont)
{

CloseAllSellTrades();

if(IsTradingTime())
{
BuySignalGenerated();
}

}
}
  • #4
  • Nov 14, 2006 6:42pm Nov 14, 2006 6:42pm
Quoting aicccia
This is just a shot in the dark but wouldn't you need to tell it what the "IsActiveLongPostion" is not equal to? Shouldn't it be more like this?

if(var == 1)
{
if(X!=IsActiveLongPostion && var2 >= varCont)
{

CloseAllSellTrades();

if(IsTradingTime())
{
BuySignalGenerated();
}

}
}
Thats a Bool
  • #5
  • Nov 14, 2006 6:43pm Nov 14, 2006 6:43pm
Quoting thebts
I think the first one might be a mt bug. there is a post on the meta quotes forum similar to this.
Hope its not, coz it makes things very inconsistant.
  • #6
  • Nov 14, 2006 7:08pm Nov 14, 2006 7:08pm
Just a quick note about the first one. I never use == comparison for "double" type. It's better to define a threshold. For example if "var1-var2 <= 0.001". "double" type parameters are usually very tricky.
  • #7
  • Nov 14, 2006 7:15pm Nov 14, 2006 7:15pm
Quoting aparsai
Just a quick note about the first one. I never use == comparison for "double" type. It's better to define a threshold. For example if "var1-var2 <= 0.001". "double" type parameters are usually very tricky.
Aparsai, actually I am doing

if(dblVal1 - dblVal2 >= ThreshHold)

and I've also tried spillting the greater then and equal to into two if conditions.

I've been programming for over 8 years, so I'm sure I'm not doing something silly. Its either a bug in MT or its something about MTs control flow that I dont know about.

And that issue is intermittent. Out of every 50 checks, a couple might fail.
  • #8
  • Nov 14, 2006 7:28pm Nov 14, 2006 7:28pm
Quoting saaedb
Aparsai, actually I am doing

if(dblVal1 - dblVal2 >= ThreshHold)

and I've also tried spillting the greater then and equal to into two if conditions.

I've been programming for over 8 years, so I'm sure I'm not doing something silly. Its either a bug in MT or its something about MTs control flow that I dont know about.

And that issue is intermittent. Out of every 50 checks, a couple might fail.
I might be very picky but MT4 apparently is very sensitive to the use of paranthesis. I would suggest to add a pair of paranthesis as follows:

if((dblVal1 - dblVal2) >= ThreshHold)

BTW, I placed that comment based on the info you provided. I'm doing the same based on what you've typed.

Good Luck,
Al
  • #9
  • Nov 14, 2006 7:39pm Nov 14, 2006 7:39pm
Quoting aparsai
I might be very picky but MT4 apparently is very sensitive to the use of paranthesis. I would suggest to add a pair of paranthesis as follows:

if((dblVal1 - dblVal2) >= ThreshHold)

BTW, I placed that comment based on the info you provided. I'm doing the same based on what you've typed.

Good Luck,
Al
the parenthesis are there, and like I said, its intermitent.
Here, try running this ona one min chart

Alert("MathAbs ",MathAbs(Open[1] - Close[1])," Open ",Open[1]," Close ",Close[1]," Condition ", MathAbs(Open[1] - Close[1]) >= 1*Point);
if(MathAbs(Open[1] - Close[1]) >= 1*Point)
{
Alert("Here");
}

I'm doing the same for testing and atleast once every 30 mins its misses the check.

My actual condition looks something like

Val1 = 1.800
Val2 = 1.799

ThreshHold = 1

if(MathAbs(Val1 - Val2) >= MathAbs(ThreshHold*Point))
{

}

The only issue here could be, that I'm setting the ThreshHold value in the Input tab of the EA's Properties.
  • #10
  • Nov 14, 2006 8:08pm Nov 14, 2006 8:08pm
Quoting thebts
I think the first one might be a mt bug. there is a post on the meta quotes forum similar to this.
not a bug, just floating point.

Just google for "comparing doubles" for more info.
  • #11
  • Nov 14, 2006 8:26pm Nov 14, 2006 8:26pm
Quoting ycomp
not a bug, just floating point.

Just google for "comparing doubles" for more info.
Normalizing the Doubles takes care of the issue you're talking about. And I'm normalizing them.
  • #12
  • Nov 16, 2006 9:05am Nov 16, 2006 9:05am
Quoting saaedb
Normalizing the Doubles takes care of the issue you're talking about. And I'm normalizing them.
Some ideas

- Multiply by a power of ten 10 (if you know exactly how many decimal places and do what ever you want to do in integer arithmetic.
- Transform it to string and compare the part you want
  • #13
  • Last Post: Nov 16, 2006 9:43am Nov 16, 2006 9:43am
Quoting chipstan
Some ideas

- Multiply by a power of ten 10 (if you know exactly how many decimal places and do what ever you want to do in integer arithmetic.
- Transform it to string and compare the part you want
Right now, I'm dividing it by Point to get by this issue. But still, it would be nice to know if thats a bug in MQL or was I missing something.
0 traders viewing now