Help adding a take profit function to this EA | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

required to function call function 2 replies

I need help adding a trailing stoploss function 1 reply

help adding alert function to MACD indicator 0 replies

Adding icustom function parameters to SHI Channel EA 0 replies

stop loss function and edit time function for Breakout EA 1 reply

Attachments: Help adding a take profit function to this EA
Exit Attachments

Help adding a take profit function to this EA

  • #1
  • First Post: Dec 17, 2021 6:26am Dec 17, 2021 6:26am
I hope your help to this Ea. It have to be as it is. Just I want a close all position after reaching a user-defined profit. So if the trades that are open acheave specific percentage or amount of profit it have to close all the open positions so the cycle can begin from start. So it is not just close all and wait for the user to start it agian. It have to close all position then start the trading again with same parameters of course.

I hope for your help.
Attached File(s)
File Type: ex4 Jupiter_M._v.4.1.1_eng.ex4   81 KB | 226 downloads
File Type: mq4 Jupiter_M._v.4.1.1_eng.mq4   79 KB | 267 downloads
  • #2
  • Dec 18, 2021 4:15am Dec 18, 2021 4:15am
I hope your help here dear coders. I will highly appreciate it.
  • #3
  • Dec 19, 2021 2:13am Dec 19, 2021 2:13am
Ok I thought to add such a function to this ea is very simple. But of course I will think that since I have no idea about coding. I still hope if there are anyone that will help me with this.
  • #4
  • Dec 19, 2021 3:38am Dec 19, 2021 3:38am
do you want a hard TP or a virtual one ?
  • #5
  • Dec 19, 2021 4:12am Dec 19, 2021 4:12am
Quoting ionone
do you want a hard TP or a virtual one ?
A virtual one. You know when a cycle of trading begin, so if it generate a specific percentage or specific amount, it have to close all, so the cycle begin again.
  • #6
  • Dec 19, 2021 4:28am Dec 19, 2021 4:28am
Quoting aalaarajy
{quote} A virtual one. You know when a cycle of trading begin, so if it generate a specific percentage or specific amount, it have to close all, so the cycle begin again.
Inserted Code
extern int TP = 500;
extern int Magic = 123;
void VirtualTP()
{
   for (int i=0; i<OrdersTotal(); i++) 
   {  
      if (OrderSelect(i, SELECT_BY_POS)==true)
      {  
         if (OrderSymbol()==Symbol() && OrderMagicNumber()==Magic)
         {
            int type = OrderType();
            double c0 = iClose(NULL,0,0);
             switch(type)
             {    
               //Close opened long positions
               case OP_BUY       : if (c0 > OrderOpenPrice() + TP * Point)
                                       int result = OrderClose(OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_BID), 5, Red );
                                   break;         
               
               //Close opened short positions
               case OP_SELL      : if (c0 < OrderOpenPrice() - TP * Point)
                                       int result = OrderClose(OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_ASK), 5, Red );
                                   break;         
             } 
         }
      }
   }   
}
  • #7
  • Dec 19, 2021 4:57am Dec 19, 2021 4:57am
[quote=ionone;13830424

Thanks so much for your time and help. I am though without any knowledge about coding that I dont know where to put this code in the EA. I tryed to copy and paste it in the end of the code, and the EA after saving it began to not work. And also I tryed to insert it in the begining with same result. Maybe I should remove or add something to the code??? I hope you will add the code for me???
  • #8
  • Dec 19, 2021 5:24am Dec 19, 2021 5:24am
[quote=aalaarajy;13830432][quote=ionone;13830424 Thanks so much for your time and help. I am though without any knowledge about coding that I dont know where to put this code in the EA. I tryed to copy and paste it in the end of the code, and the EA after saving it began to not work. And also I tryed to insert it in the begining with same result. Maybe I should remove or add something to the code??? I hope you will add the code for me???[/quote]
try this
Attached File(s)
File Type: mq4 Jupiter_M._v.4.1.1_eng (1).mq4   80 KB | 389 downloads
  • #9
  • Dec 19, 2021 1:14pm Dec 19, 2021 1:14pm
[quote=ionone;13830407

I am really thankful for the efferts you have put into it. It worked with me, but the problem is that is dealing with the tp only if you have enabled the "use averiging" function. If I disable it and the EA begin to just open trades and take every tp independently the code you added will not understand. It begin to teal with every trade separretly. I hope you will add a code that will calculate the balnce and then see if the user-defined percentage or amount is acheaved then it have to wipe all trades so the cycle can begin again.

I hope this is possible and easy to do, and that you have time to put into it.
  • #10
  • Dec 25, 2021 7:51am Dec 25, 2021 7:51am
Let me express my thanks and apreciation for your work and time ionone, but I am still need a function in this EA that will close all trades when a specific profit is reached. I dont know why the code you added do not work when we choose the false mode of the use averige of the trading, but I think this is because than the EA begin to deal with every trade on its own and not connected to the other trades. So I think the function have to look after the equity in somehow perspective. So when the equity have reached the user desired level then it closes all the trades that are open

I hope you have more time you can waste for me, or any one that know how this can be done.

Thanks in advance, and happy chrismass
  • #11
  • Edited 4:23am Dec 26, 2021 4:13am | Edited 4:23am
Why not solve with a second EA in another chart window?
In this second EA you can select the amount, if reached all orders will be closed. What do you mean - would this suits your needs?

It will only work on open market - not in test modus.
Attached File(s)
File Type: ex4 Mannage_Account_Profit.ex4   33 KB | 320 downloads
File Type: mq4 Mannage_Account_Profit.mq4   41 KB | 426 downloads
  • #12
  • Dec 26, 2021 6:21am Dec 26, 2021 6:21am
[quote=kofix11;13837221]

Thanks for your input. Yes it could be a good solution, but I want to backtest the idea itself since I do not have any imagining about what and how it will turn out to be. Also I like to make many modifications and shanges.
  • #13
  • Dec 28, 2021 6:27am Dec 28, 2021 6:27am
I hope you all have had a happy chrismass, and good days with your families and loved ones.
I just wanted to ask further if anyone can modify this ea so it can close all trades after a specific porfit acheaved. It have to be even when we choose the false state of the averige trading, so the ea will open trade and take profit for each trade seperately. Even in such state I will have the ea close all trades when the overall trading have added specific profit to the account.
  • #14
  • Jan 8, 2022 3:46am Jan 8, 2022 3:46am
Sorry, is there anyone that have knowledge about coding that have time to spend on this EA? I hope so
  • #15
  • Jan 9, 2022 7:29am Jan 9, 2022 7:29am
Quoting aalaarajy
Sorry, is there anyone that have knowledge about coding that have time to spend on this EA? I hope so
yes please .... how can i help you
  • #16
  • Jan 13, 2022 8:57am Jan 13, 2022 8:57am
[quote=kalyanashrir;13850711]{quote

Sorry I didn't see your post until now.

I need a close-all after reaching specific percentage of the profit for the EA I have attached in the first post.

I need the EA to close all the trade and then start over after the user defined equity percentage.

I hope anyone that can do this to add it. I will apereciate it.
  • #17
  • Jan 14, 2022 10:21am Jan 14, 2022 10:21am
I need the close all after specific equity percentage added to the EA because it will let me backtest many of the idea I have in mind. So I hope your help
  • #18
  • Jan 17, 2022 6:20am Jan 17, 2022 6:20am
It is the Ea I have attached in the first post. But let me add it here again in this post in case of you that will not scroll back.
Attached File(s)
File Type: mq4 Jupiter_M._v.4.1.1_eng (1).mq4   80 KB | 214 downloads
  • #19
  • Jan 29, 2022 5:28am Jan 29, 2022 5:28am
I still hope someone is here helping me out with it.
  • #20
  • Last Post: Feb 8, 2022 12:26pm Feb 8, 2022 12:26pm
I am despite of I have moved on to other ideas still hope that anyone will be kind and put the function that I have described to this ea.
0 traders viewing now