Zero Divide Error: (2216,68), why? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Divide by zero error? 2 replies

Zero Divide Error 4 replies

Zero Divide error? Where do I need to look to fix it? 28 replies

Zero Divide error coding conundrum 3 replies

Zero Divide Error 5 replies

Zero Divide Error: (2216,68), why?

  • #1
  • First Post: Edited 4:21am Dec 11, 2021 3:06am | Edited 4:21am
Hi coders, seeking for your help. Sorry, the subject title above is wrong (cannot be amended), but it should be "Output = 0 Without a Value"

I have two loops to calculate.

Inserted Code
   int cnBars=0; for(int i=AA; i>=BB; i--) {
   double Hi=iHigh(symbol,5,i), Lo=iLow(symbol,5,i);
   if(Hi>=Lo) cnBars++;
   }
   // to count total number of bars for a length from shift AA to BB backward
   // No worry, I do understand that AA-BB+1 would be the total number of
   // bars, but this loop is just for illustration only
 
   int cnRedBars=0; for(int i=AA; i>=BB; i--) {
   double Op=iOpen(symbol,5,i), Cs=iClose(symbol,5,i);
   if(Op>=Cs) cnRedBars++;
   } // to count number of Red bars for a length from shift AA to BB backward

When come to signal stage, I want to get the ratio by a division, so that I can use this ratio for other purposes, let's say I want to have 90% of red bars out of total bars to get a signal :-

Inserted Code
cnRedBars / cnBars >= 0.9 // (signal stage)
 
{Alert(symbol+" Red Bars Ratio : "+DoubleToStr(cnRedBars/cnBars,3));}

Now, the output message appeared to be ZERO, why ? Any solution ?

Is it due to problem of both cnBars and cnRedBars are integer values, therefore the MT4 terminal cannot recognise a int / int >= 0.9, ended up with a Zero ? Any solution so that a ratio value can be alerted ? Thanks
  • #2
  • Dec 11, 2021 11:35am Dec 11, 2021 11:35am
I think you're holding yourself back by constantly asking questions that you can figure out. If you know what an int is, then you probably know what a double is, you could use a double to see if there is any difference, and if you dont know what a double is, then you could still replace the variables with actual numbers, decimal or not and see if there is any difference. This is is basic debugging/investigating/googling that you're refusing to do, and that holds you back.
  • #3
  • Dec 12, 2021 1:19am Dec 12, 2021 1:19am
Quoting jeanlouie
I think you're holding yourself back by constantly asking questions that you can figure out. If you know what an int is, then you probably know what a double is, you could use a double to see if there is any difference, and if you dont know what a double is, then you could still replace the variables with actual numbers, decimal or not and see if there is any difference. This is is basic debugging/investigating/googling that you're refusing to do, and that holds you back.
Hi Jean, thanks, I'll try double next trading day, perhaps it should work. I did googled int / int but cannot find any relevant solution.
  • #4
  • Dec 12, 2021 4:41pm Dec 12, 2021 4:41pm
1. You can see from the code that 'cnBars' is declared and used as an integer. Casting it as a double not only doesn't make sense, it won't make any difference when executing.

2. The expression 'cnRedBars / cnBars' blows up and gives the 'Divide By Zero' error because in algebra you can't divide by '0'. Dividing by '0' gives the result of INFINITY, which is not defined. So, the solution: Do not divide by '0'. In your 'for' loop check whether 'cnBars' is '0' -- if not, then proceed with subsequent calculations. Otherwise, skip the current iteration or break-out of the 'for' loop.

You only showed a small snippet of your code, so I can only guess what you are doing, but it could go something like this:

for (int i = limit-1; i >= 0; i--)
{
.... // some code

// Check for divide by zero...
if (0 == cnBars)
continue;

.... // more code
}


If the 'for' loop counts down, then use 'continue' to skip the current iteration...
If the 'for' loop counts up, then use 'break' to break-out of the 'for' loop...
  • #5
  • Last Post: Dec 13, 2021 9:36am Dec 13, 2021 9:36am
Quoting robots4me
1. You can see from the code that 'cnBars' is declared and used as an integer. Casting it as a double not only doesn't make sense, it won't make any difference when executing. 2. The expression 'cnRedBars / cnBars' blows up and gives the 'Divide By Zero' error because in algebra you can't divide by '0'. Dividing by '0' gives the result of INFINITY, which is not defined. So, the solution: Do not divide by '0'. In your 'for' loop check whether 'cnBars' is '0' -- if not, then proceed with subsequent calculations. Otherwise, skip the current iteration...
Hi Robots4me, noted with thanks.
0 traders viewing now