Need Help : Merge 2 Loops into 1 Loop

Quoting fxanalysis

Disliked

just added break; in one more place. Originally it was not needed there, as the code was made to be in one loop only, but now because there is a second loop it is needed to stop the second loop. int minGrn=3; // (changed) int MAStrSf=0; int MAEndSf = 0; int cnGrn=0; bool checkStart=false; bool signalFound=false; for(int i=1; i<=600; i++) { double MA0=iMA(symbol,5,5,0,3,0,i), MA1=iMA(symbol,5,5,0,3,0,i+1); double MA2=iMA(symbol,5,5,0,3,0,i+2), MA3=iMA(symbol,5,5,0,3,0,i+3); if(!checkStart){ if(MA0>MA1 && MA1<=MA2 && MA2<=MA3) { MAStrSf=i; // MA 2-drop...

Ignored

   int minGrn=3; // (changed)
   int MAStrSf=0;
   int MAEndSf = 0;
   int cnGrn=0;
   bool checkStart=false;
   bool signalFound=false;
 
   for(int i=1; i<=600; i++) {
   double MA0=iMA(symbol,5,5,0,3,0,i), MA1=iMA(symbol,5,5,0,3,0,i+1);
   double MA2=iMA(symbol,5,5,0,3,0,i+2), MA3=iMA(symbol,5,5,0,3,0,i+3);
   if(!checkStart){
      if(MA0>MA1 && MA1<=MA2 && MA2<=MA3) {
         MAStrSf=i; // MA 2-drop 1-Up
         checkStart=true;
         Print("Start = ",i);
         }
      }
   else //check start=true
      for(int cn=i; cn>=4; cn--) {
      double Op0=iOpen(symbol,5,cn), Cs0=iClose(symbol,5,cn);
      double ATR0=iATR(symbol,5,5,cn), cMA0=iMA(symbol,5,5,0,3,0,cn); // (changed)
      double cMA1=iMA(symbol,5,5,0,3,0,cn+1), cMA2=iMA(symbol,5,5,0,3,0,cn+2); // (changed)
      if(!(cMA0<cMA1 && cMA1<=cMA2)) { // (changed)
         if(Cs0-Op0>=ATR0*0.8) { // (changed)
            cnGrn++;
            }
            }
         else { // END OF TREND
         MAEndSf=cn;
         Print("End = ",cn);
         if(cnGrn>=minGrn) {
            signalFound=true;
            break;
            }
            else {
            checkStart=false;
            cnGrn=0;
            MAStrSf=0;
            MAEndSf=0;
            break;
            }
         } // Count No. of Big Green bars and stops at next MA 2-drop
        
      if(cn==4 && checkStart){
      checkStart=false; cnGrn=0; MAStrSf=0;MAEndSf=0;}
      }
   if(signalFound) break;
   }

   int minGrn=3; // (changed)
   int MAStrSf=0;
   int MAEndSf = 0;
   int cnGrn=0;
   bool checkStart=false;
   bool signalFound=false;
 
   for(int i=1; i<=600; i++) {
   double MA0=iMA(symbol,5,5,0,3,0,i), MA1=iMA(symbol,5,5,0,3,0,i+1);
   double MA2=iMA(symbol,5,5,0,3,0,i+2), MA3=iMA(symbol,5,5,0,3,0,i+3);
   if(!checkStart){
      if(MA0>MA1 && MA1<=MA2 && MA2<=MA3) {
         MAStrSf=i; // MA 2-drop 1-Up
         checkStart=true;
         Print("Start = ",i);
         }
      }
   else //check start=true
      for(int cn=i; cn>=4; cn--) {
      double Op0=iOpen(symbol,5,cn), Cs0=iClose(symbol,5,cn);
      double ATR0=iATR(symbol,5,5,cn), cMA0=iMA(symbol,5,5,0,3,0,cn); // (changed)
      double cMA1=iMA(symbol,5,5,0,3,0,cn+1), cMA2=iMA(symbol,5,5,0,3,0,cn+2); // (changed)
      if(!(cMA0<cMA1 && cMA1<=cMA2)) { // (changed)
         if(Cs0-Op0>=ATR0*0.8) { // (changed)
            cnGrn++;
            }
            }
         else { // END OF TREND
         MAEndSf=cn;
         Print("End = ",cn);
         Print("Candle count = ",cnGrn);
         if(cnGrn>=minGrn) {
            signalFound=true;
            break;
            }
            else {
            checkStart=false;
            cnGrn=0;
            MAStrSf=0;
            MAEndSf=0;
            break;
            }
         } // Count No. of Big Green bars and stops at next MA 2-drop
        
      if(cn==4 && checkStart){
      checkStart=false; cnGrn=0; MAStrSf=0;MAEndSf=0;}
      }
   if(signalFound) break;
   }

Quoting fxanalysis

Disliked

you can also check the candle count for strong bars. Added Print("Candle count = ",cnGrn); int minGrn=3; // (changed) int MAStrSf=0; int MAEndSf = 0; int cnGrn=0; bool checkStart=false; bool signalFound=false; for(int i=1; i<=600; i++) { double MA0=iMA(symbol,5,5,0,3,0,i), MA1=iMA(symbol,5,5,0,3,0,i+1); double MA2=iMA(symbol,5,5,0,3,0,i+2), MA3=iMA(symbol,5,5,0,3,0,i+3); if(!checkStart){ if(MA0>MA1 && MA1<=MA2 && MA2<=MA3) { MAStrSf=i; // MA 2-drop 1-Up checkStart=true; Print("Start = ",i); } } else //check start=true for(int cn=i; cn>=4; cn--)...

Ignored

Quoting fxanalysis

Disliked

1) no 2) no the reason why I used 4 is is beacause of iMA shift being i-3, minGrn is not even anywhere in the picture in this case

Ignored

  double Hg0 = iHigh (_Symbol, 5, сп), 
         Lw0 = iLow  (_Symbol, 5, сп), 
         Cs0 = iClose(_Symbol, 5, сп); 
  //---
  //---
        if(Hg0-Cs0 < Cs0-Lw0) // bar UP
          {
          if (Cs0-Lw0 > = ATR0 * 0.8)
              cnGrn_up ++;
          }
          else { // bar DN
                 if (Hg0-Cs0 > = ATR0 * 0.8)
                    cnGrn_dn ++;
               }

Quoting forex-wolf

Disliked

I certainly don't know the logic behind your code. I would try to do this part like this. This is such a simple suggestion to think about. double Hg0 = iHigh (_Symbol, 5, сп), Lw0 = iLow (_Symbol, 5, сп), Cs0 = iClose(_Symbol, 5, сп); //--- //--- if(Hg0-Cs0 < Cs0-Lw0) // bar UP { if (Cs0-Lw0 > = ATR0 * 0.8) cnGrn_up ++; } else { // bar DN if (Hg0-Cs0 > = ATR0 * 0.8) cnGrn_dn ++; }

Ignored

Quoting fxanalysis

Disliked

1) no 2) no the reason why I used 4 is is beacause of iMA shift being cn-3, minGrn is not even anywhere in the picture in this case

Ignored

。
。
。
            else {
            checkStart=false;
            cnGrn=0;
            MAStrSf=0;
            MAEndSf=0;
            break;
            }

Quoting chimoong

Disliked

{quote} Why output is yet 0 || 0 despite there are yet 600 bars to run ? From my understanding about your codes, kindly look below :- 。 。 。 else { checkStart=false; cnGrn=0; MAStrSf=0; MAEndSf=0; break; } Please look at pic https://www.forexfactory.com/attachm...3&d=1638614442 , if at shift "A" found out that it is not a MAStrSf (not a complete set-up), based on the codes above, it will set the MAStrSf to 0, means it will start looping from bar1 again, am I right ? If yes, that's why the output...

Ignored

 
   int MAEndSf=0;
   int MAStrSf=0;
   int cnGrn=0;
   int minGrn=4;
   bool trendEnd=false;
   bool trendStart=false;
   for(int i=3;i<2000;i++)
      {
      //First find the end of trend
    
      if(!trendEnd)
         {
         double MA0=iMA(symbol,5,5,0,3,0,i), MA1=iMA(symbol,5,5,0,3,0,i-1);
         double MA2=iMA(symbol,5,5,0,3,0,i-2);//, MA3=iMA(symbol,5,5,0,3,0,i+3);
         if(MA0>=MA1 && MA1>MA2)//End of trend
            {
            MAEndSf=i;
            trendEnd=true;
            Print("trend end = ",i);
            //Check last bar
            double Op0=iOpen(symbol,5,i), Cs0=iClose(symbol,5,i);
            double ATR0=iATR(symbol,5,5,i);
            if(Cs0-Op0>=ATR0*0.8) cnGrn++;
            
            }
         }
      else// trend end found
         {
         //Now look for strong bars and trend start
         double Op0=iOpen(symbol,5,i), Cs0=iClose(symbol,5,i);
         double ATR0=iATR(symbol,5,5,i), MA0=iMA(symbol,5,5,0,3,0,i); // (changed)
         double MA1=iMA(symbol,5,5,0,3,0,i+1), MA2=iMA(symbol,5,5,0,3,0,i+2),MA3=iMA(symbol,5,5,0,3,0,i+3); // (changed)
        
         if(Cs0-Op0>=ATR0*0.8) cnGrn++;
        
         if(MA0>MA1 && MA1<=MA2 && MA2<=MA3)
            {
            Print("trend start = ",i);
            if(cnGrn>=minGrn)
               {
               MAStrSf=i;
               trendStart=true;
              
               break;
               }
            else
               {
               trendEnd=false;
               MAEndSf=0;
               cnGrn=0;
               }
            }
        
         }
      }
   if(trendStart)Alert("Start =",MAStrSf," End = ",MAEndSf);

Quoting chimoong

Disliked

{quote} Hi Fxanalysis, thanks for your weekend time, highly appreciated. It is weekend now, only crypto BTCUSD is live, just tested your codes. Crypto is in bear trend now and with 600 bars, I managed to get a complete bull set-up at shift 288 (MAStrSf) and shift 280 (MAEndSf). Currently, the codes are giving "0" output, means it does NOT keep on looking the complete set-up from bar1 to bar 600, yet wrong somewhere in the codes, kindly help to relook into the codes again. Thanks {image} {image}

Ignored

Quoting fxanalysis

Disliked

{quote} nop that's not it here is how you should have joined everyting in one loop, like I asked some time ago. you start with finding the end of trend and then calculate strong bars and look for start , if start is found then break the loop. int MAEndSf=0; int MAStrSf=0; int cnGrn=0; int minGrn=4; bool trendEnd=false; bool trendStart=false; for(int i=3;i<2000;i++) { //First find the end of trend if(!trendEnd) { double MA0=iMA(symbol,5,5,0,3,0,i), MA1=iMA(symbol,5,5,0,3,0,i-1); double MA2=iMA(symbol,5,5,0,3,0,i-2);//, MA3=iMA(symbol,5,5,0,3,0,i+3);...

Ignored

  
   int minGrn=3; // (changed)
   int MAStrSf=0;
   int MAEndSf = 0;
   int cnGrn=0;
   bool checkStart=false;
   bool signalFound=false;
 
   for(int i=1; i<=600; i++) {
   double MA0=iMA(symbol,PERIOD_M5,5,0,3,0,i), MA1=iMA(symbol,PERIOD_M5,5,0,3,0,i+1);
   double MA2=iMA(symbol,PERIOD_M5,5,0,3,0,i+2), MA3=iMA(symbol,PERIOD_M5,5,0,3,0,i+3);
   if(!checkStart){
      if(MA0>MA1 && MA1<=MA2 && MA2<=MA3) {
         MAStrSf=i; // MA 2-drop 1-Up
         checkStart=true;
         //Print("Start = ",iTime(_Symbol,PERIOD_M5,i));
         }
      }
   else //check start=true
      for(int cn=i; cn>=4; cn--) {
      double Op0=iOpen(symbol,PERIOD_M5,cn), Cs0=iClose(symbol,PERIOD_M5,cn);
      double ATR0=iATR(symbol,PERIOD_M5,5,cn), cMA0=iMA(symbol,PERIOD_M5,5,0,3,0,cn); // (changed)
      double cMA1=iMA(symbol,PERIOD_M5,5,0,3,0,cn-1), cMA2=iMA(symbol,PERIOD_M5,5,0,3,0,cn-2); // (changed)
      
      if(Cs0-Op0>=ATR0*0.8) { // (changed)
            cnGrn++;
            }
      if((cMA0>=cMA1 && cMA1>cMA2)) { // (changed)
          // END OF TREND
         MAEndSf=cn;
         //Print("End = ",iTime(_Symbol,PERIOD_M5,cn));
         //Print("Candle count = ",cnGrn);
         if(cnGrn>=minGrn) {
            signalFound=true;
            break;
            }
            else {
            checkStart=false;
            cnGrn=0;
            MAStrSf=0;
            MAEndSf=0;
            break;
            }
         } // Count No. of Big Green bars and stops at next MA 2-drop
        
      if(cn==4 && checkStart){
      checkStart=false; cnGrn=0; MAStrSf=0;MAEndSf=0;}
      }
   if(signalFound) break;
   }

Quoting fxanalysis

Disliked

{quote} nop that's not it here is how you should have joined everyting in one loop, like I asked some time ago. you start with finding the end of trend and then calculate strong bars and look for start , if start is found then break the loop. int MAEndSf=0; int MAStrSf=0; int cnGrn=0; int minGrn=4; bool trendEnd=false; bool trendStart=false; for(int i=3;i<2000;i++) { //First find the end of trend if(!trendEnd) { double MA0=iMA(symbol,5,5,0,3,0,i), MA1=iMA(symbol,5,5,0,3,0,i-1); double MA2=iMA(symbol,5,5,0,3,0,i-2);//, MA3=iMA(symbol,5,5,0,3,0,i+3); if(MA0>=MA1 && MA1>MA2)//End of trend { MAEndSf=i; trendEnd=true; Print("trend end = ",i); //Check last bar double Op0=iOpen(symbol,5,i), Cs0=iClose(symbol,5,i); double ATR0=iATR(symbol,5,5,i); if(Cs0-Op0>=ATR0*0.8) cnGrn++; } } else// trend end found { //Now look for strong bars and trend start double Op0=iOpen(symbol,5,i), Cs0=iClose(symbol,5,i); double ATR0=iATR(symbol,5,5,i), MA0=iMA(symbol,5,5,0,3,0,i); // (changed) double MA1=iMA(symbol,5,5,0,3,0,i+1), MA2=iMA(symbol,5,5,0,3,0,i+2),MA3=iMA(symbol,5,5,0,3,0,i+3); // (changed) if(Cs0-Op0>=ATR0*0.8) cnGrn++; if(MA0>MA1 && MA1<=MA2 && MA2<=MA3) { Print("trend start = ",i); if(cnGrn>=minGrn) { MAStrSf=i; trendStart=true; break; } else { trendEnd=false; MAEndSf=0; cnGrn=0; } } } } if(trendStart)Alert("Start =",MAStrSf," End = ",MAEndSf);

Ignored

Quoting chimoong

Disliked

{quote} Hi FxAnalysis, thanks for your efforts to provide the solution, unfortunately my broker is now under maintenance, no crypto market now and it will resume in a few hours later and I'll test it later. Oops, your codes start from MAEndSf to look for MAStrSf and this may limit my ideas (of course, unless your codes can mod to suit my ideas, is okay then). On 26 Nov 2021, you gave me a solution at https://www.forexfactory.com/thread/...7#post13801247 and I tested for a couple of days. For green bar condition of Cs0-Op0>=ATR0,...

Ignored

Quoting fxanalysis

Disliked

{quote} latest code I provided is like the old ones which first find start and then end , so you will be able to do your calculations like you wanted

Ignored

Quoting chimoong

Disliked

{quote} Thousands of thanks for your kind help. Yes, I just realised that the latest code is the solution (start from MAStrSf to get MAEndSf), tested, the right final solution, thanks again. Honestly, due to non-programming background for myself, I tried to understand the codes' logic behind but do not fully understand, anyway, when time goes by, perhaps I can fully understand the codes in later stage. One question, for these two : cn>=4; and (cn==4 && checkStart), the "4" is specially to count the last two MA-drop (cMA0>=cMA1 && cMA1>cMA2) (2 bars...

Ignored

Quoting fxanalysis

Disliked

{quote} cn>=4; and (cn==4 && checkStart) used the 4 as limit because I thought indicator used iMA with shift cn-3 so when cn= 4 it would be 4-3=1 , not using candle 0 because it is still in development. Looks like largest decrease in shift is -2 so yes you can use cn>=3; and (cn==3 && checkStart) without any problem

Ignored