Need Help : Merge 2 Loops into 1 Loop

Quoting Kafin

Disliked

With my understanding, I wont code the second loop the way you are doing. A forward-looking logic (MA based on cn-1, cn-2 index) is not very practical As you can see, the coders that tried to assist you are not very clear of what you are doing. If you cannot post your source code, at least describe what you want this module to achieve instead of forcing everyone to think along the original idea you had. What are you trying to find and when do you want it to be displayed?

Ignored

Quoting chimoong

Disliked

{quote} Hi Kafin FxAnalysis' source codes are here https://www.forexfactory.com/thread/...7#post13801247 ... in fact, FxAnalysis' codes have met my requirements but I need a little bit of further mod / fine tune ... I'm the beginner without programming background, in learning stage. I have my ideas how to make use of the codes. Of course, if you have better ideas, you may write down your codes and I will test it, thanks so much.

Ignored

Quoting Kafin

Disliked

{quote} That is your logic, I will bet that none of the coders that have responded clearly see what you need because you have not given much description, otherwise you should have a working solution by now. You have two conditions and need to merge them together - I might be wrong, and that is why I asked you to describe what you want to achieve. With an MA that uses cn-1, cn-2, cn-3 index, when (at which point) would you mark the conditions as being satisfied?

Ignored

Quoting skillz16

Disliked

Is this based on some sort of indicator? A zig-zag perhaps? *Worth noting that a lot of those "repaint" the latest bar usually, and so are often garbage and not usable. *Or if you do/did use them, you always need to look a bar back in the past for the signal... IE on a chart they would look A TON better than they always are. Is this based on an indicator though? If so, then you could look at those values that return from the indicator script to figure this out, rather than re-coding a lot of things.

Ignored

Quoting chimoong

Disliked

{quote} Hi Kafin, you're right, I have two conditions of loops that needed to merge for a bull trend :- 1) Start with 2 MA-drop and to the right, end with another 2 MA-drop. 2) In between the (1) above, there must be 4 minimum strong green bars Cs0-Op0>=ATR0, of course, it can be 4, 5, 6, 7 or more strong green bars. What I want to get is the 2 bars' shifts (MAStartSf and MAEndSf) : https://www.forexfactory.com/attachm...7&d=1638529043

Ignored

Quoting Kafin

Disliked

{quote} I would take the most-recent "2 MA-drop" as MAEndSf. Then search previous bars for the next "2 MA-drop" this is your MAStartSf Search between them for the number of bullish bars What information is this suppose to provide?

Ignored

Quoting chimoong

Disliked

{quote} Hi Kafin, I cannot imagine how's your ideas, please go ahead to write down your codes and I'll test it, thank you.

Ignored

Quoting fxanalysis

Disliked

Sorry forgot to add one thing - turn checkStart to false in if if(cn==1&&checkStart){ checkStart=false; cnGrn=0; MA2Dp1UpSf=0;}

Ignored

   int minGrn=4;
   int MAStrSf=0;
   int cnGrn=0;
   bool checkStart=false;
   bool signalFound=false;
   for(int i=4; i<=600; i++) {
   double MA0=iMA(symbol,5,5,0,3,0,i), MA1=iMA(symbol,5,5,0,3,0,i+1);
   double MA2=iMA(symbol,5,5,0,3,0,i+2), MA3=iMA(symbol,5,5,0,3,0,i+3);
   if(!checkStart){
      if(MA0>MA1 && MA1<=MA2 && MA2<=MA3) {
         MAStrSf=i; // MA 2-drop 1-Up
         checkStart=true;
         }
      }
   else //check start=true
      for(int cn=i; cn>=1; cn--) {
      double Op0=iOpen(symbol,5,cn), Cs0=iClose(symbol,5,cn);
      double ATR0=iATR(symbol,5,5,cn), MAn1=iMA(symbol,5,5,0,3,0,cn-1);
      double MAn2=iMA(symbol,5,5,0,3,0,cn-2), MAn3=iMA(symbol,5,5,0,3,0,cn-3);
      if(MAn1<=MathMax(MAn2,MAn3)) {
         if(Cs0-Op0>=ATR0) {
            cnGrn++;
            }
 
      if(cn==1 && checkStart){
      checkStart=false; cnGrn=0; MAStrSf=0;}
 
         } else { // END OF TREND
         if(cnGrn>=minGrn) {
            signalFound=true;
            break;
            }
            else {
            checkStart=false;
            cnGrn=0;
            MAStrSf=0;
            }
         } // Count No. of Big Green bars and stops at next MA 2-drop
      }
   if(signalFound) break;
   }

Quoting Kafin

Disliked

{quote} You haven't my question -- What information is this suppose to provide? I don't think I should spend hours writing code for you, and not get anything in return -- most especially when I believe that the code will eventually be thrown away.

Ignored

Quoting chimoong

Disliked

{quote} Thanks Kafin, sorry, I don't really understand your "What information is this suppose to provide?". My original request is at my 1st post : https://www.forexfactory.com/thread/...2-loops-into-1 and all the information are here ...

Ignored

Quoting Kafin

Disliked

{quote} Why are you interested in knowing (or getting notified) when this condition(s) are met, how does it help your trading decision(s) People don't discuss the reasons behind their idea, they just want a code. But if we can combine few reasonable ideas, we can come up with a winning solution - I think

Ignored

Quoting chimoong

Disliked

{quote} Hi Fxanalysis, thanks for your reply. I amended the codes as follows but with errors :- 1) I changed the name of MA2Dp1UpSf to "MAStrSf" 2) I added the following codes prior to "END OF TREND" text. if(cn==1 && checkStart){ checkStart=false; cnGrn=0; MAStrSf=0;} int minGrn=4; int MAStrSf=0; int cnGrn=0; bool checkStart=false; bool signalFound=false; for(int i=4; i<=600; i++) { double MA0=iMA(symbol,5,5,0,3,0,i), MA1=iMA(symbol,5,5,0,3,0,i+1); double MA2=iMA(symbol,5,5,0,3,0,i+2), MA3=iMA(symbol,5,5,0,3,0,i+3); if(!checkStart){ if(MA0>MA1...

Ignored

   int minGrn=4;
   int MAStrSf=0;
   int cnGrn=0;
   bool checkStart=false;
   bool signalFound=false;
   for(int i=4; i<=600; i++) {
   double MA0=iMA(symbol,5,5,0,3,0,i), MA1=iMA(symbol,5,5,0,3,0,i+1);
   double MA2=iMA(symbol,5,5,0,3,0,i+2), MA3=iMA(symbol,5,5,0,3,0,i+3);
   if(!checkStart){
      if(MA0>MA1 && MA1<=MA2 && MA2<=MA3) {
         MAStrSf=i; // MA 2-drop 1-Up
         checkStart=true;
         }
      }
   else //check start=true
      for(int cn=i; cn>=4; cn--) {
      double Op0=iOpen(symbol,5,cn), Cs0=iClose(symbol,5,cn);
      double ATR0=iATR(symbol,5,5,cn), MAn1=iMA(symbol,5,5,0,3,0,cn-1);
      double MAn2=iMA(symbol,5,5,0,3,0,cn-2), MAn3=iMA(symbol,5,5,0,3,0,cn-3);
      if(MAn1<=MathMax(MAn2,MAn3)) {
         if(Cs0-Op0>=ATR0) {
            cnGrn++;
            }
            } 
         else { // END OF TREND
         if(cnGrn>=minGrn) {
            signalFound=true;
            break;
            }
            else {
            checkStart=false;
            cnGrn=0;
            MAStrSf=0;
            }
         } // Count No. of Big Green bars and stops at next MA 2-drop
         
      if(cn==4 && checkStart){
      checkStart=false; cnGrn=0; MAStrSf=0;}
      }
   if(signalFound) break;
   }

Quoting fxanalysis

Disliked

{quote} You added the if in the wrong place.. What I meant was inside the loop after all the existing code. And again there was problem with i>=1 and iMA(1-3 shift?) int minGrn=4; int MAStrSf=0; int cnGrn=0; bool checkStart=false; bool signalFound=false; for(int i=4; i<=600; i++) { double MA0=iMA(symbol,5,5,0,3,0,i), MA1=iMA(symbol,5,5,0,3,0,i+1); double MA2=iMA(symbol,5,5,0,3,0,i+2), MA3=iMA(symbol,5,5,0,3,0,i+3); if(!checkStart){ if(MA0>MA1 && MA1<=MA2 && MA2<=MA3) { MAStrSf=i; // MA 2-drop 1-Up checkStart=true; } } else //check start=true for(int...

Ignored

   int minGrn=3; // (changed)
   int MAStrSf=0;
   int cnGrn=0;
   bool checkStart=false;
   bool signalFound=false;
 
   for(int i=1; i<=600; i++) {
   double MA0=iMA(symbol,5,5,0,3,0,i), MA1=iMA(symbol,5,5,0,3,0,i+1);
   double MA2=iMA(symbol,5,5,0,3,0,i+2), MA3=iMA(symbol,5,5,0,3,0,i+3);
   if(!checkStart){
      if(MA0>MA1 && MA1<=MA2 && MA2<=MA3) {
         MAStrSf=i; // MA 2-drop 1-Up
         checkStart=true;
         }
      }
   else //check start=true
      for(int cn=i; cn>=4; cn--) {
      double Op0=iOpen(symbol,5,cn), Cs0=iClose(symbol,5,cn);
      double ATR0=iATR(symbol,5,5,cn), cMA0=iMA(symbol,5,5,0,3,0,cn); // (changed)
      double cMA1=iMA(symbol,5,5,0,3,0,cn+1), cMA2=iMA(symbol,5,5,0,3,0,cn+2); // (changed)
      if(!(cMA0<cMA1 && cMA1<=cMA2)) { // (changed)
         if(Cs0-Op0>=ATR0*0.8) { // (changed)
            cnGrn++;
            }
            }
         else { // END OF TREND
         if(cnGrn>=minGrn) {
            signalFound=true;
            break;
            }
            else {
            checkStart=false;
            cnGrn=0;
            MAStrSf=0;
            }
         } // Count No. of Big Green bars and stops at next MA 2-drop
        
      if(cn==4 && checkStart){
      checkStart=false; cnGrn=0; MAStrSf=0;}
      }
   if(signalFound) break;
   }

   int minGrn=3; // (changed)
   int MAStrSf=0;
   int MAEndSf = 0;
   int cnGrn=0;
   bool checkStart=false;
   bool signalFound=false;
 
   for(int i=1; i<=600; i++) {
   double MA0=iMA(symbol,5,5,0,3,0,i), MA1=iMA(symbol,5,5,0,3,0,i+1);
   double MA2=iMA(symbol,5,5,0,3,0,i+2), MA3=iMA(symbol,5,5,0,3,0,i+3);
   if(!checkStart){
      if(MA0>MA1 && MA1<=MA2 && MA2<=MA3) {
         MAStrSf=i; // MA 2-drop 1-Up
         checkStart=true;
         }
      }
   else //check start=true
      for(int cn=i; cn>=4; cn--) {
      double Op0=iOpen(symbol,5,cn), Cs0=iClose(symbol,5,cn);
      double ATR0=iATR(symbol,5,5,cn), cMA0=iMA(symbol,5,5,0,3,0,cn); // (changed)
      double cMA1=iMA(symbol,5,5,0,3,0,cn+1), cMA2=iMA(symbol,5,5,0,3,0,cn+2); // (changed)
      if(!(cMA0<cMA1 && cMA1<=cMA2)) { // (changed)
         if(Cs0-Op0>=ATR0*0.8) { // (changed)
            cnGrn++;
            }
            }
         else { // END OF TREND
         MAEndSf=cn;
         if(cnGrn>=minGrn) {
            signalFound=true;
            break;
            }
            else {
            checkStart=false;
            cnGrn=0;
            MAStrSf=0;
            MAEndSf=0;
            }
         } // Count No. of Big Green bars and stops at next MA 2-drop
        
      if(cn==4 && checkStart){
      checkStart=false; cnGrn=0; MAStrSf=0;MAEndSf=0;}
      }
   if(signalFound) break;
   }

   int minGrn=3; // (changed)
   int MAStrSf=0;
   int MAEndSf = 0;
   int cnGrn=0;
   bool checkStart=false;
   bool signalFound=false;
 
   for(int i=1; i<=600; i++) {
   double MA0=iMA(symbol,5,5,0,3,0,i), MA1=iMA(symbol,5,5,0,3,0,i+1);
   double MA2=iMA(symbol,5,5,0,3,0,i+2), MA3=iMA(symbol,5,5,0,3,0,i+3);
   if(!checkStart){
      if(MA0>MA1 && MA1<=MA2 && MA2<=MA3) {
         MAStrSf=i; // MA 2-drop 1-Up
         checkStart=true;
         }
      }
   else //check start=true
      for(int cn=i; cn>=4; cn--) {
      double Op0=iOpen(symbol,5,cn), Cs0=iClose(symbol,5,cn);
      double ATR0=iATR(symbol,5,5,cn), cMA0=iMA(symbol,5,5,0,3,0,cn); // (changed)
      double cMA1=iMA(symbol,5,5,0,3,0,cn+1), cMA2=iMA(symbol,5,5,0,3,0,cn+2); // (changed)
      if(!(cMA0<cMA1 && cMA1<=cMA2)) { // (changed)
         if(Cs0-Op0>=ATR0*0.8) { // (changed)
            cnGrn++;
            }
            }
         else { // END OF TREND
         MAEndSf=cn;
         if(cnGrn>=minGrn) {
            signalFound=true;
            break;
            }
            else {
            checkStart=false;
            cnGrn=0;
            MAStrSf=0;
            MAEndSf=0;
            break;
            }
         } // Count No. of Big Green bars and stops at next MA 2-drop
        
      if(cn==4 && checkStart){
      checkStart=false; cnGrn=0; MAStrSf=0;MAEndSf=0;}
      }
   if(signalFound) break;
   }