template <typename T> Problem

      //***********************************************************************************************
      // For test just a simple class and one instance of it: x
      // I want to call several instance dependent on settings so it has to be this way!
      //***********************************************************************************************
      class Cx{
         public:
            void f(){
            }
      };        
      Cx x();
      //***********************************************************************************************
      // My test class with methods
      //***********************************************************************************************
      class CTest{
         public:            
            //*******************************************************************
            // buy
            //******************************************************************      
            template <typename T> void buy(T t){
               // coding here with "t"
            };
              
              
            //***********************************************************************************************
            // verifyAndCloseBuy
            //***********************************************************************************************
            bool verifyAndCloseBuy(int i){              
               // Calling method "buy" with instance object x: works 100%
               this.buy(&x);
               return false;          
            }    
                
  
            //***********************************************************************************************
            // getActTrade
            //***********************************************************************************************
            template <typename T> void getActTrade(T actTrade){  
               // Set my Object to actTrade
               actTrade=&x;
            }
            //***********************************************************************************************
            // verifyAndCloseOpenOrdersEA
            //***********************************************************************************************
              template <typename T> void actionWithSettingActTrade(){  
               T actTrade;
               getActTrade(actTrade);
               this.buy(actTrade);  
            };
                        
      };      
      CTest test();
  
 
      //***********************************************************************************************
      // Call outside the class
      //***********************************************************************************************  
      void testAll(){
         // The rest is compiled......
         test.actionWithSettingActTrade();
      }

Quoting reteid2222

Disliked

The code: //*********************************************************************************************** // For test just a simple class and one instance of it: x // I want to call several instance dependent on settings so it has to be this way! //*********************************************************************************************** class Cx{ public: void f(){ } }; Cx x(); //*********************************************************************************************** // My test class with methods //***********************************************************************************************...

Ignored

Quoting reteid2222

Disliked

I know this site and it didn t help me anyway.....

Ignored

Quoting braintheboss

Disliked

{quote} I didn't test code but i see one thing. If you use T in almost all methods is better use it at class definition. It have some advantages as you can use virtual methods or avoid names conflict.

Ignored

Quoting braintheboss

Disliked

I think your error is because you missed ";" in 2 previous methods at end of class. Finish methods with }; and check if error disappear. I don't see anything weird at code but if you are using mt4 last metaeditor builds then maybe the problem is that. It have a nasty bug made many weird typo errors even code is fine and compile well in older builds

Ignored

Quoting braintheboss

Disliked

I checked it and I saw problem is you have define type if method havent parameters. Try this: test.actionWithSettingActTrade<uint>()

Ignored

               if (typeOfCHOICE==INUM_CHOICES_X)              
                  this.buy(&x);  
               else if (typeOfCHOICE==INUM_CHOICES_Y)
                  this.buy(&y);

               T t;
               setTValue(t);
               this.buy(&t);

      //***********************************************************************************************
      // A list of classes
      //***********************************************************************************************
      enum INUM_CHOICES{
         INUM_CHOICES_X,                                                   // X
         INUM_CHOICES_Y,                                                   // Y
        };
      input INUM_CHOICES typeOfCHOICE=INUM_CHOICES_X;                     // Type of choice    
  
      class Cx{};        
      Cx x();
      
      class Cy{};        
      Cy y();
      //***********************************************************************************************
      // Calling the classes Cx and Cy per user choice
      //***********************************************************************************************
      class CTest{
         public:    
            //*******************************************************************
            // buy
            //******************************************************************      
            template <typename T> void buy(T t){
               // coding here with "t"
            };
                      
            //***********************************************************************************************
            // action
            //***********************************************************************************************
              void action(){  
               // This is my intention:
               if (typeOfCHOICE==INUM_CHOICES_X)              
                  this.buy(&x);  
               else if (typeOfCHOICE==INUM_CHOICES_Y)
                  this.buy(&y);  
            };
                        
      };      
      CTest test();
  
 
      //***********************************************************************************************
      // Call outside the class
      //***********************************************************************************************  
      void testAll(){
         test.action();
      }

Quoting reteid2222

Disliked

I try to show it much clearer what I want....

Ignored

#property strict
#property indicator_chart_window
 
  enum INUM_CHOICES{
         INUM_CHOICES_X,                                                   // X
         INUM_CHOICES_Y,                                                   // Y
  };
  
  input INUM_CHOICES typeOfCHOICE=INUM_CHOICES_X;                     // Type of choice  
  
      interface CommonInterface
      {
          void method(){};
      };
 
      class Cx : public CommonInterface {
          void method() override {
              int i=1;
              Print("i: " + (string)i);
              return;
          }
      };
    
      class Cy : public CommonInterface {
          void method() override{
              int i=2;
              Print("i: " + (string)i);
              return;
          }
      };
      
      
       //***********************************************************************************************
      // Calling the classes Cx and Cy per user choice
      //***********************************************************************************************
      class CTest{
         public:    
           CommonInterface *CIntA;
           CommonInterface *CIntB;
          
           virtual void Create(){
                if (typeOfCHOICE==INUM_CHOICES_X){      
                  CIntA = new Cx;
                  buy(CIntA);
               }
               else if (typeOfCHOICE==INUM_CHOICES_Y){
                  CIntB = new Cy;
                  buy(CIntB);
               }
           };
            
            
           void buy(CommonInterface *myInterface) {
                  myInterface.method();
           };
                      
            ~CTest(){
                 delete CIntA;
                 delete CIntB;
            };  
                        
    };      
      
CTest test;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int OnInit()
  {
   test.Create();
//--- indicator buffers mapping
  
//---
   return(INIT_SUCCEEDED);
  }
  
void OnDeinit(const int reason)
{
  
}  
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
//---
  
//--- return value of prev_calculated for next call
   return(rates_total);
  }

Quoting eess

Disliked

{quote} See whether this works for you: #property strict #property indicator_chart_window enum INUM_CHOICES{ INUM_CHOICES_X, // X INUM_CHOICES_Y, // Y }; input INUM_CHOICES typeOfCHOICE=INUM_CHOICES_X; // Type of choice interface CommonInterface { void method(){}; }; class Cx : public CommonInterface { void method() override { int i=1; Print("i: " + (string)i); return; } }; class Cy : public CommonInterface { void method() override{ int i=2; Print("i: " + (string)i); return; } }; //***********************************************************************************************...

Ignored

Quoting reteid2222

Disliked

{quote} You can t use Cx or cx for uint.... that s what I needed.....

Ignored

Quoting hal7

Disliked

Thanks for unignoring all of us....

Ignored

Quoting reteid2222

Disliked

{quote} Thanks for filling my threads with comments I don t need....

Ignored

   #property strict
   #property indicator_chart_window
    
     enum INUM_CHOICES{
            INUM_CHOICES_X,                                                   // X
            INUM_CHOICES_Y,                                                   // Y
     };
    
     input INUM_CHOICES typeOfCHOICE=INUM_CHOICES_X;                     // Type of choice  
    
         interface Cxyz
         {
             void method(){};
         };
    
         class Cx : public Cxyz {
             void method() override {
                  Alert("1 "+(string)TimeCurrent());                
             }
         };
      
         class Cy : public Cxyz {
             void method() override{
                  Alert("2 "+(string)TimeCurrent());                
             }
         };
        
        
          //***********************************************************************************************
         // Calling the classes Cx and Cy per user choice
         //***********************************************************************************************
         class CTest{
            public:    
              Cxyz *getInstance() {
                  if (typeOfCHOICE==INUM_CHOICES_X)    
                     return new Cx;
                  else if (typeOfCHOICE==INUM_CHOICES_Y)
                     return new Cy;
                  // For compiler - will never happen!
                  else
                     return NULL;
              };
                              
              
              void action() {
                  // Similar calls will be used several times in different methods in the class!
                  buy(getInstance());
              };
              
              void buy(Cxyz *cxyz) {
                     cxyz.method();
              };                                                    
       };      
        
   CTest test;
  
   int OnInit(){
      // Main part does not know which cx or cy to use
      test.action();
      return(INIT_SUCCEEDED);
     }
    
   int start(){return -1;     }

Quoting reteid2222

Disliked

Thank you for all you help..... the question was how to use 2 or more classes in a class dependent on settings....all code in in one file and can be include and the main class does not know anything about this part. The idea was to create an interface so that all helper classes could be declared as parameter and used as arguments! My final solution looks like this

Ignored

Quoting eess

Disliked

{quote} Looks good, just one thing, when you're allocating memory dynamically with "new", need to explicitly call "delete" somewhere when you do not need it anymore to prevent memory leakage. Refer to the code I sent earlier..in the class destructor.

Ignored