I will code your EAs and Indicators for no charge

hello everyone,

i am trying writing a very simple EA for MT4. i dont know yet if this is correct code. but i run it. only few result because of the conditions, i think.
i am just a newbie for this. hope good samaritan out there can help me improve this.
the conditions are in this script, but i want to add an AUTO_TAKE_PROFIT to close order for buy once the price will cross the Moving Average and close below MA, and auto take profit to close order for sell once the price will cross the Moving Average and close above MA.
and add aTRAIL STOPS too. please help. thank you.


double MA1 = iMA(NULL,0,period,0, MODE_EMA,PRICE_CLOSE,barshift);
double OpenPrice = Open[1];
double ClosePrice = Close[1];
double LowPrice = Low[1];
double HighPrice = High[1];
double OpenBuyOrder;
double OpenSellOrder;

if((HighPrice>MA1)&&(LowPrice<MA1))
{
OpenSellOrder=OrderSend(Symbol(),OP_SELL,Lots,Bid,2,0,0,MAGICNUM,0,Red);

}
else if((LowPrice<MA1)&&(HighPrice>MA1))
{
OpenBuyOrder=OrderSend(Symbol(),OP_BUY,Lots,Ask,2,0,0,MAGICNUM,0,Green);
}

You're smart, I think its me that have not been able to communicate properly. Was hoping to make the composite RSI behave like the other indicator since the repainting is very marginal and its MTF.
Thanks for the effort.

no shortage of requests in this thread if someone has a profitable strategy i can code it for you and free but i make over 100 ea now and nothing will make profit reliably
I think human still have to be involved not just rely on EA

hi, thank you for your reply. in the backtest i dont see any result, and no appearance or execution from this EA code. please fix. thank you.

//==============================
this is the .mq4 file in Expert Advisor

//| Copyright 2021. JuliefaFX. |
//| https://disqus.com/by/nic_colito |
//+------------------------------------------------------------------+
#property copyright "Copyright 2021. JuliefaFX."
#property link "https://disqus.com/by/nic_colito"
#property version "1.01"
#property strict
#include "10k-50k Common.mqh"


==============================================
this file is for common .mqh file in Expert Advisor

//| Copyright 2021. JuliefaFX. |
//| https://disqus.com/by/nic_colito |
//+------------------------------------------------------------------+
#property copyright "Copyright 2021. JuliefaFX."
#property link "https://disqus.com/by/nic_colito"
#property version "1.01"
#property strict

#include "10k-50k Class.mqh" //get source functions from '10k-50k Class.mqh' file


//inputs indicators
// bollinger band
input int InpBandsPeriods = 20; //bband periods
input double InpBandsDeviation = 2.0; // bband deviation
input ENUM_APPLIED_PRICE InpBandsAppliedPrice = PRICE_CLOSE; //bband applied price

// moving average line
input int InpMaPeriods = 9; //ma periods
input ENUM_MA_METHOD InpMaMethod = MODE_SMA; //ma method
input ENUM_APPLIED_PRICE InpMaAppliedPrice = PRICE_CLOSE; //ma applied price

// the standard inputs
input double InpPLRatio = 1.0; // profit/loss ratio
input int InpMagicNumber0 = 210613; //magic number part1
int InpMagicNumber1 = InpMagicNumber0+1; //magic number
input string InpTradeComment = "10k-50k"; //trade comment
input double InpTradeVolume0 = 0.02; //volume per trade
input double InpTradeVolume1 = 0.01; //volume per trade

CCurrentTrade *CurrentTrade[2];

int OnInit()
{
CurrentTrade[0] = new CCurrentTrade(InpMaPeriods, InpMaMethod, InpMaAppliedPrice,
InpBandsPeriods, InpBandsDeviation, InpBandsAppliedPrice,
InpPLRatio, InpMagicNumber0, InpTradeComment, InpTradeVolume0, 0);
if (CurrentTrade[0].InitStatus()!=INIT_SUCCEEDED) return(CurrentTrade[0].InitStatus());

CurrentTrade[1] = new CCurrentTrade(InpMaPeriods, InpMaMethod, InpMaAppliedPrice,
InpBandsPeriods, InpBandsDeviation, InpBandsAppliedPrice,
InpPLRatio, InpMagicNumber1, InpTradeComment, InpTradeVolume1, 1);
if (CurrentTrade[1].InitStatus()!=INIT_SUCCEEDED) return(CurrentTrade[1].InitStatus());
return(INIT_SUCCEEDED);
}

void OnDeinit(const int reason) {

delete CurrentTrade[0];
delete CurrentTrade[1];
}

void OnTick() {
// 3 things to consider here
// 1. part 0 must not open a trade if there is a trade still open from part 0 or part 1
// 2. when part 0 opens a trade part 1 must also open a trade
// 3. when part 0 trade closes part 1 must move to break even

CurrentTrade[1].CheckIfClosed();
if (CurrentTrade[0].CurrentTicket()>0) { // there is an open ticket here
CurrentTrade[0].CheckIfClosed(); //update if the ticket was closed since last loop
if (CurrentTrade[0].CurrentTicket()==0) { // zero here means the ticket has just closed
CurrentTrade[1].SetBreakEven(); //move the other leg to break even
}
}

// now open if ther are no open tickets
if (NewBar() && CurrentTrade[0].CurrentTicket()==0 && CurrentTrade[1].CurrentTicket()==0) {
CurrentTrade[0].UpdateIndicators();
CurrentTrade[1].UpdateIndicators();
int condition = CurrentTrade[0].GetOpenCondition();
if (condition!=0) {
CurrentTrade[0].OpenOnCondition(condition);
CurrentTrade[1].OpenOnCondition(condition);
}
}
}
// just detect if a new bar has opened since the last time this was called
// this will ignore the current bar when the function is first called
bool NewBar() {

datetime now = iTime(Symbol(), Period(), 0);
static datetime prev = now;
if (prev==now) return(false);
prev = now;
return(true);
}


//===============================
this is the class .mqh file in Expert Advisor

//| Copyright 2021. JuliefaFX. |
//| https://disqus.com/by/nic_colito |
//+------------------------------------------------------------------+
#property copyright "Copyright 2021. JuliefaFX."
#property link "https://disqus.com/by/nic_colito"
#property version "1.01"
#property strict


#ifdef __MQL5__
#include <Trade/Trade.mqh>
CTrade Trade;
CPositionInfo PositionInfo;
#endif

class CCurrentTrade {

private:

int mMaPeriods;
ENUM_MA_METHOD mMaMethod;
ENUM_APPLIED_PRICE mMaAppliedPrice;

int mBandsPeriods;
double mBandsDeviation;
ENUM_APPLIED_PRICE mBandsAppliedPrice;

double mPLRatio;
int mMagicNumber;
double mTradeComment;
double mTradeVolume;

int mLeg;

int mInitStatus;
ulong mCurrentTicket;


//indicator values - can now be set by a common function
double mMa;
double mBandUpper1;
double mBandUpper2;
double mBandLower1;
double mBandLower2;
double mBandMid;
double mClose1;
double mClose2;
double mBid;
double mAsk;

#ifdef __MQL5__
int HandleMa;
double BufferMa[];
int HandleBands;
double BufferBandsUpper[];
double BufferBandsLower[];
double BufferBandsMid[];
#endif

public:

int InitStatus() { return(mInitStatus); }
ulong CurrentTicket() { return(mCurrentTicket); }

public:
CCurrentTrade(int maPeriods, ENUM_MA_METHOD maMethod, ENUM_APPLIED_PRICE maAppliedPrice,
int bandsPeriods, double bandsDeviation, ENUM_APPLIED_PRICE bandsAppliedPrice,
double plRatio, int magicNumber, string tradeComment, double tradeVolume,
int leg) {

mMaPeriods = maPeriods;
mMaMethod = maMethod;
mMaAppliedPrice = maAppliedPrice;
mBandsPeriods = bandsPeriods;
mBandsDeviation = bandsDeviation;
mBandsAppliedPrice = bandsAppliedPrice;
mPLRatio = plRatio;
mMagicNumber = magicNumber;
mTradeComment = tradeComment;
mTradeVolume = tradeVolume;

mLeg = leg;


#ifdef __MQL5__
//init the indicator handles
// and set the buffers to series
HandleMa = iMA(Symbol(), Period(); mMaPeriods, 0, mMaMetod, mMaAppliedPrice);
Print("Could not create MA Handle");
mInitStatus - INIT_FAILED);
return;
}
ArraySetAsSeries(BufferMa, true);
HandleBands = iBands(Symbol(), Period(), mBandsPeriods, 0, mBandsDeviation, mBandsAppliedPrice);
if (HandleBands==INVALID_HANDLE) {
Print("Could not create Bands Handle");
mInitStatus = INIT_FAILED;
return;
}
ArraySetAsSeries(BufferBandsUpper, true);
ArraySetAsSeries(BufferBandsLower, true);
ArraySetAsSeries(BufferBandsMid, true);

// one time set the magic number
Trade. SetExpertMagicNumber(mMagicNumber);
##endif

FindCurrentTicket();

mInitStatus = INIT_SUCCEEDED;
}
~CCurrentTrade() {
#ifdef __MQL5__
IndicatorRelease(HandleMa);
IndicatorRelease(HandleBands);
#endif
}
// If already tracking a ticket check if still open\
// set to zero if closed
void CheckIfClosed() {

// if already tracking a ticket check if stil open
// if the ticket is still open then exit with nothing more to do
if (mCurrentTicket>0) {
if (IsTicketOpen(mCurrentTicket)) return;
// at this point i should be able to just assume there are not tickets
mCurrentTicket = 0;
}
} // end CheckIfClosed()

// function to update the current indicator values
void UpdateIndicators() {
#ifdef __MQL4__
mMa = iMA(Symbol(), Period(), mMaPeriods, 0, mMaMethod, mMaAppliedPrice, 1);

mBandUpper1 = iBands(Symbol(), Period(), mBandsPeriods, mBandsDeviation, 0, mBandsAppliedPrice, MODE_UPPER, 1);
mBandUpper2 = iBands(Symbol(), Period(), mBandsPeriods, mBandsDeviation, 0, mBandsAppliedPrice, MODE_UPPER, 2);

mBandLower1 = iBands(Symbol(), Period(), mBandsPeriods, mBandsDeviation, 0, mBandsAppliedPrice, MODE_LOWER, 1);
mBandLower2 = iBands(Symbol(), Period(), mBandsPeriods, mBandsDeviation, 0, mBandsAppliedPrice, MODE_LOWER, 2);

mBandMid = iBands(Symbol(), Period(), mBandsPeriods, mBandsDeviation, 0, mBandsAppliedPrice, MODE_MAIN, 1);

#endif

#ifdef __MQL5__
if (!FillBuffers()) return;
mMa = BufferMa[1];

mBandUpper1 = BufferBandsUpper[1];
mBandUpper2 = BufferBandsUpper[2];

mBandLower1 = BufferBandsLower[1];
mBandLower2 = BufferBandsLower[2];

mBandMid = BufferBandsMid[1];
#endif

mClose1 = iClose(Symbol(), Period(), 1);
mClose2 = iClose(Symbol(), Period(), 2);
mBid = SymbolBid(Symbol());
mAsk = SymbolAsk(Symbol());

} // end UpdateIndicators()

int GetOpenCondition() {
if ( (mClose2>mBandUpper2 && mClose2<mBandUpper1) // closed inside from above after being outside
&& (mMa>mBandMid) // ma above band mid for high side
&& (mMa<mBid) // price must be higher than ma
) {
return(-1); // sell
}

if ( (mClose2<mBandUpper2 && mClose2>mBandUpper1) // closed inside from below after being outside
&& (mMa<mBandMid) // ma below band mid for low side
&& (mMa>mAsk) // price must be lower than ma
) {
return(1); // buy
}
return(0); // nothing
} // end GetOpenCondition


// main processing loop
void OpenOnCondition(int condition) {

double tp = (mLeg==0) ? mMa : mBandMid;
double sl = 0;

if ( condition>0 ) { // BUY
// TP WILL DEPEND ON LEG NUMBER
// SL WILL BE RATIO FROM THE MA, SO SAME SL FOR BOTH LEGS
sl = mAsk-((mMa-mAsk) /mPLRatio);
OpenTrade(ORDER_TYPE_BUY, mAsk, sl, tp);
return;
}

if ( condition<0 ) { // SELL
// TP WILL DEPEND ON LEG NUMBER
// SL WILL BE RATIO FROM THE MA, SO SAME SL FOR BOTH LEGS
sl = mBid+((mBid-mMa) /mPLRatio);
OpenTrade(ORDER_TYPE_SELL, mBid, sl, tp);
return;
}
}

#ifdef __MQL4__

void SetBreakEven() {

if (mCurrentTicket<=0) return;
if (!OrderSelect((int)mCurrentTicket, SELECT_BY_TICKET)) return;
bool result = OrderModify(OrderTicket(), OrderOpenPrice(), OrderOpenPrice(), OrderTakeProfit(), OrderExpiration());

}
void OpenTrade(ENUM_ORDER_TYPE type, double price, double sl, double tp) {
int ticket = OrderSend(Symbol(), type, mTradeVolume, price, 0, sl, tp, mTradeComment, mMagicNumber);
if (ticket>0) {
mCurrentTicket = ticket;
}
}
bool IsTicketOpen(ulong ticket) {
if (!OrderSelect((int)ticket, SELECT_BY_TICKET)) return(false);
if (OrderCloseTime()>0) return(false);
return(true);
}

// find a ticket for this EA if there is already one open
void FindCurrentTicket() {
mCurrentTicket =0;
int cnt = OrdersTotal();
for (int i=cnt-1; i>=0; i--) {
if (!OrderSelect(i, SELECT_BY_POS, MODE_TRADES)) continue;
if (OrderSymbol()==Symbol() && OrderMagicNumber()==mMagicNumber) {
mCurrentTicket = OrderTicket();
return;
}
}
}
#endif

#ifdef __MQL5__
bool FillBuffers() {
int maCount = CopyBuffer(HandleMa, 0, 0, 3, BufferMa);
int upperCount = CopyBuffer(HandleBands, UPPER_BAND, 0, 3, BufferBandsUpper);
int lowerCount = CopyBuffer(HandleBands, LOWER_BAND, 0, 3, BufferBandsLower);
int midCount = CopyBuffer(HandleBands, BASE_LINE, 0, 3, BufferBandsMid);

if (maCount<3 || upperCount<3 || lowerCount<3 || midCount<3) return(false);
return(true);
}

void BreakEven() {

if (!PositionSelectByTicket(mCurrentTicket)) return;
Trade.PositionModify(mCurrentTicket, PositionInfo.PriceOpen(); PositionInfo.TakeProfit());
}

void OpenTrade(ENUM_ORDER_TYPE type, double price, double sl, double tp) {
if (Trade.PositionOpen(Symbol(), type, mTradeVolume, price, sl, tp, mTradeComment)) {
mCurrentTicket = Trade.ResultOrder();
}
}
bool IsTicketOpen(long ticket) {
if (!PositionSelectByTicket(ticket)) return(false);
return(true);
}

//find a ticket for this EA if there is already one open
void FindCurrentTicket() {
mCurrentTicket = 0;
if (PositionInfo.SelectByMagic(Symbol(), mMagicNumber)) {
mCurrentTicket = PositionInfo.Ticket();
}
}
#endif

double SymbolAsk(string symbol) { return(SymbolInfoDouble(symbol, SYMBOL_ASK)); }
double SymbolBid(string symbol) { return(SymbolInfoDouble(symbol, SYMBOL_BID)); }
};

the class .mqh file is for MT4 AND MT5 and both can be benefited. this is not my original code. and this code believes to get 800%. check if its true or false. thank you admin.

Hi great coders & traders,
i really need your help, may be this is a beginner question ... but i can not understand it ... please look at image below

Timeframe we see on image is M1, there are some candles not shown ... this is happened after i put some indicators on it, and then i shutdown my mt4 platform. after i open it again, i got this problem ...
Which indicators that cause this? i do not know , i believe there is some bugs on my indicators ... the solution i found is (for temporary), i remove totally all indicators, shutdown my platform and restart it again without any indicators at all. But this will time consume if every time i must do like it after i start my platform with my all indicators on it... how can i debug the cause of this error ??
Price jumping because of no data (about two hours) catch by the mt4 platform, it is not only at this time frame, but also at other time frame too (some times) ... Based on other broker, i got the same problem but the price begin from ca. 1.1783x (different time of starting the mt4 platform) ... how come ??

---
Another question: every broker have different OHLC price ... although some of them have same server time (lets say GMT+2). if our favorite broker is no more exist in the future, we will get problem. How can we make the same OHLC price of each time frame like our favorite broker, if we download ticked data from other place (lets say from ducascopy ) ... or is there any solution for this ??

Any idea/clue is really helpful ... Thank you very much in advance.

you only post picture, i mean assist to post alb centered (on chart) indicator, i cant find it online pleaseee

hello dear friend, can you put this indicator to give the intrabar signal, as soon as the arrow appears to give input?

Is there an easy way to convert a mt4 indicator into a mt5 indicator?

Thanks in advance.

It is your posted "alb TriangularMA price zone mtf alerts.mq4 " indicator
here
https://www.forexfactory.com/thread/...1#post13654081

just played with provided parameters my way -

I dont think so - i came across only few codes that were working equally on both terminals MT4/5,the same code but these were few examples and were coded the way - all rest indicators coded particularly for MT4 or MT5

OOK please help me with the parameters you used your way, on that post i cant get the price to touch the body of the channel
since you can do that please kindly share parameters your way, you are more experienced on this issue

Hello guys,

Can someone please add arrow option to this kijun sen indicator when colour change

Thanks

Thanks Mntiwana, its done. Have found another suitible indi for this purpose.

Hi Vivaldi, as per your search have you managed to find any MAD-HMA (moving average distance), MTF 2 HMA Cross dashboard, or MTF price cross HMA dashboard?
If you have would you kindly give me a shout and if you would care to share

I am an HMA strategy person

Hello Everyone,

I need litle help, kindly assist if you can.

In the attached picture, I have dashboards for the stochastic and MA. I have used Red for overbought and green for oversold. The MA tells us whether price is above below MA.

Its quite tiresome to scan through all the pairs looking for overbought pairs in a downtrend and oversold in an uptrend.

Can someone please merge the two so that only red ones and green ones appear?

Red - Short. Both Timeframes (on both dashboards are red)
Green - Long.

For Example, in the picture,

AUDNZD 1HR RED
CHFJPY 15MIN RED
ETC ETC

Only the ones that correspond should appear on the MT4 dashboard.

Hello friends, can anyone help me?
I want the indicator name and the numbers in front of it to be removed and not displayed

Good morning guys. I am searching for an EA that plots a predetermined SL when i open a trade. I can't find it anywhere. Hope you can help me

Cheers

Specifics help - MT4 or MT5 or other?

https://www.forexfactory.com/thread/...-45-platforms?



https://www.mql5.com/en/code/10689

https://www.forexfactory.com/thread/...7#post12784547