Closing Last Order

//CloseLastBuy -------------------------------------------------------------------------------
int CloseLastBuy(){
   int i_ticket = OrdersTotal()-1;
   if (i_ticket > -1 && OrderSelect (i_ticket, SELECT_BY_POS)){
      if(OrderSymbol()==Symbol() && OrderMagicNumber()==mag1){ 
         if(OrderType()==OP_BUY){
            if (OrderClose(OrderTicket(),OrderLots(),NormalizeDouble(MarketInfo(Symbol(),MODE_BID),(int)MarketInfo(Symbol(),MODE_DIGITS)),1000,Gold)) return(1);//close ok
         }
      }
   }
   return(-1);//error while closing
}

//CloseLastBuy -------------------------------------------------------------------------------
int CloseLastBuy(){
   int i_ticket = OrdersTotal()-1;
   if (i_ticket > -1 && OrderSelect (i_ticket, SELECT_BY_POS)){
      if(OrderSymbol()==Symbol() && OrderMagicNumber()==mag1){ 
         if(OrderType()==OP_BUY){
            if (OrderClose(OrderTicket(),OrderLots(),Bid,1000,Gold)) return(1);//close ok
         }
      }
   }
   return(-1);//error while closing
}

Quoting rugmo

Disliked

I have a similar error, can someone help? thanks. ticket = OpenPendingOrder(0, iLots, BuyLimit, slip, BuyLimit, Stoploss, 0, EAName + "-" + NumOfTrades, MagicNumber, 0, Aqua); 2 Error messages for this line of code: implicit conversion from 'number' to 'string' possible loss of data due to type conversion

Ignored

Quoting paulselvan

Disliked

{quote} codes of OpenPendingOrder ?

Ignored

Quoting rugmo

Disliked

2 Error messages for this line of code: implicit conversion from 'number' to 'string' possible loss of data due to type conversion

Ignored

Quoting rugmo

Disliked

I have a similar error, can someone help? thanks. ticket = OpenPendingOrder(0, iLots, BuyLimit, slip, BuyLimit, Stoploss, 0, EAName + "-" + NumOfTrades, MagicNumber, 0, Aqua); 2 Error messages for this line of code: implicit conversion from 'number' to 'string' possible loss of data due to type conversion

Ignored

Quoting Beerrun

Disliked

{quote} If NumOfTrades is not a string, then that is why the warnings. ticket = OpenPendingOrder(0, iLots, BuyLimit, slip, BuyLimit, Stoploss, 0, EAName + "-" +IntegerToString(NumOfTrades), MagicNumber, 0, Aqua);

Ignored

Quoting rugmo

Disliked

{quote} You are right! NumOfTrades is not a string. I was able to fixed the problem by adding IntegerToString(NumOfTrades) to it. Final code look like this.... ticket = OpenPendingOrder(0, iLots, Ask, slip, Bid, Stoploss, 0, EAName + "-" + IntegerToString(NumOfTrades), MagicNumber, 0, Aqua); Thanks!!!!

Ignored

Quoting Macau

Disliked

//CloseLastSell ------------------------------------------------------------------------------- int CloseLastSell(){ int i_ticket = OrdersTotal()-1; if (i_ticket > -1 && OrderSelect (i_ticket, SELECT_BY_POS)) { if(OrderSymbol()==Symbol() && OrderMagicNumber()==mag1) { if(OrderType()==OP_SELL) { if (OrderClose(OrderTicket(),OrderLots(),NormalizeDouble(MarketInfo(Symbol(),MODE_ASK),(int)MarketInfo(Symbol(),MODE_DIGITS)),1000,Gold)) return(1);//close ok } } } return(-1);//error while closing } Am I writing the correct code to close the last sell order?...

Ignored

bool closeLastSell(int mag1){
      datetime lastTime;
      int lastTicket=0;
      
      //Loop thru all orders and get the very last sell order ticket # that matches the magic number
      for(int x = OrdersTotal()-1; x >= 0 ; x--) {
            if(!OrderSelect(x, SELECT_BY_POS)) continue; //if no order go to next order
            if(OrderSymbol()!=Symbol() || OrderMagicNumber()!=mag1) continue; // if not order of interest go to next order
            if(OrderOpenTime()>=lastTime) lastTicket=OrderTicket();  //record ticket of latest order time
      }
      
      if(lastTicket==0) {
         Print(TimeToStr(TimeCurrent()),"  ",Symbol(),":  No order was found to close.");
         return(false);
      }  
      
      //At this point we have the last order  ticket, so we attempt to close it
      bool ord=OrderSelect(lastTicket, SELECT_BY_TICKET); //get order using ticket number
      if (!OrderClose(OrderTicket(),OrderLots(),NormalizeDouble(MarketInfo(Symbol(),MODE_ASK),(int)MarketInfo(Symbol(),MODE_DIGITS)),1000,clrGold)) {
            Print(TimeToStr(TimeCurrent()),"  ",Symbol(),":  Error while closing sell ticket# ",(string)lastTicket);
            return(false);
      }
                
      return(true);//error while closing
}

if(!OrderSelect(x, SELECT_BY_POS)) continue; //if no order go to next order

Quoting paulselvan

Disliked

@xmess7 isnt it : if(!OrderSelect(x, SELECT_BY_POS)) continue; //if no order go to next order

Ignored

Quoting Macau

Disliked

Many thanks xmess7 and paulselvan for the help. I have another question.... iHigh(Symbol(),Period(),iHighest(Symbol(),Period(),MODE_HIGH,60,1)) I know by using the above code, we are able to find the Highest High for the past 60 bars. What is the code if we want to find the Highest CLOSE for the past 60 bars? Thanks in advance! P/S: I can't figure out how to insert code in the reply.

Ignored

       iClose(Symbol(),Period(),iHighest(Symbol(),Period(),MODE_CLOSE,60,1)

           int bar_count= iHighest(Symbol(),Period(),MODE_CLOSE,60,1)

          iClose(Symbol(),Period(),bar_count);

Quoting xmess7

Disliked

{quote} Ooops sorry. cut and past errror Thank you sir for pointing out the discrepancy! Jess PS: Code snippet has been updated in post https://www.forexfactory.com/showthr...5#post12279605

Ignored