How to program an indicator with OBV and its MA?

// loop looking back MA_period=200 periods and taking
// the OBV values corresponding to those candles
for(int j=1; j<=MA_period; j++) {
    nOBV_vals[j-1] = iOBV(NULL, 0, PRICE_CLOSE, i+j);
}
 
// using the freshly populated nOBV_vals array,
// this line calculates the MA
nOBVMA = iMAOnArray(nOBV_vals, 0, MA_period, 0, MA_method, i);
 
// print out the moving average value
Print("OBV EMA value is " + DoubleToStr(nOBVMA));
 
// add the MA to the MABuffer so that it shows on the indicator window
// when this line is enabled, even the OBVBuffer data gets corrupted!
MABuffer[i] = nOBVMA;

Quoting levix95

Disliked

Hi all, I'm a newbie to MQL4 programming with some knowledge in other programming languages. I've been struggling with this seemingly easy code that I attached below. Basically what I'd want to achieve is having the OBV (On Balance Volume) indicator with a moving average (SMA, EMA, SMMA, or LWMA) in a separate indicator window at the bottom of the chart. This is how it should look like: {image} I used the OBV.mq4 for a start and gradually started building the code up: I added the SetIndexBuffer and SetIndexStyle functions in init() for the second...

Ignored

Quoting Beerrun

Disliked

{quote} Instead of iMAOnArray you could calculate the MA values yourself. The include folder of your MT4 installation has code that you can use, like MA calculations.

Ignored

Quoting levix95

Disliked

{quote} Hi Beerrun, For SMA it's easy but for EMA, SMMA, LWMA too? Besides, I don't feel the best strategy is to just avoid using iMAOnArray function entirely because it's a pretty common function and it actually returns values.

Ignored

//+------------------------------------------------------------------+
//| Simple Moving Average                                            |
//+------------------------------------------------------------------+
double SimpleMA(const int position,const int period,const double &price[])
  {
//---
   double result=0.0;
//--- check position
   if(position>=period-1 && period>0)
     {
      //--- calculate value
      for(int i=0;i<period;i++) result+=price[position-i];
      result/=period;
     }
//---
   return(result);
  }
//+------------------------------------------------------------------+
//| Exponential Moving Average                                       |
//+------------------------------------------------------------------+
double ExponentialMA(const int position,const int period,const double prev_value,const double &price[])
  {
//---
   double result=0.0;
//--- calculate value
   if(period>0)
     {
      double pr=2.0/(period+1.0);
      result=price[position]*pr+prev_value*(1-pr);
     }
//---
   return(result);
  }
//+------------------------------------------------------------------+
//| Smoothed Moving Average                                          |
//+------------------------------------------------------------------+
double SmoothedMA(const int position,const int period,const double prev_value,const double &price[])
  {
//---
   double result=0.0;
//--- check position
   if(period>0)
     {
      if(position==period-1)
        {
         for(int i=0;i<period;i++) result+=price[position-i];
         result/=period;
        }
      if(position>=period)
         result=(prev_value*(period-1)+price[position])/period;
     }
//---
   return(result);
  }
//+------------------------------------------------------------------+
//| Linear Weighted Moving Average                                   |
//+------------------------------------------------------------------+
double LinearWeightedMA(const int position,const int period,const double &price[])
  {
//---
   double result=0.0,sum=0.0;
   int    i,wsum=0;
//--- calculate value
   if(position>=period-1 && period>0)
     {
      for(i=period;i>0;i--)
        {
         wsum+=i;
         sum+=price[position-i+1]*(period-i+1);
        }
      result=sum/wsum;
     }
//---
   return(result);
  }

Quoting Beerrun

Disliked

{quote}I was remembering from the other thread you said it only returned zero.

Ignored

Quoting levix95

Disliked

{quote} Yeah, luckily I managed to make a lot of progress since then and got the iMAOnArray() working but run into a wall with the buffers. Thanks for the MA codes, I'll try to combine them in my OBV-MA code and see if it leads somewhere else

Ignored

nLimit=Bars-nCountedBars-1;
 
for(i=nLimit; i>=0; i--) {
   for(int j=1; j<=MA_period; j++) {
      nOBV_vals[j-1] = iOBV(NULL, 0, PRICE_CLOSE, i+j);
   }
  
   nOBVMA = iMAOnArray(nOBV_vals, 0, MA_period, 0, MA_method, i);
            
   MABuffer[i] = nOBVMA;      
}

Quoting levix95

Disliked

And victory! I managed to solve it! The one on top is my indicator, the one on the bottom is the default MT4. {image} Surprisingly, it was actually easier than I would have ever thought. Just two for loops. Also important that earlier on, I mistakenly put everything into one single for loop. The secret was putting all OBV values into one array and then using the iMAOnArray() on all the OBV values in a second for loop. I leave my code here below, maybe someone will need an OBV with MA in the future. {file}

Ignored

Quoting levix95

Disliked

And victory! I managed to solve it! The one on top is my indicator, the one on the bottom is the default MT4. {image} Surprisingly, it was actually easier than I would have ever thought. Just two for loops. Also important that earlier on, I mistakenly put everything into one single for loop. The secret was putting all OBV values into one array and then using the iMAOnArray() on all the OBV values in a second for loop. I leave my code here below, maybe someone will need an OBV with MA in the future. {file}

Ignored

Quoting levix95

Disliked

And victory! I managed to solve it! The one on top is my indicator, the one on the bottom is the default MT4. {image} Surprisingly, it was actually easier than I would have ever thought. Just two for loops. Also important that earlier on, I mistakenly put everything into one single for loop. The secret was putting all OBV values into one array and then using the iMAOnArray() on all the OBV values in a second for loop. I leave my code here below, maybe someone will need an OBV with MA in the future. {file}

Ignored

Quoting levix95

Disliked

and victory! I managed to solve it! The one on top is my indicator, the one on the bottom is the default mt4. {image} surprisingly, it was actually easier than i would have ever thought. Just two for loops. Also important that earlier on, i mistakenly put everything into one single for loop. The secret was putting all obv values into one array and then using the imaonarray() on all the obv values in a second for loop. I leave my code here below, maybe someone will need an obv with ma in the future. {file}

Ignored

Quoting belsin

Disliked

{quote} Thanks for sharing ! Is it possible to "translate" the MQ4 code to MQ5 ? Best regards,

Ignored