I need help with my function please | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Please help with custom function code 6 replies

Please help me correct this function 3 replies

required to function call function 2 replies

stop loss function and edit time function for Breakout EA 1 reply

Need Expert Help on Time Function 4 replies

Attachments: I need help with my function please
Exit Attachments

I need help with my function please

  • #1
  • First Post: Apr 19, 2021 8:41am Apr 19, 2021 8:41am
I have created the below function that would look for the value of peak points and trying to store its value in an array but for some reason, it did not work

can anyone help me?

Inserted Code
double Recent_TD_Point[];
//--------------------------------------------------
Function

Inserted Code
double High_TD_Point_Value(int CandleRef){
         if(High[CandleRef]>High[CandleRef-1]&& High[CandleRef>High[CandleRef+1]])
           {
            return (High[CandleRef]);
           }
         else
           {
            return (0);
           }
      }

Inserted Code
for(int i=0;i<3000;i++)
  {if(High_TD_Point_Value(i)>0){
        Recent_TD_Point[i]=High_TD_Point_Value(i);
        Print(Recent_TD_Point[i]);
        }
  }

thanks for your help
  • #2
  • Apr 19, 2021 8:48am Apr 19, 2021 8:48am
Quoting MichaelMano
I have created the below function that would look for the value of peak points and trying to store its value in an array but for some reason, it did not work can anyone help me? double Recent_TD_Point[]; //-------------------------------------------------- Function double High_TD_Point_Value(int CandleRef){ if(High[CandleRef]>High[CandleRef-1]&& High[CandleRef>High[CandleRef+1]]) { return (High[CandleRef]); } else { return (0); } } for(int i=0;i<3000;i++) {if(High_TD_Point_Value(i)>0){ Recent_TD_Point=High_TD_Point_Value(i); Print(Recent_TD_Point);...
Second line of the second code snippet:
if(High[CandleRef]>High[CandleRef-1]&& High[CandleRef>High[CandleRef+1]])
I guess you want:
if(High[CandleRef]>High[CandleRef-1]&& High[CandleRef]>High[CandleRef+1])

And you may need to set"int i = 1" instead of "int i = 0" in the last code snippet.

Anyway, not sure what you are after and whether these modifications will solve your problem.
Always ready to help
  • #3
  • Apr 19, 2021 8:59am Apr 19, 2021 8:59am
Yes you are right I missed the square bracket in this line but surprisingly it compiled correctly
if(High[CandleRef]>High[CandleRef-1]&& High[CandleRef]>High[CandleRef+1])
I was trying to get the peak points like fractals but not with 2 bars but with 1 bar and to check that the code is correct I was expecting to print the value of this peak points but it prints zero through the loop and one more thing although started the loop from 0 when I print I it showed me that it started from 2883

Inserted Code
for(int i=0;i<3000;i++)
{if(High_TD_Point_Value(i)>0)
{ Recent_TD_Point[i]=High_TD_Point_Value(i);
 
 
Print(Recent_TD_Point[i]); }// Print the highs
}
  • #4
  • Apr 19, 2021 10:10am Apr 19, 2021 10:10am
Quoting MichaelMano
Yes you are right I missed the square bracket in this line but surprisingly it compiled correctly if(High[CandleRef]>High[CandleRef-1]&& High[CandleRef]>High[CandleRef+1]) I was trying to get the peak points like fractals but not with 2 bars but with 1 bar and to check that the code is correct I was expecting to print the value of this peak points but it prints zero through the loop and one more thing although started the loop from 0 when I print I it showed me that it started from 2883 for(int i=0;i<3000;i++) {if(High_TD_Point_Value(i)>0) { Recent_TD_Point=High_TD_Point_Value(i);...
You have to set a size to the array and fill it with some default value:

Inserted Code
double High_TD_Point_Value(int CandleRef)
{
   if(High[CandleRef]>High[CandleRef-1]&& High[CandleRef]>High[CandleRef+1])
   {
      return (High[CandleRef]);
   }
   else
   {
      return (0);
   }
}
 
void OnStart()
{
   int total = 20;
   double Recent_TD_Point[];
   ArrayResize(Recent_TD_Point,total);
   ArrayFill(Recent_TD_Point,0,total,0.0);
   double val;
   for(int i=1;i<=total;i++)
   {
      val = High_TD_Point_Value(i);
      if(val>0)
      {
        Recent_TD_Point[i-1]= val;
      }
      
      Print(Recent_TD_Point[i-1]);
   }
}
Always ready to help
  • #5
  • Edited 12:24pm Apr 19, 2021 12:06pm | Edited 12:24pm
Thank you for the advice,
  • #6
  • Apr 19, 2021 12:45pm Apr 19, 2021 12:45pm
Can you help me understand why I have to resize the array and fill it with some default values ? or would you point out a material to me to read about it as when I checked the mql4 documentation I found how to do it but not when I need to do it?

Thanks
  • #7
  • Apr 19, 2021 1:39pm Apr 19, 2021 1:39pm
Quoting MichaelMano
Can you help me understand why I have to resize the array and fill it with some default values ? or would you point out a material to me to read about it as when I checked the mql4 documentation I found how to do it but not when I need to do it? Thanks
If you are using that array inside an indicator's buffer, then it is ok. You don't have to resize it. But if you use it, outside of an indicator buffer, then you have to assign some size to an array in order to save values at each place. Also, you can assign a default value with ArrayFill. That way, in case you don't assign a value to some specific index of the array, it will have already an appropiate value.

So, basically the confussion comes from whether you use the array as an indicator buffer or not. When it is an indicator buffer, MetaTrader sets the size of the array and you don't have to worry about it.
Always ready to help
  • #8
  • Apr 19, 2021 1:55pm Apr 19, 2021 1:55pm
that helped a lot, thank you so much
  • #9
  • Apr 19, 2021 2:11pm Apr 19, 2021 2:11pm
Quoting MichaelMano
that helped a lot, thank you so much
Glad to hear that.

You're welcome!
Always ready to help
  • #10
  • Apr 20, 2021 12:46am Apr 20, 2021 12:46am
Michael,

In programming there is often many ways to do a thing. Paul's method works but I would offer some info to help understand what you are doing.

An array is a variable, just like any other. Just like other variables, you cannot use it, or assign a value to it until you have told the system about it. So whilst you can declare an array using double Recent_TD_Point[];, that is only half the story. If you wish to store something in Recent_TD_Point[1] for example, you have to tell the system that it exists.

This is where resizing the array comes in handy. There are 2 ways to deal with an array and I think you have alluded to it in the past.

1. you can declare the arraysize at initialisation, so - double Recent_TD_Point[20]; The benefit here is simplicity ie no resizing involved, but it is not efficient. A complex program might have 50 arrays with 10 000 elements and when you declare it like this, it immediately takes up space in memory, so don't fill up your memory with empty arrays. Not a problem for you now but generally considered bad practice.

2. The solution to 1 is to size your array dynamically, or as needed, and that is where an array resize comes in. The resize does not require you to fill it with information. and needs be no more than 1 line. Just use ArrayResize(Recent_TD_Point,ArraySize(Recent_TD_Point)+1)). Your array has just grown by 1 element and you can add your value at the relevant index which equals the current arraysize + 1.
  • #11
  • Last Post: Apr 20, 2021 4:37pm Apr 20, 2021 4:37pm
Hello seniors in the house! I am a newbie here and I will like if anyone could help me out with an indicator of 5 same colour candle with the 3rd candle different as listed in the two scenario pictures below. Thanks in anticipation.
Attached Images
0 traders viewing now