Can´t close orders in EA

double trigger = iCustom(NULL,0,"StochTest", TimeFrame, var1, var2, var3, 0, 0);
 if (trigger = 1) {
 
 if (OrderSend(Symbol(), OP_BUY, lots, Ask, 3, Ask - stopLoss * Point, Ask + takeProfit * Point, "my forex wall-e order", 12345, 0, Red)) {
   OrderClose(12345, OrderLots(), Bid, 3, Violet);
   Print("Buy order succeeded!");
 }
 if (trigger = -1) {
 if (OrderSend(Symbol(), OP_SELL, lots, Bid, 3, Bid + stopLoss * Point, Bid - takeProfit * Point, "my forex wall-e order", 12345, 0, Red)) {
   OrderClose(12345, OrderLots(), Ask, 3, Violet);
 Print("Sell order succeeded!");
 }

//
// Basado en https://smartforexlearning.com/mt4-expert-advisor-forex-course-intro/
//
//+------------------------------------------------------------------+

#property version "1.00"
#property strict
//--- inputs
extern string TimeFrame  = NULL;
 
 
//--- input parameters
input int Numero;
//+------------------------------------------------------------------+
//| Expert initialization function |
//+------------------------------------------------------------------+
int OnInit()
 {
//---
//---
 return(INIT_SUCCEEDED);
 }
//+------------------------------------------------------------------+
//| Expert deinitialization function |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
 {
//---
 }
//+------------------------------------------------------------------+
//| Expert tick function |
//+------------------------------------------------------------------+
void OnTick()
 {
//---
 if (OrdersTotal() > 0) {
 return;
 }
 double lots = 0.01;
 int stopLoss = 5000;
 int takeProfit = 5000;
 double trigger = iCustom(NULL,0,"StochTest", TimeFrame, var1, var2, var3, 0, 0);
 if (trigger = 1) {
 
 if (OrderSend(Symbol(), OP_BUY, lots, Ask, 3, Ask - stopLoss * Point, Ask + takeProfit * Point, "my forex wall-e order", 12345, 0, Red)) {
   OrderClose(12345, OrderLots(), Bid, 3, Violet);
   Print("Buy order succeeded!");
 }
 if (trigger = -1) {
 if (OrderSend(Symbol(), OP_SELL, lots, Bid, 3, Bid + stopLoss * Point, Bid - takeProfit * Point, "my forex wall-e order", 12345, 0, Red)) {
   OrderClose(12345, OrderLots(), Ask, 3, Violet);
 Print("Sell order succeeded!");
 }
}
 } 
 }
//+------------------------------------------------------------------+
//| Trailing stop function |
//+------------------------------------------------------------------+
void TrailStops()
{
 int trailingStop = 300;
 for (int i = 0; i < OrdersTotal(); i++) {
 if (!OrderSelect(i, SELECT_BY_POS, MODE_TRADES)) {
 continue;
 }
 if (OrderSymbol() != Symbol()) {
 continue;
 }
 if (OrderType() == OP_BUY) {
 if (Bid - OrderOpenPrice() > trailingStop * Point && OrderStopLoss() < Bid - trailingStop * Point) {
 if (!OrderModify(OrderTicket(), OrderOpenPrice(), Bid - trailingStop * Point, OrderTakeProfit(), 0, Green)) {
 Print("OrderModify error ", GetLastError());
 }
 return;
 }
 } else if (OrderType() == OP_SELL) {
 if (OrderOpenPrice() - Ask > trailingStop * Point && OrderStopLoss() > Ask + trailingStop * Point) {
 if (!OrderModify(OrderTicket(), OrderOpenPrice(), Ask + trailingStop * Point, OrderTakeProfit(), 0, Green)) {
 Print("OrderModify error ", GetLastError());
 }
 return;
 }
}
 }
}

Quoting Q4x

Disliked

Hi. I know this is very basic, but I've tried to solve this on my own for two hours and I just can't make it work. Any help would be appreciated. I'm starting to learn MQL4 and Im trying to do an EA. The idea is to buy if indicator's signal is 1 and sell if it's -1, and I'd like to close the open order in case there's one active in that same chart (other orders may be active in other charts). Thanks in advance. double trigger = iCustom(NULL,0,"StochTest", TimeFrame, var1, var2, var3, 0, 0); if (trigger = 1) { if (OrderSend(Symbol(), OP_BUY, lots,...

Ignored

 if (OrderSend(Symbol(), OP_BUY, lots, Ask, 3, Ask - stopLoss * Point, Ask + takeProfit * Point, "my forex wall-e order", 12345, 0, Red)) {
   OrderClose(OrderTicket(), OrderLots(), Bid, 3, Violet);
   Print("Buy order succeeded!");
 }
 if (trigger = -1) {
 if (OrderSend(Symbol(), OP_SELL, lots, Bid, 3, Bid + stopLoss * Point, Bid - takeProfit * Point, "my forex wall-e order", 12345, 0, Red)) {
   OrderClose(OrderTicket(), OrderLots(), Bid, 3, Violet);
 Print("Sell order succeeded!");
 }

Quote

Disliked

if(OrderSend(..............

Quoting Q4x

Disliked

FerruFX: I tried this but it didn´t work either: if (OrderSend(Symbol(), OP_BUY, lots, Ask, 3, Ask - stopLoss * Point, Ask + takeProfit * Point, "my forex wall-e order", 12345, 0, Red)) { OrderClose(OrderTicket(), OrderLots(), Bid, 3, Violet); Print("Buy order succeeded!"); } if (trigger = -1) { if (OrderSend(Symbol(), OP_SELL, lots, Bid, 3, Bid + stopLoss * Point, Bid - takeProfit * Point, "my forex wall-e order", 12345, 0, Red)) { OrderClose(OrderTicket(), OrderLots(), Bid, 3, Violet); Print("Sell order succeeded!"); }

Ignored