Assistance with understanding difference in logic of 2 codes | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Can Brokers see your MT4 EA/Indicators and Codes? 58 replies

ADX (14,9) codes? 5 replies

Most valuauable books for understanding the logic of markets? 30 replies

could anyone write simple codes for me 3 replies

Need Help with CODES! 15 replies

Assistance with understanding difference in logic of 2 codes

  • #1
  • First Post: Apr 4, 2021 3:57am Apr 4, 2021 3:57am
I am trying to code a condition that allow the EA to trade once in each candle, and I want to understand the difference between the below 2 codes as when I test them each one take different trades

Thanks

//First version//
---------------------

Inserted Code
if(OpenPrice != Open[1]){
         Trade = 1;
         OpenPrice = Open[1];}
         else{Trade = 0;}

//second version//
-----------------------------
Inserted Code
 if(OpenPrice != Open[1]){
         Trade = 1;
         OpenPrice = Open[1];}

in this code I moved the Trade = 0 to be after the execution of the trade of OrderSend()

Can someone help me understand the difference in logic between these 2 which led to the execution of different trade?

Thanks
  • #2
  • Apr 6, 2021 9:25am Apr 6, 2021 9:25am
Probably, because in the second version, the following part of code "Trade = 0" is sometimes not reached.

Anyway, not enough information.

Also, I wouldn't use open prices for that purpose. I would use open times.
Always ready to help
  • #3
  • Last Post: Apr 6, 2021 12:03pm Apr 6, 2021 12:03pm
Quote
bool New_Bar_H1()
{
static datetime New_Time_H1 = 0;
if(New_Time_H1 != iTime(NULL, PERIOD_H1, 0))
{
New_Time_H1 = iTime(NULL, PERIOD_H1, 0);
return(true);
}
return(false);
}

New_bar is a pretty common function. Just change the period to whatever timefram you desire, or even PERIOD_CURRENT if you want the chart to determine the timeframe. Then you simply call the function like this :-

Quote
if(New_Bar_H1())
{
Do_some_code..........
}

As Paul said, forget about using prices. Comparing double creates problems. Compare the time rather.
0 traders viewing now